Link [ NetBSD | NetBSD OpenGrok source search | PR fulltext-search | Summary of daily snapshot builds | history of daily build result | pkgsrc commit viewer ]


   
        usage: [branch:branch] [user:user] [path@revision] keyword [... [-excludekeyword [...]]] (e.g. branch:MAIN sys/arch/arm, if_wm.c@1.234 )




switch to index mode

recent branches: MAIN (47m)  netbsd-8 (5d)  netbsd-10 (5d)  netbsd-9 (11d)  thorpej-ifq (175d)  thorpej-altq-separation (178d) 

2024-05-10 09:07:44 UTC Now

2017-08-03 03:16:27 UTC MAIN commitmail json YAML

2017-08-03 03:12:02 UTC MAIN commitmail json YAML

Don't allow sav->lft_c to be NULL

lft_c of an sav that was created by SADB_GETSPI could be NULL.

(ozaki-r)

2017-08-03 00:05:56 UTC MAIN commitmail json YAML

ISC DHCP 4.3.6 has released.

(taca)

2017-08-02 12:52:19 UTC MAIN commitmail json YAML

Make the 'no results found' message sound less harsh.

Changes "try using better keywords" to "try using different keywords".

(jmcneill)

2017-08-02 12:23:43 UTC MAIN commitmail json YAML

Kernel output format nit.

(simonb)

2017-08-02 10:10:10 UTC MAIN commitmail json YAML

Use endian conversion macros (and some rearrange for readability).
No functional changes.

(isaki)

2017-08-02 08:39:14 UTC MAIN commitmail json YAML

Reorg the virtio(4) config(9) code to be explicitly pci specific.

We'll later use this for a non-pci virtio(4) usecase.

ok martin

(cherry)

2017-08-02 07:35:47 UTC MAIN commitmail json YAML

2017-08-02 07:35:06 UTC MAIN commitmail json YAML

PCI device ID of Atom x5-Z8350's video is 0x22b0. ark.intel.com says 0x22b0 is
Intel HD Graphics 400.

(msaitoh)

2017-08-02 06:30:00 UTC MAIN commitmail json YAML

Add test cases that there are SPs but no relevant SAs

(ozaki-r)

2017-08-02 04:03:29 UTC MAIN commitmail json YAML

Comment out unused functions

(ozaki-r)

2017-08-02 03:45:57 UTC MAIN commitmail json YAML

Don't use KEY_NEWSP for dummy SP entries

By the change KEY_NEWSP is now not called from softint anymore
and we can use kmem_zalloc with KM_SLEEP for KEY_NEWSP.

(ozaki-r)

2017-08-02 02:19:57 UTC MAIN commitmail json YAML

2017-08-02 02:18:17 UTC MAIN commitmail json YAML

Add missing IPsec policy checks to icmp6_rip6_input

icmp6_rip6_input is quite similar to rip6_input and the same checks exist
in rip6_input.

(ozaki-r)

2017-08-02 02:12:42 UTC MAIN commitmail json YAML

Fix updating ipsec_used; turn on when SPs on sockets are added

(ozaki-r)

2017-08-02 01:59:26 UTC MAIN commitmail json YAML

Fix updating ipsec_used

- key_update_used wasn't called in key_api_spddelete2 and key_api_spdflush
- key_update_used wasn't called if an SP had been added/deleted but
  a reply to userland failed

(ozaki-r)

2017-08-02 01:28:03 UTC MAIN commitmail json YAML

Make IPsec SPD MP-safe

We use localcount(9), not psref(9), to make the sptree and secpolicy (SP)
entries MP-safe because SPs need to be referenced over opencrypto
processing that executes a callback in a different context.

SPs on sockets aren't managed by the sptree and can be destroyed in softint.
localcount_drain cannot be used in softint so we delay the destruction of
such SPs to a thread context. To do so, a list to manage such SPs is added
(key_socksplist) and key_timehandler_spd deletes dead SPs in the list.

For more details please read the locking notes in key.c.

Proposed on tech-kern@ and tech-net@

(ozaki-r)

2017-08-02 00:58:18 UTC MAIN commitmail json YAML

Fix the previous fix that doesn't even compile.

(uwe)

2017-08-01 23:41:13 UTC netbsd-8 commitmail json YAML

2017-08-01 23:36:08 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by mrg in ticket #174):
external/gpl3/binutils/usr.sbin/mdsetimage/bin_bfd.c: revision 1.2
sys/arch/evbmips/conf/CI20: revision 1.23
initialise some stack variables to zero so that later checking ensures
they are considered "unfound" instead of some random value.
part 1 in fixing the CI20 kernel build.  this one actually will cause
the build to fail, but it's outputting broken objects right now anyway.
part 2 coming up in the CI20 configuration itself.
--
don't set NEED_MDSETIMAGE when we don't enable the md_root.  move the
option in with the commented md_root options.
part 2 of the CI20 kernel build fix.  now evbmips builds completes
sanely for me.

(snj)

2017-08-01 23:33:18 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by msaitoh in ticket #173):
sys/dev/pci/if_wmreg.h: 1.99-1.103
sys/dev/pci/if_wmvar.h: 1.34-1.37
sys/dev/pci/if_wm.c: 1.510-1.537
sys/dev/mii/ihphyreg.h: 1.2
sys/dev/mii/inbmphyreg.h: 1.10
sys/dev/mii/igphy.c: 1.27
Sync wm(4) up to if_wm.c rev. 1.537:
- Set WMREG_KABGTXD not in wm_init_locked() but in wm_reset().
- If a legacy interrupt is a spurious interrupt, don't print debug
  message.
- Don't print the Image Unique ID if an NVM is iNVM (i210 and I211).
- Fix a bug that a RAL was written at incorrect address when the index
  number is more than 16 on 82544 and newer.
- The layout of RAL on PCH* are different from others. Fix it.
- Flush every MTA write. Same as Linux.
- Move the location of calling wm_set_filter. Same as some other OSes.
- Flush writing WMREG_CTRL in wm_gmii_mediachange().
- Make new wm_phy_post_reset() and use this function at all location
  after resetting phy.
- Add I219 specific workaround for legacy interrupt. From OpenBSD.
- Move the location of calling wm_lplu_d0_disable().
- Disable D0 LPLU on 8257[12356], 82580, I350 and I21[01], too. Before
  this commit, above devices and non-PCIe devices accessed wrong
  register.
- Fix latency calculation in wm_platform_pm_pch_lpt().
- Set OBFF water mark and enable OBFF on PCH_LPT and newer.
- Fix a bug that wm_gmii_i82544_{read,write}reg() didn't take care of
  page select. PHY access from igphy() automatically did it, but
  accessing from wm(4) for workaround didn't work correctly. This
  change affects 8254[17], 8257[12] ICH8, ICH9 and ICH10.
- Call wm_kmrn_lock_loss_workaround_ich8lan() before any PHY access in
  wm_linkintr_gmii().
- Register access in wm_kmrn_lock_loss_workaround_ich8lan() now works
  correctly. Enable this function.
- IF TX is not required to flush, RX is also not required to flush in
  wm_flush_desc_rings(). Same as other OSes.
- Remove wrong semaphore access in wm_nvm_{read,write}_{ich8,spt} to
  prevent hangup. A semaphore is get/put in wm_nvm_{read,write}.
- Move some initialization stuff in wm_attach() before wm_reset().
  Some flags and callback function is required to set correctly before
  wm_reset() because wm_reset() and some helper functions refer them.
- Add wm_write_smbus_addr() to set SMBus address by software.
- Modify wm_gmii_hv_{read,write}reg_locked() to make them access
  HV_SMB_ADDR correctly.
- Configure the LCD with the extended configuration region in NVM if
  it's required. Tested with Thinkpad X220.
- 8257[12]: Don't directly access SPI but use EERD register.
- 82575-I354: If the size of SPI ROM >= 32K words, use direct SPI
  access instead of EERD register access.
- Add wm_nvm_eec_clock_raise() and wm_nvm_eec_clock_lower() and use
  them for Microwire/SPI bus control. Same as Linux and FreeBSD.
- Reduce timeout value for 80003 in wm_get_swfw_semaphore(). Same as
  Linux and FreeBSD.
- Change API of kmrn_{read,write}reg() and check the return value.
- Check whether it's required to use MDIC workaround for 80003 or not
  in wm_reset(). If the workaround isn't required, don't use the
  workaround code in wm_gmii_i80003_{read,write}reg.
- Add WM_F_WA_I210_CLSEM flag for a workaround. FreeBSD/Linux drivers
  say "In rare circumstances, the SW semaphore may already be held
  unintentionally." on I21[01]. PXE boot is one of the case.
- Qemu's e1000e emulation (82574L)'s SPI has only 64 words. I've never
  seen on real 82574 hardware with such small SPI ROM. Check
  NVM word size before accessing higher address words to prevent
  timeout.
- Check some wm_nvm_read()'s return vale.
- Use device_printf() instead of aprint_error_dev() for PHY read/write
  functions because those are used not only in device attach.
- Print internal driver flags when attaching.
- Add debug printf()s.
- Rename variables.
- Add comment, update comment and remove wrong comment.

(snj)

2017-08-01 23:30:04 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by maya in ticket #171):
external/gpl3/gcc/dist/gcc/config/i386/i386.c: revision 1.13
Apply upstream patch:
Incorrect codegen from rdseed intrinsic use (CVE-2017-11671)
We should not expand call arguments in between flags reg setting and
flags reg using instructions, as it may expand with flags reg
clobbering insn (ADD in this case).
Attached patch moves expansion out of the link. Also, change
zero-extension to non-flags reg clobbering sequence in case we perform
zero-extension with and.
2017-03-25  Uros Bizjak  <ubizjak@gmail.com>

(snj)

2017-08-01 23:28:41 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by skrll in ticket #169):
sys/dev/usb/if_ural.c: revision 1.52
Free the RX list if ural_alloc_rx_list fails part way through.
Reported by Ilja Van Sprundel.

(snj)

2017-08-01 23:26:58 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by martin in ticket #168):
sys/kern/kern_malloc.c: revision 1.146
Avoid integer overflow in kern_malloc(). Reported by Ilja Van Sprundel.

(snj)

2017-08-01 23:25:11 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by nat in ticket #167):
sys/dev/audio.c: revision 1.373
sys/dev/audio.c: revision 1.374
sys/dev/audio.c: revision 1.375
Refactoring of order of auto config combinations.  Most common formats
come first.
Do not exceed AUDIO_MAX_CHANNELS.
Addresses PR kern/52435.
--
Remove unused code from audio_set_params.
Addresses PR kern/52434.
--
Remove dead code from audio open.  Found by isaki@.
Better error handling incase memory for the streams' ringbuffers cannot be
allocated.
Addresses PR kern/52433.

(snj)

2017-08-01 23:23:01 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by nat in ticket #166):
sys/dev/auconv.c: revision 1.30
sys/dev/audio.c: revision 1.372
sys/dev/ic/ac97.c: revision 1.97
sys/dev/pci/azalia_codec.c: revision 1.81
Mixer device bounds checking.
Analysis by Ilja van Sprundel.

(snj)

2017-08-01 23:21:30 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by nat in ticket #165):
sys/dev/auconv.c: revision 1.29
sys/dev/auconv.h: revision 1.19
sys/dev/ic/am7930.c: revision 1.56
Add a null_filter to help with the audio autoconfig of pmax.
Tested by flxd@.

(snj)

2017-08-01 23:18:31 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #164):
distrib/sets/lists/base/md.amd64: revision 1.269
distrib/sets/lists/debug/md.amd64: revision 1.97
sys/arch/amd64/conf/GENERIC: revision 1.460
sys/arch/amd64/conf/files.amd64: revision 1.89
sys/arch/i386/conf/GENERIC: revision 1.1157
sys/arch/i386/conf/files.i386: revision 1.379
sys/arch/i386/i386/i386_trap.S: revision 1.7-1.8
sys/arch/i386/include/frameasm.h: revision 1.16
sys/arch/x86/include/sysarch.h: revision 1.12
sys/arch/x86/x86/pmc.c: revision 1.8-1.10
sys/arch/x86/x86/sys_machdep.c: revision 1.36
sys/arch/xen/conf/files.compat: revision 1.26
sys/secmodel/suser/secmodel_suser.c: revision 1.43
sys/sys/kauth.h: revision 1.74
usr.bin/pmc/Makefile: revision 1.5
usr.bin/pmc/pmc.1: revision 1.12-1.13
usr.bin/pmc/pmc.c: revision 1.24-1.25
style
--
style
--
Disable interrupts for T_NMI (inline calltrap). Note that there's still a
way to evade the NMI mode here, if a segment register faults in
INTRFASTEXIT; but we don't care. I didn't test this change, but it seems
fine enough.
--
Make the PMC syscalls privileged.
--
Check argc, and add a message.
--
include opt_pmc.h
--
Build the pmc tool on amd64.
--
Properly handle overflows, and take them into account in userland.
--
Update.
--
Enable PMCs by default.
--
Sort sections. Fix macro usage.

(snj)

2017-08-01 23:12:06 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by nonaka in ticket #163):
sys/external/bsd/drm2/pci/drm_pci.c: revision 1.18
PR/52409: Avoid panic at resume.

(snj)

2017-08-01 23:10:00 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by maya in ticket #162):
sys/dev/pci/if_ral_pci.c: revision 1.24
sys/dev/ic/rt2860.c: revision 1.28
sys/dev/ic/rt2860var.h: revision 1.5
enable rt2860 power management code
adjust to fit netbsd:
make suspend,resume functions match desired pmf* prototypes
remove wakeup/activate wrapper functions
avoid jumping to NULL on resume by initializing if_stop
the problem machine has other issues on resume, so there might be further
issues, but it's an improvement over a jump to NULL.
tested by Riccardo Mottola

(snj)

2017-08-01 22:04:48 UTC jdolecek-ncq commitmail json YAML

2017-08-01 22:02:32 UTC jdolecek-ncq commitmail json YAML

fix logic bug in processing of finished commands - mask of active
commands can change during the loop as c_intr() callback can queue
new commands, so the interrupt routine should only mark as finished
those which were actually active before the loop started; otherwise
the code marked as finished commands which were just started, and
being executed by HBA, leading to all sorts of data corruption

while here mark the active mask volatile, as it is modified from
interrupt context

this fixes for good the random crashes, short reads, and fatal command
errors which I've been tracing down for past couple weeks

thanks to Jonathan (jakllsch@) for testing, and a script to easily
triggered the condition, and led to this bug being finally found and squashed

(jdolecek)

2017-08-01 21:50:36 UTC MAIN commitmail json YAML

convert two pairs of MACHINE_ARCH into two single MACHINE_CPU checks.

(mrg)

2017-08-01 21:43:49 UTC jdolecek-ncq commitmail json YAML

adjust code to be closer to HEAD to it's easier to compare and find
regressions, undoing some changes which were actually not necessary

(jdolecek)

2017-08-01 21:41:26 UTC jdolecek-ncq commitmail json YAML

make atastart() schedule as many commands as possible, instead of always
only one; makes it able to pick up pace again after processing non-NCQ command

(jdolecek)

2017-08-01 21:40:03 UTC MAIN commitmail json YAML

2017-08-01 21:39:51 UTC jdolecek-ncq commitmail json YAML

move the drive recovery block to drive struct, it's inherently per-drive

(jdolecek)

2017-08-01 20:09:43 UTC MAIN commitmail json YAML

Update LLVM entry.

(joerg)

2017-08-01 20:07:43 UTC MAIN commitmail json YAML

2017-08-01 19:58:42 UTC LLVM commitmail json YAML

space deleted
src/external/bsd/llvm/dist/llvm/docs/Dummy.html deleted
src/external/bsd/llvm/dist/llvm/include/llvm/CodeGen/MachineFunctionInitializer.h deleted
src/external/bsd/llvm/dist/llvm/include/llvm/DebugInfo/CodeView/CVSymbolTypes.def deleted
src/external/bsd/llvm/dist/llvm/include/llvm/DebugInfo/CodeView/CVTypeDumper.h deleted
src/external/bsd/llvm/dist/llvm/include/llvm/DebugInfo/CodeView/ModuleSubstream.h deleted
src/external/bsd/llvm/dist/llvm/include/llvm/DebugInfo/CodeView/ModuleSubstreamVisitor.h deleted
src/external/bsd/llvm/dist/llvm/include/llvm/DebugInfo/CodeView/TypeDatabase.h deleted
src/external/bsd/llvm/dist/llvm/include/llvm/DebugInfo/CodeView/TypeDatabaseVisitor.h deleted
src/external/bsd/llvm/dist/llvm/include/llvm/DebugInfo/CodeView/TypeDumperBase.h deleted
src/external/bsd/llvm/dist/llvm/include/llvm/DebugInfo/CodeView/TypeRecords.def deleted
src/external/bsd/llvm/dist/llvm/include/llvm/DebugInfo/MSF/ByteStream.h deleted
src/external/bsd/llvm/dist/llvm/include/llvm/DebugInfo/MSF/SequencedItemStream.h deleted
src/external/bsd/llvm/dist/llvm/include/llvm/DebugInfo/MSF/StreamArray.h deleted
src/external/bsd/llvm/dist/llvm/include/llvm/DebugInfo/MSF/StreamInterface.h deleted
src/external/bsd/llvm/dist/llvm/include/llvm/DebugInfo/MSF/StreamReader.h deleted
src/external/bsd/llvm/dist/llvm/include/llvm/DebugInfo/MSF/StreamRef.h deleted
src/external/bsd/llvm/dist/llvm/include/llvm/DebugInfo/MSF/StreamWriter.h deleted
src/external/bsd/llvm/dist/llvm/include/llvm/DebugInfo/PDB/Raw/DbiStream.h deleted
src/external/bsd/llvm/dist/llvm/include/llvm/DebugInfo/PDB/Raw/DbiStreamBuilder.h deleted
      :
(more 379 files)
Mark files not present in 309604 as dead.

(joerg)

2017-08-01 19:35:51 UTC MAIN commitmail json YAML


Support loading collation data from file.  Began with FreeBSD's
xlocale_collate, but had to change it somewhat to accommodate the
requirements of the Unicode Collation Algorithm (in particular,
there are maps from single-character collation elements to
multiple collation weight vectors, and multiple-to-multiple
mappings as well).

(perseant)

2017-08-01 18:08:49 UTC MAIN commitmail json YAML

Inline storage size in one place to avoid depending on DCE for removing
the USE_FORT=yes warning.

(joerg)

2017-08-01 17:04:06 UTC MAIN commitmail json YAML

Mark the compat_svr4 module obsolete.

hopefully fixes the build, this is a blind commit.

(maya)

2017-08-01 16:54:19 UTC MAIN commitmail json YAML

Restore marking ./usr/include/i386/svr4_machdep.h obsolete
instead of removing

(so it can be removed by postinstall)

(maya)

2017-08-01 16:44:19 UTC MAIN commitmail json YAML

mandoc-1.14.2 out.

(wiz)

2017-08-01 16:16:32 UTC MAIN commitmail json YAML

Don't use the custom tokenizer when compiled with debugging on

Using the custom tokenizer means one cannot interactively query the database
through the SQLite shell, thus thwarting the purpose of the debug build option.

Thanks to leot@ for reporting it.

(While there change the debug macro from DEBUG to APROPOS_DEBUG)

(abhinav)

2017-08-01 16:12:33 UTC MAIN commitmail json YAML

2017-08-01 14:43:54 UTC MAIN commitmail json YAML

2017-08-01 14:23:42 UTC MAIN commitmail json YAML

2017-08-01 13:57:03 UTC MAIN commitmail json YAML

2017-08-01 13:49:51 UTC MAIN commitmail json YAML

Don't build the svr4 module on i386.

(maxv)

2017-08-01 13:47:49 UTC MAIN commitmail json YAML

2017-08-01 13:02:37 UTC MAIN commitmail json YAML

Remove commented vestiges of bygone compat options.

COMPAT_MACH, COMPAT_DARWIN, EXEC_MACHO, and COMPAT_PECOFF were all
removed ages ago.

(riastradh)

2017-08-01 12:31:45 UTC MAIN commitmail json YAML

pthread__attr_init_private:
malloc+memset -> calloc. Also initialize all values to the proper
defaults.
This fixes the "rustc panic" discussed on pkgsrc-users.
OK: joerg

(martin)

2017-08-01 12:15:21 UTC MAIN commitmail json YAML

From bjoern johannesson, in netbsd-general... Reset the mask to 0, used to
be 0xa. Is it wrong in the cfe? Should this better be done via a quirk?

(christos)

2017-08-01 11:58:45 UTC MAIN commitmail json YAML

PR/52446: Devid Binderman: Fix error checking for wcstombs

(christos)

2017-08-01 11:56:58 UTC MAIN commitmail json YAML

PR/52445: David Binderman: Fix wcstombs error checking

(christos)

2017-08-01 11:12:49 UTC MAIN commitmail json YAML

2017-08-01 11:11:37 UTC MAIN commitmail json YAML

2017-08-01 11:11:17 UTC MAIN commitmail json YAML

2017-08-01 11:04:21 UTC MAIN commitmail json YAML

2017-08-01 10:56:42 UTC LLVM commitmail json YAML

2017-08-01 00:01:56 UTC MAIN commitmail json YAML

Enable GPCLK2 to Bluetooth.

(jmcneill)

2017-07-31 23:54:19 UTC MAIN commitmail json YAML

mark ISR as mpsafe, detect when this is the console

(jmcneill)

2017-07-31 23:53:25 UTC MAIN commitmail json YAML

Broadcom AUX UART doesn't seem to set LSR RXRDY bit when data is available
in the RX FIFO.

(jmcneill)

2017-07-31 20:11:17 UTC jdolecek-ncq commitmail json YAML

2017-07-31 19:29:19 UTC MAIN commitmail json YAML

modify code handling mismatch of nsegs in _bus_dmamem_alloc_range() to
a KASSERT() - plain return leaks memory, and this condition should
never trigger unless there is bug in uvm_pglistalloc(), so it seems
to be waste to check this

other ports usually simply do not check this, with exception of arm,
which does even full cleanup (checks it and calls uvm_pglistfree())

(jdolecek)

2017-07-31 18:54:40 UTC MAIN commitmail json YAML

Use idt_vec_set instead.

(maxv)

2017-07-31 18:45:43 UTC MAIN commitmail json YAML

2017-07-31 16:34:23 UTC MAIN commitmail json YAML

Create a config.txt for RPI and set 'enable_uart=1' and 'force_turbo=0'.
This config gives us a stable core_freq clock that is used to drive the
SD HOST and AUX UART devices.

More information on config.txt settings for the UART can be found here:

https://www.raspberrypi.org/documentation/configuration/uart.md

(jmcneill)

2017-07-31 15:51:28 UTC MAIN commitmail json YAML

Fix TCPCTL_NAMES, and remove TCPCTL_VARIABLES.

(maxv)

2017-07-31 15:43:33 UTC MAIN commitmail json YAML

Disable all the compat options until COMPAT_10. NetBSD 1.0 was released on
October 26 1994; 23 years of compatibility is enough. Discussed with
christos quickly.

(maxv)

2017-07-31 15:38:01 UTC MAIN commitmail json YAML

Remove references to COMPAT_OLDSOCK (itself removed years ago).

(maxv)

2017-07-31 14:53:08 UTC MAIN commitmail json YAML

Update confused vs_set_params().
play and rec are identical but pfil and rfil are independent.
XXX I introduce VS_USE_PREC8 option for debugging purposes
    temporarily.  I'll remove it if the problem is solved.

(isaki)

2017-07-31 10:45:04 UTC MAIN commitmail json YAML

Only remap sdhost/sdhci on boards with wifi.

(jmcneill)

2017-07-31 10:41:39 UTC MAIN commitmail json YAML

Enable AUX UART for BT on btwifi boards

(jmcneill)

2017-07-31 09:25:14 UTC MAIN commitmail json YAML

Add COM_TYPE_BCMAUXUART type for BCM2835 AUX UART.

(jmcneill)

2017-07-31 06:41:01 UTC MAIN commitmail json YAML

rename unclear functions. pointed out by msaitoh@n.o.

(knakahara)

2017-07-31 04:29:50 UTC perseant-stdc-iso10646 commitmail json YAML

Support loading collation data from file.  Began with FreeBSD's
xlocale_collate, but had to change it somewhat to accommodate the
requirements of the Unicode Collation Algorithm (in particular,
there are maps from single-character collation elements to
multiple collation weight vectors, and multiple-to-multiple
mappings as well).

(perseant)

2017-07-31 04:25:45 UTC MAIN commitmail json YAML

use pool_cache(9) instead of pool(9) as they can be called concurrently.

(knakahara)

2017-07-31 04:23:48 UTC MAIN commitmail json YAML

use kmem_alloc KPI instead of malloc KPI.

(knakahara)

2017-07-31 04:23:35 UTC perseant-stdc-iso10646 commitmail json YAML

2017-07-31 04:21:59 UTC MAIN commitmail json YAML

pack crypto_drivers variables to struct and add cacheline_aligned qualifier.

(knakahara)

2017-07-31 04:19:26 UTC MAIN commitmail json YAML

refactor: remove glue macros for FreeBSD code.

(knakahara)

2017-07-31 00:51:20 UTC MAIN commitmail json YAML

2017-07-30 23:48:32 UTC MAIN commitmail json YAML

2017-07-30 23:47:58 UTC MAIN commitmail json YAML

2017-07-30 23:13:24 UTC MAIN commitmail json YAML

Bump date for previous.

(wiz)

2017-07-30 23:02:53 UTC MAIN commitmail json YAML

Compare return value of fputs(3) with EOF instead of 0.
This is POSIX-ly correct and fixes csplit(1) on non-NetBSD systems.

(cheusov)

2017-07-30 22:53:56 UTC MAIN commitmail json YAML

According to POSIX return value of fputs(3) should be a non-netagive value if it succeeds

(cheusov)

2017-07-30 20:46:31 UTC jdolecek-ncq commitmail json YAML

2017-07-30 20:37:35 UTC MAIN commitmail json YAML

The proper way to validate a condition that's expected to be true is
to assert it, not to bolt it into the program logic in a way that will
cause strange behavior if it accidentally isn't true at some point.

(dholland)

2017-07-30 20:24:45 UTC jdolecek-ncq commitmail json YAML

adjust error recovery to similar shape as ahcisata; also switch to using
siisata_reset_channel(), as that seems more reliably get the HBA to running
state again after some errors

besides this, change several places checking PORT_READY to use
siisata_reinit_port() and properly timeout - seen several cases
where it would just loop there indefinitely on some errors with no
way to get into ddb and no error message, due to the tight DELAY() loop

(jdolecek)

2017-07-30 20:16:29 UTC jdolecek-ncq commitmail json YAML

actually change the retry to also use NCQ - with one drive I see
very frequent fatal errors on siisata when switching often between
NCQ and non-NCQ I/O commands with chaos monkey (basically, always
the next NCQ command on a slot which had non-NCQ I/O throws fatal
error); they completely vanish when just using NCQ all the time

(jdolecek)

2017-07-30 17:32:59 UTC MAIN commitmail json YAML

2017-07-30 17:01:27 UTC MAIN commitmail json YAML

enable sdhost driver (ok skrll@)

(jmcneill)

2017-07-30 16:54:36 UTC MAIN commitmail json YAML

2017-07-30 16:13:24 UTC MAIN commitmail json YAML

Remove references to COMPAT_IRIX - does not exist anymore.

I believe svr4_machdep.h should be removed when the option is not
implemented on the target architecture; and we should also remove the
associated md.* entries.

(maxv)

2017-07-30 16:07:06 UTC MAIN commitmail json YAML

Remove lurking reference to TCP_COMPAT_42.

(maxv)

2017-07-30 14:23:54 UTC MAIN commitmail json YAML

kmem_xyz(sizeof(struct foo)) --> kmem_xyz(sizeof(*foo))

No change to amd64 binary.

(riastradh)

2017-07-30 13:43:49 UTC MAIN commitmail json YAML

Fix error branch in ttm_dma_tt_init to avoid double-free.

Should fix symptom of PR kern/52438, but who knows what underlying
problem causes us to reach the error branch in the first place.

(riastradh)

2017-07-30 13:12:49 UTC MAIN commitmail json YAML

2017-07-30 12:31:47 UTC MAIN commitmail json YAML

2017-07-30 11:38:57 UTC MAIN commitmail json YAML

Initialize iospace_size instead of iospace (will be overwritten) to 64k.
Brings boot of emips on giano a bit closer, but now it's stuck (hangs).

(he)

2017-07-30 05:51:34 UTC MAIN commitmail json YAML

Improve diagnostic code.
If the specified encoding is wrong, it outputs a sound like a buzzer :)
rather than panic.

(isaki)

2017-07-30 02:41:58 UTC MAIN commitmail json YAML

Typo in debug message.

(isaki)

2017-07-30 00:53:58 UTC MAIN commitmail json YAML

Audio now compiles with WARNS=5, so there is no need to specify WARNS=3.

(nat)

2017-07-30 00:50:52 UTC MAIN commitmail json YAML

The pad module will now compile with WARNS=5.

(nat)

2017-07-30 00:47:48 UTC MAIN commitmail json YAML

2017-07-29 23:10:36 UTC MAIN commitmail json YAML

dts updated to 4.12.4

(jmcneill)

2017-07-29 23:09:10 UTC MAIN commitmail json YAML

2017-07-29 23:06:22 UTC MAIN commitmail json YAML

Use cp -RL to follow symlinks

(jmcneill)

2017-07-29 22:47:55 UTC MAIN commitmail json YAML

Standardize NAME section.

Remove unneeded troff macros.

XXX: this is still MLINKed as names that are not in Nm.

(wiz)

2017-07-29 22:40:04 UTC jdolecek-ncq commitmail json YAML

add macro for getting the slot from context register, just for reference for now

(jdolecek)

2017-07-29 21:04:07 UTC MAIN commitmail json YAML

Clarify compile-time and run-time arithmetic safety assertions.

This is an experiment with a handful of macros for writing the
checks, most of which are compile-time:

MUL_OK(t, a, b)        Does a*b avoid overflow in type t?
ADD_OK(t, a, b)        Does a + b avoid overflow in type t?
TOOMANY(t, x, b, m)    Are there more than m b-element blocks in x in type t?
                        (I.e., does ceiling(x/b) > m?)

Addenda that might make sense but are not needed here:

MUL(t, a, b, &p)        Set p = a*b and return 0, or return ERANGE if overflow.
ADD(t, a, b, &s)        Set s = a+b and return 0, or return ERANGE if overflow.

Example:

uint32_t a = ..., b = ..., y = ..., z = ..., x, w;

        /* input validation */
        error = MUL(size_t, a, b, &x);
        if (error)
                fail;
        if (TOOMANY(uint32_t, x, BLKSIZ, MAX_NBLK))
                fail;
        y = HOWMANY(x, BLKSIZ);
        if (z > Z_MAX)
                fail;
        ...
        /* internal computation */
        __CTASSERT(MUL_OK(uint32_t, Z_MAX, MAX_NBLK));
        w = z*y;

Obvious shortcomings:

1. Nothing checks your ctassert matches your subsequent arithmetic.
  (Maybe we could have BOUNDED_MUL(t, x, xmax, y, ymax) with a
  ctassert inside.)

2. Nothing flows the bounds needed by the arithmetic you use back
  into candidate definitions of X_MAX/Y_MAX.

But at least the reviewer's job is only to make sure that (a) the
MUL_OK matches the *, and (b) the bounds in the assertion match the
bounds on the inputs -- in particular, the reviewer need not derive
the bounds from the context, only confirm they are supported by the
paths to it.

This is not meant to be a general-purpose proof assistant, or even a
special-purpose one like gfverif <http://gfverif.cryptojedi.org/>.
Rather, it is an experiment in adding a modicum of compile-time
verification with a simple C API change.

This also is not intended to serve as trapping arithmetic on
overflow.  The goal here is to enable writing the program with
explicit checks on input and compile-time annotations on computation
to gain confident that overflow won't happen in the computation.

(riastradh)

2017-07-29 19:39:58 UTC MAIN commitmail json YAML

If i386/svr4_machdep.h is no longer to be installed in /usr/include
it should no longer be listed in the sets lists as installed.
Mark it obsolete (hopefully unbreak builds.)

(kre)

2017-07-29 18:08:59 UTC MAIN commitmail json YAML

2017-07-29 16:50:32 UTC jdolecek-ncq commitmail json YAML

2017-07-29 15:07:46 UTC jdolecek-ncq commitmail json YAML

2017-07-29 14:50:58 UTC jdolecek-ncq commitmail json YAML

make ahci_channel_recover() non-static, so that it's visible in backtrace,
and can set a separate breakpoint there

(jdolecek)

2017-07-29 13:05:16 UTC MAIN commitmail json YAML

2017-07-29 13:04:43 UTC jdolecek-ncq commitmail json YAML

fix AHCI_P_CMD_CCS_SHIFT - must shift only by 8, otherwise the result would
be always 0

(jdolecek)

2017-07-29 13:02:50 UTC jdolecek-ncq commitmail json YAML

do not do the drive reset on non-fatal recovery - spec explicitely says
says the READ LOG EXT should only be done when neither COMRESET nor software
reset was done, and indeed it returns junk in this case

use C_RECOVERY slot for drive reset, so that it now will always succeed
in getting a slot, in cases when it would be necessary

adjust code and comments on the recovery path to explain better what's going on

with this AHCI error recovery works with real hardware without timeouts again

(jdolecek)

2017-07-29 12:58:30 UTC jdolecek-ncq commitmail json YAML

reserve the highest slot for error recovery, and also have ata_channel
include space for the READ LOG EXT sector, so that it's not necessary
to allocate memory on the error handling path; now ata_read_log_ext_ncq()
will never fail due to resource shortage

(jdolecek)

2017-07-29 12:51:22 UTC jdolecek-ncq commitmail json YAML

actually count the REQUEUE as retry also, so that it will be retried
as non-NCQ, will not be subject to chaos monkey, and reported as fixed
once finished, too

(jdolecek)

2017-07-29 12:34:34 UTC MAIN commitmail json YAML

Remove undocumented hack.

(maxv)

2017-07-29 12:28:28 UTC MAIN commitmail json YAML

2017-07-29 12:15:13 UTC MAIN commitmail json YAML

2017-07-29 12:07:45 UTC MAIN commitmail json YAML

2017-07-29 12:03:37 UTC MAIN commitmail json YAML

Remove i386. By the way, it looks like several architectures are missing
here.

(maxv)

2017-07-29 12:00:56 UTC MAIN commitmail json YAML

2017-07-29 11:54:14 UTC MAIN commitmail json YAML

Drop support for svr4 on i386. This feature is not maintained, not
reliable, and of a limited use case. Most svr4 applications got time to be
ported to linux, and we do have a functional, maintained linux emulation.

Reduces the number of entry points into the kernel, the number of
places that need special care (cpu context).

Note that compat_svr4 is still available on sparc.

(maxv)

2017-07-29 10:39:48 UTC MAIN commitmail json YAML

Remove exec_aout support in compat_freebsd. The only reason we still have
compat_freebsd is because of tw_cli, and it is an elf32 binary (could test,
manuel sent it to me).

(maxv)

2017-07-29 09:04:39 UTC jdolecek-ncq commitmail json YAML

do not use freed xfer in error message in wdc_atapi_get_params()

(jdolecek)

2017-07-29 07:30:39 UTC MAIN commitmail json YAML

Audio vchan auto config works again due to the use of a null_filter.

Tested and confirmed working by isaki@.

(nat)

2017-07-29 07:19:47 UTC MAIN commitmail json YAML

2017-07-29 07:16:15 UTC MAIN commitmail json YAML

2017-07-29 06:45:35 UTC MAIN commitmail json YAML

"bits" sounds better than "name" for argument name.
I feel expression (name / NBBY) a little strange.

(isaki)

2017-07-29 06:36:21 UTC MAIN commitmail json YAML

Use do .. while (0) for macros.

(isaki)

2017-07-29 06:33:45 UTC MAIN commitmail json YAML

Fix a resource leak on error handling in audio_alloc_ring().

(isaki)

2017-07-29 06:30:56 UTC MAIN commitmail json YAML

Fix error handling of ring buffers allocation in audioattach().
NULL dereference, dead code, reference to uninitialized variable,
and mutex leak.
XXX In the current implementation, if audio_alloc_ring() returns error,
    it is not guaranteed that ringbuf->s.start will be NULL.

(isaki)

2017-07-29 06:29:32 UTC MAIN commitmail json YAML

2017-07-29 06:12:50 UTC MAIN commitmail json YAML

Only compat_43 needs compat_osock. Note that the use of vec_compat_ifioctl
is racy.

(maxv)

2017-07-29 06:00:47 UTC MAIN commitmail json YAML

0 -> NULL in audioattach()

(isaki)

2017-07-29 05:59:08 UTC MAIN commitmail json YAML

Disable COMPAT_386BSD_MBRPART on Xen - not enabled in GENERIC.

(maxv)

2017-07-29 05:55:58 UTC MAIN commitmail json YAML

2017-07-29 05:48:16 UTC MAIN commitmail json YAML

Remove TCP_COMPAT_42.

(maxv)

2017-07-29 05:46:29 UTC MAIN commitmail json YAML

Remove TCP_COMPAT_42.

(maxv)

2017-07-29 05:08:48 UTC MAIN commitmail json YAML

Forgot to commit this file yesterday.

(maxv)

2017-07-29 04:08:47 UTC MAIN commitmail json YAML

Kill needless nested extern of vec_compat_cvtcmd/ioctl.

Already declared in if_43.h.

(riastradh)

2017-07-29 04:02:49 UTC MAIN commitmail json YAML

Declare mountcompatnames in sys/vfs_syscalls.h to kill nested extern.

(riastradh)

2017-07-29 03:32:00 UTC MAIN commitmail json YAML

make comment match code...

(macallan)

2017-07-29 03:29:49 UTC MAIN commitmail json YAML

- use hardware to draw bitmap fonts
- while there enable font loading etc.

(macallan)

2017-07-29 03:05:51 UTC MAIN commitmail json YAML

Improve audio_set_vchan_defaults().
- Correct confused input/output parameters.
- Remove sc->{sc_channels, sc_precision, sc_frequency}.  They are
  the same as sc->sc_vchan_params.{channels, precision, sample_rate}.
The input parameter of audio_set_vchan_defaults() is now only
sc->sc_vchan_params.

Fix PR kern/52437

(isaki)

2017-07-29 02:31:22 UTC MAIN commitmail json YAML

Put suser check in the right function: settimeofday, not gettimeofday.

While here, remove wrong comment.

Noted by kre@.

(riastradh)

2017-07-29 02:21:30 UTC MAIN commitmail json YAML

Avoid memory leak in sonic_get.

If this is the first time around, top is null and nothing else will
free m.

From Ilja Van Sprundel.

(riastradh)

2017-07-29 02:17:44 UTC MAIN commitmail json YAML

Avoid memory leak in netdock_get.

If top is null, this is the first time through and nothing else will
free m.

From Ilja Van Sprundel.

(riastradh)

2017-07-29 01:54:56 UTC MAIN commitmail json YAML

Null out sbuf->m on failure to avoid double-free later.

From Ilja Van Sprundel.

Also null out sbuf->map out of paranoia.

(riastradh)

2017-07-29 01:47:48 UTC MAIN commitmail json YAML

Check for MCLGET failure in et_newbuf.

From Ilja Van Sprundel.

(riastradh)

2017-07-29 01:45:22 UTC MAIN commitmail json YAML

Null out sc_rx_mbuf[i] after m_freem to avoid double-free later.

From Ilja Van Sprundel.

Also null out sc_tx_mbuf[i] after m_freem, out of paranoia.

XXX Not entirely clear to how tx mbufs are freed, but no way to test
this since it's ews4800mips- and hp700-only, so not keen to make any
more elaborate changes...

(riastradh)

2017-07-29 01:34:49 UTC MAIN commitmail json YAML

Plug mbuf leak on MCLGET failure in sonic_rxintr.

From Ilja Van Sprundel.

(riastradh)

2017-07-29 01:31:20 UTC MAIN commitmail json YAML

Check for MCLGET failure in dme_alloc_receive_buffer.

From Ilja Van Sprundel.

(riastradh)

2017-07-29 01:19:29 UTC MAIN commitmail json YAML

Check for M_EXT in m->m_flags, whether m is NULL, after MCLGET.

From Ilja Van Sprundel.

(riastradh)

2017-07-29 01:14:59 UTC MAIN commitmail json YAML

Only let the superuser set the compat_linux timezone.

Not really keen to invent a new kauth cookie for this useless purpose.

From Ilja Van Sprundel.

(riastradh)

2017-07-29 01:14:00 UTC MAIN commitmail json YAML

Little happy on the commit trigger.  Actually use the out label.

(riastradh)

2017-07-29 01:05:54 UTC MAIN commitmail json YAML

Don't drop vnode ref until we're done with mount in ibcs2_stat(v)fs.

Nothing else guarantees the mount will stick around.

From Ilja Van Sprundel.

(riastradh)

2017-07-28 22:53:32 UTC MAIN commitmail json YAML

expat-2.2.2 security fix release out.

(wiz)

2017-07-28 22:24:27 UTC MAIN commitmail json YAML

Apply upstream patch:
Incorrect codegen from rdseed intrinsic use (CVE-2017-11671)

We should not expand call arguments in between flags reg setting and
flags reg using instructions, as it may expand with flags reg
clobbering insn (ADD in this case).

Attached patch moves expansion out of the link. Also, change
zero-extension to non-flags reg clobbering sequence in case we perform
zero-extension with and.

2017-03-25  Uros Bizjak

(maya)

2017-07-28 22:23:05 UTC MAIN commitmail json YAML

Apply upstream patch:
Incorrect codegen from rdseed intrinsic use (CVE-2017-11671)

We should not expand call arguments in between flags reg setting and
flags reg using instructions, as it may expand with flags reg
clobbering insn (ADD in this case).

Attached patch moves expansion out of the link. Also, change
zero-extension to non-flags reg clobbering sequence in case we perform
zero-extension with and.

2017-03-25  Uros Bizjak  <ubizjak@gmail.com>

(maya)

2017-07-28 19:31:59 UTC MAIN commitmail json YAML

binutils-2.29 out.

(wiz)

2017-07-28 19:26:16 UTC MAIN commitmail json YAML

2017-07-28 19:16:41 UTC MAIN commitmail json YAML

Remove TCP_COMPAT_42. This feature is a workaround for a bug in the TCP
stack of BSD4.2. Having such features just does not make any sense, and
looking at the code, I'm not sure it actually works.

(maxv)

2017-07-28 17:57:48 UTC MAIN commitmail json YAML

Zero buffers in ibcs2 ioctl to avoid disclosing stack to userland.

From Ilja Van Sprundel.

(riastradh)

2017-07-28 17:52:47 UTC MAIN commitmail json YAML

Check bounds in svr4_sys_putmsg.  Check more svr4_strmcmd bounds.

svr4 streams code is still a disaster.

From Ilja Van Sprundel.

(riastradh)

2017-07-28 17:43:46 UTC MAIN commitmail json YAML

Feebly attempt to get this reference counting less bad.

This svr4 streams code is bad and it should feel bad.

From Ilja Van Sprundel.

(riastradh)

2017-07-28 17:38:36 UTC MAIN commitmail json YAML

Fix indexing of svr4 signals.

From Ilja Van Sprundel.

(riastradh)

2017-07-28 17:14:04 UTC MAIN commitmail json YAML

Avoid another userland-controlled integer overflow.

From Ilja Van Sprundel.

(riastradh)

2017-07-28 16:57:12 UTC MAIN commitmail json YAML

Zero stack data before copyout.

From Ilja Van Sprundel.

(riastradh)

2017-07-28 16:55:48 UTC MAIN commitmail json YAML

Fix some of the multitudinous holes in svr4 streams.

We should never have enabled this by default; it is a minefield.

From Ilja Van Sprundel.

(riastradh)

2017-07-28 16:30:41 UTC MAIN commitmail json YAML

Appease toxic bullshit warning from gcc.

If you have a better way to write a useful bounds check that happens
to always pass on LP64 but doesn't always on LP32, without making it
fail to compile on LP64 or making it an #ifdef conditional on LP32,
please put it in here instead.

(riastradh)

2017-07-28 16:22:01 UTC MAIN commitmail json YAML

Fix indentation.  u_intN_t -> uintN_t.  ntohl -> be32toh.

No functional change intended.

(riastradh)

2017-07-28 16:19:20 UTC MAIN commitmail json YAML

Put in a litany of judicious bounds checks around vnd headers.

Thought I was done with this crap after I rewrote vndcompress(1)!

From Ilja Van Sprundel.

(riastradh)

2017-07-28 16:11:03 UTC MAIN commitmail json YAML

New sentence, new line.

(wiz)

2017-07-28 16:10:29 UTC MAIN commitmail json YAML

After a careful review, and all things considered, disable compat43 by
default on amd64. The use case is limited, the potential for damage too
high, and it is safer to run a BSD4.3 binary on i386 since the kernel does
not have to go through netbsd32 - which may not correctly reproduce i386.

(maxv)

2017-07-28 15:58:24 UTC MAIN commitmail json YAML

* sii(4) was never used in VAXstation 3100 (uses si(4) and is NCR-based).
* Reference scsi(4) in sii(4).
* Add more machines to pmax/intro(4).
* Small fixes.

(flxd)

2017-07-28 15:52:53 UTC MAIN commitmail json YAML

Tweak whitespace to make this definition more greppable.

(riastradh)

2017-07-28 15:51:35 UTC MAIN commitmail json YAML

Make sure we move forward over the buffer.

From Ilja Van Sprundel.

(riastradh)

2017-07-28 15:50:04 UTC MAIN commitmail json YAML

Make sure we have enough space in the buffer before reading it.

From Ilja Van Sprundel.

(riastradh)

2017-07-28 15:47:23 UTC MAIN commitmail json YAML

Check for NUL termination within the buffer we have.

From Ilja Van Sprundel.

(riastradh)

2017-07-28 15:40:38 UTC MAIN commitmail json YAML

Add some more bogus compat options to amd64/ALL for compile-testing.

(riastradh)

2017-07-28 15:37:23 UTC MAIN commitmail json YAML

Don't walk off the end of the dirent buffer.

From Ilja Van Sprundel.

(riastradh)

2017-07-28 15:34:07 UTC MAIN commitmail json YAML

2017-07-28 15:16:39 UTC MAIN commitmail json YAML

Clamp the length we use, not the length we don't.

Avoids uninitialized memory disclosure to userland.

From Ilja Van Sprundel.

(riastradh)

2017-07-28 15:02:52 UTC MAIN commitmail json YAML

Reject out-of-bounds channel index.

From Ilja Van Sprundel.

(riastradh)

2017-07-28 14:49:55 UTC MAIN commitmail json YAML

Reject negative indices from userland.

(riastradh)

2017-07-28 14:45:59 UTC MAIN commitmail json YAML

Reject negative offset/count for smb read/write.

Not clear that this is actually a problem for the kernel -- might
overwrite user's buffers or return garbage to user, but that's their
own damn fault.  But it's hard to imagine that negative offset/count
ever makes sense, and I haven't ruled out a problem for the kernel.

(riastradh)

2017-07-28 14:40:42 UTC MAIN commitmail json YAML

Reject negative ioc_setupcnt.

(riastradh)

2017-07-28 14:37:27 UTC MAIN commitmail json YAML

2017-07-28 14:26:51 UTC MAIN commitmail json YAML

2017-07-28 14:20:46 UTC MAIN commitmail json YAML

Reject allocations for too-small buffers from userland.

From Ilja Van Sprundel.

(riastradh)