Build fixes for TGA driver.

(jakllsch)

Fix invalid PBA setting on ICH{9,10}. This bug was introduced in the last
commit. I noticed this problem via mail from spz.

(msaitoh)

make this compile with DEBUG (_ALIGN was not defined).

(christos)

Add prototype for decCloseScreen().

(jakllsch)

Add prototype for alphaCloseScreen().

(jakllsch)

Take address of structure element rather than casting,
like is done in the amiga version of this code.

(jakllsch)

Needs "mi.h".

(jakllsch)

Needs "mi.h".

(jakllsch)

#include <err.h> for warn(3).

(jakllsch)

Convert some simple_lock uses to mutex(9).
Tested by: jak@, mhitch@

(rmind)

- Describe some locking.
- Add VOP argument comments, add some asserts.
- Update/fix/remove outdated/missleading comments.
- Clean up, de-indent, KNF, misc.

No functional changes intended.

(rmind)

need DrawablePtr not Drawable

(christos)

add unistd for close.

(christos)

all driver needed includes

(christos)

use new dix API; the old one is gone.

(christos)

catch some corner cases of user input

(drochner)

copy AES-XCBC-MAC support from KAME IPSEC to FAST_IPSEC
For this to fit, an API change in cryptosoft was adopted from OpenBSD
(addition of a "Setkey" method to hashes) which was done for GCM/GMAC
support there, so it might be useful in the future anyway.
tested against KAME IPSEC
AFAICT, FAST_IPSEC now supports as much as KAME.

(drochner)

move the "context size" struct member (which is a pure software
implementation thing) from the abstract xform descriptor to
the cryptosoft implementation part -- for sanity, and now clients
of opencrypto don't depend on headers of cipher implementations anymore

(drochner)

Change the way the IV is generated for AES-CTR: use a simple counter
instead of arc4random(). AES-CTR is sensitive against IV recurrence
(with the same key / nonce), and a random number doesn't give that
guarantee.
This needs a little API change in cryptosoft -- I've suggested it to
Open/FreeBSD, might change it depending on feedback.
Thanks to Steven Bellovin for hints.

(drochner)

Note units and current value for TCP_DELACK_TICKS.

(gdt)

Give the body the same static inline treatment as the definition

(joerg)

Explicitly get rid of constness.

(joerg)

Use some format specifiers that actually exist

(joerg)

Use a real panic as safe guard

(joerg)

Use proper format string

(joerg)

Kill self-assignment

(joerg)

RA flood mitigation via a limit on accepted routes:
- introduce a limit for the routes accepted via IPv6 Router Advertisement:
  a common 2 interface client will have 6, the default limit is 100 and
  can be adjusted via sysctl
- report the current number of routes installed via RA via sysctl
- count discarded route additions. Note that one RA message is two routes.
  This is at present only across all interfaces even though per-interface
  would be more useful, since the per-interface structure complies to RFC2466
- bump kernel version due to the previous change
- adjust netstat to use the new value (with netstat -p icmp6)

(spz)

Merge in the patch in PR/44965 with some improvements (removing ifs when
possible).

(matt)

Needs "mi.h".

(jakllsch)

Add code to auto-deencapsulate 0 tagged VLANs.

(matt)

Use proper format string

(joerg)

Use proper format string.

(joerg)

Properly use format string

(joerg)

Use proper format string

(joerg)

Use proper format string

(joerg)

Add some needed __UNCONST

(joerg)

Kill redundant ()

(joerg)

Use proper format string

(joerg)

Kill redundant ()

(joerg)

Fix obvious condition snafu

(joerg)

Fix format string

(joerg)

Use proper format string

(joerg)

Fix formatting of time_t

(joerg)

Fix printing of time_t

(joerg)

Fix another format string

(joerg)

Needs "mi.h".

(jakllsch)

Fix format string

(joerg)

Use proper format string

(joerg)

Fix logic error

(joerg)

Use volatile for explicit 0 dereference

(joerg)

Kill redundant unused extern.

(joerg)

Use proper format string

(joerg)

tmpfs_free_node: comment out assert, which can fire e.g. on shutdown.

(rmind)

Provide correct GCC_NORETURN

(joerg)

No input needed

(joerg)

Properly use format strings

(joerg)

Properly use format strings

(joerg)

Explicitly mark a NEWREF as unused

(joerg)

Properly use format strings

(joerg)

Use proper format string

(joerg)

Kill redundant ()

(joerg)

Packed pointers are non-sense

(joerg)

Kill redundant externs

(joerg)

Properly use format strings

(joerg)

Fix format string usage

(joerg)

Properly use format string

(joerg)

Properly use format strings

(joerg)

Fix usage() to actually not return

(joerg)

Properly use format strings.

(joerg)

Properly use format string.

(joerg)

Properly use format string

(joerg)

Use proper format strings.

(joerg)

Doesn't need input.

(joerg)

Fix const issues

(joerg)

Fix sign compare

(joerg)

Don't use user input as format string

(joerg)

Simplify

(joerg)

Kill self assignment

(joerg)

Use portable macros

(joerg)

input is unused

(joerg)

input is unused.

(joerg)

Decide on printing an int as int and not as short.

(joerg)

Use bitwise operators, logical and with a constant doesn't make sense

(joerg)

Don't use address strings as format string.

(joerg)

for SPI devices, allow platform code to set "scsi-initiator-id" device
property, and if set, use it instead of pfp.PortSCSIID.

on sparc64 systems on "scsi" or "scsi-2" devices, look from our node
up the tree for a "scsi-initiator-id" property, and if present, copy
it into the device properties.

this fixes mpt(4) issues on PRIMEPOWER250 (and probably other) systems.
idea from freebsd r207243/r207287, but reworked to use our device
properties instead of platform #ifdefs.

look in "device_type" as well as "name" for "ethernet" or "network",
and also look to see if a "local-mac-address" is set when choosing if
this may be a network device.  fixes bge(4) nul ethernet address on
the same PRIMEPOWER250.

(mrg)

avoid mutex locking botch and introduce an unlocked version of
pcppi_bell_stop().  fixes a problem reported in private email.

(mrg)

Bump date for previous.

(wiz)

Suggested to oster@ and approved via private e-mail as a help to
people who are getting reconstruction failures.

(buhrow)

Remove two entirely unused members of struct domain (previously struct
_dom_binding). I guess these were there because it was cutpasted at
some point from struct dom_binding in <rpcsvc/yp_prot.h>.

(dholland)

Merge a couple more minor improvements from Wolfgang Stukenbrock's
patch in PR 43900.

(dholland)

The FILE* kept open for /var/yp/binding/foo.ypservers needs to be
per-domain. Also, use the file for the domain we're servicing instead
of always the file for the default domain.

Partly from Wolfgang Stukenbrock's patch in PR 43900.

(dholland)

The been_ypset flag really needs to be per-domain also. Do that.

Partly from Wolfgang Stukenbrock's patch in PR 43900.

(dholland)

The ypbindmode really needs to be per-domain, so adjust accordingly.

Partly from Wolfgang Stukenbrock's patch in PR 43900.

(dholland)

Allowing ypset is a global permission flag, not an operating mode like
broadcast vs. configured/direct. Don't conflate the logic. As I proposed
in PR 43900.

(dholland)

Fix initialization of struct domain; initialize all fields in all
cases, merge duplicate code, make sure every domain gets an xid
assigned.

Partly from Wolfgang Stukenbrock's patch in PR 43900.

(dholland)

The name field of a domain should be dom->dom_name, not dom->dom_domain.
(This and the previous patch make the code far more readable.)

(dholland)

The default name for a "domain" variable should be "dom", not "ypdb".
Change them all, and make a couple other related adjustments.

(dholland)

ypbindlist -> domains

(dholland)

xid2ypdb() -> domain_find()

(dholland)

Rename struct _dom_binding -> struct domain.

(dholland)

Move a bunch of messy sunrpc-related initialization stuff into its own
function instead of blatting it all into main().

(dholland)

Assimilate the open/flock combination used several times into its own
function.

(dholland)

Fix up calls to yp_log. They cannot use %m, because if the -d option
is used the messages are sent via printf instead of syslog(3).

Also, make sure that none of the calls include a trailing newline and
issue a trailing newline in the -d case so they actually print properly.
(This was noted by Wolfgang Stukenbrock in PR 43900.)

And finally, fix some cases that could in some circumstances print
uninitialized errnos.

(dholland)

Abstract out some of the handling of the ypservers file.

(dholland)

Check that the domain name is valid up front, instead of doing it
after opening sockets and registering services and whatnot.

(dholland)

Remove now-unnecessary extra forward decls; sprinkle a little more static.

(dholland)

Sort contents of file.

(dholland)

It's NEED_, not NEEDS_

(matt)

Add a NEED_MDSETIMAGE block.

(matt)

Add a NEED_UBOOTIMAGE block (inside NEED_BINARY)

(matt)

fix incorrect variable name

(ryo)

fix proc.pid.corename:
- "oldp is not NULL" means the get case
- "newp is not NULL" means the set case
which may both happen at the same time.

(mrg)

also match the fujitsu sab: "FJSV,se" (from openbsd, pointed out by jdc)

(mrg)

- tmpfs_alloc_node/tmpfs_free_node: move inode limiting into tmpfs_node_get()
  and tmpfs_node_put(), update outdated/wrong comments and move/add asserts.
- tmpfs_mount: check for the version of arguments a bit earlier.

(rmind)

Conditionalize printfs instead of using conditional empty format
strings.

(joerg)

Map RCSID to __RCSID

(joerg)

ANSIfy

(joerg)

Don't use variables as format string.

(joerg)

Kill some pointer indirections. Don't use variables as format strings.

(joerg)

ANSIfy

(joerg)

#if 0 some unused code.

(joerg)

Don't use variables as format string.

(joerg)

Correctly print variables as strings, not as format string.

(joerg)

Properly print string.

(joerg)

Don't use variables as format strings.

(joerg)

ANSIfy

(joerg)

Don't use strings from arrays as format string.

(joerg)

Don't use return value of a function as format string.

(joerg)

Make a gross hack nice enough to not trigger warnings with clang.

(joerg)

Fix cast

(joerg)

Avoid using a variable as format string.

(joerg)

ufs_wapbl_verify_inodes: update to reality (if somebody decides to use this).

(rmind)

Convert some simple_lock(9) uses to mutex(9) and malloc(9) to kmem(9).

(rmind)

Use __builtin_offsetof if present for _DIRENT_NAMEOFF to avoid false
positives for uninitialized variable checks.

(joerg)

simplify

(joerg)

Don't use the name of the task queue as format string

(joerg)

rf_panicbuf is already format, so don't pass it as format string to
panic()

(joerg)

Update from GNU extension to C99 syntax for designated initializer

(joerg)

Use __UNCONST to get rid of const

(joerg)

Don't use the device name as format string.

(joerg)

Don't use string literal as format string.

(joerg)

Mark rumpuser_exit and rumpuser_thread_exit as dead.

(joerg)

Ensure that rumpuser_thread_exit doesn't return.

(joerg)

Save space, kill some ()

(joerg)

more prototypes.

(christos)

Add prototype and include

(christos)

don't declare inb/outb.

(christos)

fbComposite does not return a value.

(christos)

Add missing casts.

(christos)

change prototype to avoid casts.

(christos)

more prototypes.

(christos)

need err.h for warn

(christos)

nmi_hard: convert nmi_hard_wait to use atomics.

OK mrg@

(rmind)

kgdb_acc: use mutex since pm_lock was converted to it.

(rmind)

Add explicit -lfoo for libraries that are required because of NEEDED
entries in other libraries.
This avoids a bug in 'ld' which causes it to look in the directory
specified by the RPATH entry (in the library with the NEEDED entry)
without adding the directory supplied by --sysroot.
When the RPATH entry in blindly folloed the link is done w.r.t the
systems own libfoo.so which may be missing some symbols.
(Or might have a wrong sized data area that would need copying
into the programs (or other libraries) data space.)
ld also seems to add a NEEDED entry for these libraries directly
into the program binary - this doesn't seem right to me.
Fixes my build where the installed libX11.so is dated from 2009.
CVS :----------------------------------------------------------------------

(dsl)

update draft-ipsec-* -> RFC
clarify a sentence

(drochner)

- use DPRINTF() style debug printfs
- use __func__ to print function names
- consistently use #ifdef DEBUG_FPE
- add some missing debug messages including \n in error paths

(tsutsui)

-remove references to crypto/arc4/arc4.* -- the code isn't used
anywhere afaics
(The confusion comes probably from use of arc4random() at various places,
  but this lives in libkern and doesn't share code with the former.)
-g/c non-implementation of arc4 encryption in swcrypto(4)
-remove special casing of ARC4 in crypto(4) -- the point is that it
doesn't use an IV, and this fact is made explicit by the new "ivsize"
property of xforms

(drochner)

Use the static inline for the body as well.

(joerg)

If symmetric encryption is done from userland crypto(4) and no IV
is specified, the kernel gets one from the random generator. Make sure it
is copied out to the user, otherwise the result is quite useless.

(drochner)

g/c remainders of IV handling in pfkey code -- this is done in
opencrypto now

(drochner)

Remove pointless self-assignment

(joerg)

Make intermediate size variable size_t like the rest to avoid
unnecessary casting.

(joerg)

Use C99-style init in _CITRUS_PROP_HINT_END to avoid warnings for
uninitialised type field.

(joerg)

KNF, mostly indent. No binary change.

(tsutsui)

Actually return something deterministic

(joerg)

Remove self-assignment of an argument that is later used.

(joerg)

Disable Clang's array boundary checker for now (hits e.g. in GCC and BDB)

(joerg)

report aes-ctr statistic counter by name

(drochner)

allow ESP to use AES-CTR
(pfkey and userland tool support is already there because it has been
in KAME IPSEC all the time)
tested against KAME IPSEC

(drochner)

Reorder flag order to not depend on -Wextra being applied before
-Wno-sign-compare

(joerg)

being here, export camellia-cbc through crypto(4) to allow userland tests

(drochner)

add an AES-CTR xform, from OpenBSD

(drochner)

-in the descriptor for encryption xforms, split the "blocksize" field
into "blocksize" and "IV size"
-add an "reinit" function pointer which, if set, means that the xform
does its IV handling itself and doesn't want the default CBC handling
by the framework (poor name, but left that way to avoid unecessary
differences)
This syncs with Open/FreeBSD, purpose is to allow non-CBC transforms.
Refer to ivsize instead of blocksize where appropriate.
(At this point, blocksize and ivsize are identical.)

(drochner)

move KERNHIST stuff much earlier, so drivers can depend upon it.

(mrg)

where there are multiple scripts and no syspkg category, take the first
script name as being the category.

also remove unwanted characters from the syspkg category names (not just for
scripts but for any category)

(agc)

sort includes

(dholland)

include for ioctl()

(christos)

include for ioctl()

(christos)

need to include in fb.

(christos)

Don't use _t as an identifier suffix meaning "variable containing a time".

(dholland)

remove bogus extern

(christos)

fix mouse prototype

(christos)

get the afb.h file from the normal place.

(christos)

Introduce DPRINTF() macro, remove most #ifdef DEBUG usages.
No change to compiler output.

(dholland)

remove extra paren.

(christos)

not enough fixing the Imakefile, we need this one too.

(christos)

u_int32_t -> uint32_t and similar

(dholland)

include system headers after config.h

(christos)

Let's not be silly. Use a fancy "if else" to decide behavior of a bool
and hope cosmic radition doesn't create a third state.

(joerg)