---
- branch: MAIN
  date: Mon Mar 28 12:42:54 UTC 2022
  files:
  - new: '1.52'
    old: '1.51'
    path: src/sys/dev/usb/ucycom.c
    pathrev: src/sys/dev/usb/ucycom.c@1.52
    type: modified
  - new: '1.121'
    old: '1.120'
    path: src/sys/dev/usb/uhid.c
    pathrev: src/sys/dev/usb/uhid.c@1.121
    type: modified
  - new: '1.83'
    old: '1.82'
    path: src/sys/dev/usb/uhidev.c
    pathrev: src/sys/dev/usb/uhidev.c@1.83
    type: modified
  - new: '1.22'
    old: '1.21'
    path: src/sys/dev/usb/uhidev.h
    pathrev: src/sys/dev/usb/uhidev.h@1.22
    type: modified
  id: 20220328T124254Z.47d65a20028ab1e45d441846f9e4f2b2cb0ba1d3
  log: |
    uhidev(9): Partially fix uhidev_write aborting.

    In my previous change, I intended to make uhidev_stop abort any
    pending write -- but I forgot to initialize sc->sc_writereportid, so
    it never did anything.

    This changes the API and ABI of uhidev_write so it takes the struct
    uhidev pointer, rather than the struct uhidev_softc pointer; this way
    uhidev_write knows what the report id of the client is, so it can
    arrange to have uhidev_stop abort only this one.

    XXX Except it still doesn't actually work because we do this
    unlocked, ugh, so the write might complete before we abort anything.
    To be fixed some more in a later change.

    XXX kernel ABI change to uhidev_write signature, used by uhidev
    driver modules, requires bump
  module: src
  subject: 'CVS commit: src/sys/dev/usb'
  unixtime: '1648471374'
  user: riastradh