--- - branch: MAIN date: Sat Apr 9 23:38:57 UTC 2022 files: - new: '1.4' old: '1.3' path: src/common/lib/libc/atomic/atomic_load.c pathrev: src/common/lib/libc/atomic/atomic_load.c@1.4 type: modified - new: '1.4' old: '1.3' path: src/common/lib/libc/atomic/atomic_store.c pathrev: src/common/lib/libc/atomic/atomic_store.c@1.4 type: modified id: 20220409T233857Z.3a34b5a987fce8dae8aca043b4b2826a36e03baa log: | libc/atomic: Fix membars in __atomic_load/store_* stubs. - membar_enter/exit ordering was backwards. - membar_enter doesn't make any sense for load anyway. - Switch to membar_release for store and membar_acquire for load. The only sensible orderings for a simple load or store are acquire or release, respectively, or sequential consistency. This never provided correct sequential consistency before -- we should really make it conditional on memmodel but I don't know offhand what the values of memmodel might be and this is at least better than before. module: src subject: 'CVS commit: src/common/lib/libc/atomic' unixtime: '1649547537' user: riastradh