---
- branch: netbsd-8
  date: Mon Jul 31 16:16:05 UTC 2023
  files:
  - new: 1.39.8.1
    old: '1.39'
    path: src/sys/netatalk/at_control.c
    pathrev: src/sys/netatalk/at_control.c@1.39.8.1
    type: modified
  id: 20230731T161605Z.971d99e40d8a5104c4b48f384c150e7d9c330464
  log: "Pull up following revision(s) (requested by riastradh in ticket #1866):\n\n\tsys/netatalk/at_control.c:
    revision 1.44\n\natalk(4): Don't let userland control sa_len when adding addresses.\n-
    The struct sockaddr_at object accessed by at_ifinit always comes\n  from an ioctl
    buffer that is adequately sized and fully initialized\n  from userland memory.\n-
    The newly created sockaddr_at object is later used with\n  sockaddr_copy, which
    requires sa_len to be correctly initialized.\n- sa_len is not generally required
    to be correctly initialized by\n  userland in most entry points (with some exceptions,
    e.g. gif(4)\n  configuration).\n\nI don't know whether existing userland programs
    initialize sa_len\ncorrectly; if they do, we can verify it matches sizeof(struct\nsockaddr_at),
    but there's no need to copy sa_len then if it is\nverified to be that fixed value.\n"
  module: src
  subject: 'CVS commit: [netbsd-8] src/sys/netatalk'
  unixtime: '1690820165'
  user: martin