---
- branch: MAIN
  date: Mon Mar 18 16:15:24 UTC 2024
  files:
  - new: '1.66'
    old: '1.65'
    path: src/lib/libc/time/strptime.c
    pathrev: src/lib/libc/time/strptime.c@1.66
    type: modified
  id: 20240318T161524Z.5cff9bedbebd0523611ff2f10e98f6d8329ef822
  log: |
    strptime(3): Declare digit d as time_t.

    This doesn't make a semantic difference -- d can only take on the ten
    values {0,1,2,3,4,5,6,7,8,9}, and the arithmetic with it later all
    comes out the same whether the type is unsigned or time_t, even if
    time_t were int32_t instead of int64_t.

    But it pacifies overzealous compilers used by downstream users of
    this code.  And while it's silly to use a much wider type (64-bit
    signed) than is needed here to store a single digit, it doesn't
    really hurt either (32-bit unsigned is much larger than needed too).

    PR lib/58041
  module: src
  subject: 'CVS commit: src/lib/libc/time'
  unixtime: '1710778524'
  user: riastradh