--- - branch: MAIN date: Tue Mar 24 14:56:32 UTC 2020 files: - new: '1.75' old: '1.74' path: src/lib/librumpuser/rumpuser_sp.c pathrev: src/lib/librumpuser/rumpuser_sp.c@1.75 type: modified id: 20200324T145632Z.e04ab0aa87d83723878abd2bbde90f3c4c0325eb log: | If we're going to loop, pausing and then retrying malloc() after it has failed, in the hope that some other thread has free'd some memory, but we want to bound the number of attempts, it helps if we actually count them - otherwise we never get nearer to the limit. In practice, malloc() for a reasonable application on a modern system almost never fails, so the code containing this bug has probably never been, and never will be, executed, but just in case, someday. For this, it isn't clear if the intent was to have 10 retries (ie: 11 attempts) or 10 tries, but as the code said "retries > 10", I am assuming the former (not that it matters, if the malloc() has failed 10 times in a row, with 10 second pauses between, the chances of an 11th succeeding aren't great). module: src subject: 'CVS commit: src/lib/librumpuser' unixtime: '1585061792' user: kre