--- - branch: MAIN date: Tue Dec 19 02:16:07 UTC 2023 files: - new: '1.5' old: '1.4' path: src/external/bsd/iscsi/dist/src/lib/protocol.c pathrev: src/external/bsd/iscsi/dist/src/lib/protocol.c@1.5 type: modified id: 20231219T021607Z.60eed807a4cf2c8f825495ca201a94f99ecd9b18 log: | libiscsi: Fix types of Time2Wait and Time2Retain in logout decap. According to https://www.rfc-editor.org/rfc/rfc7143#section-11.15, these are both 2-byte quantities. Loading 4-byte quantities and passing them through ISCSI_NTOHS might have worked by accident on x86, but it's not gonna fly on big-endian. (Fortunately sparc64 is not just big-endian but also strict-alignment so it caught this problem!) XXX Is there an upstream for this code? doc/3RDPARTY doesn't cite any easily-followed references. PR port-sparc64/57784 XXX pullup-10 XXX pullup-9 XXX pullup-8 module: src subject: 'CVS commit: src/external/bsd/iscsi/dist/src/lib' unixtime: '1702952167' user: riastradh