Fix import

(roy)

Note dhcpcd-10.0.6

(roy)

Sync with dhcpcd-10.0.6

(roy)

Note import of dhcpcd-10.0.4

(roy)

Sync with dhcpcd-10.0.4

(roy)

Note update to dhcpcd-10.0.3

(roy)

sync with dhcpcd-10.0.3

(roy)

Note import of dhcpcd-10.0.2

(roy)

Sync with dhcpcd-10.0.2

(roy)

Note update to openresolv-3.13.2

(roy)

Sync with openresolv-3.13.2

(roy)

dhcpcd: Fix non INET6 builds.

Thanks to J. Hannken-Illjes for the fix.

(roy)

Note update to dhcpcd-10.0.1

(roy)

Merge changes

(roy)

arp: Validate ARP source hardware address matches Ethernet source

RFC 5227 section 1.1 states that for a DaD ARP probe the sender hardware
address must match the hardware address of the interface sending the
packet.

We can now verify this by checking the mbuf tag PACKET_TAG_ETHERNET_SRC.

This fixes an obsure issue where an old router was sending out bogus
ARP probes.

Thanks to Ryo Shimizu <ryo@nerv.org> for the re-implementation.

(roy)

Revert prior.

(roy)

Revert prior.

(roy)

Revert prior.

(roy)

Adjust comment for new sizes.

Thanks to Kengo NAKAHARA <k-nakahara@iij.ad.jp>

(roy)

arp: Validate L2 sender hardware address matches ARP probe

RFC 5227 section 1.1 states that for a DaD ARP probe the sender hardware
address must match the hardware address of the interface sending the
packet.

We can now verify this by checking the mbuf packet header.

This fixes an obsure issue where an old router was sending out bogus
ARP probes.

(roy)

net: Store a pointer to the Layer 2 Sender Hardware address in mbuf

The BSD networking stack is designed around passing a mbuf down the chain
and each layer removes the part it's interested in before passing it to
the next. This makes it easy for each layer to do it's work,
but non trivial to work backwards.

As such we now store a pointer to the Senders Hardware address in the
mbuf packet header so that protocols can perform any required validation.

(roy)

Handle the SIOCGNBRINFO ioctl for compat32.
arp -a works with compat32 now.

Credit to simonb@ for the ndp fix from which this is cribbed.

(roy)

Fix build of xlint/line1 with OBJDIR set.

(roy)

Note update to dhcpcd-9.4.1

(roy)

Remove build for stuff dhcpcd's import-src target now does.

(roy)

Sync update

(roy)

netinet: Allow binding the unspecified address when no addresses exist

You should always be able to bind to the unspecified address even if
no addresses have been configured on any interface.

For example, a DHCP client could be started before the loopback interface
has been fully configured.

(roy)

if_arp: Just KASSERT that arphrd is aligned

While here improve readability of checking ARP IEEE1394 matches interface.

(roy)

if_ether: revert prior alignment checks

Apparently not needed as our drivers ensure this.

(roy)

if_gre: Remove alignment checks in favour copying to stack

Makes the code a lot simpler, idea from dyoung@

(roy)

Prior alignment fixes should not use an offset

(roy)

if_arp: Ensure that arphdr is aligned

(roy)

if_ether: Ensure that ether_header is aligned

(roy)

if_gre: Ensure that gre_h is aligned

(roy)

CTASSERT -> __CTASSERT to unbreak userland build.

While here move __packed in tcp_debug.h back to where it was and
note removal warrants more investigation.

(roy)

Guard CTASSERT

(roy)

if_llc.h: Replace __packed with CTASSERT

(roy)

Sprinkle CTASSERT to enforce on-wire layout without __packed

(roy)

tcp_debug: restore __packed

(roy)

Whitespace

(roy)

tftp: no longer need packed member warning

(roy)

rtadvd: no longer need packed member warning

(roy)

traceroute: no longer need gcc packed member warning

(roy)

ldpd: Discard warning about accessing packed member

I don't see a good way of fixing this right now.

(roy)

traceroute6: Remove __packed

(roy)

Remove __packed from various network structures

They are already network aligned and adding the __packed attribute
just causes needless compiler warnings about accssing members of packed
objects.

(roy)

ntpd: ignore errno EINTR on reads from the routing socket

(roy)

ntpd: move route socket overflow message from LOG_ERR to LOG_DEBUG

While here stop caring about RTM_LOSING as that's purely informational.
If routing does change then we get RTM_ADD/DEL/CHANGE.
Also stop caring about RTM_IFANNOUNCE as we really only want addresses
and interface flag updates which we get by RTM_NEWADDR/DELADDR/CHGADDR and
RTM_IFINFO.

(roy)

ntp: respect user's wishes to disable interface scanning

While here, disable periodic scanning by default on NetBSD as it's
no longer needed.
The user can still enable it though with a positive number to the -U
option.

kardel@ So far I see no other issues from the pitfalls I know of

(roy)

libunbound: Enforce that mini_event isn't used by include/config.h

As I tire of fixing it to use libevent.

(roy)

Revert prior

With the correct #defines mini_event.c and winsock_event.c are
compiled but practically unused.

What is exposed is not part of the public API, but appease the
peanut gallery.

(roy)

libunbound: Now we use libevent, don't build mini_event or winsock_event.

(roy)

libunbound: actually use libevent as we link to it

Would appreciate if people modify this file to actually test what
polling mechanism unbound uses as select(2) is pretty poor.

(roy)

ntpd: In the event of route(4) overflow, update the interfaces

(roy)

wpa: If route socket overflows, sync drivers to system interfaces

Messages such as RTM_IFNFO or RTM_IFANNOUNCE could have been lost.
As such, sync the state of our internal driver to the state of the
system interfaces as reported by getifaddrs(2).

This change requires the routing socket be placed in non-blocking
mode. While here, set the routing and inet sockets to close on exec.

(roy)

Note update to dhcpcd-9.4.0

(roy)

Sync with dhcpcd-9.4.0

(roy)

Note openresolv-3.12.0 update

(roy)

Sync with openresolv-3.12.0

(roy)

t_ossaudio was installed for clang, so remove gcc marking

(roy)

diffutils: execl requires a NULL sentinel

(roy)

Note update to dhcpcd-9.3.4

(roy)

Sync with dhcpcd-9.3.4

(roy)

Note import of dhcpcd-9.3.3

(roy)

Sync with dhcpcd-9.3.3

(roy)

bridge: revert prior

It's of little use.
If we need to do this in the future, consider a sysctl to do it for all
interfaces in the bridge and not just the one being added.

(roy)

Note dhcpcd update

(roy)

Sync with dhcpcd-9.3.2

(roy)

l2tp: call if_link_state_change rather then directly setting it.

This allows protocols to do their thing.

(roy)

l2tp: Revert prior

It proves I can't read comments and that if_initialize should not be used.

(roy)

Remove extra parens

(roy)

libossaudio: return newfd here as we return retval elsewhere

(roy)

le(4): add link status change reporting to drivers which support it

Reviewed by thorpej@
Tested by martin@

(roy)

wg: Fix tests by sprinkling ifconfig -w 10

So protocols have time to finish setup.

(roy)

net: remove IFEF_NO_LINK_STATE_CHANGE

This flag was only set for virtual interfaces.
All virtual interfaces have a means of knowing if they are going to work
or not and as such now support link state changes.

If we want this flag back, it should be used as an indicator that
the interfaces does not support link state changes that userland can use
so it can make a decision on what to do when the link state is UNKNOWN.

(roy)

wg: with no peers, the link status is DOWN, otherwise UP

This mirrors the recent changes to gif(4) where the link is UP when a
tunnel is set, otherwise DOWN.

(roy)

l2tp: Set the link state UP if we have a tunnel, otherwise DOWN.

(roy)

ipsecif: Set the link state UP if we have a tunnel, otherwise DOWN.

(roy)

loop: set LINK_STATE_UP a touch earlier

(roy)

loop: this interface's link state cannot be anything other than UP

Let's not pretend it's UNKNOWN anymore.

(roy)

gif: Set the link state UP if we have a tunnel, otherwise DOWN.

(roy)

carp: Don't set a link level address if vhid == -1

Link level address for carp is dervied from vhid.
Until vhid is set, carp is useless, so don't give it a link level address
until a vhid is set.

This fixes recent test case breakage where carp was fixed to actually
print the ethernet address set by default. Note that neither carp nor
the test case itself was actually broken as the error is the common
ATF net code assuming that a cloned interface's link level address is
unique upon creation.

(roy)

ifconfig: go back to using direct ioctls rather than data from getifaddrs

AF_LINK may not be the first address returned for the interface.
Technically, it *might* not even exist on the interface even though
other families do.
This is likely a driver bug if this really is the case though.

As such it's just easier to use direct ioctls rather than thump around
getifaddrs results. As it stands, the code makes a lot of getifaddrs
calls anyway, so an extra ioctl or two won't break the bank.

(roy)

powerd: Stop crashing if entries are not found in the dictionary

If the first three are not found, log a diagnostic and do nothing.
If the latter two are not found, set them to NULL rather than garbage.

(roy)

carp: link state is DOWN until it becomes a MASTER

This is consitent with other BSD's handling of CARP and means
we don't have to carry a custom flag for it.

(roy)

Note update to dhcpcd-9.3.1

(roy)

Sync withn dhcpcd-9.3.1

(roy)

carp: Set ethernet address just before interface registation

Otherwise ifconfig reports SIOCGLIFADDR errors.

(roy)

ifconfig: if SIOCGLIFADDR fails, continue to the next address

(roy)

carp: Remove media, software should use link status.

carp literally has no media just like ppp, vlan, etc.

(roy)

net80211: Initialise the interface with a decent link state.

Link state transitions to UP when a node is joined and DOWN when left.
This means that with the interface UP, the link state could be UNKNOWN
for a while, implying it can be used in BSS mode.
Which is of course false.

Add a function to set an initial link state based on the operating mode.
Also call this when the operating mode changes.

Basically in BSS and MONITOR it starts off down.
BSS will transition UP and DOWN as before, MONITOR will stay down.
IBSS, AHDEMO and HOSTAP will remain as link unknown because the state is
..... unknown.

(roy)

Minor correction to prior

(roy)

ifconfig: Warn once more if media supported but no types

This reverts media.c -r1.7

(roy)

ppp: Remove media

There is none after all.
Applications should be using ifi_link_state and not checking media.

(roy)

Note import of dhcpcd-9.3.0

(roy)

Sync with dhcpcd-9.3.0

(roy)

soreadable() should consider so_rerror

(roy)

ifwatchd: Enable SO_RERROR to re-sync interface state.

Interface arrival, departure and link state changes will sync
and if different will be actioned.

Currently we do not track addresses, so any changes there are still lost.

(roy)

Add if_tap directory for DEBUG builds.

(roy)

Be like other tests and speciy the binary name we install

(roy)

Fix prior

(roy)

Add rump_open_tap

(roy)

tap(4): update the test so that we can open the tap to ping across a bridge

ping with tap closed to ensure it fails
ping with tap open to ensure it works

(roy)

vether(4): Add ATF tests based on the tap(4) tests.

(roy)

inet: Treat LINK_STATE_UNKNOWN as LINK_STATE_UP when changing

It's something we have always done.
it's really rare for anything to transition to UNKNOWN from either
UP or DOWN, but technically it is possible.

(roy)

rumpify vether(4)

(roy)

libtap: Improve comment

(roy)

Whitespace

(roy)

Fix build with clang.

(roy)

xinstall: define MAKE_NATIVE so our make parts compile

(roy)

ifconfig: Just look at if_data->ifi_link_state for carrier

It should be the sole source of truth.
if_data is also carried in ifa_data from getifaddrs(3) which saves
more ioctl calls.

(roy)

ifwatchd: remove SIOCGIFDATA and SIOCGIFMEDIA ioctls

getifaddrs(3) and route(4) provide all the data we need.

(roy)

Note that opening and closing the tun/tap devices affects link state.

And how this influences Duplicate Address Detection.

(roy)

tun: Report link state based on if the interface has been opened or not

This mirrors tap(4).

(roy)

bridge: When an interface joins then mark addresses on it as tentative

The exact flow is detatch addresses, join bridge and then mark detached
addresses as tentative.
This ensures that Duplicate Address Detection for the joining interface
are performed across all members of the bridge.

(roy)

Wups, forgot to commit this with vether.

(roy)

bridge(4): Note that the bridge does not allow assignment of IP addresses

Document using vether(4) instead to get the same effect.

(roy)

tap(4): Improve the description to differentiate from vether(4)

(roy)

vether: Add to kernel configurations

It's only enabled if the kernel enabled bridge AND tap.
Otherwise it's commented out.

(roy)

Note import of vether(4)

(roy)

tap: Report link state based on if the interface has been opened or not

While a nice addition, it does render tap(4) useless as a bridge(4)
endpoint. We now have vether(4) for use as bridge endpoint.

(roy)

vether: Implement a virtual ethernet interface

The vether interface simulates a normal Ethernet interface by encapsulating
standard network frames with an Ethernet header, specifically for use as
a member in a bridge(4).

To use vether the administrator needs to configure an address onto the
interface so that packets can be routed to it. An Ethernet header will
be prepended and, if the vether interface is a member of a bridge(4),
the frame will show up there.

Taken from OpenBSD.

(roy)

rump: Add weak alias for bridge_calc_link_state

(roy)

bridge: Calculate link state as the best link state of any member

If any member is LINK_STATE_UP then it's LINK_STATE_UP.
Otherwise if any member is LINK_STATE_UNKNOWN then it's LINK_STATE_UNKNOWN.
Otherwise it's LINK_STATE_DOWN.

(roy)

rump: Try to fix build

(roy)

ifconfig: We already have struct if_data in ifa_data.

So let's not bother with an ioctl we don't need.

(roy)

tap: Remove media from this virtual interface

It serves no purpose at all.

(roy)

vlan: match the interface link state with that of the parent

Now addresses on a vlan will detach and undergo duplicate address
dectection on link state changes just as on a standard interface.

(roy)

net: Add a callback to ifnet to notify of link state changes

(roy)

net: Fix the setting of if_link_state

Link state changes are not dependant on the interface being up, but we also
need to guard against more link state changes being scheduled when the
interface is being detached.

We do this by clearing the link queue but keeping if_link_sheduled = true.
We can check for this in both if_link_state_change() and
if_link_state_change_work() to abort early as there is no point in doing
anything if the interface is being detached because if_down() is called
in if_detach() after the workqueue has been drained to the same overall
effect.

(roy)

ifconfig: test cases want LINK_STATE_UNKNOWN to be treated as up.

(roy)

ifwatchd: Check link state if no media is supported on initial ups.

We can check this via SIOCGIFDATA and ifi_link_state.

(roy)

ifconfig: teach carrier test about ifi_link_state from SIOCGIFDATA

Because not all interfaces support media.

(roy)

ifconfig: Report link state even if media is not supported

For AF_LINK addrs from getifaddrs(2), ifa_data is struct if_data.
This in turn holds ifi_link_state which we can use to report
link status if the interface does not support media where it's normally
reported.

Based on OpenBSD.

(roy)

arp tests: Delete ARP entry after failed ping test

As it might hang around in WAITDELETE for a few seconds.

(roy)

ndp_rtm: Only ping once

Pointless doing 3 pings.
On a slow system, it's possible that many RTM_MISS messages could
overflow into the next test.

(roy)

arp_rtm: Only ping once

Pointless doing 10 pings.
On a slow system, it's possible that many RTM_MISS messages could
overflow into the next test.

(roy)

Note ND changes for ARP and RFC 7048.

(roy)

9.99.73 welcomes SIOCGNBRINFO

(roy)

nd: give missed a default of ND_LLINFO_NOSTATE

It's impossible to miss from this state, where-as 0 is ND_LLINFO_INCOMPLETE
which we can miss from.

(roy)

Don't check lifetime when testing published

(roy)

arp: Permanence is from the llentry, not the route

(roy)

ndp: Show U for Unreachable

(roy)

arp: Show U for Unreachable

(roy)

Implement RFC 7048, making Neighbor Unreachability Detection less impatient

RFC 7048 Section 3 says in the UNREACHABLE state packets continue to be
sent to the link-layer address and then backoff exponentially.
We adjust this slightly and move to the INCOMPLETE state after
`nd_mmaxtries` probes and then start backing off.

This results in simpler code whilst providing a more robust model which
doubles the time to failure over what we did before.
We don't want to be back to the old ARP model where no unreachability
errors are returned because very few applications would look at
unreachability hints provided such as ND_LLINFO_UNREACHABLE or RTM_MISS.

(roy)

nd: Name l3addr union of llentry and use in-place of nd_addr.

Probably makes more sense and makes nd.h less messy.

(roy)

arp test: Use the ndp cache expiration test in place of the old one

As the logic is the same.
While here, GC some variables and comment out a redundant sleep.

(roy)

nd needs arp or inet6. inet is not enough.

(roy)

inet: Fix build without ARP

(roy)

Include nd.h in sets

(roy)

rump: Add nd.c to libnet

(roy)

kdump: include netinet/in_var.h to access in_nbrinfo

(roy)

arp: Use SIOCGNBRINFO to display neighbor state information

(roy)

inet: Add SIOCGNBRINFO to retrieve neighbor state about an address

(roy)

in: No need to set expire here anymore

(roy)

sysctl: Adjust man page for new ARP sysctl ND settings

(roy)

ARP: Use ND rather than our own.

This brings the benefit of Neighbour Unreachability Detection which is
something ARP sorely lacks.

The new timings mirror those of IPv6 and are adjustable via sysctl(8).
Unlike IPv6 ND, these are global and not per interface.

(roy)

tcp_input: Adjust for ND changes

(roy)

inet6: Use generic Neighor Detection rather than IPv6 specific

No functional change intended.

(roy)

if_llatbl.c: adjust for nd changes

(roy)

Implement address agnostic Neighbor Detection.

This is heavily based on IPv6 Neighbor Detection and allows per protocol
timers which also facilitate Neighor Unreachability Detection.

(roy)

Note dhcpcd update

(roy)

dhcpcd: Use ppoll(2)

(roy)

Sync

(roy)

Sprinkle some const

(roy)

icmp6: Remove __packed attribute from icmp6 structures

They should naturally align.
Add compile time assertations to icmp6.c to prove this.

(roy)

ip6: Remove __packed attribute from ip6 structures

They should naturally align.
Add compile time assertations to ip6_input.c to prove this.

(roy)

mdnsd: Make the unable to parse resolv.conf message informative

resovconf will SIGHUP mdnsd when resolv.conf changes so this message
should not be an error.

(roy)

Note openresolv update

(roy)

Note the new resolvconf files

(roy)

openresolv: Rework the build system to cope with more directories

While here, install avahi-daemon and mdnsd notifiers for when
/etc/resolv.conf is updated.

(roy)

Sync

(roy)

mdnsd: starting and stopping are informational messages

(roy)

mdnsd: Treat EADDRNOTAVAIL as a transient error

(roy)

wpa_supplicant: Matching unspecified interfaces should not log driver fails

If there is no matching interface given, but interface matching is enabled
then all interfaces on the system will try to be initialized.

Non wireless interfaces will fail and the loopback device will be one
of these, so just log a diagnostic rather than an error.

(roy)

wpa_supplicant: Don't report an error when there are no op classes to add

Instead, log a diagnostic so that noise to the user is reduced.

(roy)

wpa_supplicant: don't log SIOCG80211 errors during interface setup

Unless debugging.
wpa_supplicant will log it failed to initialized the driver for the
interface anyway so this just silences some noise for users.

(roy)

unbreak build, put /var/db/dhcpcd into the set lists

(roy)

Add /var/db/dhcpcd back

(roy)

Note import of dhcpcd-9.1.4

(roy)

Sync

(roy)

dhcpcd: Fix SMALL build

(roy)

Note import of dhcpcd-9.1.3

(roy)

Sync

(roy)

Adjust prior to enforce minimum socket length includes sa_family

Not that the code strictly needs it, but if the macro is ever used
elsewhere then it makes sense as every sockaddr must have it.
The rest of the structure is dictated by the family and in some cases,
truncated on purpose so this is fine.

(roy)

Ensure sockaddrs have valid lengths for RO_MISSFILTER.

Thanks to maxv@ for spotting this.

(roy)

libterminfo: cast to uint16/32_t before conversion to preserve negativity

Otherwise the ABSENT_NUMERIC(-1) or CANCELLED_NUMERIC(-2) will be converted
incorrectly to size_t and then down to uint16/32_t.
Picked up by DIAGNOSTIC builds.

Thanks to Michael Forney for the fix for PR lib/52293.

(roy)

icmp6.h: #define ND_RA_FLAG_PROXY

RFC 4389, experimental. Maybe someone will implement it one day.

(roy)

icmp6.h: #define ND_OPT_PI_FLAG_ROUTER

We already define ND_RA_FLAG_HOME_AGENT and that kind of requires
ND_OPT_PI_FLAG_ROUTER.

(roy)

Note import of dhcpcd-9.1.2

(roy)

dhcpcd: Build privsep resource limited sandbox.

(roy)

Sync

(roy)

inet6: Allow addresses to be marked AUTOCONF from userland

(roy)

SCTP: Use ifp->if_mtu rather than ND_IFINFO(ifp)->linkmtu

(roy)

ndp: Sync usage and SYNPOSIS with reality

(roy)

Add nd6.h compat header

(roy)

Revert accidental part of prior

(roy)

9.99.66 welcomes the removal of in-kernel RA handling

(roy)

Note removal of RA handling.

(roy)

Remove in-kernel handling of Router Advertisements

This is much better handled by a user-land tool.
Proposed on tech-net here:
https://mail-index.netbsd.org/tech-net/2020/04/22/msg007766.html

Note that the ioctl SIOCGIFINFO_IN6 no longer sets flags. That now
needs to be done using the pre-existing SIOCSIFINFO_FLAGS ioctl.

Compat is fully provided where it makes sense, but trying to turn on
RA handling will obviously throw an error as it no longer exists.

Note that if you use IPv6 temporary addresses, this now needs to be
turned on in dhcpcd.conf(5) rather than in sysctl.conf(5).

(roy)