Received: by mail.netbsd.org (Postfix, from userid 605) id 25A4284EB2; Sat, 10 Feb 2018 04:25:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 7F1B184CEF for ; Sat, 10 Feb 2018 04:25:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([127.0.0.1]) by localhost (mail.netbsd.org [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id 4bCDxzw5XJB5 for ; Sat, 10 Feb 2018 04:25:38 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.netbsd.org [199.233.217.197]) by mail.netbsd.org (Postfix) with ESMTP id 026DF84EB6 for ; Sat, 10 Feb 2018 04:25:37 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id 2FC0FFB41; Sat, 10 Feb 2018 04:25:36 +0000 (UTC) Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" MIME-Version: 1.0 Date: Sat, 10 Feb 2018 04:25:36 +0000 From: "Soren Jacobsen" Subject: CVS commit: [netbsd-6-1] src/sys/dist/pf/net To: source-changes@NetBSD.org X-Mailer: log_accum Message-Id: <20180210042536.2FC0FFB41@cvs.NetBSD.org> Sender: source-changes-owner@NetBSD.org List-Id: source-changes.NetBSD.org Precedence: bulk Reply-To: source-changes-d@NetBSD.org Mail-Reply-To: "Soren Jacobsen" Mail-Followup-To: source-changes-d@NetBSD.org List-Unsubscribe: Module Name: src Committed By: snj Date: Sat Feb 10 04:25:36 UTC 2018 Modified Files: src/sys/dist/pf/net [netbsd-6-1]: pf.c Log Message: Pull up following revision(s) (requested by maxv in ticket #1527): sys/dist/pf/net/pf.c: revision 1.78 via patch Oh, what is this. Fix a remotely-triggerable integer overflow: the way we define TCPOLEN_SACK makes it unsigned, and the comparison in the while() is unsigned too. That's not the expected behavior, the original code wanted a signed comparison. It's pretty easy to make 'hlen' go negative and trigger a buffer overflow. This bug was reported 8 years ago by Lucio Albornoz in PR/44059. To generate a diff of this commit: cvs rdiff -u -r1.68 -r1.68.8.1 src/sys/dist/pf/net/pf.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.