Received: by mail.netbsd.org (Postfix, from userid 605) id 0FC8C84D9B; Sat, 25 Aug 2018 14:22:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 0E22384D9E for ; Sat, 25 Aug 2018 14:22:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([IPv6:::1]) by localhost (mail.netbsd.org [IPv6:::1]) (amavisd-new, port 10025) with ESMTP id q54Upt9btbE6 for ; Sat, 25 Aug 2018 14:22:50 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.NetBSD.org [IPv6:2001:470:a085:999:28c:faff:fe03:5984]) by mail.netbsd.org (Postfix) with ESMTP id 2F08584CD7 for ; Sat, 25 Aug 2018 14:22:50 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id 1EAF2FBEC; Sat, 25 Aug 2018 14:22:50 +0000 (UTC) Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" MIME-Version: 1.0 Date: Sat, 25 Aug 2018 14:22:50 +0000 From: "Martin Husemann" Subject: CVS commit: [netbsd-8] src/bin/sh To: source-changes@NetBSD.org X-Mailer: log_accum Message-Id: <20180825142250.1EAF2FBEC@cvs.NetBSD.org> Sender: source-changes-owner@NetBSD.org List-Id: source-changes.NetBSD.org Precedence: bulk Reply-To: source-changes-d@NetBSD.org Mail-Reply-To: "Martin Husemann" Mail-Followup-To: source-changes-d@NetBSD.org List-Unsubscribe: Module Name: src Committed By: martin Date: Sat Aug 25 14:22:50 UTC 2018 Modified Files: src/bin/sh [netbsd-8]: eval.c eval.h main.c Log Message: Pull up following revision(s) (requested by kre in ticket #983): bin/sh/eval.c: revision 1.158 bin/sh/eval.h: revision 1.21 bin/sh/main.c: revision 1.74 PR bin/48875 Revert the changes that were made 19 May 2016 (principally eval.c 1.125) and the bug fixes in subsequent days (eval.c 1.126 and 1.127) and also update some newer code that was added more recently which acted in accordance with those changes (make that code be as it would have been if the changes now being reverted had never been made). While the changes made did solve the problem, in a sense, they were never correct (see the PR for some discussion) and it had always been intended that they be reverted. However, in practical sh code, no issues were reported - until just recently - so nothing was done, until now... After this commit, the validate_fn_redirects test case of the sh ATF test t_redir will fail. In particular, the subtest of that test case which is described in the source (of the test) as: This one is the real test for PR bin/48875 will fail. Alternative changes, not to "fix" the problem in the PR, but to often avoid it will be coming very soon - after which that ATF test will succeed again. XXX pullup-8 To generate a diff of this commit: cvs rdiff -u -r1.140.2.4 -r1.140.2.5 src/bin/sh/eval.c cvs rdiff -u -r1.19 -r1.19.8.1 src/bin/sh/eval.h cvs rdiff -u -r1.70.2.1 -r1.70.2.2 src/bin/sh/main.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.