Received: by mail.netbsd.org (Postfix, from userid 605) id A05DC84D41; Sat, 22 Dec 2018 10:00:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 97ED484D32 for ; Sat, 22 Dec 2018 10:00:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([127.0.0.1]) by localhost (mail.netbsd.org [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id NlkDbLbRBaH9 for ; Sat, 22 Dec 2018 10:00:39 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.netbsd.org [199.233.217.197]) by mail.netbsd.org (Postfix) with ESMTP id D573C84CCF for ; Sat, 22 Dec 2018 10:00:39 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id CCEFBFB16; Sat, 22 Dec 2018 10:00:39 +0000 (UTC) Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" MIME-Version: 1.0 Date: Sat, 22 Dec 2018 10:00:39 +0000 From: "Maxime Villard" Subject: CVS commit: src/sys/arch/x86/x86 To: source-changes@NetBSD.org X-Mailer: log_accum Message-Id: <20181222100039.CCEFBFB16@cvs.NetBSD.org> Sender: source-changes-owner@NetBSD.org List-Id: source-changes.NetBSD.org Precedence: bulk Reply-To: source-changes-d@NetBSD.org Mail-Reply-To: "Maxime Villard" Mail-Followup-To: source-changes-d@NetBSD.org List-Unsubscribe: Module Name: src Committed By: maxv Date: Sat Dec 22 10:00:39 UTC 2018 Modified Files: src/sys/arch/x86/x86: spectre.c Log Message: In the end, disable the supposed architectural SpectreV2 mitigation on AMD f12h and f16h. The SDMs of these CPUs haven't been updated since, and we shouldn't assume the position of the bits, we just can't know where they are. Initially I included f12h and f16h because f10h is actually documented to have a bit to disable the indirect branch predictor, and there were patches available in SuSE and CentOS that were treating f10h/f12h/f16h all the same. Knowing that SuSE has ties with AMD, it seemed safe to assume that these patches were correct and that f12h and f16h could indeed be treated the same way as f10h. But these patches have now disappeared, and the main Linux branch doesn't have them, without clear explanation. Therefore, I prefer to roll-back. To generate a diff of this commit: cvs rdiff -u -r1.21 -r1.22 src/sys/arch/x86/x86/spectre.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.