Received: by mail.netbsd.org (Postfix, from userid 605) id DD22A84D57; Thu, 10 Oct 2019 03:44:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 6102884D44 for ; Thu, 10 Oct 2019 03:44:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([127.0.0.1]) by localhost (mail.netbsd.org [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id l7TznP0Q9cxg for ; Thu, 10 Oct 2019 03:44:00 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.netbsd.org [199.233.217.197]) by mail.netbsd.org (Postfix) with ESMTP id 783D284C6C for ; Thu, 10 Oct 2019 03:44:00 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id 713DDFBF4; Thu, 10 Oct 2019 03:44:00 +0000 (UTC) Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" MIME-Version: 1.0 Date: Wed, 9 Oct 2019 23:44:00 -0400 From: "Christos Zoulas" Subject: CVS commit: src/sys/dev/raidframe To: source-changes@NetBSD.org X-Mailer: log_accum Message-Id: <20191010034400.713DDFBF4@cvs.NetBSD.org> Sender: source-changes-owner@NetBSD.org List-Id: source-changes.NetBSD.org Precedence: bulk Reply-To: source-changes-d@NetBSD.org Mail-Reply-To: "Christos Zoulas" Mail-Followup-To: source-changes-d@NetBSD.org List-Unsubscribe: Module Name: src Committed By: christos Date: Thu Oct 10 03:44:00 UTC 2019 Modified Files: src/sys/dev/raidframe: raidframevar.h rf_callback.c rf_callback.h rf_copyback.c rf_dag.h rf_dagdegrd.c rf_dagdegrd.h rf_dagdegwr.c rf_dagdegwr.h rf_dagffrd.c rf_dagffwr.c rf_dagffwr.h rf_dagfuncs.c rf_dagfuncs.h rf_dagutils.c rf_dagutils.h rf_desc.h rf_diskqueue.c rf_diskqueue.h rf_driver.c rf_engine.c rf_engine.h rf_evenodd_dagfuncs.c rf_evenodd_dagfuncs.h rf_evenodd_dags.c rf_netbsd.h rf_paritylog.c rf_paritylog.h rf_paritylogDiskMgr.c rf_paritylogDiskMgr.h rf_parityloggingdags.c rf_parityloggingdags.h rf_parityscan.c rf_parityscan.h rf_pq.c rf_pq.h rf_psstatus.c rf_psstatus.h rf_raid.h rf_raid1.c rf_reconbuffer.c rf_reconstruct.c rf_reconstruct.h rf_states.c rf_states.h rf_stripelocks.h Log Message: fix the function pointer and callback mess: - callback functions return 0 and their result is not checked; make them void. - there are two types of callbacks and they used to overload their parameters and the callback structure; separate them into "function" and "value" callbacks. - make the wait function signature consistent. To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.21 src/sys/dev/raidframe/raidframevar.h \ src/sys/dev/raidframe/rf_dagffrd.c src/sys/dev/raidframe/rf_dagutils.h \ src/sys/dev/raidframe/rf_desc.h cvs rdiff -u -r1.23 -r1.24 src/sys/dev/raidframe/rf_callback.c \ src/sys/dev/raidframe/rf_evenodd_dagfuncs.c cvs rdiff -u -r1.6 -r1.7 src/sys/dev/raidframe/rf_callback.h \ src/sys/dev/raidframe/rf_dagdegwr.h src/sys/dev/raidframe/rf_engine.h \ src/sys/dev/raidframe/rf_parityloggingdags.h cvs rdiff -u -r1.51 -r1.52 src/sys/dev/raidframe/rf_copyback.c cvs rdiff -u -r1.19 -r1.20 src/sys/dev/raidframe/rf_dag.h \ src/sys/dev/raidframe/rf_paritylog.c cvs rdiff -u -r1.30 -r1.31 src/sys/dev/raidframe/rf_dagdegrd.c \ src/sys/dev/raidframe/rf_dagfuncs.c cvs rdiff -u -r1.8 -r1.9 src/sys/dev/raidframe/rf_dagdegrd.h \ src/sys/dev/raidframe/rf_parityscan.h \ src/sys/dev/raidframe/rf_stripelocks.h cvs rdiff -u -r1.34 -r1.35 src/sys/dev/raidframe/rf_dagdegwr.c cvs rdiff -u -r1.35 -r1.36 src/sys/dev/raidframe/rf_dagffwr.c \ src/sys/dev/raidframe/rf_parityscan.c cvs rdiff -u -r1.7 -r1.8 src/sys/dev/raidframe/rf_dagffwr.h cvs rdiff -u -r1.10 -r1.11 src/sys/dev/raidframe/rf_dagfuncs.h cvs rdiff -u -r1.56 -r1.57 src/sys/dev/raidframe/rf_dagutils.c cvs rdiff -u -r1.55 -r1.56 src/sys/dev/raidframe/rf_diskqueue.c cvs rdiff -u -r1.24 -r1.25 src/sys/dev/raidframe/rf_diskqueue.h cvs rdiff -u -r1.135 -r1.136 src/sys/dev/raidframe/rf_driver.c cvs rdiff -u -r1.52 -r1.53 src/sys/dev/raidframe/rf_engine.c cvs rdiff -u -r1.5 -r1.6 src/sys/dev/raidframe/rf_evenodd_dagfuncs.h \ src/sys/dev/raidframe/rf_pq.h cvs rdiff -u -r1.4 -r1.5 src/sys/dev/raidframe/rf_evenodd_dags.c \ src/sys/dev/raidframe/rf_paritylogDiskMgr.h \ src/sys/dev/raidframe/rf_states.h cvs rdiff -u -r1.33 -r1.34 src/sys/dev/raidframe/rf_netbsd.h cvs rdiff -u -r1.12 -r1.13 src/sys/dev/raidframe/rf_paritylog.h cvs rdiff -u -r1.29 -r1.30 src/sys/dev/raidframe/rf_paritylogDiskMgr.c cvs rdiff -u -r1.22 -r1.23 src/sys/dev/raidframe/rf_parityloggingdags.c cvs rdiff -u -r1.16 -r1.17 src/sys/dev/raidframe/rf_pq.c cvs rdiff -u -r1.36 -r1.37 src/sys/dev/raidframe/rf_psstatus.c \ src/sys/dev/raidframe/rf_raid1.c cvs rdiff -u -r1.14 -r1.15 src/sys/dev/raidframe/rf_psstatus.h cvs rdiff -u -r1.47 -r1.48 src/sys/dev/raidframe/rf_raid.h cvs rdiff -u -r1.25 -r1.26 src/sys/dev/raidframe/rf_reconbuffer.c cvs rdiff -u -r1.122 -r1.123 src/sys/dev/raidframe/rf_reconstruct.c cvs rdiff -u -r1.28 -r1.29 src/sys/dev/raidframe/rf_reconstruct.h cvs rdiff -u -r1.50 -r1.51 src/sys/dev/raidframe/rf_states.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.