Received: by mail.netbsd.org (Postfix, from userid 605) id 1114384E6C; Thu, 5 Dec 2019 05:29:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 8C04984E68 for ; Thu, 5 Dec 2019 05:29:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([127.0.0.1]) by localhost (mail.netbsd.org [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id cEd-WnZsJHz7 for ; Thu, 5 Dec 2019 05:29:28 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.NetBSD.org [IPv6:2001:470:a085:999:28c:faff:fe03:5984]) by mail.netbsd.org (Postfix) with ESMTP id 2AC0D84D04 for ; Thu, 5 Dec 2019 05:29:28 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id 2869BFA97; Thu, 5 Dec 2019 05:29:28 +0000 (UTC) Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" MIME-Version: 1.0 Date: Thu, 5 Dec 2019 05:29:28 +0000 From: "SAITOH Masanobu" Subject: CVS commit: src/sys/net To: source-changes@NetBSD.org X-Mailer: log_accum Message-Id: <20191205052928.2869BFA97@cvs.NetBSD.org> Sender: source-changes-owner@NetBSD.org List-Id: source-changes.NetBSD.org Precedence: bulk Reply-To: source-changes-d@NetBSD.org Mail-Reply-To: "SAITOH Masanobu" Mail-Followup-To: source-changes-d@NetBSD.org List-Unsubscribe: Module Name: src Committed By: msaitoh Date: Thu Dec 5 05:29:28 UTC 2019 Modified Files: src/sys/net: if_media.h Log Message: Fix previous comment change for ifm_media. It was correct. The real problem is that some driver misuse ifm_media as the current active media. struct mii_data has the current active media(mii_media_active). If a driver use mii(4), it can be use mii->mii_media_active for this purpose. struct ifmedia has no entry for this purpose. Some drivers have an entry in their own softc to keep the value, but some other's don't have it and they mistakenly use ifm_media. We might add a new entry to struct ifmedia in future to avoid this confusion and for simplify. To generate a diff of this commit: cvs rdiff -u -r1.67 -r1.68 src/sys/net/if_media.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.