Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified)) by mollari.NetBSD.org (Postfix) with ESMTPS id 149121A9213 for ; Sun, 26 Jul 2020 15:09:12 +0000 (UTC) Received: by mail.netbsd.org (Postfix, from userid 605) id 7A3D584D86; Sun, 26 Jul 2020 15:09:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id EFB8684D80 for ; Sun, 26 Jul 2020 15:09:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([127.0.0.1]) by localhost (mail.netbsd.org [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id twCMEKjUHewX for ; Sun, 26 Jul 2020 15:09:10 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.netbsd.org [199.233.217.197]) by mail.netbsd.org (Postfix) with ESMTP id 83F1B84CDA for ; Sun, 26 Jul 2020 15:09:10 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id 7CE09FB28; Sun, 26 Jul 2020 15:09:10 +0000 (UTC) Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" MIME-Version: 1.0 Date: Sun, 26 Jul 2020 15:09:10 +0000 From: "Roland Illig" Subject: CVS commit: src/usr.bin/make To: source-changes@NetBSD.org X-Mailer: log_accum Message-Id: <20200726150910.7CE09FB28@cvs.NetBSD.org> Sender: source-changes-owner@NetBSD.org List-Id: source-changes.NetBSD.org Precedence: bulk Reply-To: source-changes-d@NetBSD.org Mail-Reply-To: "Roland Illig" Mail-Followup-To: source-changes-d@NetBSD.org List-Unsubscribe: Module Name: src Committed By: rillig Date: Sun Jul 26 15:09:10 UTC 2020 Modified Files: src/usr.bin/make: buf.c buf.h var.c Log Message: make(1): add Buffer functions for common tasks Adding a string or a substring to a buffer are common tasks when handling variables. There is no need to spell out the strlen call or the pointer subtraction at every call site. Subtracting pointers results in a ptrdiff_t, which would have to be converted to an int in each case for WARNS=6. Having this conversion in a single place keeps the code clean. To generate a diff of this commit: cvs rdiff -u -r1.27 -r1.28 src/usr.bin/make/buf.c cvs rdiff -u -r1.20 -r1.21 src/usr.bin/make/buf.h cvs rdiff -u -r1.312 -r1.313 src/usr.bin/make/var.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.