Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"
MIME-Version: 1.0
Date: Mon, 31 Aug 2020 17:32:13 +0000
From: "Roland Illig" <rillig@netbsd.org>
Subject: CVS commit: src/usr.bin/make/unit-tests
To: source-changes@NetBSD.org
Message-Id: <20200831173213.AF13CFB27@cvs.NetBSD.org>
Sender: source-changes-owner@NetBSD.org
Precedence: bulk
Reply-To: source-changes-d@NetBSD.org
Mail-Reply-To: "Roland Illig" <rillig@netbsd.org>
Mail-Followup-To: source-changes-d@NetBSD.org

Module Name:	src
Committed By:	rillig
Date:		Mon Aug 31 17:32:13 UTC 2020

Modified Files:
	src/usr.bin/make/unit-tests: varmod-unique.exp varmod-unique.mk

Log Message:
make(1): add test for the currently broken :u variable modifier

The :u modifier had been broken in var.c 1.479 from 2020.08.30.19.56.02.
The code that implements the :u modifier was well-covered in the unit
tests, except for the single line that actually deals with adjacent
duplicate words.

The "refactoring" commit that replaced brk_string with Str_Words had not
taken into account that the number of words (in ac) had to be passed to
WordList_JoinFree.  Instead, the number of words was always preserved,
and the words at the end were therefore duplicated in the result.

The fix for this bug will be in the follow-up commit.


To generate a diff of this commit:
cvs rdiff -u -r1.1 -r1.2 src/usr.bin/make/unit-tests/varmod-unique.exp
cvs rdiff -u -r1.2 -r1.3 src/usr.bin/make/unit-tests/varmod-unique.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.