Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified)) by mollari.NetBSD.org (Postfix) with ESMTPS id 2E6111A921F for ; Sun, 18 Oct 2020 11:09:10 +0000 (UTC) Received: by mail.netbsd.org (Postfix, from userid 605) id A754384DEE; Sun, 18 Oct 2020 11:09:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 2ACD784DED for ; Sun, 18 Oct 2020 11:09:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([IPv6:::1]) by localhost (mail.netbsd.org [IPv6:::1]) (amavisd-new, port 10025) with ESMTP id Mu6pbmjNW9Ew for ; Sun, 18 Oct 2020 11:09:08 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.netbsd.org [199.233.217.197]) by mail.netbsd.org (Postfix) with ESMTP id B026884CE3 for ; Sun, 18 Oct 2020 11:09:08 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id A6731FB28; Sun, 18 Oct 2020 11:09:08 +0000 (UTC) Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" MIME-Version: 1.0 Date: Sun, 18 Oct 2020 11:09:08 +0000 From: "Roland Illig" Subject: CVS commit: src/usr.bin/make To: source-changes@NetBSD.org X-Mailer: log_accum Message-Id: <20201018110908.A6731FB28@cvs.NetBSD.org> Sender: source-changes-owner@NetBSD.org List-Id: source-changes.NetBSD.org Precedence: bulk Reply-To: source-changes-d@NetBSD.org Mail-Reply-To: "Roland Illig" Mail-Followup-To: source-changes-d@NetBSD.org List-Unsubscribe: Module Name: src Committed By: rillig Date: Sun Oct 18 11:09:08 UTC 2020 Modified Files: src/usr.bin/make: make.c make.h Log Message: make(1): convert NoExecute to non-inline The header make.h is not only used by usr.bin/make but also by usr.bin/xinstall, to get the needshell function. That program does not declare the variables noRecursiveExecute and noExecute, leading to an "unresolved reference" at link time. To fix this, move the inline functions away from make.h. It's a quirk that make.h gets included by other programs since it contains a whole lot of definitions that are only useful in make itself. If any, there should be a separate header that defines the public library API of make, and only that. To generate a diff of this commit: cvs rdiff -u -r1.158 -r1.159 src/usr.bin/make/make.c cvs rdiff -u -r1.156 -r1.157 src/usr.bin/make/make.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.