Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified)) by mollari.NetBSD.org (Postfix) with ESMTPS id 4A3571A9217 for ; Fri, 30 Oct 2020 14:51:49 +0000 (UTC) Received: by mail.netbsd.org (Postfix, from userid 605) id D8CC784E01; Fri, 30 Oct 2020 14:51:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 55D9084DFF for ; Fri, 30 Oct 2020 14:51:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([127.0.0.1]) by localhost (mail.netbsd.org [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id t_cryjTBmNXa for ; Fri, 30 Oct 2020 14:51:47 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.NetBSD.org [IPv6:2001:470:a085:999:28c:faff:fe03:5984]) by mail.netbsd.org (Postfix) with ESMTP id D465784D25 for ; Fri, 30 Oct 2020 14:51:47 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id C749EFB28; Fri, 30 Oct 2020 14:51:47 +0000 (UTC) Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" MIME-Version: 1.0 Date: Fri, 30 Oct 2020 14:51:47 +0000 From: "Roland Illig" Subject: CVS commit: src/usr.bin/make To: source-changes@NetBSD.org X-Mailer: log_accum Message-Id: <20201030145147.C749EFB28@cvs.NetBSD.org> Sender: source-changes-owner@NetBSD.org List-Id: source-changes.NetBSD.org Precedence: bulk Reply-To: source-changes-d@NetBSD.org Mail-Reply-To: "Roland Illig" Mail-Followup-To: source-changes-d@NetBSD.org List-Unsubscribe: Module Name: src Committed By: rillig Date: Fri Oct 30 14:51:47 UTC 2020 Modified Files: src/usr.bin/make: cond.c src/usr.bin/make/unit-tests: cond-cmp-string.exp cond-cmp-string.mk Log Message: make(1): fix parse error in string literal in conditional The string literal "${VAR} " had produced a "Malformed conditional", at least since 2003. (That's the oldest make I have available for testing.) Strange that nobody else noticed that in the last 17 years. To generate a diff of this commit: cvs rdiff -u -r1.170 -r1.171 src/usr.bin/make/cond.c cvs rdiff -u -r1.6 -r1.7 src/usr.bin/make/unit-tests/cond-cmp-string.exp cvs rdiff -u -r1.9 -r1.10 src/usr.bin/make/unit-tests/cond-cmp-string.mk Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.