Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id BA6351A923D
	for <mhonarc+source-changes@mail-index.netbsd.org>; Sat, 31 Oct 2020 11:54:35 +0000 (UTC)
Received: by mail.netbsd.org (Postfix, from userid 605)
	id 4224884D56; Sat, 31 Oct 2020 11:54:35 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by mail.netbsd.org (Postfix) with ESMTP id B69BB84D51
	for <source-changes@NetBSD.org>; Sat, 31 Oct 2020 11:54:34 +0000 (UTC)
X-Virus-Scanned: amavisd-new at netbsd.org
Received: from mail.netbsd.org ([127.0.0.1])
	by localhost (mail.netbsd.org [127.0.0.1]) (amavisd-new, port 10025)
	with ESMTP id NNlasq3AxezZ for <source-changes@netbsd.org>;
	Sat, 31 Oct 2020 11:54:34 +0000 (UTC)
Received: from cvs.NetBSD.org (ivanova.netbsd.org [199.233.217.197])
	by mail.netbsd.org (Postfix) with ESMTP id 0141384CE9
	for <source-changes@NetBSD.org>; Sat, 31 Oct 2020 11:54:33 +0000 (UTC)
Received: by cvs.NetBSD.org (Postfix, from userid 500)
	id E658AFB28; Sat, 31 Oct 2020 11:54:33 +0000 (UTC)
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"
MIME-Version: 1.0
Date: Sat, 31 Oct 2020 11:54:33 +0000
From: "Roland Illig" <rillig@netbsd.org>
Subject: CVS commit: src/usr.bin/make
To: source-changes@NetBSD.org
X-Mailer: log_accum
Message-Id: <20201031115433.E658AFB28@cvs.NetBSD.org>
Sender: source-changes-owner@NetBSD.org
List-Id: source-changes.NetBSD.org
Precedence: bulk
Reply-To: source-changes-d@NetBSD.org
Mail-Reply-To: "Roland Illig" <rillig@netbsd.org>
Mail-Followup-To: source-changes-d@NetBSD.org
List-Unsubscribe: <mailto:majordomo@NetBSD.org?subject=Unsubscribe%20source-changes&body=unsubscribe%20source-changes>

Module Name:	src
Committed By:	rillig
Date:		Sat Oct 31 11:54:33 UTC 2020

Modified Files:
	src/usr.bin/make: arch.c compat.c job.c make.c make.h meta.c nonints.h
	    suff.c var.c

Log Message:
make(1): do not look up local variables like .TARGET anywhere else

Nobody defines a global variable named .TARGET since that would have
many unpredictable effects, applying to all targets at once.

Nobody defines an environment variable named .TARGET since that's
against the naming conventions for environment variables and would have
the same effect.

Because of this, there is no point looking up the variables that are
local to a GNode anywhere else.  This means they cannot come from the
environment and thus their value doesn't need to be freed after use,
which makes the code simpler.

The newly added accessor functions in make.h refer to external
functions, but since that header is not used anywhere outside of
usr.bin/make, it doesn't matter.  Between 2020-08-25 and 2020-10-30,
that header had been referenced by usr.bin/xinstall.


To generate a diff of this commit:
cvs rdiff -u -r1.149 -r1.150 src/usr.bin/make/arch.c
cvs rdiff -u -r1.170 -r1.171 src/usr.bin/make/compat.c
cvs rdiff -u -r1.296 -r1.297 src/usr.bin/make/job.c
cvs rdiff -u -r1.183 -r1.184 src/usr.bin/make/make.c
cvs rdiff -u -r1.177 -r1.178 src/usr.bin/make/make.h
cvs rdiff -u -r1.134 -r1.135 src/usr.bin/make/meta.c
cvs rdiff -u -r1.147 -r1.148 src/usr.bin/make/nonints.h
cvs rdiff -u -r1.229 -r1.230 src/usr.bin/make/suff.c
cvs rdiff -u -r1.615 -r1.616 src/usr.bin/make/var.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.