Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified)) by mollari.NetBSD.org (Postfix) with ESMTPS id F18A41A921F for ; Sun, 20 Dec 2020 22:36:42 +0000 (UTC) Received: by mail.netbsd.org (Postfix, from userid 605) id 5320A8512B; Sun, 20 Dec 2020 22:36:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 7F2318512A for ; Sun, 20 Dec 2020 22:36:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([127.0.0.1]) by localhost (mail.netbsd.org [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id o2y9pR-ze5qu for ; Sun, 20 Dec 2020 22:36:41 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.NetBSD.org [IPv6:2001:470:a085:999:28c:faff:fe03:5984]) by mail.netbsd.org (Postfix) with ESMTP id 07D4D84D6B for ; Sun, 20 Dec 2020 22:36:41 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id E72A1FA9D; Sun, 20 Dec 2020 22:36:40 +0000 (UTC) Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" MIME-Version: 1.0 Date: Sun, 20 Dec 2020 22:36:40 +0000 From: "Roland Illig" Subject: CVS commit: src/usr.bin/make To: source-changes@NetBSD.org X-Mailer: log_accum Message-Id: <20201220223640.E72A1FA9D@cvs.NetBSD.org> Sender: source-changes-owner@NetBSD.org List-Id: Precedence: bulk Reply-To: source-changes-d@NetBSD.org Mail-Reply-To: "Roland Illig" Mail-Followup-To: source-changes-d@NetBSD.org List-Unsubscribe: Module Name: src Committed By: rillig Date: Sun Dec 20 22:36:40 UTC 2020 Modified Files: src/usr.bin/make: meta.c Log Message: make(1): fix undefined behavior in meta_oodate Do not increment a null pointer. Do not assign to a variable twice in the same statement. To be fair, this may be safe because of the sequence point when the function is called, but anyway, it looks too close to undefined behavior. To generate a diff of this commit: cvs rdiff -u -r1.163 -r1.164 src/usr.bin/make/meta.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.