Received: by mail.netbsd.org (Postfix, from userid 605) id 552FC84D8E; Sun, 14 Mar 2021 15:04:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 865BD84D8C for ; Sun, 14 Mar 2021 15:04:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([127.0.0.1]) by localhost (mail.netbsd.org [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id BV2Edz6XL3Tl for ; Sun, 14 Mar 2021 15:04:14 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.NetBSD.org [IPv6:2001:470:a085:999:28c:faff:fe03:5984]) by mail.netbsd.org (Postfix) with ESMTP id 19DED84D64 for ; Sun, 14 Mar 2021 15:04:14 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id 06ED0FA95; Sun, 14 Mar 2021 15:04:14 +0000 (UTC) Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" MIME-Version: 1.0 Date: Sun, 14 Mar 2021 15:04:14 +0000 From: "Roland Illig" Subject: CVS commit: src/usr.bin/make To: source-changes@NetBSD.org X-Mailer: log_accum Message-Id: <20210314150414.06ED0FA95@cvs.NetBSD.org> Sender: source-changes-owner@NetBSD.org List-Id: Precedence: bulk Reply-To: source-changes-d@NetBSD.org Mail-Reply-To: "Roland Illig" Mail-Followup-To: source-changes-d@NetBSD.org List-Unsubscribe: Module Name: src Committed By: rillig Date: Sun Mar 14 15:04:13 UTC 2021 Modified Files: src/usr.bin/make: var.c Log Message: make: document how error handling should be done correctly Right now, when a variable expression cannot be parsed, the result of calling Var_Subst is a string containing garbage, and no error is reported. In addition, there are some silent errors that are not reported at all. This combination makes it difficult to change the error handling without introducing subtle breakage in some edge cases. An example for garbage output is in varmod-subst-regex.mk, in target mod-regex-compile-error. No functional change. To generate a diff of this commit: cvs rdiff -u -r1.857 -r1.858 src/usr.bin/make/var.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.