Received: by mail.netbsd.org (Postfix, from userid 605) id 7F00E84E7A; Sat, 12 Feb 2022 17:17:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id B0A0484E77 for ; Sat, 12 Feb 2022 17:17:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([127.0.0.1]) by localhost (mail.netbsd.org [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id dNno5zbfCFkp for ; Sat, 12 Feb 2022 17:17:54 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.netbsd.org [199.233.217.197]) by mail.netbsd.org (Postfix) with ESMTP id 43EAF84D10 for ; Sat, 12 Feb 2022 17:17:54 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id 3CCF5FB24; Sat, 12 Feb 2022 17:17:54 +0000 (UTC) Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" MIME-Version: 1.0 Date: Sat, 12 Feb 2022 17:17:54 +0000 From: "Taylor R Campbell" Subject: CVS commit: src/sys/arch To: source-changes@NetBSD.org X-Mailer: log_accum Message-Id: <20220212171754.3CCF5FB24@cvs.NetBSD.org> Sender: source-changes-owner@NetBSD.org List-Id: Precedence: bulk Reply-To: source-changes-d@NetBSD.org Mail-Reply-To: "Taylor R Campbell" Mail-Followup-To: source-changes-d@NetBSD.org List-Unsubscribe: Module Name: src Committed By: riastradh Date: Sat Feb 12 17:17:54 UTC 2022 Modified Files: src/sys/arch/alpha/include: lock.h src/sys/arch/hppa/include: lock.h src/sys/arch/ia64/include: lock.h src/sys/arch/powerpc/include: lock.h src/sys/arch/vax/include: lock.h src/sys/arch/x86/include: lock.h Log Message: __cpu_simple_lock(9): Omit needless barriers in init. It is, and always has been, the caller's responsibility to ensure the lock is initialized before it can be used -- otherwise the memory could hold garbage; it is nonsensical to even attempt locking operations on it before initialization. So there's no need to issue explicit barriers here. The barrier seems to have been introduced in sys/arch/alpha/alpha/lock_machdep.c rev. 1.1 (since moved to inline asm in alpha/include/lock.h) and then copied & pasted into several other architectures. To generate a diff of this commit: cvs rdiff -u -r1.31 -r1.32 src/sys/arch/alpha/include/lock.h cvs rdiff -u -r1.22 -r1.23 src/sys/arch/hppa/include/lock.h cvs rdiff -u -r1.8 -r1.9 src/sys/arch/ia64/include/lock.h cvs rdiff -u -r1.16 -r1.17 src/sys/arch/powerpc/include/lock.h cvs rdiff -u -r1.32 -r1.33 src/sys/arch/vax/include/lock.h cvs rdiff -u -r1.28 -r1.29 src/sys/arch/x86/include/lock.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.