Received: by mail.netbsd.org (Postfix, from userid 605) id 6FFBE84F08; Sun, 22 May 2022 11:39:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 9257F84F18 for ; Sun, 22 May 2022 11:39:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([IPv6:::1]) by localhost (mail.netbsd.org [IPv6:::1]) (amavisd-new, port 10025) with ESMTP id Q8kS6svVaGkk for ; Sun, 22 May 2022 11:39:20 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.NetBSD.org [IPv6:2001:470:a085:999:28c:faff:fe03:5984]) by mail.netbsd.org (Postfix) with ESMTP id 1D69F84CEA for ; Sun, 22 May 2022 11:39:20 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id 4F852FAEB; Sun, 22 May 2022 11:40:04 +0000 (UTC) Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" MIME-Version: 1.0 Date: Sun, 22 May 2022 11:40:04 +0000 From: "Taylor R Campbell" Subject: CVS commit: src To: source-changes@NetBSD.org X-Mailer: log_accum Message-Id: <20220522114004.4F852FAEB@cvs.NetBSD.org> Sender: source-changes-owner@NetBSD.org List-Id: Precedence: bulk Reply-To: source-changes-d@NetBSD.org Mail-Reply-To: "Taylor R Campbell" Mail-Followup-To: source-changes-d@NetBSD.org List-Unsubscribe: Module Name: src Committed By: riastradh Date: Sun May 22 11:40:04 UTC 2022 Modified Files: src/share/man/man9: opencrypto.9 src/sys/netipsec: xform_ah.c xform_esp.c xform_ipcomp.c src/sys/opencrypto: crypto.c cryptodev.c cryptodev.h Log Message: opencrypto: Rip out EAGAIN logic when unregistering crypto drivers. I'm pretty sure this never worked reliably based on code inspection, and it's unlikely to have ever been tested because it only applies when unregistering a driver -- but we have no crypto drivers for removable devices, so it would only apply if we went out of our way to trigger detach with drvctl. Instead, just make the operation fail with ENODEV, and remove all the callback logic to resubmit the request on EAGAIN. (Maybe this should be ENXIO, but crypto_kdispatch already does ENODEV.) To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.21 src/share/man/man9/opencrypto.9 cvs rdiff -u -r1.112 -r1.113 src/sys/netipsec/xform_ah.c cvs rdiff -u -r1.103 -r1.104 src/sys/netipsec/xform_esp.c cvs rdiff -u -r1.72 -r1.73 src/sys/netipsec/xform_ipcomp.c cvs rdiff -u -r1.126 -r1.127 src/sys/opencrypto/crypto.c cvs rdiff -u -r1.121 -r1.122 src/sys/opencrypto/cryptodev.c cvs rdiff -u -r1.48 -r1.49 src/sys/opencrypto/cryptodev.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.