Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"
MIME-Version: 1.0
Date: Wed, 22 Feb 2023 19:30:51 +0000
From: "Martin Husemann" <martin@netbsd.org>
Subject: CVS commit: [netbsd-9] src
To: source-changes@NetBSD.org
Message-Id: <20230222193051.48044FA90@cvs.NetBSD.org>
Sender: source-changes-owner@NetBSD.org
Precedence: bulk
Reply-To: source-changes-d@NetBSD.org
Mail-Reply-To: "Martin Husemann" <martin@netbsd.org>
Mail-Followup-To: source-changes-d@NetBSD.org

Module Name:	src
Committed By:	martin
Date:		Wed Feb 22 19:30:51 UTC 2023

Modified Files:
	src/crypto/external/bsd/openssh/bin [netbsd-9]: Makefile
	src/etc/bluetooth [netbsd-9]: Makefile
	src/etc/iscsi [netbsd-9]: Makefile
	src/etc/root [netbsd-9]: Makefile
	src/etc/ssh [netbsd-9]: Makefile
	src/external/ibm-public/postfix/etc [netbsd-9]: Makefile
	src/usr.bin/mail [netbsd-9]: Makefile

Log Message:
Pull up following revision(s) (requested by riastradh in ticket #1604):

	etc/ssh/Makefile: revision 1.4
	usr.bin/mail/Makefile: revision 1.41
	external/ibm-public/postfix/etc/Makefile: revision 1.2
	etc/bluetooth/Makefile: revision 1.6
	crypto/external/bsd/openssh/bin/Makefile: revision 1.5
	etc/root/Makefile: revision 1.5
	etc/iscsi/Makefile: revision 1.4

/root: Install .cshrc and .profile links with the same mode.

Previously we would:

1. Install /root/.cshrc and /root/.profile with mode FILESMODE=644 as
   requested in src/etc/root/Makefile and as echoed in
   /etc/mtree/special.
2. Create hard links at /.cshrc and /.profile through CONFIGLINKS.
3. Because LINKSMODE was unset and defaults to NOBINMODE=444, change
   the mode to 444.

This scenario is confusing, and mtree objects to it, which is bad for
warning fatigue in a security-relevant mechanism.  (There are also
several other files mtree objects to out of the box -- we should fix
those too.)

With this change we install the links with the same mode as the
original files, in agreement with the mtree.  The files, .cshrc and
.profile, are intended to be editable configuration files, so 644
makes sense while 444 makes no sense and gets in the way of editors
like vi.

Discussed on tech-userlevel:
https://mail-index.netbsd.org/tech-userlevel/2022/08/29/msg013498.html

etc: Fix permissions of various editable configuration files.

This way they match the mtree and make sense and don't cause editors
to ask to override read-only files when editing them.

Exception: Not sure /etc/bluetooth/protocols makes as much sense to
edit, but the mtree says 644, so if you want to change it, make sure
to change it in both places -- Makefile and mtree.

/etc/ssh: Install ssh_known_hosts with mode 644.
Makes it agree with the mtree and more convenient for admin to edit.


To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.4.2.1 src/crypto/external/bsd/openssh/bin/Makefile
cvs rdiff -u -r1.5 -r1.5.68.1 src/etc/bluetooth/Makefile
cvs rdiff -u -r1.3 -r1.3.90.1 src/etc/iscsi/Makefile
cvs rdiff -u -r1.4 -r1.4.34.1 src/etc/root/Makefile
cvs rdiff -u -r1.3 -r1.3.12.1 src/etc/ssh/Makefile
cvs rdiff -u -r1.1 -r1.1.52.1 src/external/ibm-public/postfix/etc/Makefile
cvs rdiff -u -r1.38 -r1.38.4.1 src/usr.bin/mail/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.