Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 5142284E7D for ; Sun, 24 Dec 2023 16:48:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([127.0.0.1]) by localhost (mail.netbsd.org [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id rk-p3zxBbqoq for ; Sun, 24 Dec 2023 16:48:30 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.NetBSD.org [IPv6:2001:470:a085:999:28c:faff:fe03:5984]) by mail.netbsd.org (Postfix) with ESMTP id E113284D44 for ; Sun, 24 Dec 2023 16:48:30 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id CFB63FA42; Sun, 24 Dec 2023 16:48:30 +0000 (UTC) Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" MIME-Version: 1.0 Date: Sun, 24 Dec 2023 16:48:30 +0000 From: "Simon J. Gerraty" Subject: CVS commit: src/usr.bin/make To: source-changes@NetBSD.org Approved: for-source-only Reply-To: sjg@netbsd.org X-Mailer: log_accum Message-Id: <20231224164830.CFB63FA42@cvs.NetBSD.org> Module Name: src Committed By: sjg Date: Sun Dec 24 16:48:30 UTC 2023 Modified Files: src/usr.bin/make: compat.c make.1 src/usr.bin/make/unit-tests: shell-sh.mk Log Message: Compat_RunCommand call Shell_Init is shellPath is NULL Since .SHELL is potentially used in compat mode as well, the man page description should not imply it is only used in jobs mode. Remove path="sh" from shell-sh unit-test - and it would have detected this bug. Reviewed by: rillig To generate a diff of this commit: cvs rdiff -u -r1.248 -r1.249 src/usr.bin/make/compat.c cvs rdiff -u -r1.371 -r1.372 src/usr.bin/make/make.1 cvs rdiff -u -r1.1 -r1.2 src/usr.bin/make/unit-tests/shell-sh.mk Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.