Wed Oct 8 14:58:57 2008 UTC ()

memset to zero the entire nop_in structure.  Fixes PR#39688 by
Henning Petersen.  Thanks!


(oster)

diff -r1.23 -r1.24 src/dist/iscsi/src/target.c

--- src/dist/iscsi/src/Attic/target.c 2008/02/07 19:09:02	1.23
+++ src/dist/iscsi/src/Attic/target.c 2008/10/08 14:58:57	1.24

 @@ -539,27 +539,27 @@ nop_out_t(target_session_t * sess, uint8
 			if (ping_data) {
 				iscsi_free(ping_data);
+			}
 			return -1;
+		}
 		iscsi_trace(TRACE_ISCSI_DEBUG, __FILE__, __LINE__, "successfully read %d bytes ping data:\n", nop_out.length);
 		iscsi_print_buffer(ping_data, nop_out.length);
+	}
 	if (nop_out.tag != 0xffffffff) {
 		iscsi_nop_in_args_t  nop_in;
 		uint8_t   rsp_header[ISCSI_HEADER_LEN];
 		iscsi_trace(TRACE_ISCSI_DEBUG, __FILE__, __LINE__, "sending %d bytes ping response\n", nop_out.length);
-		(void) memset(&nop_in, 0x0, sizeof(&nop_in));
+		(void) memset(&nop_in, 0x0, sizeof(nop_in));
 		nop_in.length = nop_out.length;
 		nop_in.lun = nop_out.lun;
 		nop_in.tag = nop_out.tag;
 		nop_in.transfer_tag = 0xffffffff;
 		nop_in.StatSN = ++(sess->StatSN);
 		nop_in.ExpCmdSN = sess->ExpCmdSN;
 		nop_in.MaxCmdSN = sess->MaxCmdSN;
 		if (iscsi_nop_in_encap(rsp_header, &nop_in) != 0) {
 			iscsi_trace_error(__FILE__, __LINE__, "iscsi_nop_in_encap() failed\n");
 			if (ping_data) {
 				iscsi_free(ping_data);
+			}