Mon Mar 16 13:01:21 2009 UTC ()
fix sign-compare issues


(lukem)
diff -r1.20 -r1.21 src/sbin/clri/clri.c

cvs diff -r1.20 -r1.21 src/sbin/clri/clri.c (switch to unified diff)

--- src/sbin/clri/clri.c 2008/07/20 01:20:21 1.20
+++ src/sbin/clri/clri.c 2009/03/16 13:01:21 1.21
@@ -1,198 +1,198 @@ @@ -1,198 +1,198 @@
1/* $NetBSD: clri.c,v 1.20 2008/07/20 01:20:21 lukem Exp $ */ 1/* $NetBSD: clri.c,v 1.21 2009/03/16 13:01:21 lukem Exp $ */
2 2
3/* 3/*
4 * Copyright (c) 1990, 1993 4 * Copyright (c) 1990, 1993
5 * The Regents of the University of California. All rights reserved. 5 * The Regents of the University of California. All rights reserved.
6 * 6 *
7 * This code is derived from software contributed to Berkeley by 7 * This code is derived from software contributed to Berkeley by
8 * Rich $alz of BBN Inc. 8 * Rich $alz of BBN Inc.
9 * 9 *
10 * Redistribution and use in source and binary forms, with or without 10 * Redistribution and use in source and binary forms, with or without
11 * modification, are permitted provided that the following conditions 11 * modification, are permitted provided that the following conditions
12 * are met: 12 * are met:
13 * 1. Redistributions of source code must retain the above copyright 13 * 1. Redistributions of source code must retain the above copyright
14 * notice, this list of conditions and the following disclaimer. 14 * notice, this list of conditions and the following disclaimer.
15 * 2. Redistributions in binary form must reproduce the above copyright 15 * 2. Redistributions in binary form must reproduce the above copyright
16 * notice, this list of conditions and the following disclaimer in the 16 * notice, this list of conditions and the following disclaimer in the
17 * documentation and/or other materials provided with the distribution. 17 * documentation and/or other materials provided with the distribution.
18 * 3. Neither the name of the University nor the names of its contributors 18 * 3. Neither the name of the University nor the names of its contributors
19 * may be used to endorse or promote products derived from this software 19 * may be used to endorse or promote products derived from this software
20 * without specific prior written permission. 20 * without specific prior written permission.
21 * 21 *
22 * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND 22 * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
23 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 23 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
24 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE 24 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
25 * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE 25 * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
26 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 26 * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
27 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS 27 * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
28 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) 28 * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
29 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT 29 * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
30 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY 30 * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
31 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF 31 * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
32 * SUCH DAMAGE. 32 * SUCH DAMAGE.
33 */ 33 */
34 34
35#include <sys/cdefs.h> 35#include <sys/cdefs.h>
36#ifndef lint 36#ifndef lint
37__COPYRIGHT("@(#) Copyright (c) 1990, 1993\ 37__COPYRIGHT("@(#) Copyright (c) 1990, 1993\
38 The Regents of the University of California. All rights reserved."); 38 The Regents of the University of California. All rights reserved.");
39#endif /* not lint */ 39#endif /* not lint */
40 40
41#ifndef lint 41#ifndef lint
42#if 0 42#if 0
43static char sccsid[] = "@(#)clri.c 8.3 (Berkeley) 4/28/95"; 43static char sccsid[] = "@(#)clri.c 8.3 (Berkeley) 4/28/95";
44#else 44#else
45__RCSID("$NetBSD: clri.c,v 1.20 2008/07/20 01:20:21 lukem Exp $"); 45__RCSID("$NetBSD: clri.c,v 1.21 2009/03/16 13:01:21 lukem Exp $");
46#endif 46#endif
47#endif /* not lint */ 47#endif /* not lint */
48 48
49#include <sys/param.h> 49#include <sys/param.h>
50#include <sys/time.h> 50#include <sys/time.h>
51 51
52#include <ufs/ufs/dinode.h> 52#include <ufs/ufs/dinode.h>
53#include <ufs/ufs/ufs_bswap.h> 53#include <ufs/ufs/ufs_bswap.h>
54#include <ufs/ffs/fs.h> 54#include <ufs/ffs/fs.h>
55#include <ufs/ffs/ffs_extern.h> 55#include <ufs/ffs/ffs_extern.h>
56 56
57#include <err.h> 57#include <err.h>
58#include <errno.h> 58#include <errno.h>
59#include <fcntl.h> 59#include <fcntl.h>
60#include <stdlib.h> 60#include <stdlib.h>
61#include <string.h> 61#include <string.h>
62#include <stdio.h> 62#include <stdio.h>
63#include <unistd.h> 63#include <unistd.h>
64 64
65/* 65/*
66 * Possible superblock locations ordered from most to least likely. 66 * Possible superblock locations ordered from most to least likely.
67 */ 67 */
68static off_t sblock_try[] = SBLOCKSEARCH; 68static off_t sblock_try[] = SBLOCKSEARCH;
69off_t sblockloc; 69off_t sblockloc;
70 70
71 71
72int 72int
73main(int argc, char *argv[]) 73main(int argc, char *argv[])
74{ 74{
75 struct fs *sbp; 75 struct fs *sbp;
76 struct ufs1_dinode *ip1; 76 struct ufs1_dinode *ip1;
77 struct ufs2_dinode *ip2; 77 struct ufs2_dinode *ip2;
78 int fd; 78 int fd;
79 char *ibuf[MAXBSIZE]; 79 char *ibuf[MAXBSIZE];
80 int32_t generation; 80 int32_t generation;
81 off_t offset; 81 off_t offset;
82 size_t bsize; 82 size_t bsize;
83 int inonum; 83 int inonum;
84 char *fs, sblock[SBLOCKSIZE]; 84 char *fs, sblock[SBLOCKSIZE];
85 int needswap = 0, is_ufs2 = 0; 85 int needswap = 0, is_ufs2 = 0;
86 int i, imax; 86 int i, imax;
87 87
88 if (argc < 3) { 88 if (argc < 3) {
89 (void)fprintf(stderr, "usage: clri filesystem inode ...\n"); 89 (void)fprintf(stderr, "usage: clri filesystem inode ...\n");
90 exit(1); 90 exit(1);
91 } 91 }
92 92
93 fs = *++argv; 93 fs = *++argv;
94 94
95 95
96 /* get the superblock. */ 96 /* get the superblock. */
97 if ((fd = open(fs, O_RDWR, 0)) < 0) 97 if ((fd = open(fs, O_RDWR, 0)) < 0)
98 err(1, "%s", fs); 98 err(1, "%s", fs);
99 for (i = 0;; i++) { 99 for (i = 0;; i++) {
100 sblockloc = sblock_try[i]; 100 sblockloc = sblock_try[i];
101 if (sblockloc == -1) 101 if (sblockloc == -1)
102 errx(1, "%s: can't find superblock", fs); 102 errx(1, "%s: can't find superblock", fs);
103 if (pread(fd, sblock, sizeof(sblock), sblockloc) != sizeof(sblock)) 103 if (pread(fd, sblock, sizeof(sblock), sblockloc) != sizeof(sblock))
104 errx(1, "%s: can't read superblock", fs); 104 errx(1, "%s: can't read superblock", fs);
105 105
106 sbp = (struct fs *)sblock; 106 sbp = (struct fs *)sblock;
107 switch(sbp->fs_magic) { 107 switch(sbp->fs_magic) {
108 case FS_UFS2_MAGIC: 108 case FS_UFS2_MAGIC:
109 is_ufs2 = 1; 109 is_ufs2 = 1;
110 /*FALLTHROUGH*/ 110 /*FALLTHROUGH*/
111 case FS_UFS1_MAGIC: 111 case FS_UFS1_MAGIC:
112 break; 112 break;
113 case FS_UFS2_MAGIC_SWAPPED: 113 case FS_UFS2_MAGIC_SWAPPED:
114 is_ufs2 = 1; 114 is_ufs2 = 1;
115 /*FALLTHROUGH*/ 115 /*FALLTHROUGH*/
116 case FS_UFS1_MAGIC_SWAPPED: 116 case FS_UFS1_MAGIC_SWAPPED:
117 needswap = 1; 117 needswap = 1;
118 break; 118 break;
119 default: 119 default:
120 continue; 120 continue;
121 } 121 }
122 122
123 /* check we haven't found an alternate */ 123 /* check we haven't found an alternate */
124 if (is_ufs2 || sbp->fs_old_flags & FS_FLAGS_UPDATED) { 124 if (is_ufs2 || sbp->fs_old_flags & FS_FLAGS_UPDATED) {
125 if (sblockloc != ufs_rw64(sbp->fs_sblockloc, needswap)) 125 if ((uint64_t)sblockloc != ufs_rw64(sbp->fs_sblockloc, needswap))
126 continue; 126 continue;
127 } else { 127 } else {
128 if (sblockloc == SBLOCK_UFS2) 128 if (sblockloc == SBLOCK_UFS2)
129 continue; 129 continue;
130 } 130 }
131 131
132 break; 132 break;
133 } 133 }
134 134
135 /* check that inode numbers are valid */ 135 /* check that inode numbers are valid */
136 imax = ufs_rw32(sbp->fs_ncg, needswap) * 136 imax = ufs_rw32(sbp->fs_ncg, needswap) *
137 ufs_rw32(sbp->fs_ipg, needswap); 137 ufs_rw32(sbp->fs_ipg, needswap);
138 for (i = 1; i < (argc - 1); i++) 138 for (i = 1; i < (argc - 1); i++)
139 if (atoi(argv[i]) <= 0 || atoi(argv[i]) >= imax)  139 if (atoi(argv[i]) <= 0 || atoi(argv[i]) >= imax)
140 errx(1, "%s is not a valid inode number", argv[i]); 140 errx(1, "%s is not a valid inode number", argv[i]);
141 141
142 /* delete clean flag in the superblok */ 142 /* delete clean flag in the superblok */
143 sbp->fs_clean = ufs_rw32(ufs_rw32(sbp->fs_clean, needswap) << 1, 143 sbp->fs_clean = ufs_rw32(ufs_rw32(sbp->fs_clean, needswap) << 1,
144 needswap); 144 needswap);
145 if (lseek(fd, sblockloc, SEEK_SET) < 0) 145 if (lseek(fd, sblockloc, SEEK_SET) < 0)
146 err(1, "%s", fs); 146 err(1, "%s", fs);
147 if (write(fd, sblock, sizeof(sblock)) != sizeof(sblock)) 147 if (write(fd, sblock, sizeof(sblock)) != sizeof(sblock))
148 errx(1, "%s: can't rewrite superblock", fs); 148 errx(1, "%s: can't rewrite superblock", fs);
149 (void)fsync(fd); 149 (void)fsync(fd);
150 150
151 if (needswap) 151 if (needswap)
152 ffs_sb_swap(sbp, sbp); 152 ffs_sb_swap(sbp, sbp);
153 bsize = sbp->fs_bsize; 153 bsize = sbp->fs_bsize;
154 154
155 /* remaining arguments are inode numbers. */ 155 /* remaining arguments are inode numbers. */
156 while (*++argv) { 156 while (*++argv) {
157 /* get the inode number. */ 157 /* get the inode number. */
158 inonum = atoi(*argv); 158 inonum = atoi(*argv);
159 (void)printf("clearing %d\n", inonum); 159 (void)printf("clearing %d\n", inonum);
160 160
161 /* read in the appropriate block. */ 161 /* read in the appropriate block. */
162 offset = ino_to_fsba(sbp, inonum); /* inode to fs blk */ 162 offset = ino_to_fsba(sbp, inonum); /* inode to fs blk */
163 offset = fsbtodb(sbp, offset); /* fs blk disk blk */ 163 offset = fsbtodb(sbp, offset); /* fs blk disk blk */
164 offset *= DEV_BSIZE; /* disk blk to bytes */ 164 offset *= DEV_BSIZE; /* disk blk to bytes */
165 165
166 /* seek and read the block */ 166 /* seek and read the block */
167 if (lseek(fd, offset, SEEK_SET) < 0) 167 if (lseek(fd, offset, SEEK_SET) < 0)
168 err(1, "%s", fs); 168 err(1, "%s", fs);
169 if (read(fd, ibuf, bsize) != bsize) 169 if ((size_t)read(fd, ibuf, bsize) != bsize)
170 err(1, "%s", fs); 170 err(1, "%s", fs);
171 171
172 /* get the inode within the block. */ 172 /* get the inode within the block. */
173 if (is_ufs2) { 173 if (is_ufs2) {
174 ip2 = &((struct ufs2_dinode *)ibuf) 174 ip2 = &((struct ufs2_dinode *)ibuf)
175 [ino_to_fsbo(sbp, inonum)]; 175 [ino_to_fsbo(sbp, inonum)];
176 /* clear the inode, and bump the generation count. */ 176 /* clear the inode, and bump the generation count. */
177 generation = ip2->di_gen + 1; 177 generation = ip2->di_gen + 1;
178 memset(ip2, 0, sizeof(*ip2)); 178 memset(ip2, 0, sizeof(*ip2));
179 ip2->di_gen = generation; 179 ip2->di_gen = generation;
180 } else { 180 } else {
181 ip1 = &((struct ufs1_dinode *)ibuf) 181 ip1 = &((struct ufs1_dinode *)ibuf)
182 [ino_to_fsbo(sbp, inonum)]; 182 [ino_to_fsbo(sbp, inonum)];
183 /* clear the inode, and bump the generation count. */ 183 /* clear the inode, and bump the generation count. */
184 generation = ip1->di_gen + 1; 184 generation = ip1->di_gen + 1;
185 memset(ip1, 0, sizeof(*ip1)); 185 memset(ip1, 0, sizeof(*ip1));
186 ip1->di_gen = generation; 186 ip1->di_gen = generation;
187 } 187 }
188 188
189 /* backup and write the block */ 189 /* backup and write the block */
190 if (lseek(fd, offset, SEEK_SET) < 0) 190 if (lseek(fd, offset, SEEK_SET) < 0)
191 err(1, "%s", fs); 191 err(1, "%s", fs);
192 if (write(fd, ibuf, bsize) != bsize) 192 if ((size_t)write(fd, ibuf, bsize) != bsize)
193 err(1, "%s", fs); 193 err(1, "%s", fs);
194 (void)fsync(fd); 194 (void)fsync(fd);
195 } 195 }
196 (void)close(fd); 196 (void)close(fd);
197 exit(0); 197 exit(0);
198} 198}