Wed Apr 27 06:22:11 2011 UTC ()
Simplify previous: the original code was mostly correct but relied on
"register_t" being signed.


(martin)
diff -r1.112 -r1.113 src/sys/kern/kern_prot.c
cvs diff -r1.112 -r1.113 src/sys/kern/kern_prot.c (expand / switch to context diff)
--- src/sys/kern/kern_prot.c 2011/04/26 19:58:12 1.112
+++ src/sys/kern/kern_prot.c 2011/04/27 06:22:11 1.113
@@ -1,4 +1,4 @@
-/*	$NetBSD: kern_prot.c,v 1.112 2011/04/26 19:58:12 martin Exp $	*/
+/*	$NetBSD: kern_prot.c,v 1.113 2011/04/27 06:22:11 martin Exp $	*/
 
 /*
  * Copyright (c) 1982, 1986, 1989, 1990, 1991, 1993
@@ -41,7 +41,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: kern_prot.c,v 1.112 2011/04/26 19:58:12 martin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: kern_prot.c,v 1.113 2011/04/27 06:22:11 martin Exp $");
 
 #include "opt_compat_43.h"
 
@@ -231,9 +231,7 @@
 	*retval = kauth_cred_ngroups(l->l_cred);
 	if (SCARG(uap, gidsetsize) == 0)
 		return 0;
-	if (SCARG(uap, gidsetsize) < 0)
-		return EINVAL;
-	if (SCARG(uap, gidsetsize) < *retval)
+	if (SCARG(uap, gidsetsize) < (int)*retval)
 		return EINVAL;
 
 	return kauth_cred_getgroups(l->l_cred, SCARG(uap, gidset), *retval,