Sun Jun 12 07:19:49 2011 UTC ()
Initialize i2cbus_attach_args before call config_found().  It has other member.


(kiyohara)
diff -r1.6 -r1.7 src/sys/arch/powerpc/ibm4xx/dev/gpiic_opb.c

cvs diff -r1.6 -r1.7 src/sys/arch/powerpc/ibm4xx/dev/gpiic_opb.c (switch to unified diff)

--- src/sys/arch/powerpc/ibm4xx/dev/gpiic_opb.c 2008/07/12 02:04:07 1.6
+++ src/sys/arch/powerpc/ibm4xx/dev/gpiic_opb.c 2011/06/12 07:19:49 1.7
@@ -1,245 +1,246 @@ @@ -1,245 +1,246 @@
1/* $NetBSD: gpiic_opb.c,v 1.6 2008/07/12 02:04:07 tsutsui Exp $ */ 1/* $NetBSD: gpiic_opb.c,v 1.7 2011/06/12 07:19:49 kiyohara Exp $ */
2 2
3/* 3/*
4 * Copyright 2002, 2003 Wasabi Systems, Inc. 4 * Copyright 2002, 2003 Wasabi Systems, Inc.
5 * All rights reserved. 5 * All rights reserved.
6 * 6 *
7 * Written by Steve C. Woodford for Wasabi Systems, Inc. 7 * Written by Steve C. Woodford for Wasabi Systems, Inc.
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions 10 * modification, are permitted provided that the following conditions
11 * are met: 11 * are met:
12 * 1. Redistributions of source code must retain the above copyright 12 * 1. Redistributions of source code must retain the above copyright
13 * notice, this list of conditions and the following disclaimer. 13 * notice, this list of conditions and the following disclaimer.
14 * 2. Redistributions in binary form must reproduce the above copyright 14 * 2. Redistributions in binary form must reproduce the above copyright
15 * notice, this list of conditions and the following disclaimer in the 15 * notice, this list of conditions and the following disclaimer in the
16 * documentation and/or other materials provided with the distribution. 16 * documentation and/or other materials provided with the distribution.
17 * 3. All advertising materials mentioning features or use of this software 17 * 3. All advertising materials mentioning features or use of this software
18 * must display the following acknowledgement: 18 * must display the following acknowledgement:
19 * This product includes software developed for the NetBSD Project by 19 * This product includes software developed for the NetBSD Project by
20 * Wasabi Systems, Inc. 20 * Wasabi Systems, Inc.
21 * 4. The name of Wasabi Systems, Inc. may not be used to endorse 21 * 4. The name of Wasabi Systems, Inc. may not be used to endorse
22 * or promote products derived from this software without specific prior 22 * or promote products derived from this software without specific prior
23 * written permission. 23 * written permission.
24 * 24 *
25 * THIS SOFTWARE IS PROVIDED BY WASABI SYSTEMS, INC. ``AS IS'' AND 25 * THIS SOFTWARE IS PROVIDED BY WASABI SYSTEMS, INC. ``AS IS'' AND
26 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED 26 * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
27 * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 27 * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
28 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL WASABI SYSTEMS, INC 28 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL WASABI SYSTEMS, INC
29 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR 29 * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
30 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF 30 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
31 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS 31 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
32 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN 32 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
33 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) 33 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
34 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE 34 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
35 * POSSIBILITY OF SUCH DAMAGE. 35 * POSSIBILITY OF SUCH DAMAGE.
36 */ 36 */
37 37
38#include "locators.h" 38#include "locators.h"
39 39
40#include <sys/param.h> 40#include <sys/param.h>
41#include <sys/systm.h> 41#include <sys/systm.h>
42#include <sys/device.h> 42#include <sys/device.h>
43#include <sys/errno.h> 43#include <sys/errno.h>
44#include <sys/mutex.h> 44#include <sys/mutex.h>
45#include <sys/cpu.h> 45#include <sys/cpu.h>
46 46
47#include <dev/i2c/i2cvar.h> 47#include <dev/i2c/i2cvar.h>
48#include <dev/i2c/i2c_bitbang.h> 48#include <dev/i2c/i2c_bitbang.h>
49 49
50#include <powerpc/ibm4xx/dev/opbvar.h> 50#include <powerpc/ibm4xx/dev/opbvar.h>
51#include <powerpc/ibm4xx/dev/gpiicreg.h> 51#include <powerpc/ibm4xx/dev/gpiicreg.h>
52 52
53struct gpiic_softc { 53struct gpiic_softc {
54 struct device sc_dev; 54 struct device sc_dev;
55 bus_space_tag_t sc_bust; 55 bus_space_tag_t sc_bust;
56 bus_space_handle_t sc_bush; 56 bus_space_handle_t sc_bush;
57 uint8_t sc_txen; 57 uint8_t sc_txen;
58 uint8_t sc_tx; 58 uint8_t sc_tx;
59 struct i2c_controller sc_i2c; 59 struct i2c_controller sc_i2c;
60 struct i2c_bitbang_ops sc_bops; 60 struct i2c_bitbang_ops sc_bops;
61 kmutex_t sc_buslock; 61 kmutex_t sc_buslock;
62}; 62};
63 63
64static int gpiic_match(struct device *, struct cfdata *, void *); 64static int gpiic_match(struct device *, struct cfdata *, void *);
65static void gpiic_attach(struct device *, struct device *, void *); 65static void gpiic_attach(struct device *, struct device *, void *);
66 66
67CFATTACH_DECL(gpiic, sizeof(struct gpiic_softc), 67CFATTACH_DECL(gpiic, sizeof(struct gpiic_softc),
68 gpiic_match, gpiic_attach, NULL, NULL); 68 gpiic_match, gpiic_attach, NULL, NULL);
69 69
70static int gpiic_acquire_bus(void *, int); 70static int gpiic_acquire_bus(void *, int);
71static void gpiic_release_bus(void *, int); 71static void gpiic_release_bus(void *, int);
72static int gpiic_send_start(void *, int); 72static int gpiic_send_start(void *, int);
73static int gpiic_send_stop(void *, int); 73static int gpiic_send_stop(void *, int);
74static int gpiic_initiate_xfer(void *, i2c_addr_t, int); 74static int gpiic_initiate_xfer(void *, i2c_addr_t, int);
75static int gpiic_read_byte(void *, uint8_t *, int); 75static int gpiic_read_byte(void *, uint8_t *, int);
76static int gpiic_write_byte(void *, uint8_t, int); 76static int gpiic_write_byte(void *, uint8_t, int);
77static void gpiic_set_dir(void *, uint32_t); 77static void gpiic_set_dir(void *, uint32_t);
78static void gpiic_set_bits(void *, uint32_t); 78static void gpiic_set_bits(void *, uint32_t);
79static uint32_t gpiic_read_bits(void *); 79static uint32_t gpiic_read_bits(void *);
80 80
81static int 81static int
82gpiic_match(struct device *parent, struct cfdata *cf, void *args) 82gpiic_match(struct device *parent, struct cfdata *cf, void *args)
83{ 83{
84 struct opb_attach_args *oaa = args; 84 struct opb_attach_args *oaa = args;
85 85
86 if (strcmp(oaa->opb_name, cf->cf_name) != 0) 86 if (strcmp(oaa->opb_name, cf->cf_name) != 0)
87 return 0; 87 return 0;
88 88
89 return (1); 89 return (1);
90} 90}
91 91
92static void 92static void
93gpiic_attach(struct device *parent, struct device *self, void *args) 93gpiic_attach(struct device *parent, struct device *self, void *args)
94{ 94{
95 struct gpiic_softc *sc = (struct gpiic_softc *)self; 95 struct gpiic_softc *sc = (struct gpiic_softc *)self;
96 struct opb_attach_args *oaa = args; 96 struct opb_attach_args *oaa = args;
97 struct i2cbus_attach_args iba; 97 struct i2cbus_attach_args iba;
98 98
99 aprint_naive(": IIC controller\n"); 99 aprint_naive(": IIC controller\n");
100 aprint_normal(": On-Chip IIC controller\n"); 100 aprint_normal(": On-Chip IIC controller\n");
101 101
102 sc->sc_bust = oaa->opb_bt; 102 sc->sc_bust = oaa->opb_bt;
103 103
104 bus_space_map(sc->sc_bust, oaa->opb_addr, IIC_NREG, 0, &sc->sc_bush); 104 bus_space_map(sc->sc_bust, oaa->opb_addr, IIC_NREG, 0, &sc->sc_bush);
105 105
106 mutex_init(&sc->sc_buslock, MUTEX_DEFAULT, IPL_NONE); 106 mutex_init(&sc->sc_buslock, MUTEX_DEFAULT, IPL_NONE);
107 107
108 sc->sc_txen = 0; 108 sc->sc_txen = 0;
109 sc->sc_tx = IIC_DIRECTCNTL_SCC | IIC_DIRECTCNTL_SDAC; 109 sc->sc_tx = IIC_DIRECTCNTL_SCC | IIC_DIRECTCNTL_SDAC;
110 sc->sc_i2c.ic_cookie = sc; 110 sc->sc_i2c.ic_cookie = sc;
111 sc->sc_i2c.ic_acquire_bus = gpiic_acquire_bus; 111 sc->sc_i2c.ic_acquire_bus = gpiic_acquire_bus;
112 sc->sc_i2c.ic_release_bus = gpiic_release_bus; 112 sc->sc_i2c.ic_release_bus = gpiic_release_bus;
113 sc->sc_i2c.ic_exec = NULL; 113 sc->sc_i2c.ic_exec = NULL;
114 sc->sc_i2c.ic_send_start = gpiic_send_start; 114 sc->sc_i2c.ic_send_start = gpiic_send_start;
115 sc->sc_i2c.ic_send_stop = gpiic_send_stop; 115 sc->sc_i2c.ic_send_stop = gpiic_send_stop;
116 sc->sc_i2c.ic_initiate_xfer = gpiic_initiate_xfer; 116 sc->sc_i2c.ic_initiate_xfer = gpiic_initiate_xfer;
117 sc->sc_i2c.ic_read_byte = gpiic_read_byte; 117 sc->sc_i2c.ic_read_byte = gpiic_read_byte;
118 sc->sc_i2c.ic_write_byte = gpiic_write_byte; 118 sc->sc_i2c.ic_write_byte = gpiic_write_byte;
119 119
120 sc->sc_bops.ibo_set_dir = gpiic_set_dir; 120 sc->sc_bops.ibo_set_dir = gpiic_set_dir;
121 sc->sc_bops.ibo_set_bits = gpiic_set_bits; 121 sc->sc_bops.ibo_set_bits = gpiic_set_bits;
122 sc->sc_bops.ibo_read_bits = gpiic_read_bits; 122 sc->sc_bops.ibo_read_bits = gpiic_read_bits;
123 sc->sc_bops.ibo_bits[I2C_BIT_SDA] = IIC_DIRECTCNTL_SDAC; 123 sc->sc_bops.ibo_bits[I2C_BIT_SDA] = IIC_DIRECTCNTL_SDAC;
124 sc->sc_bops.ibo_bits[I2C_BIT_SCL] = IIC_DIRECTCNTL_SCC; 124 sc->sc_bops.ibo_bits[I2C_BIT_SCL] = IIC_DIRECTCNTL_SCC;
125 sc->sc_bops.ibo_bits[I2C_BIT_OUTPUT] = 1; 125 sc->sc_bops.ibo_bits[I2C_BIT_OUTPUT] = 1;
126 sc->sc_bops.ibo_bits[I2C_BIT_INPUT] = 0; 126 sc->sc_bops.ibo_bits[I2C_BIT_INPUT] = 0;
127 127
128 /* 128 /*
129 * Put the controller into Soft Reset. This allows us to 129 * Put the controller into Soft Reset. This allows us to
130 * manually bit-bang the I2C clock/data lines. 130 * manually bit-bang the I2C clock/data lines.
131 */ 131 */
132 bus_space_write_1(sc->sc_bust, sc->sc_bush, IIC_XTCNTLSS, 132 bus_space_write_1(sc->sc_bust, sc->sc_bush, IIC_XTCNTLSS,
133 IIC_XTCNTLSS_SRST); 133 IIC_XTCNTLSS_SRST);
134 delay(10); 134 delay(10);
135 bus_space_write_1(sc->sc_bust, sc->sc_bush, IIC_DIRECTCNTL, 135 bus_space_write_1(sc->sc_bust, sc->sc_bush, IIC_DIRECTCNTL,
136 IIC_DIRECTCNTL_SCC | IIC_DIRECTCNTL_SDAC); 136 IIC_DIRECTCNTL_SCC | IIC_DIRECTCNTL_SDAC);
137 137
 138 memset(&iba, 0, sizeof(iba));
138 iba.iba_tag = &sc->sc_i2c; 139 iba.iba_tag = &sc->sc_i2c;
139 (void) config_found_ia(&sc->sc_dev, "i2cbus", &iba, iicbus_print); 140 (void) config_found_ia(&sc->sc_dev, "i2cbus", &iba, iicbus_print);
140} 141}
141 142
142static int 143static int
143gpiic_acquire_bus(void *arg, int flags) 144gpiic_acquire_bus(void *arg, int flags)
144{ 145{
145 struct gpiic_softc *sc = arg; 146 struct gpiic_softc *sc = arg;
146 147
147 if (flags & I2C_F_POLL) 148 if (flags & I2C_F_POLL)
148 return (0); 149 return (0);
149 150
150 mutex_enter(&sc->sc_buslock); 151 mutex_enter(&sc->sc_buslock);
151 return (0); 152 return (0);
152} 153}
153 154
154static void 155static void
155gpiic_release_bus(void *arg, int flags) 156gpiic_release_bus(void *arg, int flags)
156{ 157{
157 struct gpiic_softc *sc = arg; 158 struct gpiic_softc *sc = arg;
158 159
159 if (flags & I2C_F_POLL) 160 if (flags & I2C_F_POLL)
160 return; 161 return;
161 162
162 mutex_exit(&sc->sc_buslock); 163 mutex_exit(&sc->sc_buslock);
163} 164}
164 165
165static int 166static int
166gpiic_send_start(void *arg, int flags) 167gpiic_send_start(void *arg, int flags)
167{ 168{
168 struct gpiic_softc *sc = arg; 169 struct gpiic_softc *sc = arg;
169 170
170 return (i2c_bitbang_send_start(sc, flags, &sc->sc_bops)); 171 return (i2c_bitbang_send_start(sc, flags, &sc->sc_bops));
171} 172}
172 173
173static int 174static int
174gpiic_send_stop(void *arg, int flags) 175gpiic_send_stop(void *arg, int flags)
175{ 176{
176 struct gpiic_softc *sc = arg; 177 struct gpiic_softc *sc = arg;
177 178
178 return (i2c_bitbang_send_stop(sc, flags, &sc->sc_bops)); 179 return (i2c_bitbang_send_stop(sc, flags, &sc->sc_bops));
179} 180}
180 181
181static int 182static int
182gpiic_initiate_xfer(void *arg, i2c_addr_t addr, int flags) 183gpiic_initiate_xfer(void *arg, i2c_addr_t addr, int flags)
183{ 184{
184 struct gpiic_softc *sc = arg; 185 struct gpiic_softc *sc = arg;
185 186
186 return (i2c_bitbang_initiate_xfer(sc, addr, flags, &sc->sc_bops)); 187 return (i2c_bitbang_initiate_xfer(sc, addr, flags, &sc->sc_bops));
187} 188}
188 189
189static int 190static int
190gpiic_read_byte(void *arg, uint8_t *vp, int flags) 191gpiic_read_byte(void *arg, uint8_t *vp, int flags)
191{ 192{
192 struct gpiic_softc *sc = arg; 193 struct gpiic_softc *sc = arg;
193 194
194 return (i2c_bitbang_read_byte(sc, vp, flags, &sc->sc_bops)); 195 return (i2c_bitbang_read_byte(sc, vp, flags, &sc->sc_bops));
195} 196}
196 197
197static int 198static int
198gpiic_write_byte(void *arg, uint8_t v, int flags) 199gpiic_write_byte(void *arg, uint8_t v, int flags)
199{ 200{
200 struct gpiic_softc *sc = arg; 201 struct gpiic_softc *sc = arg;
201 202
202 return (i2c_bitbang_write_byte(sc, v, flags, &sc->sc_bops)); 203 return (i2c_bitbang_write_byte(sc, v, flags, &sc->sc_bops));
203} 204}
204 205
205static void 206static void
206gpiic_set_dir(void *arg, uint32_t bits) 207gpiic_set_dir(void *arg, uint32_t bits)
207{ 208{
208 struct gpiic_softc *sc = arg; 209 struct gpiic_softc *sc = arg;
209 uint8_t tx, txen; 210 uint8_t tx, txen;
210 211
211 txen = (uint8_t)bits; 212 txen = (uint8_t)bits;
212 if (sc->sc_txen == txen) 213 if (sc->sc_txen == txen)
213 return; 214 return;
214 215
215 sc->sc_txen = txen; 216 sc->sc_txen = txen;
216 217
217 tx = sc->sc_tx; 218 tx = sc->sc_tx;
218 if (sc->sc_txen == 0) 219 if (sc->sc_txen == 0)
219 tx |= IIC_DIRECTCNTL_SDAC; 220 tx |= IIC_DIRECTCNTL_SDAC;
220 bus_space_write_1(sc->sc_bust, sc->sc_bush, IIC_DIRECTCNTL, tx); 221 bus_space_write_1(sc->sc_bust, sc->sc_bush, IIC_DIRECTCNTL, tx);
221} 222}
222 223
223static void 224static void
224gpiic_set_bits(void *arg, uint32_t bits) 225gpiic_set_bits(void *arg, uint32_t bits)
225{ 226{
226 struct gpiic_softc *sc = arg; 227 struct gpiic_softc *sc = arg;
227 228
228 sc->sc_tx = (uint8_t)bits; 229 sc->sc_tx = (uint8_t)bits;
229 if (sc->sc_txen == 0) 230 if (sc->sc_txen == 0)
230 bits |= IIC_DIRECTCNTL_SDAC; 231 bits |= IIC_DIRECTCNTL_SDAC;
231 232
232 bus_space_write_1(sc->sc_bust, sc->sc_bush, IIC_DIRECTCNTL, bits); 233 bus_space_write_1(sc->sc_bust, sc->sc_bush, IIC_DIRECTCNTL, bits);
233} 234}
234 235
235static uint32_t 236static uint32_t
236gpiic_read_bits(void *arg) 237gpiic_read_bits(void *arg)
237{ 238{
238 struct gpiic_softc *sc = arg; 239 struct gpiic_softc *sc = arg;
239 uint8_t rv; 240 uint8_t rv;
240 241
241 rv = bus_space_read_1(sc->sc_bust, sc->sc_bush, IIC_DIRECTCNTL) << 2; 242 rv = bus_space_read_1(sc->sc_bust, sc->sc_bush, IIC_DIRECTCNTL) << 2;
242 rv &= (IIC_DIRECTCNTL_SCC | IIC_DIRECTCNTL_SDAC); 243 rv &= (IIC_DIRECTCNTL_SCC | IIC_DIRECTCNTL_SDAC);
243 244
244 return ((uint32_t)rv); 245 return ((uint32_t)rv);
245} 246}