Mon Mar 2 02:26:37 2015 UTC ()
Fix broken error checking in kmalloc_array/kcalloc.


(riastradh)
diff -r1.4 -r1.5 src/sys/external/bsd/drm2/include/linux/slab.h

cvs diff -r1.4 -r1.5 src/sys/external/bsd/drm2/include/linux/Attic/slab.h (expand / switch to context diff)
--- src/sys/external/bsd/drm2/include/linux/Attic/slab.h 2014/07/16 20:59:58 1.4
+++ src/sys/external/bsd/drm2/include/linux/Attic/slab.h 2015/03/02 02:26:37 1.5
@@ -1,4 +1,4 @@
-/*	$NetBSD: slab.h,v 1.4 2014/07/16 20:59:58 riastradh Exp $	*/
+/*	$NetBSD: slab.h,v 1.5 2015/03/02 02:26:37 riastradh Exp $	*/
 
 /*-
  * Copyright (c) 2013 The NetBSD Foundation, Inc.
@@ -96,16 +96,14 @@
 static inline void *
 kmalloc_array(size_t n, size_t size, gfp_t gfp)
 {
-	KASSERT(size != 0);
-	KASSERT(n <= (SIZE_MAX / size));
+	if ((size != 0) && (n > (SIZE_MAX / size)))
+		return NULL;
 	return malloc((n * size), M_TEMP, linux_gfp_to_malloc(gfp));
 }
 
 static inline void *
 kcalloc(size_t n, size_t size, gfp_t gfp)
 {
-	if ((size == 0) && (n > (SIZE_MAX / size)))
-		return NULL;
 	return kmalloc_array(n, size, (gfp | __GFP_ZERO));
 }