Fri Mar 6 14:02:39 2015 UTC ()
Synchronize permission checks with upstream drm_ioctl_permit.


(riastradh)
diff -r1.13 -r1.14 src/sys/external/bsd/drm2/drm/drm_drv.c

cvs diff -r1.13 -r1.14 src/sys/external/bsd/drm2/drm/Attic/drm_drv.c (expand / switch to context diff)
--- src/sys/external/bsd/drm2/drm/Attic/drm_drv.c 2015/01/01 01:15:42 1.13
+++ src/sys/external/bsd/drm2/drm/Attic/drm_drv.c 2015/03/06 14:02:39 1.14
@@ -1,4 +1,4 @@
-/*	$NetBSD: drm_drv.c,v 1.13 2015/01/01 01:15:42 mrg Exp $	*/
+/*	$NetBSD: drm_drv.c,v 1.14 2015/03/06 14:02:39 riastradh Exp $	*/
 
 /*-
  * Copyright (c) 2013 The NetBSD Foundation, Inc.
@@ -30,7 +30,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: drm_drv.c,v 1.13 2015/01/01 01:15:42 mrg Exp $");
+__KERNEL_RCSID(0, "$NetBSD: drm_drv.c,v 1.14 2015/03/06 14:02:39 riastradh Exp $");
 
 #include <sys/param.h>
 #include <sys/types.h>
@@ -642,17 +642,26 @@
 	if ((ioctl == NULL) || (ioctl->func == NULL))
 		return EINVAL;
 
+	/* XXX Synchronize with drm_ioctl_permit in upstream drm_drv.c.  */
 	if (ISSET(ioctl->flags, DRM_ROOT_ONLY) && !DRM_SUSER())
 		return EACCES;
 
-	if (ISSET(ioctl->flags, DRM_AUTH) && !file->authenticated)
+	if (ISSET(ioctl->flags, DRM_AUTH) &&
+	    (file->minor->type != DRM_MINOR_RENDER) &&
+	    !file->authenticated)
 		return EACCES;
 
-	if (ISSET(ioctl->flags, DRM_MASTER) && (file->master == NULL))
+	if (ISSET(ioctl->flags, DRM_MASTER) &&
+	    (file->master == NULL) &&
+	    (file->minor->type != DRM_MINOR_CONTROL))
 		return EACCES;
 
 	if (!ISSET(ioctl->flags, DRM_CONTROL_ALLOW) &&
 	    (file->minor->type == DRM_MINOR_CONTROL))
+		return EACCES;
+
+	if (!ISSET(ioctl->flags, DRM_RENDER_ALLOW) &&
+	    (file->minor->type == DRM_MINOR_RENDER))
 		return EACCES;
 
 	if (!ISSET(ioctl->flags, DRM_UNLOCKED))