Tue Oct 4 15:38:31 2016 UTC ()

am335x's main interrupt source is 128.


(kiyohara)

diff -r1.9 -r1.10 src/sys/arch/arm/omap/omap2_icu.c

--- src/sys/arch/arm/omap/Attic/omap2_icu.c 2012/08/20 12:38:28	1.9
+++ src/sys/arch/arm/omap/Attic/omap2_icu.c 2016/10/04 15:38:31	1.10

 @@ -1,14 +1,14 @@
-/*	$NetBSD: omap2_icu.c,v 1.9 2012/08/20 12:38:28 matt Exp $	*/
+/*	$NetBSD: omap2_icu.c,v 1.10 2016/10/04 15:38:31 kiyohara Exp $	*/
 /*
  * Define the SDP2430 specific information and then include the generic OMAP
  * interrupt header.
  */
 /*
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain this list of conditions
  *    and the following disclaimer.
  * 2. Redistributions in binary form must reproduce this list of conditions
  *    and the following disclaimer in the documentation and/or other materials
 @@ -20,27 +20,27 @@
  * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
  * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
  * OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
  * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
  * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
  * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 #include "opt_omap.h"
 #define _INTR_PRIVATE
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: omap2_icu.c,v 1.9 2012/08/20 12:38:28 matt Exp $");
+__KERNEL_RCSID(0, "$NetBSD: omap2_icu.c,v 1.10 2016/10/04 15:38:31 kiyohara Exp $");
 #include <sys/param.h>
 #include <sys/evcnt.h>
 #include <sys/device.h>
 #include <uvm/uvm_extern.h>
 #include <machine/intr.h>
 #include <sys/bus.h>
 #include <arm/cpu.h>
 #include <arm/armreg.h>
 #include <arm/cpufunc.h>
 @@ -72,31 +72,39 @@ static const struct pic_ops omap2icu_pic
 #if 0
 	.pic_source_name = omap2icu_source_name,
 #endif
 };
 #define	PICTOSOFTC(pic)	\
 	((void *)((uintptr_t)(pic) - offsetof(struct omap2icu_softc, sc_pic)))
 static struct omap2icu_softc {
 	device_t sc_dev;
 	bus_space_tag_t sc_memt;
 	bus_space_handle_t sc_memh;
 	struct pic_softc sc_pic;
 #if defined(TI_AM335X)
 	uint32_t sc_enabled_irqs[4];
 #else
 	uint32_t sc_enabled_irqs[3];
 #endif
 } omap2icu_softc = {
 	.sc_pic = {
 		.pic_ops = &omap2icu_picops,
 #if defined(TI_AM335X)
 		.pic_maxsources = 128,
 #else
 		.pic_maxsources = 96,
 #endif
 		.pic_name = "omap2icu",
 	},
 };
 static void
 omap2icu_unblock_irqs(struct pic_softc *pic, size_t irqbase, uint32_t irq_mask)
+{
 	struct omap2icu_softc * const sc = PICTOSOFTC(pic);
 	const size_t group = irqbase / 32;
 	KASSERT((irq_mask & sc->sc_enabled_irqs[group]) == 0);
 	sc->sc_enabled_irqs[group] |= irq_mask;
 	INTC_WRITE(sc, group, INTC_MIR_CLEAR, irq_mask);
 @@ -151,27 +159,27 @@ omap_irq_handler(void *frame)
 	/* force INTC to recomputq IRQ */
 	INTC_WRITE(sc, 0, INTC_CONTROL, INTC_CONTROL_NEWIRQAGR);
 	/*
 	 * Record the pending_ipls and deliver them if we can.
 	 */
 	if ((ipl_mask & ~oldipl_mask) > oldipl_mask)
 		pic_do_pending_ints(I32_bit, oldipl, frame);
+}
 void
 omap2icu_establish_irq(struct pic_softc *pic, struct intrsource *is)
+{
-	KASSERT(is->is_irq < 96);
+	KASSERT(is->is_irq < omap2icu_softc.sc_pic.pic_maxsources);
 	KASSERT(is->is_type == IST_LEVEL);
+}
 int
 omap2icu_match(device_t parent, cfdata_t cf, void *aux)
+{
 	struct obio_attach_args * const oa = aux;
 #if defined(OMAP_2430) || defined(OMAP_2420)
 	return oa->obio_addr == INTC_BASE;
 #elif defined(OMAP3)
 	return oa->obio_addr == INTC_BASE_3530;
 #else