 @@ -1,1173 +1,1195 @@
-/*	$NetBSD: kernfs_vnops.c,v 1.154 2014/07/25 08:20:52 dholland Exp $	*/
+/*	$NetBSD: kernfs_vnops.c,v 1.154.10.1 2019/08/29 16:14:37 martin Exp $	*/
 /*
  * Copyright (c) 1992, 1993
  *	The Regents of the University of California.  All rights reserved.
+ *
  * This code is derived from software donated to Berkeley by
  * Jan-Simon Pendry.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  * 3. Neither the name of the University nor the names of its contributors
  *    may be used to endorse or promote products derived from this software
  *    without specific prior written permission.
+ *
  * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
  * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
  * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
+ *
  *	@(#)kernfs_vnops.c	8.15 (Berkeley) 5/21/95
  */
 /*
  * Kernel parameter filesystem (/kern)
  */
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: kernfs_vnops.c,v 1.154 2014/07/25 08:20:52 dholland Exp $");
+__KERNEL_RCSID(0, "$NetBSD: kernfs_vnops.c,v 1.154.10.1 2019/08/29 16:14:37 martin Exp $");
 #include <sys/param.h>
 #include <sys/systm.h>
 #include <sys/kernel.h>
 #include <sys/vmmeter.h>
 #include <sys/time.h>
 #include <sys/proc.h>
 #include <sys/vnode.h>
 #include <sys/malloc.h>
 #include <sys/file.h>
 #include <sys/stat.h>
 #include <sys/mount.h>
 #include <sys/namei.h>
 #include <sys/buf.h>
 #include <sys/dirent.h>
 #include <sys/msgbuf.h>
 #include <miscfs/genfs/genfs.h>
 #include <miscfs/kernfs/kernfs.h>
 #include <miscfs/specfs/specdev.h>
 #include <uvm/uvm_extern.h>
 #define KSTRING	256		/* Largest I/O available via this filesystem */
 #define	UIO_MX 32
 #define	READ_MODE	(S_IRUSR|S_IRGRP|S_IROTH)
 #define	WRITE_MODE	(S_IWUSR|S_IRUSR|S_IRGRP|S_IROTH)
 #define	UREAD_MODE	(S_IRUSR)
 #define	DIR_MODE	(S_IRUSR|S_IXUSR|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH)
 #define	UDIR_MODE	(S_IRUSR|S_IXUSR)
 #define N(s) sizeof(s)-1, s
 const struct kern_target kern_targets[] = {
 /* NOTE: The name must be less than UIO_MX-16 chars in length */
      /*        name            data          tag           type  ro/rw */
      { DT_DIR, N("."),         0,            KFSkern,        VDIR, DIR_MODE   },
      { DT_DIR, N(".."),        0,            KFSroot,        VDIR, DIR_MODE   },
      { DT_REG, N("boottime"),  &boottime.tv_sec, KFSint,     VREG, READ_MODE  },
 			/* XXXUNCONST */
      { DT_REG, N("copyright"), __UNCONST(copyright),
      					     KFSstring,      VREG, READ_MODE  },
      { DT_REG, N("hostname"),  0,            KFShostname,    VREG, WRITE_MODE },
      { DT_REG, N("hz"),        &hz,          KFSint,         VREG, READ_MODE  },
      { DT_REG, N("loadavg"),   0,            KFSavenrun,     VREG, READ_MODE  },
      { DT_REG, N("msgbuf"),    0,	     KFSmsgbuf,      VREG, READ_MODE  },
      { DT_REG, N("pagesize"),  &uvmexp.pagesize, KFSint,     VREG, READ_MODE  },
      { DT_REG, N("physmem"),   &physmem,     KFSint,         VREG, READ_MODE  },
 #if 0
      { DT_DIR, N("root"),      0,            KFSnull,        VDIR, DIR_MODE   },
 #endif
      { DT_BLK, N("rootdev"),   &rootdev,     KFSdevice,      VBLK, READ_MODE  },
      { DT_CHR, N("rrootdev"),  &rrootdev,    KFSdevice,      VCHR, READ_MODE  },
      { DT_REG, N("time"),      0,            KFStime,        VREG, READ_MODE  },
 			/* XXXUNCONST */
      { DT_REG, N("version"),   __UNCONST(version),
      					     KFSstring,      VREG, READ_MODE  },
 };
 const struct kern_target subdir_targets[] = {
 /* NOTE: The name must be less than UIO_MX-16 chars in length */
      /*        name            data          tag           type  ro/rw */
      { DT_DIR, N("."),         0,            KFSsubdir,      VDIR, DIR_MODE   },
      { DT_DIR, N(".."),        0,            KFSkern,        VDIR, DIR_MODE   },
 };
 #undef N
 SIMPLEQ_HEAD(,dyn_kern_target) dyn_kern_targets =
 	SIMPLEQ_HEAD_INITIALIZER(dyn_kern_targets);
 int nkern_targets = sizeof(kern_targets) / sizeof(kern_targets[0]);
 const int static_nkern_targets = sizeof(kern_targets) / sizeof(kern_targets[0]);
 int nkern_dirs = 2;
 int kernfs_try_fileop(kfstype, kfsfileop, void *, int);
 int kernfs_try_xread(kfstype, const struct kernfs_node *, char **,
     size_t, int);
 int kernfs_try_xwrite(kfstype, const struct kernfs_node *, char *,
     size_t, int);
 static int kernfs_default_xread(void *v);
 static int kernfs_default_xwrite(void *v);
 static int kernfs_default_fileop_getattr(void *);
 /* must include all fileop's */
 const struct kernfs_fileop kernfs_default_fileops[] = {
   { .kf_fileop = KERNFS_XREAD },
   { .kf_fileop = KERNFS_XWRITE },
   { .kf_fileop = KERNFS_FILEOP_OPEN },
   { .kf_fileop = KERNFS_FILEOP_GETATTR,
     .kf_vop = kernfs_default_fileop_getattr },
   { .kf_fileop = KERNFS_FILEOP_IOCTL },
   { .kf_fileop = KERNFS_FILEOP_CLOSE },
   { .kf_fileop = KERNFS_FILEOP_READ,
     .kf_vop = kernfs_default_xread },
   { .kf_fileop = KERNFS_FILEOP_WRITE,
     .kf_vop = kernfs_default_xwrite },
 };
 int	kernfs_lookup(void *);
 #define	kernfs_create	genfs_eopnotsupp
 #define	kernfs_mknod	genfs_eopnotsupp
 int	kernfs_open(void *);
 int	kernfs_close(void *);
 int	kernfs_access(void *);
 int	kernfs_getattr(void *);
 int	kernfs_setattr(void *);
 int	kernfs_read(void *);
 int	kernfs_write(void *);
 #define	kernfs_fcntl	genfs_fcntl
 int	kernfs_ioctl(void *);
 #define	kernfs_poll	genfs_poll
 #define kernfs_revoke	genfs_revoke
 #define	kernfs_fsync	genfs_nullop
 #define	kernfs_seek	genfs_nullop
 #define	kernfs_remove	genfs_eopnotsupp
 int	kernfs_link(void *);
 #define	kernfs_rename	genfs_eopnotsupp
 #define	kernfs_mkdir	genfs_eopnotsupp
 #define	kernfs_rmdir	genfs_eopnotsupp
 int	kernfs_symlink(void *);
 int	kernfs_readdir(void *);
 #define	kernfs_readlink	genfs_eopnotsupp
 #define	kernfs_abortop	genfs_abortop
 int	kernfs_inactive(void *);
 int	kernfs_reclaim(void *);
 #define	kernfs_lock	genfs_lock
 #define	kernfs_unlock	genfs_unlock
 #define	kernfs_bmap	genfs_badop
 #define	kernfs_strategy	genfs_badop
 int	kernfs_print(void *);
 #define	kernfs_islocked	genfs_islocked
 int	kernfs_pathconf(void *);
 #define	kernfs_advlock	genfs_einval
 #define	kernfs_bwrite	genfs_eopnotsupp
 int	kernfs_getpages(void *);
 #define	kernfs_putpages	genfs_putpages
 static int	kernfs_xread(struct kernfs_node *, int, char **,
 				size_t, size_t *);
 static int	kernfs_xwrite(const struct kernfs_node *, char *, size_t);
 int (**kernfs_vnodeop_p)(void *);
 const struct vnodeopv_entry_desc kernfs_vnodeop_entries[] = {
 	{ &vop_default_desc, vn_default_error },
 	{ &vop_lookup_desc, kernfs_lookup },		/* lookup */
 	{ &vop_create_desc, kernfs_create },		/* create */
 	{ &vop_mknod_desc, kernfs_mknod },		/* mknod */
 	{ &vop_open_desc, kernfs_open },		/* open */
 	{ &vop_close_desc, kernfs_close },		/* close */
 	{ &vop_access_desc, kernfs_access },		/* access */
 	{ &vop_getattr_desc, kernfs_getattr },		/* getattr */
 	{ &vop_setattr_desc, kernfs_setattr },		/* setattr */
 	{ &vop_read_desc, kernfs_read },		/* read */
 	{ &vop_write_desc, kernfs_write },		/* write */
 	{ &vop_fallocate_desc, genfs_eopnotsupp },	/* fallocate */
 	{ &vop_fdiscard_desc, genfs_eopnotsupp },	/* fdiscard */
 	{ &vop_fcntl_desc, kernfs_fcntl },		/* fcntl */
 	{ &vop_ioctl_desc, kernfs_ioctl },		/* ioctl */
 	{ &vop_poll_desc, kernfs_poll },		/* poll */
 	{ &vop_revoke_desc, kernfs_revoke },		/* revoke */
 	{ &vop_fsync_desc, kernfs_fsync },		/* fsync */
 	{ &vop_seek_desc, kernfs_seek },		/* seek */
 	{ &vop_remove_desc, kernfs_remove },		/* remove */
 	{ &vop_link_desc, kernfs_link },		/* link */
 	{ &vop_rename_desc, kernfs_rename },		/* rename */
 	{ &vop_mkdir_desc, kernfs_mkdir },		/* mkdir */
 	{ &vop_rmdir_desc, kernfs_rmdir },		/* rmdir */
 	{ &vop_symlink_desc, kernfs_symlink },		/* symlink */
 	{ &vop_readdir_desc, kernfs_readdir },		/* readdir */
 	{ &vop_readlink_desc, kernfs_readlink },	/* readlink */
 	{ &vop_abortop_desc, kernfs_abortop },		/* abortop */
 	{ &vop_inactive_desc, kernfs_inactive },	/* inactive */
 	{ &vop_reclaim_desc, kernfs_reclaim },		/* reclaim */
 	{ &vop_lock_desc, kernfs_lock },		/* lock */
 	{ &vop_unlock_desc, kernfs_unlock },		/* unlock */
 	{ &vop_bmap_desc, kernfs_bmap },		/* bmap */
 	{ &vop_strategy_desc, kernfs_strategy },	/* strategy */
 	{ &vop_print_desc, kernfs_print },		/* print */
 	{ &vop_islocked_desc, kernfs_islocked },	/* islocked */
 	{ &vop_pathconf_desc, kernfs_pathconf },	/* pathconf */
 	{ &vop_advlock_desc, kernfs_advlock },		/* advlock */
 	{ &vop_bwrite_desc, kernfs_bwrite },		/* bwrite */
 	{ &vop_getpages_desc, kernfs_getpages },	/* getpages */
 	{ &vop_putpages_desc, kernfs_putpages },	/* putpages */
 	{ NULL, NULL }
 };
 const struct vnodeopv_desc kernfs_vnodeop_opv_desc =
 	{ &kernfs_vnodeop_p, kernfs_vnodeop_entries };
 static inline int
 kernfs_fileop_compare(struct kernfs_fileop *a, struct kernfs_fileop *b)
+{
 	if (a->kf_type < b->kf_type)
 		return -1;
 	if (a->kf_type > b->kf_type)
 		return 1;
 	if (a->kf_fileop < b->kf_fileop)
 		return -1;
 	if (a->kf_fileop > b->kf_fileop)
 		return 1;
 	return (0);
+}
 SPLAY_HEAD(kfsfileoptree, kernfs_fileop) kfsfileoptree =
 	SPLAY_INITIALIZER(kfsfileoptree);
 SPLAY_PROTOTYPE(kfsfileoptree, kernfs_fileop, kf_node, kernfs_fileop_compare);
 SPLAY_GENERATE(kfsfileoptree, kernfs_fileop, kf_node, kernfs_fileop_compare);
 kfstype
 kernfs_alloctype(int nkf, const struct kernfs_fileop *kf)
+{
 	static u_char nextfreetype = KFSlasttype;
 	struct kernfs_fileop *dkf, *fkf, skf;
 	int i;
 	/* XXX need to keep track of dkf's memory if we support
            deallocating types */
 	dkf = malloc(sizeof(kernfs_default_fileops), M_TEMP, M_WAITOK);
 	memcpy(dkf, kernfs_default_fileops, sizeof(kernfs_default_fileops));
 	for (i = 0; i < sizeof(kernfs_default_fileops) /
 		     sizeof(kernfs_default_fileops[0]); i++) {
 		dkf[i].kf_type = nextfreetype;
 		SPLAY_INSERT(kfsfileoptree, &kfsfileoptree, &dkf[i]);
+	}
 	for (i = 0; i < nkf; i++) {
 		skf.kf_type = nextfreetype;
 		skf.kf_fileop = kf[i].kf_fileop;
 		if ((fkf = SPLAY_FIND(kfsfileoptree, &kfsfileoptree, &skf)))
 			fkf->kf_vop = kf[i].kf_vop;
+	}
 	return nextfreetype++;
+}
 int
 kernfs_try_fileop(kfstype type, kfsfileop fileop, void *v, int error)
+{
 	struct kernfs_fileop *kf, skf;
 	skf.kf_type = type;
 	skf.kf_fileop = fileop;
 	if ((kf = SPLAY_FIND(kfsfileoptree, &kfsfileoptree, &skf)))
 		if (kf->kf_vop)
 			return kf->kf_vop(v);
 	return error;
+}
 int
 kernfs_try_xread(kfstype type, const struct kernfs_node *kfs, char **bfp,
     size_t len, int error)
+{
 	struct kernfs_fileop *kf, skf;
 	skf.kf_type = type;
 	skf.kf_fileop = KERNFS_XREAD;
 	if ((kf = SPLAY_FIND(kfsfileoptree, &kfsfileoptree, &skf)))
 		if (kf->kf_xread)
 			return kf->kf_xread(kfs, bfp, len);
 	return error;
+}
 int
 kernfs_try_xwrite(kfstype type, const struct kernfs_node *kfs, char *bf,
     size_t len, int error)
+{
 	struct kernfs_fileop *kf, skf;
 	skf.kf_type = type;
 	skf.kf_fileop = KERNFS_XWRITE;
 	if ((kf = SPLAY_FIND(kfsfileoptree, &kfsfileoptree, &skf)))
 		if (kf->kf_xwrite)
 			return kf->kf_xwrite(kfs, bf, len);
 	return error;
+}
 int
 kernfs_addentry(kernfs_parentdir_t *pkt, kernfs_entry_t *dkt)
+{
 	struct kernfs_subdir *ks, *parent;
 	if (pkt == NULL) {
 		SIMPLEQ_INSERT_TAIL(&dyn_kern_targets, dkt, dkt_queue);
 		nkern_targets++;
 		if (dkt->dkt_kt.kt_vtype == VDIR)
 			nkern_dirs++;
 	} else {
 		parent = (struct kernfs_subdir *)pkt->kt_data;
 		SIMPLEQ_INSERT_TAIL(&parent->ks_entries, dkt, dkt_queue);
 		parent->ks_nentries++;
 		if (dkt->dkt_kt.kt_vtype == VDIR)
 			parent->ks_dirs++;
+	}
 	if (dkt->dkt_kt.kt_vtype == VDIR && dkt->dkt_kt.kt_data == NULL) {
 		ks = malloc(sizeof(struct kernfs_subdir),
 		    M_TEMP, M_WAITOK);
 		SIMPLEQ_INIT(&ks->ks_entries);
 		ks->ks_nentries = 2; /* . and .. */
 		ks->ks_dirs = 2;
 		ks->ks_parent = pkt ? pkt : &kern_targets[0];
 		dkt->dkt_kt.kt_data = ks;
+	}
 	return 0;
+}
 static int
 kernfs_xread(struct kernfs_node *kfs, int off, char **bufp, size_t len, size_t *wrlen)
+{
 	const struct kern_target *kt;
 	int err;
 	kt = kfs->kfs_kt;
 	switch (kfs->kfs_type) {
 	case KFStime: {
 		struct timeval tv;
 		microtime(&tv);
 		snprintf(*bufp, len, "%lld %ld\n", (long long)tv.tv_sec,
 		    (long)tv.tv_usec);
 		break;
+	}
 	case KFSint: {
 		int *ip = kt->kt_data;
 		snprintf(*bufp, len, "%d\n", *ip);
 		break;
+	}
 	case KFSstring: {
 		char *cp = kt->kt_data;
 		*bufp = cp;
 		break;
+	}
 	case KFSmsgbuf: {
 		long n;
 		/*
 		 * deal with cases where the message buffer has
 		 * become corrupted.
 		 */
 		if (!msgbufenabled || msgbufp->msg_magic != MSG_MAGIC) {
 			msgbufenabled = 0;
 			return (ENXIO);
+		}
 		/*
 		 * Note that reads of /kern/msgbuf won't necessarily yield
 		 * consistent results, if the message buffer is modified
 		 * while the read is in progress.  The worst that can happen
 		 * is that incorrect data will be read.  There's no way
 		 * that this can crash the system unless the values in the
 		 * message buffer header are corrupted, but that'll cause
 		 * the system to die anyway.
 		 */
 		if (off >= msgbufp->msg_bufs) {
 			*wrlen = 0;
 			return (0);
+		}
 		n = msgbufp->msg_bufx + off;
 		if (n >= msgbufp->msg_bufs)
 			n -= msgbufp->msg_bufs;
 		len = min(msgbufp->msg_bufs - n, msgbufp->msg_bufs - off);
 		*bufp = msgbufp->msg_bufc + n;
 		*wrlen = len;
 		return (0);
+	}
 	case KFShostname: {
 		char *cp = hostname;
 		size_t xlen = hostnamelen;
 		if (xlen >= (len - 2))
 			return (EINVAL);
 		memcpy(*bufp, cp, xlen);
 		(*bufp)[xlen] = '\n';
 		(*bufp)[xlen+1] = '\0';
 		break;
+	}
 	case KFSavenrun:
 		averunnable.fscale = FSCALE;
 		snprintf(*bufp, len, "%d %d %d %ld\n",
 		    averunnable.ldavg[0], averunnable.ldavg[1],
 		    averunnable.ldavg[2], averunnable.fscale);
 		break;
 	default:
 		err = kernfs_try_xread(kfs->kfs_type, kfs, bufp, len,
 		    EOPNOTSUPP);
 		if (err)
 			return err;
+	}
 	len = strlen(*bufp);
 	if (len <= off)
 		*wrlen = 0;
 	else {
 		*bufp += off;
 		*wrlen = len - off;
+	}
 	return (0);
+}
 static int
 kernfs_xwrite(const struct kernfs_node *kfs, char *bf, size_t len)
+{
 	switch (kfs->kfs_type) {
 	case KFShostname:
 		if (bf[len-1] == '\n')
 			--len;
 		memcpy(hostname, bf, len);
 		hostname[len] = '\0';
 		hostnamelen = (size_t) len;
 		return (0);
 	default:
 		return kernfs_try_xwrite(kfs->kfs_type, kfs, bf, len, EIO);
+	}
+}
 /*
  * vp is the current namei directory
  * ndp is the name to locate in that directory...
  */
 int
 kernfs_lookup(void *v)
+{
 	struct vop_lookup_v2_args /* {
 		struct vnode * a_dvp;
 		struct vnode ** a_vpp;
 		struct componentname * a_cnp;
 	} */ *ap = v;
 	struct componentname *cnp = ap->a_cnp;
 	struct vnode **vpp = ap->a_vpp;
 	struct vnode *dvp = ap->a_dvp;
 	const char *pname = cnp->cn_nameptr;
 	const struct kernfs_node *kfs;
 	const struct kern_target *kt;
 	const struct dyn_kern_target *dkt;
 	const struct kernfs_subdir *ks;
 	int error, i;
 	*vpp = NULLVP;
 	if (cnp->cn_nameiop == DELETE || cnp->cn_nameiop == RENAME)
 		return (EROFS);
 	if (cnp->cn_namelen == 1 && *pname == '.') {
 		*vpp = dvp;
 		vref(dvp);
 		return (0);
+	}
 	kfs = VTOKERN(dvp);
 	switch (kfs->kfs_type) {
 	case KFSkern:
 		/*
 		 * Shouldn't get here with .. in the root node.
 		 */
 		if (cnp->cn_flags & ISDOTDOT)
 			return (EIO);
 		for (i = 0; i < static_nkern_targets; i++) {
 			kt = &kern_targets[i];
 			if (cnp->cn_namelen == kt->kt_namlen &&
 			    memcmp(kt->kt_name, pname, cnp->cn_namelen) == 0)
 				goto found;
+		}
 		SIMPLEQ_FOREACH(dkt, &dyn_kern_targets, dkt_queue) {
 			if (cnp->cn_namelen == dkt->dkt_kt.kt_namlen &&
 			    memcmp(dkt->dkt_kt.kt_name, pname, cnp->cn_namelen) == 0) {
 				kt = &dkt->dkt_kt;
 				goto found;
+			}
+		}
 		break;
 	found:
 		error = vcache_get(dvp->v_mount, &kt, sizeof(kt), vpp);
 		return error;
 	case KFSsubdir:
 		ks = (struct kernfs_subdir *)kfs->kfs_kt->kt_data;
 		if (cnp->cn_flags & ISDOTDOT) {
 			kt = ks->ks_parent;
 			goto found;
+		}
 		SIMPLEQ_FOREACH(dkt, &ks->ks_entries, dkt_queue) {
 			if (cnp->cn_namelen == dkt->dkt_kt.kt_namlen &&
 			    memcmp(dkt->dkt_kt.kt_name, pname, cnp->cn_namelen) == 0) {
 				kt = &dkt->dkt_kt;
 				goto found;
+			}
+		}
 		break;
 	default:
 		return (ENOTDIR);
+	}
 	return (cnp->cn_nameiop == LOOKUP ? ENOENT : EROFS);
+}
 int
 kernfs_open(void *v)
+{
 	struct vop_open_args /* {
 		struct vnode *a_vp;
 		int a_mode;
 		kauth_cred_t a_cred;
 	} */ *ap = v;
 	struct kernfs_node *kfs = VTOKERN(ap->a_vp);
 	return kernfs_try_fileop(kfs->kfs_type, KERNFS_FILEOP_OPEN, v, 0);
+}
 int
 kernfs_close(void *v)
+{
 	struct vop_close_args /* {
 		struct vnode *a_vp;
 		int a_fflag;
 		kauth_cred_t a_cred;
 	} */ *ap = v;
 	struct kernfs_node *kfs = VTOKERN(ap->a_vp);
 	return kernfs_try_fileop(kfs->kfs_type, KERNFS_FILEOP_CLOSE, v, 0);
+}
 int
 kernfs_access(void *v)
+{
 	struct vop_access_args /* {
 		struct vnode *a_vp;
 		int a_mode;
 		kauth_cred_t a_cred;
 	} */ *ap = v;
 	struct vattr va;
 	int error;
 	if ((error = VOP_GETATTR(ap->a_vp, &va, ap->a_cred)) != 0)
 		return (error);
 	return kauth_authorize_vnode(ap->a_cred,
 	    KAUTH_ACCESS_ACTION(ap->a_mode, ap->a_vp->v_type, va.va_mode),
 	    ap->a_vp, NULL, genfs_can_access(va.va_type, va.va_mode,
 	    va.va_uid, va.va_gid, ap->a_mode, ap->a_cred));
+}
 static int
 kernfs_default_fileop_getattr(void *v)
+{
 	struct vop_getattr_args /* {
 		struct vnode *a_vp;
 		struct vattr *a_vap;
 		kauth_cred_t a_cred;
 	} */ *ap = v;
 	struct vattr *vap = ap->a_vap;
 	vap->va_nlink = 1;
 	vap->va_bytes = vap->va_size = 0;
 	return 0;
+}
 int
 kernfs_getattr(void *v)
+{
 	struct vop_getattr_args /* {
 		struct vnode *a_vp;
 		struct vattr *a_vap;
 		kauth_cred_t a_cred;
 	} */ *ap = v;
 	struct kernfs_node *kfs = VTOKERN(ap->a_vp);
 	struct kernfs_subdir *ks;
 	struct vattr *vap = ap->a_vap;
 	int error = 0;
 	char strbuf[KSTRING], *bf;
 	size_t nread, total;
 	vattr_null(vap);
 	vap->va_type = ap->a_vp->v_type;
 	vap->va_uid = 0;
 	vap->va_gid = 0;
 	vap->va_mode = kfs->kfs_mode;
 	vap->va_fileid = kfs->kfs_fileno;
 	vap->va_flags = 0;
 	vap->va_size = 0;
 	vap->va_blocksize = DEV_BSIZE;
 	/* Make all times be current TOD, except for the "boottime" node. */
 	if (kfs->kfs_kt->kt_namlen == 8 &&
 	    !memcmp(kfs->kfs_kt->kt_name, "boottime", 8)) {
 		vap->va_ctime = boottime;
 	} else {
 		getnanotime(&vap->va_ctime);
+	}
 	vap->va_atime = vap->va_mtime = vap->va_ctime;
 	vap->va_gen = 0;
 	vap->va_flags = 0;
 	vap->va_rdev = 0;
 	vap->va_bytes = 0;
 	switch (kfs->kfs_type) {
 	case KFSkern:
 		vap->va_nlink = nkern_dirs;
 		vap->va_bytes = vap->va_size = DEV_BSIZE;
 		break;
 	case KFSdevice:
 		vap->va_nlink = 1;
 		vap->va_rdev = ap->a_vp->v_rdev;
 		break;
 	case KFSroot:
 		vap->va_nlink = 1;
 		vap->va_bytes = vap->va_size = DEV_BSIZE;
 		break;
 	case KFSsubdir:
 		ks = (struct kernfs_subdir *)kfs->kfs_kt->kt_data;
 		vap->va_nlink = ks->ks_dirs;
 		vap->va_bytes = vap->va_size = DEV_BSIZE;
 		break;
 	case KFSnull:
 	case KFStime:
 	case KFSint:
 	case KFSstring:
 	case KFShostname:
 	case KFSavenrun:
 	case KFSmsgbuf:
 		vap->va_nlink = 1;
 		total = 0;
 		do {
 			bf = strbuf;
 			error = kernfs_xread(kfs, total, &bf,
 			    sizeof(strbuf), &nread);
 			total += nread;
 		} while (error == 0 && nread != 0);
 		vap->va_bytes = vap->va_size = total;
 		break;
 	default:
 		error = kernfs_try_fileop(kfs->kfs_type,
 		    KERNFS_FILEOP_GETATTR, v, EINVAL);
 		break;
+	}
 	return (error);
+}
 /*ARGSUSED*/
 int
 kernfs_setattr(void *v)
+{
 	/*
 	 * Silently ignore attribute changes.
 	 * This allows for open with truncate to have no
 	 * effect until some data is written.  I want to
 	 * do it this way because all writes are atomic.
 	 */
 	return (0);
+}
 int
 kernfs_default_xread(void *v)
+{
 	struct vop_read_args /* {
 		struct vnode *a_vp;
 		struct uio *a_uio;
 		int  a_ioflag;
 		kauth_cred_t a_cred;
 	} */ *ap = v;
 	struct uio *uio = ap->a_uio;
 	struct kernfs_node *kfs = VTOKERN(ap->a_vp);
 	char strbuf[KSTRING], *bf;
 	int off;
 	size_t len;
 	int error;
 	if (ap->a_vp->v_type == VDIR)
 		return EISDIR;
 	off = (int)uio->uio_offset;
 	/* Don't allow negative offsets */
 	if (off < 0)
 		return EINVAL;
 	bf = strbuf;
 	if ((error = kernfs_xread(kfs, off, &bf, sizeof(strbuf), &len)) == 0)
 		error = uiomove(bf, len, uio);
 	return (error);
+}
 int
 kernfs_read(void *v)
+{
 	struct vop_read_args /* {
 		struct vnode *a_vp;
 		struct uio *a_uio;
 		int  a_ioflag;
 		struct ucred *a_cred;
 	} */ *ap = v;
 	struct kernfs_node *kfs = VTOKERN(ap->a_vp);
 	if (kfs->kfs_type < KFSlasttype) {
 		/* use default function */
 		return kernfs_default_xread(v);
+	}
 	return kernfs_try_fileop(kfs->kfs_type, KERNFS_FILEOP_READ, v,
 	   EOPNOTSUPP);
+}
 static int
 kernfs_default_xwrite(void *v)
+{
 	struct vop_write_args /* {
 		struct vnode *a_vp;
 		struct uio *a_uio;
 		int  a_ioflag;
 		kauth_cred_t a_cred;
 	} */ *ap = v;
 	struct kernfs_node *kfs = VTOKERN(ap->a_vp);
 	struct uio *uio = ap->a_uio;
 	int error;
 	size_t xlen;
 	char strbuf[KSTRING];
 	if (uio->uio_offset != 0)
 		return (EINVAL);
 	xlen = min(uio->uio_resid, KSTRING-1);
 	if ((error = uiomove(strbuf, xlen, uio)) != 0)
 		return (error);
 	if (uio->uio_resid != 0)
 		return (EIO);
 	strbuf[xlen] = '\0';
 	xlen = strlen(strbuf);
 	return (kernfs_xwrite(kfs, strbuf, xlen));
+}
 int
 kernfs_write(void *v)
+{
 	struct vop_write_args /* {
 		struct vnode *a_vp;
 		struct uio *a_uio;
 		int  a_ioflag;
 		kauth_cred_t a_cred;
 	} */ *ap = v;
 	struct kernfs_node *kfs = VTOKERN(ap->a_vp);
 	if (kfs->kfs_type < KFSlasttype) {
 		/* use default function */
 		return kernfs_default_xwrite(v);
+	}
 	return kernfs_try_fileop(kfs->kfs_type, KERNFS_FILEOP_WRITE, v,
 	    EOPNOTSUPP);
+}
 int
 kernfs_ioctl(void *v)
+{
 	struct vop_ioctl_args /* {
 		const struct vnodeop_desc *a_desc;
 		struct vnode *a_vp;
 		u_long a_command;
 		void *a_data;
 		int a_fflag;
 		kauth_cred_t a_cred;
 	} */ *ap = v;
 	struct kernfs_node *kfs = VTOKERN(ap->a_vp);
 	return kernfs_try_fileop(kfs->kfs_type, KERNFS_FILEOP_IOCTL, v,
 	    EPASSTHROUGH);
+}
 static int
 kernfs_setdirentfileno_kt(struct dirent *d, const struct kern_target *kt,
     struct vop_readdir_args *ap)
+{
 	struct kernfs_node *kfs;
 	struct vnode *vp;
 	int error;
 	if ((error = vcache_get(ap->a_vp->v_mount, &kt, sizeof(kt), &vp)) != 0)
 		return error;
 	kfs = VTOKERN(vp);
 	d->d_fileno = kfs->kfs_fileno;
 	vrele(vp);
 	return 0;
+}
 static int
 kernfs_setdirentfileno(struct dirent *d, off_t entry,
     struct kernfs_node *thisdir_kfs, const struct kern_target *parent_kt,
     const struct kern_target *kt, struct vop_readdir_args *ap)
+{
 	const struct kern_target *ikt;
 	int error;
 	switch (entry) {
 	case 0:
 		d->d_fileno = thisdir_kfs->kfs_fileno;
 		return 0;
 	case 1:
 		ikt = parent_kt;
 		break;
 	default:
 		ikt = kt;
 		break;
+	}
 	if (ikt != thisdir_kfs->kfs_kt) {
 		if ((error = kernfs_setdirentfileno_kt(d, ikt, ap)) != 0)
 			return error;
 	} else
 		d->d_fileno = thisdir_kfs->kfs_fileno;
 	return 0;
+}
 int
 kernfs_readdir(void *v)
+{
 	struct vop_readdir_args /* {
 		struct vnode *a_vp;
 		struct uio *a_uio;
 		kauth_cred_t a_cred;
 		int *a_eofflag;
 		off_t **a_cookies;
 		int a_*ncookies;
 	} */ *ap = v;
 	struct uio *uio = ap->a_uio;
 	struct dirent d;
 	struct kernfs_node *kfs = VTOKERN(ap->a_vp);
 	const struct kern_target *kt;
 	const struct dyn_kern_target *dkt = NULL;
 	const struct kernfs_subdir *ks;
 	off_t i, j;
 	int error;
 	off_t *cookies = NULL;
 	int ncookies = 0, n;
 	if (uio->uio_resid < UIO_MX)
 		return (EINVAL);
 	if (uio->uio_offset < 0)
 		return (EINVAL);
 	error = 0;
 	i = uio->uio_offset;
 	memset(&d, 0, sizeof(d));
 	d.d_reclen = UIO_MX;
 	ncookies = uio->uio_resid / UIO_MX;
 	switch (kfs->kfs_type) {
 	case KFSkern:
 		if (i >= nkern_targets)
 			return (0);
 		if (ap->a_ncookies) {
 			ncookies = min(ncookies, (nkern_targets - i));
 			cookies = malloc(ncookies * sizeof(off_t), M_TEMP,
 			    M_WAITOK);
 			*ap->a_cookies = cookies;
+		}
 		n = 0;
 		for (; i < nkern_targets && uio->uio_resid >= UIO_MX; i++) {
 			if (i < static_nkern_targets)
 				kt = &kern_targets[i];
 			else {
 				if (dkt == NULL) {
 					dkt = SIMPLEQ_FIRST(&dyn_kern_targets);
 					for (j = static_nkern_targets; j < i &&
 						     dkt != NULL; j++)
 						dkt = SIMPLEQ_NEXT(dkt, dkt_queue);
 					if (j != i)
 						break;
 				} else {
 					dkt = SIMPLEQ_NEXT(dkt, dkt_queue);
+				}
 				if (dkt == NULL)
 					break;
 				kt = &dkt->dkt_kt;
+			}
 			if (kt->kt_tag == KFSdevice) {
 				dev_t *dp = kt->kt_data;
 				struct vnode *fvp;
 				if (*dp == NODEV ||
 				    !vfinddev(*dp, kt->kt_vtype, &fvp))
 					continue;
 				vrele(fvp);
+			}
 			if (kt->kt_tag == KFSmsgbuf) {
 				if (!msgbufenabled
 				    || msgbufp->msg_magic != MSG_MAGIC) {
 					continue;
+				}
+			}
 			d.d_namlen = kt->kt_namlen;
 			if ((error = kernfs_setdirentfileno(&d, i, kfs,
 			    &kern_targets[0], kt, ap)) != 0)
 				break;
 			memcpy(d.d_name, kt->kt_name, kt->kt_namlen + 1);
 			d.d_type = kt->kt_type;
 			if ((error = uiomove(&d, UIO_MX, uio)) != 0)
 				break;
 			if (cookies)
 				*cookies++ = i + 1;
 			n++;
+		}
 		ncookies = n;
 		break;
 	case KFSroot:
 		if (i >= 2)
 			return 0;
 		if (ap->a_ncookies) {
 			ncookies = min(ncookies, (2 - i));
 			cookies = malloc(ncookies * sizeof(off_t), M_TEMP,
 			    M_WAITOK);
 			*ap->a_cookies = cookies;
+		}
 		n = 0;
 		for (; i < 2 && uio->uio_resid >= UIO_MX; i++) {
 			kt = &kern_targets[i];
 			d.d_namlen = kt->kt_namlen;
 			d.d_fileno = KERNFS_FILENO(kt, kt->kt_tag, 0);
 			memcpy(d.d_name, kt->kt_name, kt->kt_namlen + 1);
 			d.d_type = kt->kt_type;
 			if ((error = uiomove(&d, UIO_MX, uio)) != 0)
 				break;
 			if (cookies)
 				*cookies++ = i + 1;
 			n++;
+		}
 		ncookies = n;
 		break;
 	case KFSsubdir:
 		ks = (struct kernfs_subdir *)kfs->kfs_kt->kt_data;
 		if (i >= ks->ks_nentries)
 			return (0);
 		if (ap->a_ncookies) {
 			ncookies = min(ncookies, (ks->ks_nentries - i));
 			cookies = malloc(ncookies * sizeof(off_t), M_TEMP,
 			    M_WAITOK);
 			*ap->a_cookies = cookies;
+		}
 		dkt = SIMPLEQ_FIRST(&ks->ks_entries);
 		for (j = 0; j < i && dkt != NULL; j++)
 			dkt = SIMPLEQ_NEXT(dkt, dkt_queue);
 		n = 0;
 		for (; i < ks->ks_nentries && uio->uio_resid >= UIO_MX; i++) {
 			if (i < 2)
 				kt = &subdir_targets[i];
 			else {
 				/* check if ks_nentries lied to us */
 				if (dkt == NULL)
 					break;
 				kt = &dkt->dkt_kt;
 				dkt = SIMPLEQ_NEXT(dkt, dkt_queue);
+			}
 			if (kt->kt_tag == KFSdevice) {
 				dev_t *dp = kt->kt_data;
 				struct vnode *fvp;
 				if (*dp == NODEV ||
 				    !vfinddev(*dp, kt->kt_vtype, &fvp))
 					continue;
 				vrele(fvp);
+			}
 			d.d_namlen = kt->kt_namlen;
 			if ((error = kernfs_setdirentfileno(&d, i, kfs,
 			    ks->ks_parent, kt, ap)) != 0)
 				break;
 			memcpy(d.d_name, kt->kt_name, kt->kt_namlen + 1);
 			d.d_type = kt->kt_type;
 			if ((error = uiomove(&d, UIO_MX, uio)) != 0)
 				break;
 			if (cookies)
 				*cookies++ = i + 1;
 			n++;
+		}
 		ncookies = n;
 		break;
 	default:
 		error = ENOTDIR;
 		break;
+	}
 	if (ap->a_ncookies) {
 		if (error) {
 			if (cookies)
 				free(*ap->a_cookies, M_TEMP);
 			*ap->a_ncookies = 0;
 			*ap->a_cookies = NULL;
 		} else
 			*ap->a_ncookies = ncookies;
+	}
 	uio->uio_offset = i;
 	return (error);
+}
 int
 kernfs_inactive(void *v)
+{
 	struct vop_inactive_args /* {
 		struct vnode *a_vp;
 		bool *a_recycle;
 	} */ *ap = v;
 	struct vnode *vp = ap->a_vp;
 	*ap->a_recycle = false;
 	VOP_UNLOCK(vp);
 	return (0);
+}
 int
 kernfs_reclaim(void *v)
+{
 	struct vop_reclaim_args /* {
 		struct vnode *a_vp;
 	} */ *ap = v;
 	struct vnode *vp = ap->a_vp;
 	struct kernfs_node *kfs = VTOKERN(vp);
 	vp->v_data = NULL;
 	vcache_remove(vp->v_mount, &kfs->kfs_kt, sizeof(kfs->kfs_kt));
 	mutex_enter(&kfs_lock);
 	TAILQ_REMOVE(&VFSTOKERNFS(vp->v_mount)->nodelist, kfs, kfs_list);
 	mutex_exit(&kfs_lock);
 	kmem_free(kfs, sizeof(struct kernfs_node));
 	return 0;
+}
 /*
  * Return POSIX pathconf information applicable to special devices.
  */
 int
 kernfs_pathconf(void *v)
+{
 	struct vop_pathconf_args /* {
 		struct vnode *a_vp;
 		int a_name;
 		register_t *a_retval;
 	} */ *ap = v;
 	switch (ap->a_name) {
 	case _PC_LINK_MAX:
 		*ap->a_retval = LINK_MAX;
 		return (0);
 	case _PC_MAX_CANON:
 		*ap->a_retval = MAX_CANON;
 		return (0);
 	case _PC_MAX_INPUT:
 		*ap->a_retval = MAX_INPUT;
 		return (0);
 	case _PC_PIPE_BUF:
 		*ap->a_retval = PIPE_BUF;
 		return (0);
 	case _PC_CHOWN_RESTRICTED:
 		*ap->a_retval = 1;
 		return (0);
 	case _PC_VDISABLE:
 		*ap->a_retval = _POSIX_VDISABLE;
 		return (0);
 	case _PC_SYNC_IO:
 		*ap->a_retval = 1;
 		return (0);
 	default:
 		return (EINVAL);
+	}
 	/* NOTREACHED */
+}
 /*
  * Print out the contents of a /dev/fd vnode.
  */
 /* ARGSUSED */
 int
 kernfs_print(void *v)
+{
 	printf("tag VT_KERNFS, kernfs vnode\n");
 	return (0);
+}
 int
 kernfs_link(void *v)
+{
 	struct vop_link_args /* {
 		struct vnode *a_dvp;
 		struct vnode *a_vp;
 		struct componentname *a_cnp;
 	} */ *ap = v;
 	VOP_ABORTOP(ap->a_dvp, ap->a_cnp);
 	vput(ap->a_dvp);
 	return (EROFS);
+}
 int
 kernfs_symlink(void *v)
+{
 	struct vop_symlink_v3_args /* {
 		struct vnode *a_dvp;
 		struct vnode **a_vpp;
 		struct componentname *a_cnp;
 		struct vattr *a_vap;
 		char *a_target;
 	} */ *ap = v;
 	VOP_ABORTOP(ap->a_dvp, ap->a_cnp);
 	return (EROFS);
+}
 int
 kernfs_getpages(void *v)
+{
 	struct vop_getpages_args /* {
 		struct vnode *a_vp;
 		voff_t a_offset;
 		struct vm_page **a_m;
 		int *a_count;
 		int a_centeridx;
 		vm_prot_t a_access_type;
 		int a_advice;
 		int a_flags;
 	} */ *ap = v;
 	if ((ap->a_flags & PGO_LOCKED) == 0)
 		mutex_exit(ap->a_vp->v_interlock);
 	return (EFAULT);
+}

 @@ -1,1728 +1,1750 @@
-/*	$NetBSD: procfs_vnops.c,v 1.191 2014/07/27 16:47:26 hannken Exp $	*/
+/*	$NetBSD: procfs_vnops.c,v 1.191.8.1 2019/08/29 16:14:37 martin Exp $	*/
 /*-
  * Copyright (c) 2006, 2007, 2008 The NetBSD Foundation, Inc.
  * All rights reserved.
+ *
  * This code is derived from software contributed to The NetBSD Foundation
  * by Andrew Doran.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
+ *
  * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
  * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
  * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
  * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
  * POSSIBILITY OF SUCH DAMAGE.
  */
 /*
  * Copyright (c) 1993, 1995
  *	The Regents of the University of California.  All rights reserved.
+ *
  * This code is derived from software contributed to Berkeley by
  * Jan-Simon Pendry.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  * 3. Neither the name of the University nor the names of its contributors
  *    may be used to endorse or promote products derived from this software
  *    without specific prior written permission.
+ *
  * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
  * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
  * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
+ *
  *	@(#)procfs_vnops.c	8.18 (Berkeley) 5/21/95
  */
 /*
  * Copyright (c) 1993 Jan-Simon Pendry
+ *
  * This code is derived from software contributed to Berkeley by
  * Jan-Simon Pendry.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  * 3. All advertising materials mentioning features or use of this software
  *    must display the following acknowledgement:
  *	This product includes software developed by the University of
  *	California, Berkeley and its contributors.
  * 4. Neither the name of the University nor the names of its contributors
  *    may be used to endorse or promote products derived from this software
  *    without specific prior written permission.
+ *
  * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
  * ARE DISCLAIMED.  IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
  * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
+ *
  *	@(#)procfs_vnops.c	8.18 (Berkeley) 5/21/95
  */
 /*
  * procfs vnode interface
  */
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: procfs_vnops.c,v 1.191 2014/07/27 16:47:26 hannken Exp $");
+__KERNEL_RCSID(0, "$NetBSD: procfs_vnops.c,v 1.191.8.1 2019/08/29 16:14:37 martin Exp $");
 #include <sys/param.h>
 #include <sys/systm.h>
 #include <sys/time.h>
 #include <sys/kernel.h>
 #include <sys/file.h>
 #include <sys/filedesc.h>
 #include <sys/proc.h>
 #include <sys/vnode.h>
 #include <sys/namei.h>
 #include <sys/malloc.h>
 #include <sys/mount.h>
 #include <sys/dirent.h>
 #include <sys/resourcevar.h>
 #include <sys/stat.h>
 #include <sys/ptrace.h>
 #include <sys/kauth.h>
 #include <uvm/uvm_extern.h>	/* for PAGE_SIZE */
 #include <machine/reg.h>
 #include <miscfs/genfs/genfs.h>
 #include <miscfs/procfs/procfs.h>
 /*
  * Vnode Operations.
+ *
  */
 static int procfs_validfile_linux(struct lwp *, struct mount *);
 static int procfs_root_readdir_callback(struct proc *, void *);
 static void procfs_dir(pfstype, struct lwp *, struct proc *, char **, char *,
     size_t);
 /*
  * This is a list of the valid names in the
  * process-specific sub-directories.  It is
  * used in procfs_lookup and procfs_readdir
  */
 static const struct proc_target {
 	u_char	pt_type;
 	u_char	pt_namlen;
 	const char	*pt_name;
 	pfstype	pt_pfstype;
 	int	(*pt_valid)(struct lwp *, struct mount *);
 } proc_targets[] = {
 #define N(s) sizeof(s)-1, s
 	/*	  name		type		validp */
 	{ DT_DIR, N("."),	PFSproc,	NULL },
 	{ DT_DIR, N(".."),	PFSroot,	NULL },
 	{ DT_DIR, N("fd"),	PFSfd,		NULL },
 	{ DT_REG, N("file"),	PFSfile,	procfs_validfile },
 	{ DT_REG, N("mem"),	PFSmem,		NULL },
 	{ DT_REG, N("regs"),	PFSregs,	procfs_validregs },
 	{ DT_REG, N("fpregs"),	PFSfpregs,	procfs_validfpregs },
 	{ DT_REG, N("ctl"),	PFSctl,		NULL },
 	{ DT_REG, N("stat"),	PFSstat,	procfs_validfile_linux },
 	{ DT_REG, N("status"),	PFSstatus,	NULL },
 	{ DT_REG, N("note"),	PFSnote,	NULL },
 	{ DT_REG, N("notepg"),	PFSnotepg,	NULL },
 	{ DT_REG, N("map"),	PFSmap,		procfs_validmap },
 	{ DT_REG, N("maps"),	PFSmaps,	procfs_validmap },
 	{ DT_REG, N("cmdline"), PFScmdline,	NULL },
 	{ DT_REG, N("exe"),	PFSexe,		procfs_validfile },
 	{ DT_LNK, N("cwd"),	PFScwd,		NULL },
 	{ DT_LNK, N("root"),	PFSchroot,	NULL },
 	{ DT_LNK, N("emul"),	PFSemul,	NULL },
 	{ DT_REG, N("statm"),	PFSstatm,	procfs_validfile_linux },
 	{ DT_DIR, N("task"),	PFStask,	procfs_validfile_linux },
 #ifdef __HAVE_PROCFS_MACHDEP
 	PROCFS_MACHDEP_NODETYPE_DEFNS
 #endif
 #undef N
 };
 static const int nproc_targets = sizeof(proc_targets) / sizeof(proc_targets[0]);
 /*
  * List of files in the root directory. Note: the validate function will
  * be called with p == NULL for these ones.
  */
 static const struct proc_target proc_root_targets[] = {
 #define N(s) sizeof(s)-1, s
 	/*	  name		    type	    validp */
 	{ DT_REG, N("meminfo"),     PFSmeminfo,        procfs_validfile_linux },
 	{ DT_REG, N("cpuinfo"),     PFScpuinfo,        procfs_validfile_linux },
 	{ DT_REG, N("uptime"),      PFSuptime,         procfs_validfile_linux },
 	{ DT_REG, N("mounts"),	    PFSmounts,	       procfs_validfile_linux },
 	{ DT_REG, N("devices"),     PFSdevices,        procfs_validfile_linux },
 	{ DT_REG, N("stat"),	    PFScpustat,        procfs_validfile_linux },
 	{ DT_REG, N("loadavg"),	    PFSloadavg,        procfs_validfile_linux },
 	{ DT_REG, N("version"),     PFSversion,        procfs_validfile_linux },
 #undef N
 };
 static const int nproc_root_targets =
     sizeof(proc_root_targets) / sizeof(proc_root_targets[0]);
 int	procfs_lookup(void *);
 #define	procfs_create	genfs_eopnotsupp
 #define	procfs_mknod	genfs_eopnotsupp
 int	procfs_open(void *);
 int	procfs_close(void *);
 int	procfs_access(void *);
 int	procfs_getattr(void *);
 int	procfs_setattr(void *);
 #define	procfs_read	procfs_rw
 #define	procfs_write	procfs_rw
 #define	procfs_fcntl	genfs_fcntl
 #define	procfs_ioctl	genfs_enoioctl
 #define	procfs_poll	genfs_poll
 #define procfs_revoke	genfs_revoke
 #define	procfs_fsync	genfs_nullop
 #define	procfs_seek	genfs_nullop
 #define	procfs_remove	genfs_eopnotsupp
 int	procfs_link(void *);
 #define	procfs_rename	genfs_eopnotsupp
 #define	procfs_mkdir	genfs_eopnotsupp
 #define	procfs_rmdir	genfs_eopnotsupp
 int	procfs_symlink(void *);
 int	procfs_readdir(void *);
 int	procfs_readlink(void *);
 #define	procfs_abortop	genfs_abortop
 int	procfs_inactive(void *);
 int	procfs_reclaim(void *);
 #define	procfs_lock	genfs_lock
 #define	procfs_unlock	genfs_unlock
 #define	procfs_bmap	genfs_badop
 #define	procfs_strategy	genfs_badop
 int	procfs_print(void *);
 int	procfs_pathconf(void *);
 #define	procfs_islocked	genfs_islocked
 #define	procfs_advlock	genfs_einval
 #define	procfs_bwrite	genfs_eopnotsupp
 int	procfs_getpages(void *);
 #define procfs_putpages	genfs_null_putpages
 static int atoi(const char *, size_t);
 /*
  * procfs vnode operations.
  */
 int (**procfs_vnodeop_p)(void *);
 const struct vnodeopv_entry_desc procfs_vnodeop_entries[] = {
 	{ &vop_default_desc, vn_default_error },
 	{ &vop_lookup_desc, procfs_lookup },		/* lookup */
 	{ &vop_create_desc, procfs_create },		/* create */
 	{ &vop_mknod_desc, procfs_mknod },		/* mknod */
 	{ &vop_open_desc, procfs_open },		/* open */
 	{ &vop_close_desc, procfs_close },		/* close */
 	{ &vop_access_desc, procfs_access },		/* access */
 	{ &vop_getattr_desc, procfs_getattr },		/* getattr */
 	{ &vop_setattr_desc, procfs_setattr },		/* setattr */
 	{ &vop_read_desc, procfs_read },		/* read */
 	{ &vop_write_desc, procfs_write },		/* write */
 	{ &vop_fallocate_desc, genfs_eopnotsupp },	/* fallocate */
 	{ &vop_fdiscard_desc, genfs_eopnotsupp },	/* fdiscard */
 	{ &vop_fcntl_desc, procfs_fcntl },		/* fcntl */
 	{ &vop_ioctl_desc, procfs_ioctl },		/* ioctl */
 	{ &vop_poll_desc, procfs_poll },		/* poll */
 	{ &vop_revoke_desc, procfs_revoke },		/* revoke */
 	{ &vop_fsync_desc, procfs_fsync },		/* fsync */
 	{ &vop_seek_desc, procfs_seek },		/* seek */
 	{ &vop_remove_desc, procfs_remove },		/* remove */
 	{ &vop_link_desc, procfs_link },		/* link */
 	{ &vop_rename_desc, procfs_rename },		/* rename */
 	{ &vop_mkdir_desc, procfs_mkdir },		/* mkdir */
 	{ &vop_rmdir_desc, procfs_rmdir },		/* rmdir */
 	{ &vop_symlink_desc, procfs_symlink },		/* symlink */
 	{ &vop_readdir_desc, procfs_readdir },		/* readdir */
 	{ &vop_readlink_desc, procfs_readlink },	/* readlink */
 	{ &vop_abortop_desc, procfs_abortop },		/* abortop */
 	{ &vop_inactive_desc, procfs_inactive },	/* inactive */
 	{ &vop_reclaim_desc, procfs_reclaim },		/* reclaim */
 	{ &vop_lock_desc, procfs_lock },		/* lock */
 	{ &vop_unlock_desc, procfs_unlock },		/* unlock */
 	{ &vop_bmap_desc, procfs_bmap },		/* bmap */
 	{ &vop_strategy_desc, procfs_strategy },	/* strategy */
 	{ &vop_print_desc, procfs_print },		/* print */
 	{ &vop_islocked_desc, procfs_islocked },	/* islocked */
 	{ &vop_pathconf_desc, procfs_pathconf },	/* pathconf */
 	{ &vop_advlock_desc, procfs_advlock },		/* advlock */
 	{ &vop_getpages_desc, procfs_getpages },	/* getpages */
 	{ &vop_putpages_desc, procfs_putpages },	/* putpages */
 	{ NULL, NULL }
 };
 const struct vnodeopv_desc procfs_vnodeop_opv_desc =
 	{ &procfs_vnodeop_p, procfs_vnodeop_entries };
 /*
  * set things up for doing i/o on
  * the pfsnode (vp).  (vp) is locked
  * on entry, and should be left locked
  * on exit.
+ *
  * for procfs we don't need to do anything
  * in particular for i/o.  all that is done
  * is to support exclusive open on process
  * memory images.
  */
 int
 procfs_open(void *v)
+{
 	struct vop_open_args /* {
 		struct vnode *a_vp;
 		int  a_mode;
 		kauth_cred_t a_cred;
 	} */ *ap = v;
 	struct pfsnode *pfs = VTOPFS(ap->a_vp);
 	struct lwp *l1;
 	struct proc *p2;
 	int error;
 	if ((error = procfs_proc_lock(pfs->pfs_pid, &p2, ENOENT)) != 0)
 		return error;
 	l1 = curlwp;				/* tracer */
 #define	M2K(m)	(((m) & FREAD) && ((m) & FWRITE) ? \
 		 KAUTH_REQ_PROCESS_PROCFS_RW : \
 		 (m) & FWRITE ? KAUTH_REQ_PROCESS_PROCFS_WRITE : \
 		 KAUTH_REQ_PROCESS_PROCFS_READ)
 	mutex_enter(p2->p_lock);
 	error = kauth_authorize_process(l1->l_cred, KAUTH_PROCESS_PROCFS,
 	    p2, pfs, KAUTH_ARG(M2K(ap->a_mode)), NULL);
 	mutex_exit(p2->p_lock);
 	if (error) {
 		procfs_proc_unlock(p2);
 		return (error);
+	}
 #undef M2K
 	switch (pfs->pfs_type) {
 	case PFSmem:
 		if (((pfs->pfs_flags & FWRITE) && (ap->a_mode & O_EXCL)) ||
 		    ((pfs->pfs_flags & O_EXCL) && (ap->a_mode & FWRITE))) {
 			error = EBUSY;
 			break;
+		}
 		if (!proc_isunder(p2, l1)) {
 			error = EPERM;
 			break;
+		}
 		if (ap->a_mode & FWRITE)
 			pfs->pfs_flags = ap->a_mode & (FWRITE|O_EXCL);
 		break;
 	case PFSregs:
 	case PFSfpregs:
 		if (!proc_isunder(p2, l1)) {
 			error = EPERM;
 			break;
+		}
 		break;
 	default:
 		break;
+	}
 	procfs_proc_unlock(p2);
 	return (error);
+}
 /*
  * close the pfsnode (vp) after doing i/o.
  * (vp) is not locked on entry or exit.
+ *
  * nothing to do for procfs other than undo
  * any exclusive open flag (see _open above).
  */
 int
 procfs_close(void *v)
+{
 	struct vop_close_args /* {
 		struct vnode *a_vp;
 		int  a_fflag;
 		kauth_cred_t a_cred;
 	} */ *ap = v;
 	struct pfsnode *pfs = VTOPFS(ap->a_vp);
 	switch (pfs->pfs_type) {
 	case PFSmem:
 		if ((ap->a_fflag & FWRITE) && (pfs->pfs_flags & O_EXCL))
 			pfs->pfs_flags &= ~(FWRITE|O_EXCL);
 		break;
 	default:
 		break;
+	}
 	return (0);
+}
 /*
  * _inactive is called when the pfsnode
  * is vrele'd and the reference count goes
  * to zero.  (vp) will be on the vnode free
  * list, so to get it back vget() must be
  * used.
+ *
  * (vp) is locked on entry, but must be unlocked on exit.
  */
 int
 procfs_inactive(void *v)
+{
 	struct vop_inactive_args /* {
 		struct vnode *a_vp;
 		bool *a_recycle;
 	} */ *ap = v;
 	struct vnode *vp = ap->a_vp;
 	struct pfsnode *pfs = VTOPFS(vp);
 	mutex_enter(proc_lock);
 	*ap->a_recycle = (proc_find(pfs->pfs_pid) == NULL);
 	mutex_exit(proc_lock);
 	VOP_UNLOCK(vp);
 	return (0);
+}
 /*
  * _reclaim is called when getnewvnode()
  * wants to make use of an entry on the vnode
  * free list.  at this time the filesystem needs
  * to free any private data and remove the node
  * from any private lists.
  */
 int
 procfs_reclaim(void *v)
+{
 	struct vop_reclaim_args /* {
 		struct vnode *a_vp;
 	} */ *ap = v;
 	struct vnode *vp = ap->a_vp;
 	struct pfsnode *pfs = VTOPFS(vp);
 	/*
 	 * To interlock with procfs_revoke_vnodes().
 	 */
 	mutex_enter(vp->v_interlock);
 	vp->v_data = NULL;
 	mutex_exit(vp->v_interlock);
 	vcache_remove(vp->v_mount, &pfs->pfs_key, sizeof(pfs->pfs_key));
 	kmem_free(pfs, sizeof(*pfs));
 	return 0;
+}
 /*
  * Return POSIX pathconf information applicable to special devices.
  */
 int
 procfs_pathconf(void *v)
+{
 	struct vop_pathconf_args /* {
 		struct vnode *a_vp;
 		int a_name;
 		register_t *a_retval;
 	} */ *ap = v;
 	switch (ap->a_name) {
 	case _PC_LINK_MAX:
 		*ap->a_retval = LINK_MAX;
 		return (0);
 	case _PC_MAX_CANON:
 		*ap->a_retval = MAX_CANON;
 		return (0);
 	case _PC_MAX_INPUT:
 		*ap->a_retval = MAX_INPUT;
 		return (0);
 	case _PC_PIPE_BUF:
 		*ap->a_retval = PIPE_BUF;
 		return (0);
 	case _PC_CHOWN_RESTRICTED:
 		*ap->a_retval = 1;
 		return (0);
 	case _PC_VDISABLE:
 		*ap->a_retval = _POSIX_VDISABLE;
 		return (0);
 	case _PC_SYNC_IO:
 		*ap->a_retval = 1;
 		return (0);
 	default:
 		return (EINVAL);
+	}
 	/* NOTREACHED */
+}
 /*
  * _print is used for debugging.
  * just print a readable description
  * of (vp).
  */
 int
 procfs_print(void *v)
+{
 	struct vop_print_args /* {
 		struct vnode *a_vp;
 	} */ *ap = v;
 	struct pfsnode *pfs = VTOPFS(ap->a_vp);
 	printf("tag VT_PROCFS, type %d, pid %d, mode %x, flags %lx\n",
 	    pfs->pfs_type, pfs->pfs_pid, pfs->pfs_mode, pfs->pfs_flags);
 	return 0;
+}
 int
 procfs_link(void *v)
+{
 	struct vop_link_args /* {
 		struct vnode *a_dvp;
 		struct vnode *a_vp;
 		struct componentname *a_cnp;
 	} */ *ap = v;
 	VOP_ABORTOP(ap->a_dvp, ap->a_cnp);
 	vput(ap->a_dvp);
 	return (EROFS);
+}
 int
 procfs_symlink(void *v)
+{
 	struct vop_symlink_v3_args /* {
 		struct vnode *a_dvp;
 		struct vnode **a_vpp;
 		struct componentname *a_cnp;
 		struct vattr *a_vap;
 		char *a_target;
 	} */ *ap = v;
 	VOP_ABORTOP(ap->a_dvp, ap->a_cnp);
 	return (EROFS);
+}
 /*
  * Works out the path to (and vnode of) the target process's current
  * working directory or chroot.  If the caller is in a chroot and
  * can't "reach" the target's cwd or root (or some other error
  * occurs), a "/" is returned for the path and a NULL pointer is
  * returned for the vnode.
  */
 static void
 procfs_dir(pfstype t, struct lwp *caller, struct proc *target, char **bpp,
     char *path, size_t len)
+{
 	struct cwdinfo *cwdi;
 	struct vnode *vp, *rvp;
 	char *bp;
 	cwdi = caller->l_proc->p_cwdi;
 	rw_enter(&cwdi->cwdi_lock, RW_READER);
 	rvp = cwdi->cwdi_rdir;
 	bp = bpp ? *bpp : NULL;
 	switch (t) {
 	case PFScwd:
 		vp = target->p_cwdi->cwdi_cdir;
 		break;
 	case PFSchroot:
 		vp = target->p_cwdi->cwdi_rdir;
 		break;
 	case PFSexe:
 		vp = target->p_textvp;
 		break;
 	default:
 		rw_exit(&cwdi->cwdi_lock);
 		return;
+	}
 	/*
 	 * XXX: this horrible kludge avoids locking panics when
 	 * attempting to lookup links that point to within procfs
 	 */
 	if (vp != NULL && vp->v_tag == VT_PROCFS) {
 		if (bpp) {
 			*--bp = '/';
 			*bpp = bp;
+		}
 		rw_exit(&cwdi->cwdi_lock);
 		return;
+	}
 	if (rvp == NULL)
 		rvp = rootvnode;
 	if (vp == NULL || getcwd_common(vp, rvp, bp ? &bp : NULL, path,
 	    len / 2, 0, caller) != 0) {
 		vp = NULL;
 		if (bpp) {
 /*
 			if (t == PFSexe) {
 				snprintf(path, len, "%s/%d/file"
 				    mp->mnt_stat.f_mntonname, pfs->pfs_pid);
 			} else */ {
 				bp = *bpp;
 				*--bp = '/';
+			}
+		}
+	}
 	if (bpp)
 		*bpp = bp;
 	rw_exit(&cwdi->cwdi_lock);
+}
 /*
  * Invent attributes for pfsnode (vp) and store
  * them in (vap).
  * Directories lengths are returned as zero since
  * any real length would require the genuine size
  * to be computed, and nothing cares anyway.
+ *
  * this is relatively minimal for procfs.
  */
 int
 procfs_getattr(void *v)
+{
 	struct vop_getattr_args /* {
 		struct vnode *a_vp;
 		struct vattr *a_vap;
 		kauth_cred_t a_cred;
 	} */ *ap = v;
 	struct pfsnode *pfs = VTOPFS(ap->a_vp);
 	struct vattr *vap = ap->a_vap;
 	struct proc *procp;
 	char *path;
 	int error;
 	/* first check the process still exists */
 	switch (pfs->pfs_type) {
 	case PFSroot:
 	case PFScurproc:
 	case PFSself:
 		procp = NULL;
 		break;
 	default:
 		error = procfs_proc_lock(pfs->pfs_pid, &procp, ENOENT);
 		if (error != 0)
 			return (error);
 		break;
+	}
 	switch (pfs->pfs_type) {
 	case PFStask:
 		if (pfs->pfs_fd == -1) {
 			path = NULL;
 			break;
+		}
 		/*FALLTHROUGH*/
 	case PFScwd:
 	case PFSchroot:
 	case PFSexe:
 		path = malloc(MAXPATHLEN + 4, M_TEMP, M_WAITOK|M_CANFAIL);
 		if (path == NULL && procp != NULL) {
 			procfs_proc_unlock(procp);
 			return (ENOMEM);
+		}
 		break;
 	default:
 		path = NULL;
 		break;
+	}
 	if (procp != NULL) {
 		mutex_enter(procp->p_lock);
 		error = kauth_authorize_process(kauth_cred_get(),
 		    KAUTH_PROCESS_CANSEE, procp,
 		    KAUTH_ARG(KAUTH_REQ_PROCESS_CANSEE_ENTRY), NULL, NULL);
 		mutex_exit(procp->p_lock);
 		if (error != 0) {
 		    	procfs_proc_unlock(procp);
 		    	if (path != NULL)
 		    		free(path, M_TEMP);
 			return (ENOENT);
+		}
+	}
 	error = 0;
 	/* start by zeroing out the attributes */
 	vattr_null(vap);
 	/* next do all the common fields */
 	vap->va_type = ap->a_vp->v_type;
 	vap->va_mode = pfs->pfs_mode;
 	vap->va_fileid = pfs->pfs_fileno;
 	vap->va_flags = 0;
 	vap->va_blocksize = PAGE_SIZE;
 	/*
 	 * Make all times be current TOD.
+	 *
 	 * It would be possible to get the process start
 	 * time from the p_stats structure, but there's
 	 * no "file creation" time stamp anyway, and the
 	 * p_stats structure is not addressable if u. gets
 	 * swapped out for that process.
 	 */
 	getnanotime(&vap->va_ctime);
 	vap->va_atime = vap->va_mtime = vap->va_ctime;
 	if (procp)
 		TIMEVAL_TO_TIMESPEC(&procp->p_stats->p_start,
 		    &vap->va_birthtime);
 	else
 		getnanotime(&vap->va_birthtime);
 	switch (pfs->pfs_type) {
 	case PFSmem:
 	case PFSregs:
 	case PFSfpregs:
 #if defined(__HAVE_PROCFS_MACHDEP) && defined(PROCFS_MACHDEP_PROTECT_CASES)
 	PROCFS_MACHDEP_PROTECT_CASES
 #endif
 		/*
 		 * If the process has exercised some setuid or setgid
 		 * privilege, then rip away read/write permission so
 		 * that only root can gain access.
 		 */
 		if (procp->p_flag & PK_SUGID)
 			vap->va_mode &= ~(S_IRUSR|S_IWUSR);
 		/* FALLTHROUGH */
 	case PFSctl:
 	case PFSstatus:
 	case PFSstat:
 	case PFSnote:
 	case PFSnotepg:
 	case PFSmap:
 	case PFSmaps:
 	case PFScmdline:
 	case PFSemul:
 	case PFSstatm:
 		if (pfs->pfs_type == PFSmap || pfs->pfs_type == PFSmaps)
 			vap->va_mode = S_IRUSR;
 		vap->va_nlink = 1;
 		vap->va_uid = kauth_cred_geteuid(procp->p_cred);
 		vap->va_gid = kauth_cred_getegid(procp->p_cred);
 		break;
 	case PFSmeminfo:
 	case PFSdevices:
 	case PFScpuinfo:
 	case PFSuptime:
 	case PFSmounts:
 	case PFScpustat:
 	case PFSloadavg:
 	case PFSversion:
 		vap->va_nlink = 1;
 		vap->va_uid = vap->va_gid = 0;
 		break;
 	default:
 		break;
+	}
 	/*
 	 * now do the object specific fields
+	 *
 	 * The size could be set from struct reg, but it's hardly
 	 * worth the trouble, and it puts some (potentially) machine
 	 * dependent data into this machine-independent code.  If it
 	 * becomes important then this function should break out into
 	 * a per-file stat function in the corresponding .c file.
 	 */
 	switch (pfs->pfs_type) {
 	case PFSroot:
 		/*
 		 * Set nlink to 1 to tell fts(3) we don't actually know.
 		 */
 		vap->va_nlink = 1;
 		vap->va_uid = 0;
 		vap->va_gid = 0;
 		vap->va_bytes = vap->va_size = DEV_BSIZE;
 		break;
 	case PFSself:
 	case PFScurproc: {
 		char bf[16];		/* should be enough */
 		vap->va_nlink = 1;
 		vap->va_uid = 0;
 		vap->va_gid = 0;
 		vap->va_bytes = vap->va_size =
 		    snprintf(bf, sizeof(bf), "%ld", (long)curproc->p_pid);
 		break;
+	}
 	case PFStask:
 		if (pfs->pfs_fd != -1) {
 			char bf[4];		/* should be enough */
 			vap->va_nlink = 1;
 			vap->va_uid = 0;
 			vap->va_gid = 0;
 			vap->va_bytes = vap->va_size =
 			    snprintf(bf, sizeof(bf), "..");
 			break;
+		}
 		/*FALLTHROUGH*/
 	case PFSfd:
 		if (pfs->pfs_fd != -1) {
 			file_t *fp;
 			fp = fd_getfile2(procp, pfs->pfs_fd);
 			if (fp == NULL) {
 				error = EBADF;
 				break;
+			}
 			vap->va_nlink = 1;
 			vap->va_uid = kauth_cred_geteuid(fp->f_cred);
 			vap->va_gid = kauth_cred_getegid(fp->f_cred);
 			switch (fp->f_type) {
 			case DTYPE_VNODE:
 				vap->va_bytes = vap->va_size =
 				    ((struct vnode *)fp->f_data)->v_size;
 				break;
 			default:
 				vap->va_bytes = vap->va_size = 0;
 				break;
+			}
 			closef(fp);
 			break;
+		}
 		/*FALLTHROUGH*/
 	case PFSproc:
 		vap->va_nlink = 2;
 		vap->va_uid = kauth_cred_geteuid(procp->p_cred);
 		vap->va_gid = kauth_cred_getegid(procp->p_cred);
 		vap->va_bytes = vap->va_size = DEV_BSIZE;
 		break;
 	case PFSfile:
 		error = EOPNOTSUPP;
 		break;
 	case PFSmem:
 		vap->va_bytes = vap->va_size =
 			ctob(procp->p_vmspace->vm_tsize +
 				    procp->p_vmspace->vm_dsize +
 				    procp->p_vmspace->vm_ssize);
 		break;
 #if defined(PT_GETREGS) || defined(PT_SETREGS)
 	case PFSregs:
 		vap->va_bytes = vap->va_size = sizeof(struct reg);
 		break;
 #endif
 #if defined(PT_GETFPREGS) || defined(PT_SETFPREGS)
 	case PFSfpregs:
 		vap->va_bytes = vap->va_size = sizeof(struct fpreg);
 		break;
 #endif
 	case PFSctl:
 	case PFSstatus:
 	case PFSstat:
 	case PFSnote:
 	case PFSnotepg:
 	case PFScmdline:
 	case PFSmeminfo:
 	case PFSdevices:
 	case PFScpuinfo:
 	case PFSuptime:
 	case PFSmounts:
 	case PFScpustat:
 	case PFSloadavg:
 	case PFSstatm:
 	case PFSversion:
 		vap->va_bytes = vap->va_size = 0;
 		break;
 	case PFSmap:
 	case PFSmaps:
 		/*
 		 * Advise a larger blocksize for the map files, so that
 		 * they may be read in one pass.
 		 */
 		vap->va_blocksize = 4 * PAGE_SIZE;
 		vap->va_bytes = vap->va_size = 0;
 		break;
 	case PFScwd:
 	case PFSchroot:
 	case PFSexe: {
 		char *bp;
 		vap->va_nlink = 1;
 		vap->va_uid = 0;
 		vap->va_gid = 0;
 		bp = path + MAXPATHLEN;
 		*--bp = '\0';
 		procfs_dir(pfs->pfs_type, curlwp, procp, &bp, path,
 		     MAXPATHLEN);
 		vap->va_bytes = vap->va_size = strlen(bp);
 		break;
+	}
 	case PFSemul:
 		vap->va_bytes = vap->va_size = strlen(procp->p_emul->e_name);
 		break;
 #ifdef __HAVE_PROCFS_MACHDEP
 	PROCFS_MACHDEP_NODETYPE_CASES
 		error = procfs_machdep_getattr(ap->a_vp, vap, procp);
 		break;
 #endif
 	default:
 		panic("procfs_getattr");
+	}
 	if (procp != NULL)
 		procfs_proc_unlock(procp);
 	if (path != NULL)
 		free(path, M_TEMP);
 	return (error);
+}
 /*ARGSUSED*/
 int
 procfs_setattr(void *v)
+{
 	/*
 	 * just fake out attribute setting
 	 * it's not good to generate an error
 	 * return, otherwise things like creat()
 	 * will fail when they try to set the
 	 * file length to 0.  worse, this means
 	 * that echo $note > /proc/$pid/note will fail.
 	 */
 	return (0);
+}
 /*
  * implement access checking.
+ *
  * actually, the check for super-user is slightly
  * broken since it will allow read access to write-only
  * objects.  this doesn't cause any particular trouble
  * but does mean that the i/o entry points need to check
  * that the operation really does make sense.
  */
 int
 procfs_access(void *v)
+{
 	struct vop_access_args /* {
 		struct vnode *a_vp;
 		int a_mode;
 		kauth_cred_t a_cred;
 	} */ *ap = v;
 	struct vattr va;
 	int error;
 	if ((error = VOP_GETATTR(ap->a_vp, &va, ap->a_cred)) != 0)
 		return (error);
 	return kauth_authorize_vnode(ap->a_cred,
 	    KAUTH_ACCESS_ACTION(ap->a_mode, ap->a_vp->v_type, va.va_mode),
 	    ap->a_vp, NULL, genfs_can_access(va.va_type, va.va_mode,
 	    va.va_uid, va.va_gid, ap->a_mode, ap->a_cred));
+}
 /*
  * lookup.  this is incredibly complicated in the
  * general case, however for most pseudo-filesystems
  * very little needs to be done.
+ *
  * Locking isn't hard here, just poorly documented.
+ *
  * If we're looking up ".", just vref the parent & return it.
+ *
  * If we're looking up "..", unlock the parent, and lock "..". If everything
  * went ok, and we're on the last component and the caller requested the
  * parent locked, try to re-lock the parent. We do this to prevent lock
  * races.
+ *
  * For anything else, get the needed node. Then unlock the parent if not
  * the last component or not LOCKPARENT (i.e. if we wouldn't re-lock the
  * parent in the .. case).
+ *
  * We try to exit with the parent locked in error cases.
  */
 int
 procfs_lookup(void *v)
+{
 	struct vop_lookup_v2_args /* {
 		struct vnode * a_dvp;
 		struct vnode ** a_vpp;
 		struct componentname * a_cnp;
 	} */ *ap = v;
 	struct componentname *cnp = ap->a_cnp;
 	struct vnode **vpp = ap->a_vpp;
 	struct vnode *dvp = ap->a_dvp;
 	const char *pname = cnp->cn_nameptr;
 	const struct proc_target *pt = NULL;
 	struct vnode *fvp;
 	pid_t pid, vnpid;
 	struct pfsnode *pfs;
 	struct proc *p = NULL;
 	struct lwp *plwp;
 	int i, error;
 	pfstype type;
 	*vpp = NULL;
 	if (cnp->cn_nameiop == DELETE || cnp->cn_nameiop == RENAME)
 		return (EROFS);
 	if (cnp->cn_namelen == 1 && *pname == '.') {
 		*vpp = dvp;
 		vref(dvp);
 		return (0);
+	}
 	pfs = VTOPFS(dvp);
 	switch (pfs->pfs_type) {
 	case PFSroot:
 		/*
 		 * Shouldn't get here with .. in the root node.
 		 */
 		if (cnp->cn_flags & ISDOTDOT)
 			return (EIO);
 		for (i = 0; i < nproc_root_targets; i++) {
 			pt = &proc_root_targets[i];
 			/*
 			 * check for node match.  proc is always NULL here,
 			 * so call pt_valid with constant NULL lwp.
 			 */
 			if (cnp->cn_namelen == pt->pt_namlen &&
 			    memcmp(pt->pt_name, pname, cnp->cn_namelen) == 0 &&
 			    (pt->pt_valid == NULL ||
 			     (*pt->pt_valid)(NULL, dvp->v_mount)))
 				break;
+		}
 		if (i != nproc_root_targets) {
 			error = procfs_allocvp(dvp->v_mount, vpp, 0,
 			    pt->pt_pfstype, -1);
 			return (error);
+		}
 		if (CNEQ(cnp, "curproc", 7)) {
 			pid = curproc->p_pid;
 			vnpid = 0;
 			type = PFScurproc;
 		} else if (CNEQ(cnp, "self", 4)) {
 			pid = curproc->p_pid;
 			vnpid = 0;
 			type = PFSself;
 		} else {
 			pid = (pid_t)atoi(pname, cnp->cn_namelen);
 			vnpid = pid;
 			type = PFSproc;
+		}
 		if (procfs_proc_lock(pid, &p, ESRCH) != 0)
 			break;
 		error = procfs_allocvp(dvp->v_mount, vpp, vnpid, type, -1);
 		procfs_proc_unlock(p);
 		return (error);
 	case PFSproc:
 		if (cnp->cn_flags & ISDOTDOT) {
 			error = procfs_allocvp(dvp->v_mount, vpp, 0, PFSroot,
 			    -1);
 			return (error);
+		}
 		if (procfs_proc_lock(pfs->pfs_pid, &p, ESRCH) != 0)
 			break;
 		mutex_enter(p->p_lock);
 		LIST_FOREACH(plwp, &p->p_lwps, l_sibling) {
 			if (plwp->l_stat != LSZOMB)
 				break;
+		}
 		/* Process is exiting if no-LWPS or all LWPs are LSZOMB */
 		if (plwp == NULL) {
 			mutex_exit(p->p_lock);
 			procfs_proc_unlock(p);
 			return ESRCH;
+		}
 		lwp_addref(plwp);
 		mutex_exit(p->p_lock);
 		for (pt = proc_targets, i = 0; i < nproc_targets; pt++, i++) {
 			int found;
 			found = cnp->cn_namelen == pt->pt_namlen &&
 			    memcmp(pt->pt_name, pname, cnp->cn_namelen) == 0 &&
 			    (pt->pt_valid == NULL
 			      || (*pt->pt_valid)(plwp, dvp->v_mount));
 			if (found)
 				break;
+		}
 		lwp_delref(plwp);
 		if (i == nproc_targets) {
 			procfs_proc_unlock(p);
 			break;
+		}
 		if (pt->pt_pfstype == PFSfile) {
 			fvp = p->p_textvp;
 			/* We already checked that it exists. */
 			vref(fvp);
 			procfs_proc_unlock(p);
 			*vpp = fvp;
 			return (0);
+		}
 		error = procfs_allocvp(dvp->v_mount, vpp, pfs->pfs_pid,
 		    pt->pt_pfstype, -1);
 		procfs_proc_unlock(p);
 		return (error);
 	case PFSfd: {
 		int fd;
 		file_t *fp;
 		if ((error = procfs_proc_lock(pfs->pfs_pid, &p, ENOENT)) != 0)
 			return error;
 		if (cnp->cn_flags & ISDOTDOT) {
 			error = procfs_allocvp(dvp->v_mount, vpp, pfs->pfs_pid,
 			    PFSproc, -1);
 			procfs_proc_unlock(p);
 			return (error);
+		}
 		fd = atoi(pname, cnp->cn_namelen);
 		fp = fd_getfile2(p, fd);
 		if (fp == NULL) {
 			procfs_proc_unlock(p);
 			return ENOENT;
+		}
 		fvp = fp->f_data;
 		/* Don't show directories */
 		if (fp->f_type == DTYPE_VNODE && fvp->v_type != VDIR) {
 			vref(fvp);
 			closef(fp);
 			procfs_proc_unlock(p);
 			*vpp = fvp;
 			return 0;
+		}
 		closef(fp);
 		error = procfs_allocvp(dvp->v_mount, vpp, pfs->pfs_pid,
 		    PFSfd, fd);
 		procfs_proc_unlock(p);
 		return error;
+	}
 	case PFStask: {
 		int xpid;
 		if ((error = procfs_proc_lock(pfs->pfs_pid, &p, ENOENT)) != 0)
 			return error;
 		if (cnp->cn_flags & ISDOTDOT) {
 			error = procfs_allocvp(dvp->v_mount, vpp, pfs->pfs_pid,
 			    PFSproc, -1);
 			procfs_proc_unlock(p);
 			return (error);
+		}
 		xpid = atoi(pname, cnp->cn_namelen);
 		if (xpid != pfs->pfs_pid) {
 			procfs_proc_unlock(p);
 			return ENOENT;
+		}
 		error = procfs_allocvp(dvp->v_mount, vpp, pfs->pfs_pid,
 		    PFStask, 0);
 		procfs_proc_unlock(p);
 		return error;
+	}
 	default:
 		return (ENOTDIR);
+	}
 	return (cnp->cn_nameiop == LOOKUP ? ENOENT : EROFS);
+}
 int
 procfs_validfile(struct lwp *l, struct mount *mp)
+{
 	return l != NULL && l->l_proc != NULL && l->l_proc->p_textvp != NULL;
+}
 static int
 procfs_validfile_linux(struct lwp *l, struct mount *mp)
+{
 	int flags;
 	flags = VFSTOPROC(mp)->pmnt_flags;
 	return (flags & PROCFSMNT_LINUXCOMPAT) &&
 	    (l == NULL || l->l_proc == NULL || procfs_validfile(l, mp));
+}
 struct procfs_root_readdir_ctx {
 	struct uio *uiop;
 	off_t *cookies;
 	int ncookies;
 	off_t off;
 	off_t startoff;
 	int error;
 };
 static int
 procfs_root_readdir_callback(struct proc *p, void *arg)
+{
 	struct procfs_root_readdir_ctx *ctxp = arg;
 	struct dirent d;
 	struct uio *uiop;
 	int error;
 	uiop = ctxp->uiop;
 	if (uiop->uio_resid < UIO_MX)
 		return -1; /* no space */
 	if (ctxp->off < ctxp->startoff) {
 		ctxp->off++;
 		return 0;
+	}
 	if (kauth_authorize_process(kauth_cred_get(),
 	    KAUTH_PROCESS_CANSEE, p,
 	    KAUTH_ARG(KAUTH_REQ_PROCESS_CANSEE_ENTRY), NULL, NULL) != 0)
 		return 0;
 	memset(&d, 0, UIO_MX);
 	d.d_reclen = UIO_MX;
 	d.d_fileno = PROCFS_FILENO(p->p_pid, PFSproc, -1);
 	d.d_namlen = snprintf(d.d_name,
 	    UIO_MX - offsetof(struct dirent, d_name), "%ld", (long)p->p_pid);
 	d.d_type = DT_DIR;
 	mutex_exit(proc_lock);
 	error = uiomove(&d, UIO_MX, uiop);
 	mutex_enter(proc_lock);
 	if (error) {
 		ctxp->error = error;
 		return -1;
+	}
 	ctxp->ncookies++;
 	if (ctxp->cookies)
 		*(ctxp->cookies)++ = ctxp->off + 1;
 	ctxp->off++;
 	return 0;
+}
 /*
  * readdir returns directory entries from pfsnode (vp).
+ *
  * the strategy here with procfs is to generate a single
  * directory entry at a time (struct dirent) and then
  * copy that out to userland using uiomove.  a more efficent
  * though more complex implementation, would try to minimize
  * the number of calls to uiomove().  for procfs, this is
  * hardly worth the added code complexity.
+ *
  * this should just be done through read()
  */
 int
 procfs_readdir(void *v)
+{
 	struct vop_readdir_args /* {
 		struct vnode *a_vp;
 		struct uio *a_uio;
 		kauth_cred_t a_cred;
 		int *a_eofflag;
 		off_t **a_cookies;
 		int *a_ncookies;
 	} */ *ap = v;
 	struct uio *uio = ap->a_uio;
 	struct dirent d;
 	struct pfsnode *pfs;
 	off_t i;
 	int error;
 	off_t *cookies = NULL;
 	int ncookies;
 	struct vnode *vp;
 	const struct proc_target *pt;
 	struct procfs_root_readdir_ctx ctx;
 	struct lwp *l;
 	int nfd;
 	vp = ap->a_vp;
 	pfs = VTOPFS(vp);
 	if (uio->uio_resid < UIO_MX)
 		return (EINVAL);
 	if (uio->uio_offset < 0)
 		return (EINVAL);
 	error = 0;
 	i = uio->uio_offset;
 	memset(&d, 0, UIO_MX);
 	d.d_reclen = UIO_MX;
 	ncookies = uio->uio_resid / UIO_MX;
 	switch (pfs->pfs_type) {
 	/*
 	 * this is for the process-specific sub-directories.
 	 * all that is needed to is copy out all the entries
 	 * from the procent[] table (top of this file).
 	 */
 	case PFSproc: {
 		struct proc *p;
 		if (i >= nproc_targets)
 			return 0;
 		if (procfs_proc_lock(pfs->pfs_pid, &p, ESRCH) != 0)
 			break;
 		if (ap->a_ncookies) {
 			ncookies = min(ncookies, (nproc_targets - i));
 			cookies = malloc(ncookies * sizeof (off_t),
 			    M_TEMP, M_WAITOK);
 			*ap->a_cookies = cookies;
+		}
 		for (pt = &proc_targets[i];
 		     uio->uio_resid >= UIO_MX && i < nproc_targets; pt++, i++) {
 			if (pt->pt_valid) {
 				/* XXXSMP LWP can disappear */
 				mutex_enter(p->p_lock);
 				l = LIST_FIRST(&p->p_lwps);
 				KASSERT(l != NULL);
 				mutex_exit(p->p_lock);
 				if ((*pt->pt_valid)(l, vp->v_mount) == 0)
 					continue;
+			}
 			d.d_fileno = PROCFS_FILENO(pfs->pfs_pid,
 			    pt->pt_pfstype, -1);
 			d.d_namlen = pt->pt_namlen;
 			memcpy(d.d_name, pt->pt_name, pt->pt_namlen + 1);
 			d.d_type = pt->pt_type;
 			if ((error = uiomove(&d, UIO_MX, uio)) != 0)
 				break;
 			if (cookies)
 				*cookies++ = i + 1;
+		}
 		procfs_proc_unlock(p);
 	    	break;
+	}
 	case PFSfd: {
 		struct proc *p;
 		file_t *fp;
 		int lim, nc = 0;
 		if ((error = procfs_proc_lock(pfs->pfs_pid, &p, ESRCH)) != 0)
 			return error;
 		/* XXX Should this be by file as well? */
 		if (kauth_authorize_process(kauth_cred_get(),
 		    KAUTH_PROCESS_CANSEE, p,
 		    KAUTH_ARG(KAUTH_REQ_PROCESS_CANSEE_OPENFILES), NULL,
 		    NULL) != 0) {
 		    	procfs_proc_unlock(p);
 			return ESRCH;
+		}
 		nfd = p->p_fd->fd_dt->dt_nfiles;
 		lim = min((int)p->p_rlimit[RLIMIT_NOFILE].rlim_cur, maxfiles);
 		if (i >= lim) {
 		    	procfs_proc_unlock(p);
 			return 0;
+		}
 		if (ap->a_ncookies) {
 			ncookies = min(ncookies, (nfd + 2 - i));
 			cookies = malloc(ncookies * sizeof (off_t),
 			    M_TEMP, M_WAITOK);
 			*ap->a_cookies = cookies;
+		}
 		for (; i < 2 && uio->uio_resid >= UIO_MX; i++) {
 			pt = &proc_targets[i];
 			d.d_namlen = pt->pt_namlen;
 			d.d_fileno = PROCFS_FILENO(pfs->pfs_pid,
 			    pt->pt_pfstype, -1);
 			(void)memcpy(d.d_name, pt->pt_name, pt->pt_namlen + 1);
 			d.d_type = pt->pt_type;
 			if ((error = uiomove(&d, UIO_MX, uio)) != 0)
 				break;
 			if (cookies)
 				*cookies++ = i + 1;
 			nc++;
+		}
 		if (error) {
 			ncookies = nc;
 			break;
+		}
 		for (; uio->uio_resid >= UIO_MX && i < nfd; i++) {
 			/* check the descriptor exists */
 			if ((fp = fd_getfile2(p, i - 2)) == NULL)
 				continue;
 			closef(fp);
 			d.d_fileno = PROCFS_FILENO(pfs->pfs_pid, PFSfd, i - 2);
 			d.d_namlen = snprintf(d.d_name, sizeof(d.d_name),
 			    "%lld", (long long)(i - 2));
 			d.d_type = VREG;
 			if ((error = uiomove(&d, UIO_MX, uio)) != 0)
 				break;
 			if (cookies)
 				*cookies++ = i + 1;
 			nc++;
+		}
 		ncookies = nc;
 		procfs_proc_unlock(p);
 		break;
+	}
 	case PFStask: {
 		struct proc *p;
 		int nc = 0;
 		if ((error = procfs_proc_lock(pfs->pfs_pid, &p, ESRCH)) != 0)
 			return error;
 		nfd = 3;	/* ., .., pid */
 		if (ap->a_ncookies) {
 			ncookies = min(ncookies, (nfd + 2 - i));
 			cookies = malloc(ncookies * sizeof (off_t),
 			    M_TEMP, M_WAITOK);
 			*ap->a_cookies = cookies;
+		}
 		for (; i < 2 && uio->uio_resid >= UIO_MX; i++) {
 			pt = &proc_targets[i];
 			d.d_namlen = pt->pt_namlen;
 			d.d_fileno = PROCFS_FILENO(pfs->pfs_pid,
 			    pt->pt_pfstype, -1);
 			(void)memcpy(d.d_name, pt->pt_name, pt->pt_namlen + 1);
 			d.d_type = pt->pt_type;
 			if ((error = uiomove(&d, UIO_MX, uio)) != 0)
 				break;
 			if (cookies)
 				*cookies++ = i + 1;
 			nc++;
+		}
 		if (error) {
 			ncookies = nc;
 			break;
+		}
 		for (; uio->uio_resid >= UIO_MX && i < nfd; i++) {
 			/* check the descriptor exists */
 			d.d_fileno = PROCFS_FILENO(pfs->pfs_pid, PFStask,
 			    i - 2);
 			d.d_namlen = snprintf(d.d_name, sizeof(d.d_name),
 			    "%ld", (long)pfs->pfs_pid);
 			d.d_type = DT_LNK;
 			if ((error = uiomove(&d, UIO_MX, uio)) != 0)
 				break;
 			if (cookies)
 				*cookies++ = i + 1;
 			nc++;
+		}
 		ncookies = nc;
 		procfs_proc_unlock(p);
 		break;
+	}
 	/*
 	 * this is for the root of the procfs filesystem
 	 * what is needed are special entries for "curproc"
 	 * and "self" followed by an entry for each process
 	 * on allproc.
 	 */
 	case PFSroot: {
 		int nc = 0;
 		if (ap->a_ncookies) {
 			/*
 			 * XXX Potentially allocating too much space here,
 			 * but I'm lazy. This loop needs some work.
 			 */
 			cookies = malloc(ncookies * sizeof (off_t),
 			    M_TEMP, M_WAITOK);
 			*ap->a_cookies = cookies;
+		}
 		error = 0;
 		/* 0 ... 3 are static entries. */
 		for (; i <= 3 && uio->uio_resid >= UIO_MX; i++) {
 			switch (i) {
 			case 0:		/* `.' */
 			case 1:		/* `..' */
 				d.d_fileno = PROCFS_FILENO(0, PFSroot, -1);
 				d.d_namlen = i + 1;
 				memcpy(d.d_name, "..", d.d_namlen);
 				d.d_name[i + 1] = '\0';
 				d.d_type = DT_DIR;
 				break;
 			case 2:
 				d.d_fileno = PROCFS_FILENO(0, PFScurproc, -1);
 				d.d_namlen = sizeof("curproc") - 1;
 				memcpy(d.d_name, "curproc", sizeof("curproc"));
 				d.d_type = DT_LNK;
 				break;
 			case 3:
 				d.d_fileno = PROCFS_FILENO(0, PFSself, -1);
 				d.d_namlen = sizeof("self") - 1;
 				memcpy(d.d_name, "self", sizeof("self"));
 				d.d_type = DT_LNK;
 				break;
+			}
 			if ((error = uiomove(&d, UIO_MX, uio)) != 0)
 				break;
 			nc++;
 			if (cookies)
 				*cookies++ = i + 1;
+		}
 		/* 4 ... are process entries. */
 		ctx.uiop = uio;
 		ctx.error = 0;
 		ctx.off = 4;
 		ctx.startoff = i;
 		ctx.cookies = cookies;
 		ctx.ncookies = nc;
 		proclist_foreach_call(&allproc,
 		    procfs_root_readdir_callback, &ctx);
 		cookies = ctx.cookies;
 		nc = ctx.ncookies;
 		error = ctx.error;
 		if (error)
 			break;
 		/* misc entries. */
 		if (i < ctx.off)
 			i = ctx.off;
 		if (i >= ctx.off + nproc_root_targets)
 			break;
 		for (pt = &proc_root_targets[i - ctx.off];
 		    uio->uio_resid >= UIO_MX &&
 		    pt < &proc_root_targets[nproc_root_targets];
 		    pt++, i++) {
 			if (pt->pt_valid &&
 			    (*pt->pt_valid)(NULL, vp->v_mount) == 0)
 				continue;
 			d.d_fileno = PROCFS_FILENO(0, pt->pt_pfstype, -1);
 			d.d_namlen = pt->pt_namlen;
 			memcpy(d.d_name, pt->pt_name, pt->pt_namlen + 1);
 			d.d_type = pt->pt_type;
 			if ((error = uiomove(&d, UIO_MX, uio)) != 0)
 				break;
 			nc++;
 			if (cookies)
 				*cookies++ = i + 1;
+		}
 		ncookies = nc;
 		break;
+	}
 	default:
 		error = ENOTDIR;
 		break;
+	}
 	if (ap->a_ncookies) {
 		if (error) {
 			if (cookies)
 				free(*ap->a_cookies, M_TEMP);
 			*ap->a_ncookies = 0;
 			*ap->a_cookies = NULL;
 		} else
 			*ap->a_ncookies = ncookies;
+	}
 	uio->uio_offset = i;
 	return (error);
+}
 /*
  * readlink reads the link of `curproc' and others
  */
 int
 procfs_readlink(void *v)
+{
 	struct vop_readlink_args *ap = v;
 	char bf[16];		/* should be enough */
 	char *bp = bf;
 	char *path = NULL;
 	int len = 0;
 	int error = 0;
 	struct pfsnode *pfs = VTOPFS(ap->a_vp);
 	struct proc *pown;
 	if (pfs->pfs_fileno == PROCFS_FILENO(0, PFScurproc, -1))
 		len = snprintf(bf, sizeof(bf), "%ld", (long)curproc->p_pid);
 	else if (pfs->pfs_fileno == PROCFS_FILENO(0, PFSself, -1))
 		len = snprintf(bf, sizeof(bf), "%s", "curproc");
 	else if (pfs->pfs_fileno == PROCFS_FILENO(pfs->pfs_pid, PFStask, 0))
 		len = snprintf(bf, sizeof(bf), "..");
 	else if (pfs->pfs_fileno == PROCFS_FILENO(pfs->pfs_pid, PFScwd, -1) ||
 	    pfs->pfs_fileno == PROCFS_FILENO(pfs->pfs_pid, PFSchroot, -1) ||
 	    pfs->pfs_fileno == PROCFS_FILENO(pfs->pfs_pid, PFSexe, -1)) {
 		if ((error = procfs_proc_lock(pfs->pfs_pid, &pown, ESRCH)) != 0)
 			return error;
 		path = malloc(MAXPATHLEN + 4, M_TEMP, M_WAITOK|M_CANFAIL);
 		if (path == NULL) {
 			procfs_proc_unlock(pown);
 			return (ENOMEM);
+		}
 		bp = path + MAXPATHLEN;
 		*--bp = '\0';
 		procfs_dir(PROCFS_TYPE(pfs->pfs_fileno), curlwp, pown,
 		    &bp, path, MAXPATHLEN);
 		procfs_proc_unlock(pown);
 		len = strlen(bp);
 	} else {
 		file_t *fp;
 		struct vnode *vxp, *vp;
 		if ((error = procfs_proc_lock(pfs->pfs_pid, &pown, ESRCH)) != 0)
 			return error;
 		fp = fd_getfile2(pown, pfs->pfs_fd);
 		if (fp == NULL) {
 			procfs_proc_unlock(pown);
 			return EBADF;
+		}
 		switch (fp->f_type) {
 		case DTYPE_VNODE:
 			vxp = (struct vnode *)fp->f_data;
 			if (vxp->v_type != VDIR) {
 				error = EINVAL;
 				break;
+			}
 			if ((path = malloc(MAXPATHLEN, M_TEMP, M_WAITOK))
 			    == NULL) {
 				error = ENOMEM;
 				break;
+			}
 			bp = path + MAXPATHLEN;
 			*--bp = '\0';
 			/*
 			 * XXX: kludge to avoid locking against ourselves
 			 * in getcwd()
 			 */
 			if (vxp->v_tag == VT_PROCFS) {
 				*--bp = '/';
 			} else {
 				rw_enter(&curproc->p_cwdi->cwdi_lock,
 				    RW_READER);
 				vp = curproc->p_cwdi->cwdi_rdir;
 				if (vp == NULL)
 					vp = rootvnode;
 				error = getcwd_common(vxp, vp, &bp, path,
 				    MAXPATHLEN / 2, 0, curlwp);
 				rw_exit(&curproc->p_cwdi->cwdi_lock);
+			}
 			if (error)
 				break;
 			len = strlen(bp);
 			break;
 		case DTYPE_MISC:
 			len = snprintf(bf, sizeof(bf), "%s", "[misc]");
 			break;
 		case DTYPE_KQUEUE:
 			len = snprintf(bf, sizeof(bf), "%s", "[kqueue]");
 			break;
 		case DTYPE_SEM:
 			len = snprintf(bf, sizeof(bf), "%s", "[ksem]");
 			break;
 		default:
 			error = EINVAL;
 			break;
+		}
 		closef(fp);
 		procfs_proc_unlock(pown);
+	}
 	if (error == 0)
 		error = uiomove(bp, len, ap->a_uio);
 	if (path)
 		free(path, M_TEMP);
 	return error;
+}
 int
 procfs_getpages(void *v)
+{
 	struct vop_getpages_args /* {
 		struct vnode *a_vp;
 		voff_t a_offset;
 		struct vm_page **a_m;
 		int *a_count;
 		int a_centeridx;
 		vm_prot_t a_access_type;
 		int a_advice;
 		int a_flags;
 	} */ *ap = v;
 	if ((ap->a_flags & PGO_LOCKED) == 0)
 		mutex_exit(ap->a_vp->v_interlock);
 	return (EFAULT);
+}
 /*
  * convert decimal ascii to int
  */
 static int
 atoi(const char *b, size_t len)
+{
 	int p = 0;
 	while (len--) {
 		char c = *b++;
 		if (c < '0' || c > '9')
 			return -1;
 		p = 10 * p + (c - '0');
+	}
 	return p;
+}