 @@ -1,1194 +1,1194 @@
-/*	$NetBSD: pmap.c,v 1.411 2020/04/19 21:24:36 ad Exp $	*/
+/*	$NetBSD: pmap.c,v 1.412 2020/04/21 06:45:16 skrll Exp $	*/
 /*
  * Copyright 2003 Wasabi Systems, Inc.
  * All rights reserved.
+ *
  * Written by Steve C. Woodford for Wasabi Systems, Inc.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  * 3. All advertising materials mentioning features or use of this software
  *    must display the following acknowledgement:
  *      This product includes software developed for the NetBSD Project by
  *      Wasabi Systems, Inc.
  * 4. The name of Wasabi Systems, Inc. may not be used to endorse
  *    or promote products derived from this software without specific prior
  *    written permission.
+ *
  * THIS SOFTWARE IS PROVIDED BY WASABI SYSTEMS, INC. ``AS IS'' AND
  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
  * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL WASABI SYSTEMS, INC
  * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
  * POSSIBILITY OF SUCH DAMAGE.
  */
 /*
  * Copyright (c) 2002-2003 Wasabi Systems, Inc.
  * Copyright (c) 2001 Richard Earnshaw
  * Copyright (c) 2001-2002 Christopher Gilbert
  * All rights reserved.
+ *
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  * 3. The name of the company nor the name of the author may be used to
  *   endorse or promote products derived from this software without specific
  *    prior written permission.
+ *
  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
  * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
  * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
  * IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT,
  * INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
  * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  */
 /*-
  * Copyright (c) 1999, 2020 The NetBSD Foundation, Inc.
  * All rights reserved.
+ *
  * This code is derived from software contributed to The NetBSD Foundation
  * by Charles M. Hannum.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
+ *
  * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
  * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
  * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
  * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
  * POSSIBILITY OF SUCH DAMAGE.
  */
 /*
  * Copyright (c) 1994-1998 Mark Brinicombe.
  * Copyright (c) 1994 Brini.
  * All rights reserved.
+ *
  * This code is derived from software written for Brini by Mark Brinicombe
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  * 3. All advertising materials mentioning features or use of this software
  *    must display the following acknowledgement:
  *	This product includes software developed by Mark Brinicombe.
  * 4. The name of the author may not be used to endorse or promote products
  *    derived from this software without specific prior written permission.
+ *
  * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
  * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
  * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
  * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
  * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
  * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
+ *
  * RiscBSD kernel project
+ *
  * pmap.c
+ *
  * Machine dependent vm stuff
+ *
  * Created      : 20/09/94
  */
 /*
  * armv6 and VIPT cache support by 3am Software Foundry,
  * Copyright (c) 2007 Microsoft
  */
 /*
  * Performance improvements, UVM changes, overhauls and part-rewrites
  * were contributed by Neil A. Carson <neil@causality.com>.
  */
 /*
  * Overhauled again to speedup the pmap, use MMU Domains so that L1 tables
  * can be shared, and re-work the KVM layout, by Steve Woodford of Wasabi
  * Systems, Inc.
+ *
  * There are still a few things outstanding at this time:
+ *
  *   - There are some unresolved issues for MP systems:
+ *
  *     o The L1 metadata needs a lock, or more specifically, some places
  *       need to acquire an exclusive lock when modifying L1 translation
  *       table entries.
+ *
  *     o When one cpu modifies an L1 entry, and that L1 table is also
  *       being used by another cpu, then the latter will need to be told
  *       that a tlb invalidation may be necessary. (But only if the old
  *       domain number in the L1 entry being over-written is currently
  *       the active domain on that cpu). I guess there are lots more tlb
  *       shootdown issues too...
+ *
  *     o If the vector_page is at 0x00000000 instead of in kernel VA space,
  *       then MP systems will lose big-time because of the MMU domain hack.
  *       The only way this can be solved (apart from moving the vector
  *       page to 0xffff0000) is to reserve the first 1MB of user address
  *       space for kernel use only. This would require re-linking all
  *       applications so that the text section starts above this 1MB
  *       boundary.
+ *
  *     o Tracking which VM space is resident in the cache/tlb has not yet
  *       been implemented for MP systems.
+ *
  *     o Finally, there is a pathological condition where two cpus running
  *       two separate processes (not lwps) which happen to share an L1
  *       can get into a fight over one or more L1 entries. This will result
  *       in a significant slow-down if both processes are in tight loops.
  */
 /* Include header files */
 #include "opt_arm_debug.h"
 #include "opt_cpuoptions.h"
 #include "opt_ddb.h"
 #include "opt_lockdebug.h"
 #include "opt_multiprocessor.h"
 #ifdef MULTIPROCESSOR
 #define _INTR_PRIVATE
 #endif
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: pmap.c,v 1.411 2020/04/19 21:24:36 ad Exp $");
+__KERNEL_RCSID(0, "$NetBSD: pmap.c,v 1.412 2020/04/21 06:45:16 skrll Exp $");
 #include <sys/atomic.h>
 #include <sys/param.h>
 #include <sys/types.h>
 #include <sys/atomic.h>
 #include <sys/bus.h>
 #include <sys/cpu.h>
 #include <sys/intr.h>
 #include <sys/kernel.h>
 #include <sys/kernhist.h>
 #include <sys/kmem.h>
 #include <sys/pool.h>
 #include <sys/proc.h>
 #include <sys/sysctl.h>
 #include <sys/systm.h>
 #include <uvm/uvm.h>
 #include <uvm/pmap/pmap_pvt.h>
 #include <arm/locore.h>
 #ifdef DDB
 #include <arm/db_machdep.h>
 #endif
 #ifdef VERBOSE_INIT_ARM
 #define VPRINTF(...)	printf(__VA_ARGS__)
 #else
 #define VPRINTF(...)	__nothing
 #endif
 /*
  * pmap_kernel() points here
  */
 static struct pmap	kernel_pmap_store = {
 #ifndef ARM_MMU_EXTENDED
 	.pm_activated = true,
 	.pm_domain = PMAP_DOMAIN_KERNEL,
 	.pm_cstate.cs_all = PMAP_CACHE_STATE_ALL,
 #endif
 };
 struct pmap * const	kernel_pmap_ptr = &kernel_pmap_store;
 #undef pmap_kernel
 #define pmap_kernel()	(&kernel_pmap_store)
 #ifdef PMAP_NEED_ALLOC_POOLPAGE
 int			arm_poolpage_vmfreelist = VM_FREELIST_DEFAULT;
 #endif
 /*
  * Pool and cache that pmap structures are allocated from.
  * We use a cache to avoid clearing the pm_l2[] array (1KB)
  * in pmap_create().
  */
 static struct pool_cache pmap_cache;
 /*
  * Pool of PV structures
  */
 static struct pool pmap_pv_pool;
 static void *pmap_bootstrap_pv_page_alloc(struct pool *, int);
 static void pmap_bootstrap_pv_page_free(struct pool *, void *);
 static struct pool_allocator pmap_bootstrap_pv_allocator = {
 	pmap_bootstrap_pv_page_alloc, pmap_bootstrap_pv_page_free
 };
 /*
  * Pool and cache of l2_dtable structures.
  * We use a cache to avoid clearing the structures when they're
  * allocated. (196 bytes)
  */
 static struct pool_cache pmap_l2dtable_cache;
 static vaddr_t pmap_kernel_l2dtable_kva;
 /*
  * Pool and cache of L2 page descriptors.
  * We use a cache to avoid clearing the descriptor table
  * when they're allocated. (1KB)
  */
 static struct pool_cache pmap_l2ptp_cache;
 static vaddr_t pmap_kernel_l2ptp_kva;
 static paddr_t pmap_kernel_l2ptp_phys;
 #ifdef PMAPCOUNTERS
 #define	PMAP_EVCNT_INITIALIZER(name) \
 	EVCNT_INITIALIZER(EVCNT_TYPE_MISC, NULL, "pmap", name)
 #if defined(PMAP_CACHE_VIPT) && !defined(ARM_MMU_EXTENDED)
 static struct evcnt pmap_ev_vac_clean_one =
    PMAP_EVCNT_INITIALIZER("clean page (1 color)");
 static struct evcnt pmap_ev_vac_flush_one =
    PMAP_EVCNT_INITIALIZER("flush page (1 color)");
 static struct evcnt pmap_ev_vac_flush_lots =
    PMAP_EVCNT_INITIALIZER("flush page (2+ colors)");
 static struct evcnt pmap_ev_vac_flush_lots2 =
    PMAP_EVCNT_INITIALIZER("flush page (2+ colors, kmpage)");
 EVCNT_ATTACH_STATIC(pmap_ev_vac_clean_one);
 EVCNT_ATTACH_STATIC(pmap_ev_vac_flush_one);
 EVCNT_ATTACH_STATIC(pmap_ev_vac_flush_lots);
 EVCNT_ATTACH_STATIC(pmap_ev_vac_flush_lots2);
 static struct evcnt pmap_ev_vac_color_new =
    PMAP_EVCNT_INITIALIZER("new page color");
 static struct evcnt pmap_ev_vac_color_reuse =
    PMAP_EVCNT_INITIALIZER("ok first page color");
 static struct evcnt pmap_ev_vac_color_ok =
    PMAP_EVCNT_INITIALIZER("ok page color");
 static struct evcnt pmap_ev_vac_color_blind =
    PMAP_EVCNT_INITIALIZER("blind page color");
 static struct evcnt pmap_ev_vac_color_change =
    PMAP_EVCNT_INITIALIZER("change page color");
 static struct evcnt pmap_ev_vac_color_erase =
    PMAP_EVCNT_INITIALIZER("erase page color");
 static struct evcnt pmap_ev_vac_color_none =
    PMAP_EVCNT_INITIALIZER("no page color");
 static struct evcnt pmap_ev_vac_color_restore =
    PMAP_EVCNT_INITIALIZER("restore page color");
 EVCNT_ATTACH_STATIC(pmap_ev_vac_color_new);
 EVCNT_ATTACH_STATIC(pmap_ev_vac_color_reuse);
 EVCNT_ATTACH_STATIC(pmap_ev_vac_color_ok);
 EVCNT_ATTACH_STATIC(pmap_ev_vac_color_blind);
 EVCNT_ATTACH_STATIC(pmap_ev_vac_color_change);
 EVCNT_ATTACH_STATIC(pmap_ev_vac_color_erase);
 EVCNT_ATTACH_STATIC(pmap_ev_vac_color_none);
 EVCNT_ATTACH_STATIC(pmap_ev_vac_color_restore);
 #endif
 static struct evcnt pmap_ev_mappings =
    PMAP_EVCNT_INITIALIZER("pages mapped");
 static struct evcnt pmap_ev_unmappings =
    PMAP_EVCNT_INITIALIZER("pages unmapped");
 static struct evcnt pmap_ev_remappings =
    PMAP_EVCNT_INITIALIZER("pages remapped");
 EVCNT_ATTACH_STATIC(pmap_ev_mappings);
 EVCNT_ATTACH_STATIC(pmap_ev_unmappings);
 EVCNT_ATTACH_STATIC(pmap_ev_remappings);
 static struct evcnt pmap_ev_kernel_mappings =
    PMAP_EVCNT_INITIALIZER("kernel pages mapped");
 static struct evcnt pmap_ev_kernel_unmappings =
    PMAP_EVCNT_INITIALIZER("kernel pages unmapped");
 static struct evcnt pmap_ev_kernel_remappings =
    PMAP_EVCNT_INITIALIZER("kernel pages remapped");
 EVCNT_ATTACH_STATIC(pmap_ev_kernel_mappings);
 EVCNT_ATTACH_STATIC(pmap_ev_kernel_unmappings);
 EVCNT_ATTACH_STATIC(pmap_ev_kernel_remappings);
 static struct evcnt pmap_ev_kenter_mappings =
    PMAP_EVCNT_INITIALIZER("kenter pages mapped");
 static struct evcnt pmap_ev_kenter_unmappings =
    PMAP_EVCNT_INITIALIZER("kenter pages unmapped");
 static struct evcnt pmap_ev_kenter_remappings =
    PMAP_EVCNT_INITIALIZER("kenter pages remapped");
 static struct evcnt pmap_ev_pt_mappings =
    PMAP_EVCNT_INITIALIZER("page table pages mapped");
 EVCNT_ATTACH_STATIC(pmap_ev_kenter_mappings);
 EVCNT_ATTACH_STATIC(pmap_ev_kenter_unmappings);
 EVCNT_ATTACH_STATIC(pmap_ev_kenter_remappings);
 EVCNT_ATTACH_STATIC(pmap_ev_pt_mappings);
 static struct evcnt pmap_ev_fixup_mod =
    PMAP_EVCNT_INITIALIZER("page modification emulations");
 static struct evcnt pmap_ev_fixup_ref =
    PMAP_EVCNT_INITIALIZER("page reference emulations");
 static struct evcnt pmap_ev_fixup_exec =
    PMAP_EVCNT_INITIALIZER("exec pages fixed up");
 static struct evcnt pmap_ev_fixup_pdes =
    PMAP_EVCNT_INITIALIZER("pdes fixed up");
 #ifndef ARM_MMU_EXTENDED
 static struct evcnt pmap_ev_fixup_ptesync =
    PMAP_EVCNT_INITIALIZER("ptesync fixed");
 #endif
 EVCNT_ATTACH_STATIC(pmap_ev_fixup_mod);
 EVCNT_ATTACH_STATIC(pmap_ev_fixup_ref);
 EVCNT_ATTACH_STATIC(pmap_ev_fixup_exec);
 EVCNT_ATTACH_STATIC(pmap_ev_fixup_pdes);
 #ifndef ARM_MMU_EXTENDED
 EVCNT_ATTACH_STATIC(pmap_ev_fixup_ptesync);
 #endif
 #ifdef PMAP_CACHE_VIPT
 static struct evcnt pmap_ev_exec_mappings =
    PMAP_EVCNT_INITIALIZER("exec pages mapped");
 static struct evcnt pmap_ev_exec_cached =
    PMAP_EVCNT_INITIALIZER("exec pages cached");
 EVCNT_ATTACH_STATIC(pmap_ev_exec_mappings);
 EVCNT_ATTACH_STATIC(pmap_ev_exec_cached);
 static struct evcnt pmap_ev_exec_synced =
    PMAP_EVCNT_INITIALIZER("exec pages synced");
 static struct evcnt pmap_ev_exec_synced_map =
    PMAP_EVCNT_INITIALIZER("exec pages synced (MP)");
 static struct evcnt pmap_ev_exec_synced_unmap =
    PMAP_EVCNT_INITIALIZER("exec pages synced (UM)");
 static struct evcnt pmap_ev_exec_synced_remap =
    PMAP_EVCNT_INITIALIZER("exec pages synced (RM)");
 static struct evcnt pmap_ev_exec_synced_clearbit =
    PMAP_EVCNT_INITIALIZER("exec pages synced (DG)");
 #ifndef ARM_MMU_EXTENDED
 static struct evcnt pmap_ev_exec_synced_kremove =
    PMAP_EVCNT_INITIALIZER("exec pages synced (KU)");
 #endif
 EVCNT_ATTACH_STATIC(pmap_ev_exec_synced);
 EVCNT_ATTACH_STATIC(pmap_ev_exec_synced_map);
 #ifndef ARM_MMU_EXTENDED
 EVCNT_ATTACH_STATIC(pmap_ev_exec_synced_unmap);
 EVCNT_ATTACH_STATIC(pmap_ev_exec_synced_remap);
 EVCNT_ATTACH_STATIC(pmap_ev_exec_synced_clearbit);
 EVCNT_ATTACH_STATIC(pmap_ev_exec_synced_kremove);
 #endif
 static struct evcnt pmap_ev_exec_discarded_unmap =
    PMAP_EVCNT_INITIALIZER("exec pages discarded (UM)");
 static struct evcnt pmap_ev_exec_discarded_zero =
    PMAP_EVCNT_INITIALIZER("exec pages discarded (ZP)");
 static struct evcnt pmap_ev_exec_discarded_copy =
    PMAP_EVCNT_INITIALIZER("exec pages discarded (CP)");
 static struct evcnt pmap_ev_exec_discarded_page_protect =
    PMAP_EVCNT_INITIALIZER("exec pages discarded (PP)");
 static struct evcnt pmap_ev_exec_discarded_clearbit =
    PMAP_EVCNT_INITIALIZER("exec pages discarded (DG)");
 static struct evcnt pmap_ev_exec_discarded_kremove =
    PMAP_EVCNT_INITIALIZER("exec pages discarded (KU)");
 #ifdef ARM_MMU_EXTENDED
 static struct evcnt pmap_ev_exec_discarded_modfixup =
    PMAP_EVCNT_INITIALIZER("exec pages discarded (MF)");
 #endif
 EVCNT_ATTACH_STATIC(pmap_ev_exec_discarded_unmap);
 EVCNT_ATTACH_STATIC(pmap_ev_exec_discarded_zero);
 EVCNT_ATTACH_STATIC(pmap_ev_exec_discarded_copy);
 EVCNT_ATTACH_STATIC(pmap_ev_exec_discarded_page_protect);
 EVCNT_ATTACH_STATIC(pmap_ev_exec_discarded_clearbit);
 EVCNT_ATTACH_STATIC(pmap_ev_exec_discarded_kremove);
 #ifdef ARM_MMU_EXTENDED
 EVCNT_ATTACH_STATIC(pmap_ev_exec_discarded_modfixup);
 #endif
 #endif /* PMAP_CACHE_VIPT */
 static struct evcnt pmap_ev_updates = PMAP_EVCNT_INITIALIZER("updates");
 static struct evcnt pmap_ev_collects = PMAP_EVCNT_INITIALIZER("collects");
 static struct evcnt pmap_ev_activations = PMAP_EVCNT_INITIALIZER("activations");
 EVCNT_ATTACH_STATIC(pmap_ev_updates);
 EVCNT_ATTACH_STATIC(pmap_ev_collects);
 EVCNT_ATTACH_STATIC(pmap_ev_activations);
 #define	PMAPCOUNT(x)	((void)(pmap_ev_##x.ev_count++))
 #else
 #define	PMAPCOUNT(x)	((void)0)
 #endif
 #ifdef ARM_MMU_EXTENDED
 void pmap_md_pdetab_activate(pmap_t, struct lwp *);
 void pmap_md_pdetab_deactivate(pmap_t pm);
 #endif
 /*
  * pmap copy/zero page, and mem(5) hook point
  */
 static pt_entry_t *csrc_pte, *cdst_pte;
 static vaddr_t csrcp, cdstp;
 #ifdef MULTIPROCESSOR
 static size_t cnptes;
 #define	cpu_csrc_pte(o)	(csrc_pte + cnptes * cpu_number() + ((o) >> L2_S_SHIFT))
 #define	cpu_cdst_pte(o)	(cdst_pte + cnptes * cpu_number() + ((o) >> L2_S_SHIFT))
 #define	cpu_csrcp(o)	(csrcp + L2_S_SIZE * cnptes * cpu_number() + (o))
 #define	cpu_cdstp(o)	(cdstp + L2_S_SIZE * cnptes * cpu_number() + (o))
 #else
 #define	cpu_csrc_pte(o)	(csrc_pte + ((o) >> L2_S_SHIFT))
 #define	cpu_cdst_pte(o)	(cdst_pte + ((o) >> L2_S_SHIFT))
 #define	cpu_csrcp(o)	(csrcp + (o))
 #define	cpu_cdstp(o)	(cdstp + (o))
 #endif
 vaddr_t memhook;			/* used by mem.c & others */
 kmutex_t memlock __cacheline_aligned;	/* used by mem.c & others */
 kmutex_t pmap_lock __cacheline_aligned;
 kmutex_t kpm_lock __cacheline_aligned;
 extern void *msgbufaddr;
 int pmap_kmpages;
 /*
  * Flag to indicate if pmap_init() has done its thing
  */
 bool pmap_initialized;
 #if defined(ARM_MMU_EXTENDED) && defined(__HAVE_MM_MD_DIRECT_MAPPED_PHYS)
 /*
  * Virtual end of direct-mapped memory
  */
 vaddr_t pmap_directlimit;
 #endif
 /*
  * Misc. locking data structures
  */
 static inline void
 pmap_acquire_pmap_lock(pmap_t pm)
+{
 #if defined(MULTIPROCESSOR) && defined(DDB)
 	if (__predict_false(db_onproc != NULL))
 		return;
 #endif
 	mutex_enter(&pm->pm_lock);
+}
 static inline void
 pmap_release_pmap_lock(pmap_t pm)
+{
 #if defined(MULTIPROCESSOR) && defined(DDB)
 	if (__predict_false(db_onproc != NULL))
 		return;
 #endif
 	mutex_exit(&pm->pm_lock);
+}
 static inline void
 pmap_acquire_page_lock(struct vm_page_md *md)
+{
 	mutex_enter(&pmap_lock);
+}
 static inline void
 pmap_release_page_lock(struct vm_page_md *md)
+{
 	mutex_exit(&pmap_lock);
+}
 #ifdef DIAGNOSTIC
 static inline int
 pmap_page_locked_p(struct vm_page_md *md)
+{
 	return mutex_owned(&pmap_lock);
+}
 #endif
 /*
  * Metadata for L1 translation tables.
  */
 #ifndef ARM_MMU_EXTENDED
 struct l1_ttable {
 	/* Entry on the L1 Table list */
 	SLIST_ENTRY(l1_ttable) l1_link;
 	/* Entry on the L1 Least Recently Used list */
 	TAILQ_ENTRY(l1_ttable) l1_lru;
 	/* Track how many domains are allocated from this L1 */
 	volatile u_int l1_domain_use_count;
 	/*
 	 * A free-list of domain numbers for this L1.
 	 * We avoid using ffs() and a bitmap to track domains since ffs()
 	 * is slow on ARM.
 	 */
 	uint8_t l1_domain_first;
 	uint8_t l1_domain_free[PMAP_DOMAINS];
 	/* Physical address of this L1 page table */
 	paddr_t l1_physaddr;
 	/* KVA of this L1 page table */
 	pd_entry_t *l1_kva;
 };
 /*
  * L1 Page Tables are tracked using a Least Recently Used list.
  *  - New L1s are allocated from the HEAD.
  *  - Freed L1s are added to the TAIL.
  *  - Recently accessed L1s (where an 'access' is some change to one of
  *    the userland pmaps which owns this L1) are moved to the TAIL.
  */
 static TAILQ_HEAD(, l1_ttable) l1_lru_list;
 static kmutex_t l1_lru_lock __cacheline_aligned;
 /*
  * A list of all L1 tables
  */
 static SLIST_HEAD(, l1_ttable) l1_list;
 #endif /* ARM_MMU_EXTENDED */
 /*
  * The l2_dtable tracks L2_BUCKET_SIZE worth of L1 slots.
+ *
  * This is normally 16MB worth L2 page descriptors for any given pmap.
  * Reference counts are maintained for L2 descriptors so they can be
  * freed when empty.
  */
 struct l2_bucket {
 	pt_entry_t *l2b_kva;		/* KVA of L2 Descriptor Table */
 	paddr_t l2b_pa;			/* Physical address of same */
 	u_short l2b_l1slot;		/* This L2 table's L1 index */
 	u_short l2b_occupancy;		/* How many active descriptors */
 };
 struct l2_dtable {
 	/* The number of L2 page descriptors allocated to this l2_dtable */
 	u_int l2_occupancy;
 	/* List of L2 page descriptors */
 	struct l2_bucket l2_bucket[L2_BUCKET_SIZE];
 };
 /*
  * Given an L1 table index, calculate the corresponding l2_dtable index
  * and bucket index within the l2_dtable.
  */
 #define L2_BUCKET_XSHIFT	(L2_BUCKET_XLOG2 - L1_S_SHIFT)
 #define L2_BUCKET_XFRAME	(~(vaddr_t)0 << L2_BUCKET_XLOG2)
 #define L2_BUCKET_IDX(l1slot)	((l1slot) >> L2_BUCKET_XSHIFT)
 #define L2_IDX(l1slot)		(L2_BUCKET_IDX(l1slot) >> L2_BUCKET_LOG2)
 #define L2_BUCKET(l1slot)	(L2_BUCKET_IDX(l1slot) & (L2_BUCKET_SIZE - 1))
 __CTASSERT(0x100000000ULL == ((uint64_t)L2_SIZE * L2_BUCKET_SIZE * L1_S_SIZE));
 __CTASSERT(L2_BUCKET_XFRAME == ~(L2_BUCKET_XSIZE-1));
 /*
  * Given a virtual address, this macro returns the
  * virtual address required to drop into the next L2 bucket.
  */
 #define	L2_NEXT_BUCKET_VA(va)	(((va) & L2_BUCKET_XFRAME) + L2_BUCKET_XSIZE)
 /*
  * L2 allocation.
  */
 #define	pmap_alloc_l2_dtable()		\
 	    pool_cache_get(&pmap_l2dtable_cache, PR_NOWAIT)
 #define	pmap_free_l2_dtable(l2)		\
 	    pool_cache_put(&pmap_l2dtable_cache, (l2))
 #define pmap_alloc_l2_ptp(pap)		\
 	    ((pt_entry_t *)pool_cache_get_paddr(&pmap_l2ptp_cache,\
 	    PR_NOWAIT, (pap)))
 /*
  * We try to map the page tables write-through, if possible.  However, not
  * all CPUs have a write-through cache mode, so on those we have to sync
  * the cache when we frob page tables.
+ *
  * We try to evaluate this at compile time, if possible.  However, it's
  * not always possible to do that, hence this run-time var.
  */
 int	pmap_needs_pte_sync;
 /*
  * Real definition of pv_entry.
  */
 struct pv_entry {
 	SLIST_ENTRY(pv_entry) pv_link;	/* next pv_entry */
 	pmap_t		pv_pmap;        /* pmap where mapping lies */
 	vaddr_t		pv_va;          /* virtual address for mapping */
 	u_int		pv_flags;       /* flags */
 };
 /*
  * Macros to determine if a mapping might be resident in the
  * instruction/data cache and/or TLB
  */
 #if ARM_MMU_V7 > 0 && !defined(ARM_MMU_EXTENDED)
 /*
  * Speculative loads by Cortex cores can cause TLB entries to be filled even if
  * there are no explicit accesses, so there may be always be TLB entries to
  * flush.  If we used ASIDs then this would not be a problem.
  */
 #define	PV_BEEN_EXECD(f)  (((f) & PVF_EXEC) == PVF_EXEC)
 #define	PV_BEEN_REFD(f)   (true)
 #else
 #define	PV_BEEN_EXECD(f)  (((f) & (PVF_REF | PVF_EXEC)) == (PVF_REF | PVF_EXEC))
 #define	PV_BEEN_REFD(f)   (((f) & PVF_REF) != 0)
 #endif
 #define	PV_IS_EXEC_P(f)   (((f) & PVF_EXEC) != 0)
 #define	PV_IS_KENTRY_P(f) (((f) & PVF_KENTRY) != 0)
 #define	PV_IS_WRITE_P(f)  (((f) & PVF_WRITE) != 0)
 /*
  * Local prototypes
  */
 static bool		pmap_set_pt_cache_mode(pd_entry_t *, vaddr_t, size_t);
 static void		pmap_alloc_specials(vaddr_t *, int, vaddr_t *,
 			    pt_entry_t **);
 static bool		pmap_is_current(pmap_t) __unused;
 static bool		pmap_is_cached(pmap_t);
 static void		pmap_enter_pv(struct vm_page_md *, paddr_t, struct pv_entry *,
 			    pmap_t, vaddr_t, u_int);
 static struct pv_entry *pmap_find_pv(struct vm_page_md *, pmap_t, vaddr_t);
 static struct pv_entry *pmap_remove_pv(struct vm_page_md *, paddr_t, pmap_t, vaddr_t);
 static u_int		pmap_modify_pv(struct vm_page_md *, paddr_t, pmap_t, vaddr_t,
 			    u_int, u_int);
 static void		pmap_pinit(pmap_t);
 static int		pmap_pmap_ctor(void *, void *, int);
 static void		pmap_alloc_l1(pmap_t);
 static void		pmap_free_l1(pmap_t);
 #ifndef ARM_MMU_EXTENDED
 static void		pmap_use_l1(pmap_t);
 #endif
 static struct l2_bucket *pmap_get_l2_bucket(pmap_t, vaddr_t);
 static struct l2_bucket *pmap_alloc_l2_bucket(pmap_t, vaddr_t);
 static void		pmap_free_l2_bucket(pmap_t, struct l2_bucket *, u_int);
 static int		pmap_l2ptp_ctor(void *, void *, int);
 static int		pmap_l2dtable_ctor(void *, void *, int);
 static void		pmap_vac_me_harder(struct vm_page_md *, paddr_t, pmap_t, vaddr_t);
 #ifdef PMAP_CACHE_VIVT
 static void		pmap_vac_me_kpmap(struct vm_page_md *, paddr_t, pmap_t, vaddr_t);
 static void		pmap_vac_me_user(struct vm_page_md *, paddr_t, pmap_t, vaddr_t);
 #endif
 static void		pmap_clearbit(struct vm_page_md *, paddr_t, u_int);
 #ifdef PMAP_CACHE_VIVT
 static bool		pmap_clean_page(struct vm_page_md *, bool);
 #endif
 #ifdef PMAP_CACHE_VIPT
 static void		pmap_syncicache_page(struct vm_page_md *, paddr_t);
 enum pmap_flush_op {
 	PMAP_FLUSH_PRIMARY,
 	PMAP_FLUSH_SECONDARY,
 	PMAP_CLEAN_PRIMARY
 };
 #ifndef ARM_MMU_EXTENDED
 static void		pmap_flush_page(struct vm_page_md *, paddr_t, enum pmap_flush_op);
 #endif
 #endif
 static void		pmap_page_remove(struct vm_page_md *, paddr_t);
 static void		pmap_pv_remove(paddr_t);
 #ifndef ARM_MMU_EXTENDED
 static void		pmap_init_l1(struct l1_ttable *, pd_entry_t *);
 #endif
 static vaddr_t		kernel_pt_lookup(paddr_t);
 #ifdef ARM_MMU_EXTENDED
 static struct pool_cache pmap_l1tt_cache;
 static int		pmap_l1tt_ctor(void *, void *, int);
 static void *		pmap_l1tt_alloc(struct pool *, int);
 static void		pmap_l1tt_free(struct pool *, void *);
 static struct pool_allocator pmap_l1tt_allocator = {
 	.pa_alloc = pmap_l1tt_alloc,
 	.pa_free = pmap_l1tt_free,
 	.pa_pagesz = L1TT_SIZE,
 };
 #endif
 /*
  * Misc variables
  */
 vaddr_t virtual_avail;
 vaddr_t virtual_end;
 vaddr_t pmap_curmaxkvaddr;
 paddr_t avail_start;
 paddr_t avail_end;
 pv_addrqh_t pmap_boot_freeq = SLIST_HEAD_INITIALIZER(&pmap_boot_freeq);
 pv_addr_t kernelpages;
 pv_addr_t kernel_l1pt;
 pv_addr_t systempage;
 #ifdef PMAP_CACHE_VIPT
 #define PMAP_VALIDATE_MD_PAGE(md)	\
 	KASSERTMSG(arm_cache_prefer_mask == 0 || (((md)->pvh_attrs & PVF_WRITE) == 0) == ((md)->urw_mappings + (md)->krw_mappings == 0), \
 	    "(md) %p: attrs=%#x urw=%u krw=%u", (md), \
 	    (md)->pvh_attrs, (md)->urw_mappings, (md)->krw_mappings);
 #endif /* PMAP_CACHE_VIPT */
 /*
  * A bunch of routines to conditionally flush the caches/TLB depending
  * on whether the specified pmap actually needs to be flushed at any
  * given time.
  */
 static inline void
 pmap_tlb_flush_SE(pmap_t pm, vaddr_t va, u_int flags)
+{
 #ifdef ARM_MMU_EXTENDED
 	pmap_tlb_invalidate_addr(pm, va);
 #else
 	if (pm->pm_cstate.cs_tlb_id != 0) {
 		if (PV_BEEN_EXECD(flags)) {
 			cpu_tlb_flushID_SE(va);
 		} else if (PV_BEEN_REFD(flags)) {
 			cpu_tlb_flushD_SE(va);
+		}
+	}
 #endif /* ARM_MMU_EXTENDED */
+}
 #ifndef ARM_MMU_EXTENDED
 static inline void
 pmap_tlb_flushID(pmap_t pm)
+{
 	if (pm->pm_cstate.cs_tlb_id) {
 		cpu_tlb_flushID();
 #if ARM_MMU_V7 == 0
 		/*
 		 * Speculative loads by Cortex cores can cause TLB entries to
 		 * be filled even if there are no explicit accesses, so there
 		 * may be always be TLB entries to flush.  If we used ASIDs
 		 * then it would not be a problem.
 		 * This is not true for other CPUs.
 		 */
 		pm->pm_cstate.cs_tlb = 0;
 #endif /* ARM_MMU_V7 */
+	}
+}
 static inline void
 pmap_tlb_flushD(pmap_t pm)
+{
 	if (pm->pm_cstate.cs_tlb_d) {
 		cpu_tlb_flushD();
 #if ARM_MMU_V7 == 0
 		/*
 		 * Speculative loads by Cortex cores can cause TLB entries to
 		 * be filled even if there are no explicit accesses, so there
 		 * may be always be TLB entries to flush.  If we used ASIDs
 		 * then it would not be a problem.
 		 * This is not true for other CPUs.
 		 */
 		pm->pm_cstate.cs_tlb_d = 0;
 #endif /* ARM_MMU_V7 */
+	}
+}
 #endif /* ARM_MMU_EXTENDED */
 #ifdef PMAP_CACHE_VIVT
 static inline void
 pmap_cache_wbinv_page(pmap_t pm, vaddr_t va, bool do_inv, u_int flags)
+{
 	if (PV_BEEN_EXECD(flags) && pm->pm_cstate.cs_cache_id) {
 		cpu_idcache_wbinv_range(va, PAGE_SIZE);
 	} else if (PV_BEEN_REFD(flags) && pm->pm_cstate.cs_cache_d) {
 		if (do_inv) {
 			if (flags & PVF_WRITE)
 				cpu_dcache_wbinv_range(va, PAGE_SIZE);
 			else
 				cpu_dcache_inv_range(va, PAGE_SIZE);
 		} else if (flags & PVF_WRITE) {
 			cpu_dcache_wb_range(va, PAGE_SIZE);
+		}
+	}
+}
 static inline void
 pmap_cache_wbinv_all(pmap_t pm, u_int flags)
+{
 	if (PV_BEEN_EXECD(flags)) {
 		if (pm->pm_cstate.cs_cache_id) {
 			cpu_idcache_wbinv_all();
 			pm->pm_cstate.cs_cache = 0;
+		}
 	} else if (pm->pm_cstate.cs_cache_d) {
 		cpu_dcache_wbinv_all();
 		pm->pm_cstate.cs_cache_d = 0;
+	}
+}
 #endif /* PMAP_CACHE_VIVT */
 static inline uint8_t
 pmap_domain(pmap_t pm)
+{
 #ifdef ARM_MMU_EXTENDED
 	return pm == pmap_kernel() ? PMAP_DOMAIN_KERNEL : PMAP_DOMAIN_USER;
 #else
 	return pm->pm_domain;
 #endif
+}
 static inline pd_entry_t *
 pmap_l1_kva(pmap_t pm)
+{
 #ifdef ARM_MMU_EXTENDED
 	return pm->pm_l1;
 #else
 	return pm->pm_l1->l1_kva;
 #endif
+}
 static inline bool
 pmap_is_current(pmap_t pm)
+{
 	if (pm == pmap_kernel() || curproc->p_vmspace->vm_map.pmap == pm)
 		return true;
 	return false;
+}
 static inline bool
 pmap_is_cached(pmap_t pm)
+{
 #ifdef ARM_MMU_EXTENDED
 	if (pm == pmap_kernel())
 		return true;
 #ifdef MULTIPROCESSOR
 	// Is this pmap active on any CPU?
 	if (!kcpuset_iszero(pm->pm_active))
 		return true;
 #else
 	struct pmap_tlb_info * const ti = cpu_tlb_info(curcpu());
 	// Is this pmap active?
 	if (PMAP_PAI_ASIDVALID_P(PMAP_PAI(pm, ti), ti))
 		return true;
 #endif
 #else
 	struct cpu_info * const ci = curcpu();
 	if (pm == pmap_kernel() || ci->ci_pmap_lastuser == NULL
 	    || ci->ci_pmap_lastuser == pm)
 		return true;
 #endif /* ARM_MMU_EXTENDED */
 	return false;
+}
 /*
  * PTE_SYNC_CURRENT:
+ *
  *     Make sure the pte is written out to RAM.
  *     We need to do this for one of two cases:
  *       - We're dealing with the kernel pmap
  *       - There is no pmap active in the cache/tlb.
  *       - The specified pmap is 'active' in the cache/tlb.
  */
 #ifdef PMAP_INCLUDE_PTE_SYNC
 static inline void
 pmap_pte_sync_current(pmap_t pm, pt_entry_t *ptep)
+{
 	if (PMAP_NEEDS_PTE_SYNC && pmap_is_cached(pm))
 		PTE_SYNC(ptep);
 	arm_dsb();
+}
 # define PTE_SYNC_CURRENT(pm, ptep)	pmap_pte_sync_current(pm, ptep)
 #else
 # define PTE_SYNC_CURRENT(pm, ptep)	__nothing
 #endif
 /*
  * main pv_entry manipulation functions:
  *   pmap_enter_pv: enter a mapping onto a vm_page list
  *   pmap_remove_pv: remove a mapping from a vm_page list
+ *
  * NOTE: pmap_enter_pv expects to lock the pvh itself
  *       pmap_remove_pv expects the caller to lock the pvh before calling
  */
 /*
  * pmap_enter_pv: enter a mapping onto a vm_page lst
+ *
  * => caller should hold the proper lock on pmap_main_lock
  * => caller should have pmap locked
  * => we will gain the lock on the vm_page and allocate the new pv_entry
  * => caller should adjust ptp's wire_count before calling
  * => caller should not adjust pmap's wire_count
  */
 static void
 pmap_enter_pv(struct vm_page_md *md, paddr_t pa, struct pv_entry *pv, pmap_t pm,
     vaddr_t va, u_int flags)
+{
 	UVMHIST_FUNC(__func__);
 	UVMHIST_CALLARGS(maphist, "md %#jx pa %#jx pm %#jx va %#jx",
 	    (uintptr_t)md, (uintptr_t)pa, (uintptr_t)pm, va);
 	UVMHIST_LOG(maphist, "...pv %#jx flags %#jx",
 	    (uintptr_t)pv, flags, 0, 0);
 	struct pv_entry **pvp;
 	pv->pv_pmap = pm;
 	pv->pv_va = va;
 	pv->pv_flags = flags;
 	pvp = &SLIST_FIRST(&md->pvh_list);
 #ifdef PMAP_CACHE_VIPT
 	/*
 	 * Insert unmanaged entries, writeable first, at the head of
 	 * the pv list.
 	 */
 	if (__predict_true(!PV_IS_KENTRY_P(flags))) {
 		while (*pvp != NULL && PV_IS_KENTRY_P((*pvp)->pv_flags))
 			pvp = &SLIST_NEXT(*pvp, pv_link);
+	}
 	if (!PV_IS_WRITE_P(flags)) {
 		while (*pvp != NULL && PV_IS_WRITE_P((*pvp)->pv_flags))
 			pvp = &SLIST_NEXT(*pvp, pv_link);
+	}
 #endif
 	SLIST_NEXT(pv, pv_link) = *pvp;		/* add to ... */
 	*pvp = pv;				/* ... locked list */
 	md->pvh_attrs |= flags & (PVF_REF | PVF_MOD);
 #if defined(PMAP_CACHE_VIPT) && !defined(ARM_MMU_EXTENDED)
 	if ((pv->pv_flags & PVF_KWRITE) == PVF_KWRITE)
 		md->pvh_attrs |= PVF_KMOD;
 	if ((md->pvh_attrs & (PVF_DMOD|PVF_NC)) != PVF_NC)
 		md->pvh_attrs |= PVF_DIRTY;
 	KASSERT((md->pvh_attrs & PVF_DMOD) == 0 || (md->pvh_attrs & (PVF_DIRTY|PVF_NC)));
 #endif
 	if (pm == pmap_kernel()) {
 		PMAPCOUNT(kernel_mappings);
 		if (flags & PVF_WRITE)
 			md->krw_mappings++;
 		else
 			md->kro_mappings++;
 	} else {
 		if (flags & PVF_WRITE)
 			md->urw_mappings++;
 		else
 			md->uro_mappings++;
+	}
 #ifdef PMAP_CACHE_VIPT
 #ifndef ARM_MMU_EXTENDED
 	/*
 	 * Even though pmap_vac_me_harder will set PVF_WRITE for us,
 	 * do it here as well to keep the mappings & KVF_WRITE consistent.
 	 */
 	if (arm_cache_prefer_mask != 0 && (flags & PVF_WRITE) != 0) {
 		md->pvh_attrs |= PVF_WRITE;
+	}
 #endif
 	/*
 	 * If this is an exec mapping and its the first exec mapping
 	 * for this page, make sure to sync the I-cache.
 	 */
 	if (PV_IS_EXEC_P(flags)) {
 		if (!PV_IS_EXEC_P(md->pvh_attrs)) {
 			pmap_syncicache_page(md, pa);
 			PMAPCOUNT(exec_synced_map);
+		}
 		PMAPCOUNT(exec_mappings);
+	}
 #endif
 	PMAPCOUNT(mappings);
 	if (pv->pv_flags & PVF_WIRED)
 		++pm->pm_stats.wired_count;
+}
 /*
+ *
  * pmap_find_pv: Find a pv entry
+ *
  * => caller should hold lock on vm_page
  */
 static inline struct pv_entry *
 pmap_find_pv(struct vm_page_md *md, pmap_t pm, vaddr_t va)
+{
 	struct pv_entry *pv;
 	SLIST_FOREACH(pv, &md->pvh_list, pv_link) {
 		if (pm == pv->pv_pmap && va == pv->pv_va)
 			break;
+	}
 	return pv;
+}
 /*
  * pmap_remove_pv: try to remove a mapping from a pv_list
+ *
  * => caller should hold proper lock on pmap_main_lock
  * => pmap should be locked
  * => caller should hold lock on vm_page [so that attrs can be adjusted]
  * => caller should adjust ptp's wire_count and free PTP if needed
  * => caller should NOT adjust pmap's wire_count
  * => we return the removed pv
  */
 static struct pv_entry *
 pmap_remove_pv(struct vm_page_md *md, paddr_t pa, pmap_t pm, vaddr_t va)
+{
 	UVMHIST_FUNC(__func__);
 	UVMHIST_CALLARGS(maphist, "md %#jx pa %#jx pm %#jx va %#jx",
 	    (uintptr_t)md, (uintptr_t)pa, (uintptr_t)pm, va);
 	struct pv_entry *pv, **prevptr;
 	prevptr = &SLIST_FIRST(&md->pvh_list); /* prev pv_entry ptr */
 	pv = *prevptr;
 	while (pv) {
 		if (pv->pv_pmap == pm && pv->pv_va == va) {	/* match? */
 			UVMHIST_LOG(maphist, "pm %#jx md %#jx flags %#jx",
 			    (uintptr_t)pm, (uintptr_t)md, pv->pv_flags, 0);
 			if (pv->pv_flags & PVF_WIRED) {
 				--pm->pm_stats.wired_count;
+			}
 			*prevptr = SLIST_NEXT(pv, pv_link);	/* remove it! */
 			if (pm == pmap_kernel()) {
 				PMAPCOUNT(kernel_unmappings);
 				if (pv->pv_flags & PVF_WRITE)
 					md->krw_mappings--;
 				else
 					md->kro_mappings--;
 			} else {
 				if (pv->pv_flags & PVF_WRITE)
 					md->urw_mappings--;
 				else
 					md->uro_mappings--;
+			}
 			PMAPCOUNT(unmappings);
 #ifdef PMAP_CACHE_VIPT
 			/*
 			 * If this page has had an exec mapping, then if
 			 * this was the last mapping, discard the contents,
 			 * otherwise sync the i-cache for this page.
 			 */
 			if (PV_IS_EXEC_P(md->pvh_attrs)) {
 				if (SLIST_EMPTY(&md->pvh_list)) {
 					md->pvh_attrs &= ~PVF_EXEC;
 					PMAPCOUNT(exec_discarded_unmap);
 				} else if (pv->pv_flags & PVF_WRITE) {
 					pmap_syncicache_page(md, pa);
 					PMAPCOUNT(exec_synced_unmap);
+				}
+			}
 #endif /* PMAP_CACHE_VIPT */
 			break;
+		}
 		prevptr = &SLIST_NEXT(pv, pv_link);	/* previous pointer */
 		pv = *prevptr;				/* advance */
+	}
 #if defined(PMAP_CACHE_VIPT) && !defined(ARM_MMU_EXTENDED)
 	/*
 	 * If we no longer have a WRITEABLE KENTRY at the head of list,
 	 * clear the KMOD attribute from the page.
 	 */
 	if (SLIST_FIRST(&md->pvh_list) == NULL
 	    || (SLIST_FIRST(&md->pvh_list)->pv_flags & PVF_KWRITE) != PVF_KWRITE)
 		md->pvh_attrs &= ~PVF_KMOD;
 	/*
 	 * If this was a writeable page and there are no more writeable
 	 * mappings (ignoring KMPAGE), clear the WRITE flag and writeback
 	 * the contents to memory.
 	 */
 	if (arm_cache_prefer_mask != 0) {
 		if (md->krw_mappings + md->urw_mappings == 0)
 			md->pvh_attrs &= ~PVF_WRITE;
 		PMAP_VALIDATE_MD_PAGE(md);
+	}
 	KASSERT((md->pvh_attrs & PVF_DMOD) == 0 || (md->pvh_attrs & (PVF_DIRTY|PVF_NC)));
 #endif /* PMAP_CACHE_VIPT && !ARM_MMU_EXTENDED */
 	/* return removed pv */
 	return pv;
+}
 /*
+ *
  * pmap_modify_pv: Update pv flags
+ *
  * => caller should hold lock on vm_page [so that attrs can be adjusted]
  * => caller should NOT adjust pmap's wire_count
  * => caller must call pmap_vac_me_harder() if writable status of a page
  *    may have changed.
  * => we return the old flags
+ *
  * Modify a physical-virtual mapping in the pv table
  */
 static u_int
 pmap_modify_pv(struct vm_page_md *md, paddr_t pa, pmap_t pm, vaddr_t va,
     u_int clr_mask, u_int set_mask)
+{
 	struct pv_entry *npv;
 	u_int flags, oflags;
 	UVMHIST_FUNC(__func__);
 	UVMHIST_CALLARGS(maphist, "md %#jx pa %#jx pm %#jx va %#jx",
 	    (uintptr_t)md, (uintptr_t)pa, (uintptr_t)pm, va);
 	UVMHIST_LOG(maphist, "... clr %#jx set %#jx", clr_mask, set_mask, 0, 0);
 	KASSERT(!PV_IS_KENTRY_P(clr_mask));
 	KASSERT(!PV_IS_KENTRY_P(set_mask));
 	if ((npv = pmap_find_pv(md, pm, va)) == NULL) {
 		UVMHIST_LOG(maphist, "<--- done (not found)", 0, 0, 0, 0);
 		return 0;
+	}
 	/*
 	 * There is at least one VA mapping this page.
 	 */
 	if (clr_mask & (PVF_REF | PVF_MOD)) {
 		md->pvh_attrs |= set_mask & (PVF_REF | PVF_MOD);
 #if defined(PMAP_CACHE_VIPT) && !defined(ARM_MMU_EXTENDED)
 		if ((md->pvh_attrs & (PVF_DMOD|PVF_NC)) != PVF_NC)
 			md->pvh_attrs |= PVF_DIRTY;
 		KASSERT((md->pvh_attrs & PVF_DMOD) == 0 || (md->pvh_attrs & (PVF_DIRTY|PVF_NC)));
 @@ -1378,2006 +1378,1998 @@ static inline void
 pmap_use_l1(pmap_t pm)
+{
 	struct l1_ttable *l1;
 	/*
 	 * Do nothing if we're in interrupt context.
 	 * Access to an L1 by the kernel pmap must not affect
 	 * the LRU list.
 	 */
 	if (cpu_intr_p() || pm == pmap_kernel())
 		return;
 	l1 = pm->pm_l1;
 	/*
 	 * If the L1 is not currently on the LRU list, just return
 	 */
 	if (l1->l1_domain_use_count == PMAP_DOMAINS)
 		return;
 	mutex_spin_enter(&l1_lru_lock);
 	/*
 	 * Check the use count again, now that we've acquired the lock
 	 */
 	if (l1->l1_domain_use_count == PMAP_DOMAINS) {
 		mutex_spin_exit(&l1_lru_lock);
 		return;
+	}
 	/*
 	 * Move the L1 to the back of the LRU list
 	 */
 	TAILQ_REMOVE(&l1_lru_list, l1, l1_lru);
 	TAILQ_INSERT_TAIL(&l1_lru_list, l1, l1_lru);
 	mutex_spin_exit(&l1_lru_lock);
+}
 #endif /* !ARM_MMU_EXTENDED */
 /*
  * void pmap_free_l2_ptp(pt_entry_t *, paddr_t *)
+ *
  * Free an L2 descriptor table.
  */
 static inline void
 #if defined(PMAP_INCLUDE_PTE_SYNC) && defined(PMAP_CACHE_VIVT)
 pmap_free_l2_ptp(bool need_sync, pt_entry_t *l2, paddr_t pa)
 #else
 pmap_free_l2_ptp(pt_entry_t *l2, paddr_t pa)
 #endif
+{
 #if defined(PMAP_INCLUDE_PTE_SYNC) && defined(PMAP_CACHE_VIVT)
 	/*
 	 * Note: With a write-back cache, we may need to sync this
 	 * L2 table before re-using it.
 	 * This is because it may have belonged to a non-current
 	 * pmap, in which case the cache syncs would have been
 	 * skipped for the pages that were being unmapped. If the
 	 * L2 table were then to be immediately re-allocated to
 	 * the *current* pmap, it may well contain stale mappings
 	 * which have not yet been cleared by a cache write-back
 	 * and so would still be visible to the mmu.
 	 */
 	if (need_sync)
 		PTE_SYNC_RANGE(l2, L2_TABLE_SIZE_REAL / sizeof(pt_entry_t));
 #endif /* PMAP_INCLUDE_PTE_SYNC && PMAP_CACHE_VIVT */
 	pool_cache_put_paddr(&pmap_l2ptp_cache, (void *)l2, pa);
+}
 /*
  * Returns a pointer to the L2 bucket associated with the specified pmap
  * and VA, or NULL if no L2 bucket exists for the address.
  */
 static inline struct l2_bucket *
 pmap_get_l2_bucket(pmap_t pm, vaddr_t va)
+{
 	const size_t l1slot = l1pte_index(va);
 	struct l2_dtable *l2;
 	struct l2_bucket *l2b;
 	if ((l2 = pm->pm_l2[L2_IDX(l1slot)]) == NULL ||
 	    (l2b = &l2->l2_bucket[L2_BUCKET(l1slot)])->l2b_kva == NULL)
 		return NULL;
 	return l2b;
+}
 /*
  * Returns a pointer to the L2 bucket associated with the specified pmap
  * and VA.
+ *
  * If no L2 bucket exists, perform the necessary allocations to put an L2
  * bucket/page table in place.
+ *
  * Note that if a new L2 bucket/page was allocated, the caller *must*
  * increment the bucket occupancy counter appropriately *before*
  * releasing the pmap's lock to ensure no other thread or cpu deallocates
  * the bucket/page in the meantime.
  */
 static struct l2_bucket *
 pmap_alloc_l2_bucket(pmap_t pm, vaddr_t va)
+{
 	const size_t l1slot = l1pte_index(va);
 	struct l2_dtable *l2;
 	if ((l2 = pm->pm_l2[L2_IDX(l1slot)]) == NULL) {
 		/*
 		 * No mapping at this address, as there is
 		 * no entry in the L1 table.
 		 * Need to allocate a new l2_dtable.
 		 */
 		if ((l2 = pmap_alloc_l2_dtable()) == NULL)
 			return NULL;
 		/*
 		 * Link it into the parent pmap
 		 */
 		pm->pm_l2[L2_IDX(l1slot)] = l2;
+	}
 	struct l2_bucket * const l2b = &l2->l2_bucket[L2_BUCKET(l1slot)];
 	/*
 	 * Fetch pointer to the L2 page table associated with the address.
 	 */
 	if (l2b->l2b_kva == NULL) {
 		pt_entry_t *ptep;
 		/*
 		 * No L2 page table has been allocated. Chances are, this
 		 * is because we just allocated the l2_dtable, above.
 		 */
 		if ((ptep = pmap_alloc_l2_ptp(&l2b->l2b_pa)) == NULL) {
 			/*
 			 * Oops, no more L2 page tables available at this
 			 * time. We may need to deallocate the l2_dtable
 			 * if we allocated a new one above.
 			 */
 			if (l2->l2_occupancy == 0) {
 				pm->pm_l2[L2_IDX(l1slot)] = NULL;
 				pmap_free_l2_dtable(l2);
+			}
 			return NULL;
+		}
 		l2->l2_occupancy++;
 		l2b->l2b_kva = ptep;
 		l2b->l2b_l1slot = l1slot;
 #ifdef ARM_MMU_EXTENDED
 		/*
 		 * We know there will be a mapping here, so simply
 		 * enter this PTP into the L1 now.
 		 */
 		pd_entry_t * const pdep = pmap_l1_kva(pm) + l1slot;
 		pd_entry_t npde = L1_C_PROTO | l2b->l2b_pa
 		    | L1_C_DOM(pmap_domain(pm));
 		KASSERT(*pdep == 0);
 		l1pte_setone(pdep, npde);
 		PDE_SYNC(pdep);
 #endif
+	}
 	return l2b;
+}
 /*
  * One or more mappings in the specified L2 descriptor table have just been
  * invalidated.
+ *
  * Garbage collect the metadata and descriptor table itself if necessary.
+ *
  * The pmap lock must be acquired when this is called (not necessary
  * for the kernel pmap).
  */
 static void
 pmap_free_l2_bucket(pmap_t pm, struct l2_bucket *l2b, u_int count)
+{
 	KDASSERT(count <= l2b->l2b_occupancy);
 	/*
 	 * Update the bucket's reference count according to how many
 	 * PTEs the caller has just invalidated.
 	 */
 	l2b->l2b_occupancy -= count;
 	/*
 	 * Note:
+	 *
 	 * Level 2 page tables allocated to the kernel pmap are never freed
 	 * as that would require checking all Level 1 page tables and
 	 * removing any references to the Level 2 page table. See also the
 	 * comment elsewhere about never freeing bootstrap L2 descriptors.
+	 *
 	 * We make do with just invalidating the mapping in the L2 table.
+	 *
 	 * This isn't really a big deal in practice and, in fact, leads
 	 * to a performance win over time as we don't need to continually
 	 * alloc/free.
 	 */
 	if (l2b->l2b_occupancy > 0 || pm == pmap_kernel())
 		return;
 	/*
 	 * There are no more valid mappings in this level 2 page table.
 	 * Go ahead and NULL-out the pointer in the bucket, then
 	 * free the page table.
 	 */
 	const size_t l1slot = l2b->l2b_l1slot;
 	pt_entry_t * const ptep = l2b->l2b_kva;
 	l2b->l2b_kva = NULL;
 	pd_entry_t * const pdep = pmap_l1_kva(pm) + l1slot;
 	pd_entry_t pde __diagused = *pdep;
 #ifdef ARM_MMU_EXTENDED
 	/*
 	 * Invalidate the L1 slot.
 	 */
 	KASSERT((pde & L1_TYPE_MASK) == L1_TYPE_C);
 #else
 	/*
 	 * If the L1 slot matches the pmap's domain number, then invalidate it.
 	 */
 	if ((pde & (L1_C_DOM_MASK|L1_TYPE_MASK))
 	    == (L1_C_DOM(pmap_domain(pm))|L1_TYPE_C)) {
 #endif
 		l1pte_setone(pdep, 0);
 		PDE_SYNC(pdep);
 #ifndef ARM_MMU_EXTENDED
+	}
 #endif
 	/*
 	 * Release the L2 descriptor table back to the pool cache.
 	 */
 #if defined(PMAP_INCLUDE_PTE_SYNC) && defined(PMAP_CACHE_VIVT)
 	pmap_free_l2_ptp(!pmap_is_cached(pm), ptep, l2b->l2b_pa);
 #else
 	pmap_free_l2_ptp(ptep, l2b->l2b_pa);
 #endif
 	/*
 	 * Update the reference count in the associated l2_dtable
 	 */
 	struct l2_dtable * const l2 = pm->pm_l2[L2_IDX(l1slot)];
 	if (--l2->l2_occupancy > 0)
 		return;
 	/*
 	 * There are no more valid mappings in any of the Level 1
 	 * slots managed by this l2_dtable. Go ahead and NULL-out
 	 * the pointer in the parent pmap and free the l2_dtable.
 	 */
 	pm->pm_l2[L2_IDX(l1slot)] = NULL;
 	pmap_free_l2_dtable(l2);
+}
 #if defined(ARM_MMU_EXTENDED)
 /*
  * Pool cache constructors for L1 translation tables
  */
 static int
 pmap_l1tt_ctor(void *arg, void *v, int flags)
+{
 #ifndef PMAP_INCLUDE_PTE_SYNC
 #error not supported
 #endif
 	memset(v, 0, L1TT_SIZE);
 	PTE_SYNC_RANGE(v, L1TT_SIZE / sizeof(pt_entry_t));
 	return 0;
+}
 #endif
 /*
  * Pool cache constructors for L2 descriptor tables, metadata and pmap
  * structures.
  */
 static int
 pmap_l2ptp_ctor(void *arg, void *v, int flags)
+{
 #ifndef PMAP_INCLUDE_PTE_SYNC
 	vaddr_t va = (vaddr_t)v & ~PGOFSET;
 	/*
 	 * The mappings for these page tables were initially made using
 	 * pmap_kenter_pa() by the pool subsystem. Therefore, the cache-
 	 * mode will not be right for page table mappings. To avoid
 	 * polluting the pmap_kenter_pa() code with a special case for
 	 * page tables, we simply fix up the cache-mode here if it's not
 	 * correct.
 	 */
 	if (pte_l2_s_cache_mode != pte_l2_s_cache_mode_pt) {
 		const struct l2_bucket * const l2b =
 		    pmap_get_l2_bucket(pmap_kernel(), va);
 		KASSERTMSG(l2b != NULL, "%#lx", va);
 		pt_entry_t * const ptep = &l2b->l2b_kva[l2pte_index(va)];
 		const pt_entry_t opte = *ptep;
 		if ((opte & L2_S_CACHE_MASK) != pte_l2_s_cache_mode_pt) {
 			/*
 			 * Page tables must have the cache-mode set correctly.
 			 */
 			const pt_entry_t npte = (opte & ~L2_S_CACHE_MASK)
 			    | pte_l2_s_cache_mode_pt;
 			l2pte_set(ptep, npte, opte);
 			PTE_SYNC(ptep);
 			cpu_tlb_flushD_SE(va);
 			cpu_cpwait();
+		}
+	}
 #endif
 	memset(v, 0, L2_TABLE_SIZE_REAL);
 	PTE_SYNC_RANGE(v, L2_TABLE_SIZE_REAL / sizeof(pt_entry_t));
 	return 0;
+}
 static int
 pmap_l2dtable_ctor(void *arg, void *v, int flags)
+{
 	memset(v, 0, sizeof(struct l2_dtable));
 	return 0;
+}
 static int
 pmap_pmap_ctor(void *arg, void *v, int flags)
+{
 	memset(v, 0, sizeof(struct pmap));
 	return 0;
+}
 static void
 pmap_pinit(pmap_t pm)
+{
 #ifndef ARM_HAS_VBAR
 	struct l2_bucket *l2b;
 	if (vector_page < KERNEL_BASE) {
 		/*
 		 * Map the vector page.
 		 */
 		pmap_enter(pm, vector_page, systempage.pv_pa,
 		    VM_PROT_READ | VM_PROT_EXECUTE,
 		    VM_PROT_READ | VM_PROT_EXECUTE | PMAP_WIRED);
 		pmap_update(pm);
 		pm->pm_pl1vec = pmap_l1_kva(pm) + l1pte_index(vector_page);
 		l2b = pmap_get_l2_bucket(pm, vector_page);
 		KASSERTMSG(l2b != NULL, "%#lx", vector_page);
 		pm->pm_l1vec = l2b->l2b_pa | L1_C_PROTO |
 		    L1_C_DOM(pmap_domain(pm));
 	} else
 		pm->pm_pl1vec = NULL;
 #endif
+}
 #ifdef PMAP_CACHE_VIVT
 /*
  * Since we have a virtually indexed cache, we may need to inhibit caching if
  * there is more than one mapping and at least one of them is writable.
  * Since we purge the cache on every context switch, we only need to check for
  * other mappings within the same pmap, or kernel_pmap.
  * This function is also called when a page is unmapped, to possibly reenable
  * caching on any remaining mappings.
+ *
  * The code implements the following logic, where:
+ *
  * KW = # of kernel read/write pages
  * KR = # of kernel read only pages
  * UW = # of user read/write pages
  * UR = # of user read only pages
+ *
  * KC = kernel mapping is cacheable
  * UC = user mapping is cacheable
+ *
  *               KW=0,KR=0  KW=0,KR>0  KW=1,KR=0  KW>1,KR>=0
  *             +---------------------------------------------
  * UW=0,UR=0   | ---        KC=1       KC=1       KC=0
  * UW=0,UR>0   | UC=1       KC=1,UC=1  KC=0,UC=0  KC=0,UC=0
  * UW=1,UR=0   | UC=1       KC=0,UC=0  KC=0,UC=0  KC=0,UC=0
  * UW>1,UR>=0  | UC=0       KC=0,UC=0  KC=0,UC=0  KC=0,UC=0
  */
 static const int pmap_vac_flags[4][4] = {
 	{-1,		0,		0,		PVF_KNC},
 	{0,		0,		PVF_NC,		PVF_NC},
 	{0,		PVF_NC,		PVF_NC,		PVF_NC},
 	{PVF_UNC,	PVF_NC,		PVF_NC,		PVF_NC}
 };
 static inline int
 pmap_get_vac_flags(const struct vm_page_md *md)
+{
 	int kidx, uidx;
 	kidx = 0;
 	if (md->kro_mappings || md->krw_mappings > 1)
 		kidx |= 1;
 	if (md->krw_mappings)
 		kidx |= 2;
 	uidx = 0;
 	if (md->uro_mappings || md->urw_mappings > 1)
 		uidx |= 1;
 	if (md->urw_mappings)
 		uidx |= 2;
 	return pmap_vac_flags[uidx][kidx];
+}
 static inline void
 pmap_vac_me_harder(struct vm_page_md *md, paddr_t pa, pmap_t pm, vaddr_t va)
+{
 	int nattr;
 	nattr = pmap_get_vac_flags(md);
 	if (nattr < 0) {
 		md->pvh_attrs &= ~PVF_NC;
 		return;
+	}
 	if (nattr == 0 && (md->pvh_attrs & PVF_NC) == 0)
 		return;
 	if (pm == pmap_kernel())
 		pmap_vac_me_kpmap(md, pa, pm, va);
 	else
 		pmap_vac_me_user(md, pa, pm, va);
 	md->pvh_attrs = (md->pvh_attrs & ~PVF_NC) | nattr;
+}
 static void
 pmap_vac_me_kpmap(struct vm_page_md *md, paddr_t pa, pmap_t pm, vaddr_t va)
+{
 	u_int u_cacheable, u_entries;
 	struct pv_entry *pv;
 	pmap_t last_pmap = pm;
 	/*
 	 * Pass one, see if there are both kernel and user pmaps for
 	 * this page.  Calculate whether there are user-writable or
 	 * kernel-writable pages.
 	 */
 	u_cacheable = 0;
 	SLIST_FOREACH(pv, &md->pvh_list, pv_link) {
 		if (pv->pv_pmap != pm && (pv->pv_flags & PVF_NC) == 0)
 			u_cacheable++;
+	}
 	u_entries = md->urw_mappings + md->uro_mappings;
 	/*
 	 * We know we have just been updating a kernel entry, so if
 	 * all user pages are already cacheable, then there is nothing
 	 * further to do.
 	 */
 	if (md->k_mappings == 0 && u_cacheable == u_entries)
 		return;
 	if (u_entries) {
 		/*
 		 * Scan over the list again, for each entry, if it
 		 * might not be set correctly, call pmap_vac_me_user
 		 * to recalculate the settings.
 		 */
 		SLIST_FOREACH(pv, &md->pvh_list, pv_link) {
 			/*
 			 * We know kernel mappings will get set
 			 * correctly in other calls.  We also know
 			 * that if the pmap is the same as last_pmap
 			 * then we've just handled this entry.
 			 */
 			if (pv->pv_pmap == pm || pv->pv_pmap == last_pmap)
 				continue;
 			/*
 			 * If there are kernel entries and this page
 			 * is writable but non-cacheable, then we can
 			 * skip this entry also.
 			 */
 			if (md->k_mappings &&
 			    (pv->pv_flags & (PVF_NC | PVF_WRITE)) ==
 			    (PVF_NC | PVF_WRITE))
 				continue;
 			/*
 			 * Similarly if there are no kernel-writable
 			 * entries and the page is already
 			 * read-only/cacheable.
 			 */
 			if (md->krw_mappings == 0 &&
 			    (pv->pv_flags & (PVF_NC | PVF_WRITE)) == 0)
 				continue;
 			/*
 			 * For some of the remaining cases, we know
 			 * that we must recalculate, but for others we
 			 * can't tell if they are correct or not, so
 			 * we recalculate anyway.
 			 */
 			pmap_vac_me_user(md, pa, (last_pmap = pv->pv_pmap), 0);
+		}
 		if (md->k_mappings == 0)
 			return;
+	}
 	pmap_vac_me_user(md, pa, pm, va);
+}
 static void
 pmap_vac_me_user(struct vm_page_md *md, paddr_t pa, pmap_t pm, vaddr_t va)
+{
 	pmap_t kpmap = pmap_kernel();
 	struct pv_entry *pv, *npv = NULL;
 	u_int entries = 0;
 	u_int writable = 0;
 	u_int cacheable_entries = 0;
 	u_int kern_cacheable = 0;
 	u_int other_writable = 0;
 	/*
 	 * Count mappings and writable mappings in this pmap.
 	 * Include kernel mappings as part of our own.
 	 * Keep a pointer to the first one.
 	 */
 	npv = NULL;
 	KASSERT(pmap_page_locked_p(md));
 	SLIST_FOREACH(pv, &md->pvh_list, pv_link) {
 		/* Count mappings in the same pmap */
 		if (pm == pv->pv_pmap || kpmap == pv->pv_pmap) {
 			if (entries++ == 0)
 				npv = pv;
 			/* Cacheable mappings */
 			if ((pv->pv_flags & PVF_NC) == 0) {
 				cacheable_entries++;
 				if (kpmap == pv->pv_pmap)
 					kern_cacheable++;
+			}
 			/* Writable mappings */
 			if (pv->pv_flags & PVF_WRITE)
 				++writable;
 		} else if (pv->pv_flags & PVF_WRITE)
 			other_writable = 1;
+	}
 	/*
 	 * Enable or disable caching as necessary.
 	 * Note: the first entry might be part of the kernel pmap,
 	 * so we can't assume this is indicative of the state of the
 	 * other (maybe non-kpmap) entries.
 	 */
 	if ((entries > 1 && writable) ||
 	    (entries > 0 && pm == kpmap && other_writable)) {
 		if (cacheable_entries == 0) {
 			return;
+		}
 		for (pv = npv; pv; pv = SLIST_NEXT(pv, pv_link)) {
 			if ((pm != pv->pv_pmap && kpmap != pv->pv_pmap) ||
 			    (pv->pv_flags & PVF_NC))
 				continue;
 			pv->pv_flags |= PVF_NC;
 			struct l2_bucket * const l2b
 			    = pmap_get_l2_bucket(pv->pv_pmap, pv->pv_va);
 			KASSERTMSG(l2b != NULL, "%#lx", va);
 			pt_entry_t * const ptep
 			    = &l2b->l2b_kva[l2pte_index(pv->pv_va)];
 			const pt_entry_t opte = *ptep;
 			pt_entry_t npte = opte & ~L2_S_CACHE_MASK;
 			if ((va != pv->pv_va || pm != pv->pv_pmap)
 			    && l2pte_valid_p(opte)) {
 				pmap_cache_wbinv_page(pv->pv_pmap, pv->pv_va,
 				    true, pv->pv_flags);
 				pmap_tlb_flush_SE(pv->pv_pmap, pv->pv_va,
 				    pv->pv_flags);
+			}
 			l2pte_set(ptep, npte, opte);
 			PTE_SYNC_CURRENT(pv->pv_pmap, ptep);
+		}
 		cpu_cpwait();
 	} else if (entries > cacheable_entries) {
 		/*
 		 * Turn cacheing back on for some pages.  If it is a kernel
 		 * page, only do so if there are no other writable pages.
 		 */
 		for (pv = npv; pv; pv = SLIST_NEXT(pv, pv_link)) {
 			if (!(pv->pv_flags & PVF_NC) || (pm != pv->pv_pmap &&
 			    (kpmap != pv->pv_pmap || other_writable)))
 				continue;
 			pv->pv_flags &= ~PVF_NC;
 			struct l2_bucket * const l2b
 			    = pmap_get_l2_bucket(pv->pv_pmap, pv->pv_va);
 			KASSERTMSG(l2b != NULL, "%#lx", va);
 			pt_entry_t * const ptep
 			    = &l2b->l2b_kva[l2pte_index(pv->pv_va)];
 			const pt_entry_t opte = *ptep;
 			pt_entry_t npte = (opte & ~L2_S_CACHE_MASK)
 			    | pte_l2_s_cache_mode;
 			if (l2pte_valid_p(opte)) {
 				pmap_tlb_flush_SE(pv->pv_pmap, pv->pv_va,
 				    pv->pv_flags);
+			}
 			l2pte_set(ptep, npte, opte);
 			PTE_SYNC_CURRENT(pv->pv_pmap, ptep);
+		}
+	}
+}
 #endif
 #ifdef PMAP_CACHE_VIPT
 static void
 pmap_vac_me_harder(struct vm_page_md *md, paddr_t pa, pmap_t pm, vaddr_t va)
+{
 #ifndef ARM_MMU_EXTENDED
 	struct pv_entry *pv;
 	vaddr_t tst_mask;
 	bool bad_alias;
 	const u_int
 	    rw_mappings = md->urw_mappings + md->krw_mappings,
 	    ro_mappings = md->uro_mappings + md->kro_mappings;
 	/* do we need to do anything? */
 	if (arm_cache_prefer_mask == 0)
 		return;
 	UVMHIST_FUNC(__func__);
 	UVMHIST_CALLARGS(maphist, "md %#jx pa %#jx pm %#jx va %#jx",
 	    (uintptr_t)md, (uintptr_t)pa, (uintptr_t)pm, va);
 	KASSERT(!va || pm);
 	KASSERT((md->pvh_attrs & PVF_DMOD) == 0 || (md->pvh_attrs & (PVF_DIRTY|PVF_NC)));
 	/* Already a conflict? */
 	if (__predict_false(md->pvh_attrs & PVF_NC)) {
 		/* just an add, things are already non-cached */
 		KASSERT(!(md->pvh_attrs & PVF_DIRTY));
 		KASSERT(!(md->pvh_attrs & PVF_MULTCLR));
 		bad_alias = false;
 		if (va) {
 			PMAPCOUNT(vac_color_none);
 			bad_alias = true;
 			KASSERT((rw_mappings == 0) == !(md->pvh_attrs & PVF_WRITE));
 			goto fixup;
+		}
 		pv = SLIST_FIRST(&md->pvh_list);
 		/* the list can't be empty because it would be cachable */
 		if (md->pvh_attrs & PVF_KMPAGE) {
 			tst_mask = md->pvh_attrs;
 		} else {
 			KASSERT(pv);
 			tst_mask = pv->pv_va;
 			pv = SLIST_NEXT(pv, pv_link);
+		}
 		/*
 		 * Only check for a bad alias if we have writable mappings.
 		 */
 		tst_mask &= arm_cache_prefer_mask;
 		if (rw_mappings > 0) {
 			for (; pv && !bad_alias; pv = SLIST_NEXT(pv, pv_link)) {
 				/* if there's a bad alias, stop checking. */
 				if (tst_mask != (pv->pv_va & arm_cache_prefer_mask))
 					bad_alias = true;
+			}
 			md->pvh_attrs |= PVF_WRITE;
 			if (!bad_alias)
 				md->pvh_attrs |= PVF_DIRTY;
 		} else {
 			/*
 			 * We have only read-only mappings.  Let's see if there
 			 * are multiple colors in use or if we mapped a KMPAGE.
 			 * If the latter, we have a bad alias.  If the former,
 			 * we need to remember that.
 			 */
 			for (; pv; pv = SLIST_NEXT(pv, pv_link)) {
 				if (tst_mask != (pv->pv_va & arm_cache_prefer_mask)) {
 					if (md->pvh_attrs & PVF_KMPAGE)
 						bad_alias = true;
 					break;
+				}
+			}
 			md->pvh_attrs &= ~PVF_WRITE;
 			/*
 			 * No KMPAGE and we exited early, so we must have
 			 * multiple color mappings.
 			 */
 			if (!bad_alias && pv != NULL)
 				md->pvh_attrs |= PVF_MULTCLR;
+		}
 		/* If no conflicting colors, set everything back to cached */
 		if (!bad_alias) {
 #ifdef DEBUG
 			if ((md->pvh_attrs & PVF_WRITE)
 			    || ro_mappings < 2) {
 				SLIST_FOREACH(pv, &md->pvh_list, pv_link)
 					KDASSERT(((tst_mask ^ pv->pv_va) & arm_cache_prefer_mask) == 0);
+			}
 #endif
 			md->pvh_attrs &= (PAGE_SIZE - 1) & ~PVF_NC;
 			md->pvh_attrs |= tst_mask | PVF_COLORED;
 			/*
 			 * Restore DIRTY bit if page is modified
 			 */
 			if (md->pvh_attrs & PVF_DMOD)
 				md->pvh_attrs |= PVF_DIRTY;
 			PMAPCOUNT(vac_color_restore);
 		} else {
 			KASSERT(SLIST_FIRST(&md->pvh_list) != NULL);
 			KASSERT(SLIST_NEXT(SLIST_FIRST(&md->pvh_list), pv_link) != NULL);
+		}
 		KASSERT((md->pvh_attrs & PVF_DMOD) == 0 || (md->pvh_attrs & (PVF_DIRTY|PVF_NC)));
 		KASSERT((rw_mappings == 0) == !(md->pvh_attrs & PVF_WRITE));
 	} else if (!va) {
 		KASSERT(pmap_is_page_colored_p(md));
 		KASSERT(!(md->pvh_attrs & PVF_WRITE)
 		    || (md->pvh_attrs & PVF_DIRTY));
 		if (rw_mappings == 0) {
 			md->pvh_attrs &= ~PVF_WRITE;
 			if (ro_mappings == 1
 			    && (md->pvh_attrs & PVF_MULTCLR)) {
 				/*
 				 * If this is the last readonly mapping
 				 * but it doesn't match the current color
 				 * for the page, change the current color
 				 * to match this last readonly mapping.
 				 */
 				pv = SLIST_FIRST(&md->pvh_list);
 				tst_mask = (md->pvh_attrs ^ pv->pv_va)
 				    & arm_cache_prefer_mask;
 				if (tst_mask) {
 					md->pvh_attrs ^= tst_mask;
 					PMAPCOUNT(vac_color_change);
+				}
+			}
+		}
 		KASSERT((md->pvh_attrs & PVF_DMOD) == 0 || (md->pvh_attrs & (PVF_DIRTY|PVF_NC)));
 		KASSERT((rw_mappings == 0) == !(md->pvh_attrs & PVF_WRITE));
 		return;
 	} else if (!pmap_is_page_colored_p(md)) {
 		/* not colored so we just use its color */
 		KASSERT(md->pvh_attrs & (PVF_WRITE|PVF_DIRTY));
 		KASSERT(!(md->pvh_attrs & PVF_MULTCLR));
 		PMAPCOUNT(vac_color_new);
 		md->pvh_attrs &= PAGE_SIZE - 1;
 		md->pvh_attrs |= PVF_COLORED
 		    | (va & arm_cache_prefer_mask)
 		    | (rw_mappings > 0 ? PVF_WRITE : 0);
 		KASSERT((md->pvh_attrs & PVF_DMOD) == 0 || (md->pvh_attrs & (PVF_DIRTY|PVF_NC)));
 		KASSERT((rw_mappings == 0) == !(md->pvh_attrs & PVF_WRITE));
 		return;
 	} else if (((md->pvh_attrs ^ va) & arm_cache_prefer_mask) == 0) {
 		bad_alias = false;
 		if (rw_mappings > 0) {
 			/*
 			 * We now have writeable mappings and if we have
 			 * readonly mappings in more than once color, we have
 			 * an aliasing problem.  Regardless mark the page as
 			 * writeable.
 			 */
 			if (md->pvh_attrs & PVF_MULTCLR) {
 				if (ro_mappings < 2) {
 					/*
 					 * If we only have less than two
 					 * read-only mappings, just flush the
 					 * non-primary colors from the cache.
 					 */
 					pmap_flush_page(md, pa,
 					    PMAP_FLUSH_SECONDARY);
 				} else {
 					bad_alias = true;
+				}
+			}
 			md->pvh_attrs |= PVF_WRITE;
+		}
 		/* If no conflicting colors, set everything back to cached */
 		if (!bad_alias) {
 #ifdef DEBUG
 			if (rw_mappings > 0
 			    || (md->pvh_attrs & PMAP_KMPAGE)) {
 				tst_mask = md->pvh_attrs & arm_cache_prefer_mask;
 				SLIST_FOREACH(pv, &md->pvh_list, pv_link)
 					KDASSERT(((tst_mask ^ pv->pv_va) & arm_cache_prefer_mask) == 0);
+			}
 #endif
 			if (SLIST_EMPTY(&md->pvh_list))
 				PMAPCOUNT(vac_color_reuse);
 			else
 				PMAPCOUNT(vac_color_ok);
 			/* matching color, just return */
 			KASSERT((md->pvh_attrs & PVF_DMOD) == 0 || (md->pvh_attrs & (PVF_DIRTY|PVF_NC)));
 			KASSERT((rw_mappings == 0) == !(md->pvh_attrs & PVF_WRITE));
 			return;
+		}
 		KASSERT(SLIST_FIRST(&md->pvh_list) != NULL);
 		KASSERT(SLIST_NEXT(SLIST_FIRST(&md->pvh_list), pv_link) != NULL);
 		/* color conflict.  evict from cache. */
 		pmap_flush_page(md, pa, PMAP_FLUSH_PRIMARY);
 		md->pvh_attrs &= ~PVF_COLORED;
 		md->pvh_attrs |= PVF_NC;
 		KASSERT((md->pvh_attrs & PVF_DMOD) == 0 || (md->pvh_attrs & (PVF_DIRTY|PVF_NC)));
 		KASSERT(!(md->pvh_attrs & PVF_MULTCLR));
 		PMAPCOUNT(vac_color_erase);
 	} else if (rw_mappings == 0
 		   && (md->pvh_attrs & PVF_KMPAGE) == 0) {
 		KASSERT((md->pvh_attrs & PVF_WRITE) == 0);
 		/*
 		 * If the page has dirty cache lines, clean it.
 		 */
 		if (md->pvh_attrs & PVF_DIRTY)
 			pmap_flush_page(md, pa, PMAP_CLEAN_PRIMARY);
 		/*
 		 * If this is the first remapping (we know that there are no
 		 * writeable mappings), then this is a simple color change.
 		 * Otherwise this is a seconary r/o mapping, which means
 		 * we don't have to do anything.
 		 */
 		if (ro_mappings == 1) {
 			KASSERT(((md->pvh_attrs ^ va) & arm_cache_prefer_mask) != 0);
 			md->pvh_attrs &= PAGE_SIZE - 1;
 			md->pvh_attrs |= (va & arm_cache_prefer_mask);
 			PMAPCOUNT(vac_color_change);
 		} else {
 			PMAPCOUNT(vac_color_blind);
+		}
 		md->pvh_attrs |= PVF_MULTCLR;
 		KASSERT((md->pvh_attrs & PVF_DMOD) == 0 || (md->pvh_attrs & (PVF_DIRTY|PVF_NC)));
 		KASSERT((rw_mappings == 0) == !(md->pvh_attrs & PVF_WRITE));
 		return;
 	} else {
 		if (rw_mappings > 0)
 			md->pvh_attrs |= PVF_WRITE;
 		/* color conflict.  evict from cache. */
 		pmap_flush_page(md, pa, PMAP_FLUSH_PRIMARY);
 		/* the list can't be empty because this was a enter/modify */
 		pv = SLIST_FIRST(&md->pvh_list);
 		if ((md->pvh_attrs & PVF_KMPAGE) == 0) {
 			KASSERT(pv);
 			/*
 			 * If there's only one mapped page, change color to the
 			 * page's new color and return.  Restore the DIRTY bit
 			 * that was erased by pmap_flush_page.
 			 */
 			if (SLIST_NEXT(pv, pv_link) == NULL) {
 				md->pvh_attrs &= PAGE_SIZE - 1;
 				md->pvh_attrs |= (va & arm_cache_prefer_mask);
 				if (md->pvh_attrs & PVF_DMOD)
 					md->pvh_attrs |= PVF_DIRTY;
 				PMAPCOUNT(vac_color_change);
 				KASSERT((md->pvh_attrs & PVF_DMOD) == 0 || (md->pvh_attrs & (PVF_DIRTY|PVF_NC)));
 				KASSERT((rw_mappings == 0) == !(md->pvh_attrs & PVF_WRITE));
 				KASSERT(!(md->pvh_attrs & PVF_MULTCLR));
 				return;
+			}
+		}
 		bad_alias = true;
 		md->pvh_attrs &= ~PVF_COLORED;
 		md->pvh_attrs |= PVF_NC;
 		PMAPCOUNT(vac_color_erase);
 		KASSERT((md->pvh_attrs & PVF_DMOD) == 0 || (md->pvh_attrs & (PVF_DIRTY|PVF_NC)));
+	}
   fixup:
 	KASSERT((rw_mappings == 0) == !(md->pvh_attrs & PVF_WRITE));
 	/*
 	 * Turn cacheing on/off for all pages.
 	 */
 	SLIST_FOREACH(pv, &md->pvh_list, pv_link) {
 		struct l2_bucket * const l2b = pmap_get_l2_bucket(pv->pv_pmap,
 		    pv->pv_va);
 		KASSERTMSG(l2b != NULL, "%#lx", va);
 		pt_entry_t * const ptep = &l2b->l2b_kva[l2pte_index(pv->pv_va)];
 		const pt_entry_t opte = *ptep;
 		pt_entry_t npte = opte & ~L2_S_CACHE_MASK;
 		if (bad_alias) {
 			pv->pv_flags |= PVF_NC;
 		} else {
 			pv->pv_flags &= ~PVF_NC;
 			npte |= pte_l2_s_cache_mode;
+		}
 		if (opte == npte)	/* only update is there's a change */
 			continue;
 		if (l2pte_valid_p(opte)) {
 			pmap_tlb_flush_SE(pv->pv_pmap, pv->pv_va, pv->pv_flags);
+		}
 		l2pte_set(ptep, npte, opte);
 		PTE_SYNC_CURRENT(pv->pv_pmap, ptep);
+	}
 #endif /* !ARM_MMU_EXTENDED */
+}
 #endif	/* PMAP_CACHE_VIPT */
 /*
  * Modify pte bits for all ptes corresponding to the given physical address.
  * We use `maskbits' rather than `clearbits' because we're always passing
  * constants and the latter would require an extra inversion at run-time.
  */
 static void
 pmap_clearbit(struct vm_page_md *md, paddr_t pa, u_int maskbits)
+{
 	struct pv_entry *pv;
 #ifdef PMAP_CACHE_VIPT
 	const bool want_syncicache = PV_IS_EXEC_P(md->pvh_attrs);
 	bool need_syncicache = false;
 #ifdef ARM_MMU_EXTENDED
 	const u_int execbits = (maskbits & PVF_EXEC) ? L2_XS_XN : 0;
 #else
 	const u_int execbits = 0;
 	bool need_vac_me_harder = false;
 #endif
 #else
 	const u_int execbits = 0;
 #endif
 	UVMHIST_FUNC(__func__);
 	UVMHIST_CALLARGS(maphist, "md %#jx pa %#jx maskbits %#jx",
 	    (uintptr_t)md, pa, maskbits, 0);
 #ifdef PMAP_CACHE_VIPT
 	/*
 	 * If we might want to sync the I-cache and we've modified it,
 	 * then we know we definitely need to sync or discard it.
 	 */
 	if (want_syncicache) {
 		if (md->pvh_attrs & PVF_MOD) {
 			need_syncicache = true;
+		}
+	}
 #endif
 	KASSERT(pmap_page_locked_p(md));
 	/*
 	 * Clear saved attributes (modify, reference)
 	 */
 	md->pvh_attrs &= ~(maskbits & (PVF_MOD | PVF_REF));
 	if (SLIST_EMPTY(&md->pvh_list)) {
 #if defined(PMAP_CACHE_VIPT)
 		if (need_syncicache) {
 			/*
 			 * No one has it mapped, so just discard it.  The next
 			 * exec remapping will cause it to be synced.
 			 */
 			md->pvh_attrs &= ~PVF_EXEC;
 			PMAPCOUNT(exec_discarded_clearbit);
+		}
 #endif
 		return;
+	}
 	/*
 	 * Loop over all current mappings setting/clearing as appropos
 	 */
 	for (pv = SLIST_FIRST(&md->pvh_list); pv != NULL;) {
 		pmap_t pm = pv->pv_pmap;
 		const vaddr_t va = pv->pv_va;
 		const u_int oflags = pv->pv_flags;
 #ifndef ARM_MMU_EXTENDED
 		/*
 		 * Kernel entries are unmanaged and as such not to be changed.
 		 */
 		if (PV_IS_KENTRY_P(oflags)) {
 			pv = SLIST_NEXT(pv, pv_link);
 			continue;
+		}
 #endif
 		/*
 		 * Anything to do?
 		 */
 		if ((oflags & maskbits) == 0 && execbits == 0) {
 			pv = SLIST_NEXT(pv, pv_link);
 			continue;
 		/*
 		 * Try to get a hold on the pmap's lock.  We must do this
 		 * while still holding the page locked, to know that the
 		 * page is still associated with the pmap and the mapping is
 		 * in place.  If a hold can't be had, unlock and wait for
 		 * the pmap's lock to become available and retry.  The pmap
 		 * must be ref'd over this dance to stop it disappearing
 		 * behind us.
 		 */
 		if (!mutex_tryenter(&pm->pm_lock)) {
 			pmap_reference(pm);
 			pmap_release_page_lock(md);
 			pmap_acquire_pmap_lock(pm);
 			/* nothing, just wait for it */
 			pmap_release_pmap_lock(pm);
 			pmap_destroy(pm);
 			/* Restart from the beginning. */
 			pmap_acquire_page_lock(md);
 			pv = SLIST_FIRST(&md->pvh_list);
 			continue;
+		}
 		pv->pv_flags &= ~maskbits;
 		struct l2_bucket * const l2b = pmap_get_l2_bucket(pm, va);
 		KASSERTMSG(l2b != NULL, "%#lx", va);
 		pt_entry_t * const ptep = &l2b->l2b_kva[l2pte_index(va)];
 		const pt_entry_t opte = *ptep;
 		pt_entry_t npte = opte | execbits;
 #ifdef ARM_MMU_EXTENDED
 		KASSERT((opte & L2_XS_nG) == (pm == pmap_kernel() ? 0 : L2_XS_nG));
 #endif
 		UVMHIST_LOG(maphist, "pv %#jx pm %#jx va %#jx flag %#jx",
 		    (uintptr_t)pv, (uintptr_t)pm, va, oflags);
 		if (maskbits & (PVF_WRITE|PVF_MOD)) {
 #ifdef PMAP_CACHE_VIVT
 			if ((oflags & PVF_NC)) {
 				/*
 				 * Entry is not cacheable:
+				 *
 				 * Don't turn caching on again if this is a
 				 * modified emulation. This would be
 				 * inconsitent with the settings created by
 				 * pmap_vac_me_harder(). Otherwise, it's safe
 				 * to re-enable cacheing.
+				 *
 				 * There's no need to call pmap_vac_me_harder()
 				 * here: all pages are losing their write
 				 * permission.
 				 */
 				if (maskbits & PVF_WRITE) {
 					npte |= pte_l2_s_cache_mode;
 					pv->pv_flags &= ~PVF_NC;
+				}
 			} else if (l2pte_writable_p(opte)) {
 				/*
 				 * Entry is writable/cacheable: check if pmap
 				 * is current if it is flush it, otherwise it
 				 * won't be in the cache
 				 */
 				pmap_cache_wbinv_page(pm, va,
 				    (maskbits & PVF_REF) != 0,
 				    oflags|PVF_WRITE);
+			}
 #endif
 			/* make the pte read only */
 			npte = l2pte_set_readonly(npte);
 			if ((maskbits & oflags & PVF_WRITE)) {
 				/*
 				 * Keep alias accounting up to date
 				 */
 				if (pm == pmap_kernel()) {
 					md->krw_mappings--;
 					md->kro_mappings++;
 				} else {
 					md->urw_mappings--;
 					md->uro_mappings++;
+				}
 #ifdef PMAP_CACHE_VIPT
 				if (arm_cache_prefer_mask != 0) {
 					if (md->urw_mappings + md->krw_mappings == 0) {
 						md->pvh_attrs &= ~PVF_WRITE;
 					} else {
 						PMAP_VALIDATE_MD_PAGE(md);
+					}
+				}
 				if (want_syncicache)
 					need_syncicache = true;
 #ifndef ARM_MMU_EXTENDED
 				need_vac_me_harder = true;
 #endif
 #endif /* PMAP_CACHE_VIPT */
+			}
+		}
 		if (maskbits & PVF_REF) {
 			if (true
 #ifndef ARM_MMU_EXTENDED
 			    && (oflags & PVF_NC) == 0
 #endif
 			    && (maskbits & (PVF_WRITE|PVF_MOD)) == 0
 			    && l2pte_valid_p(npte)) {
 #ifdef PMAP_CACHE_VIVT
 				/*
 				 * Check npte here; we may have already
 				 * done the wbinv above, and the validity
 				 * of the PTE is the same for opte and
 				 * npte.
 				 */
 				pmap_cache_wbinv_page(pm, va, true, oflags);
 #endif
+			}
 			/*
 			 * Make the PTE invalid so that we will take a
 			 * page fault the next time the mapping is
 			 * referenced.
 			 */
 			npte &= ~L2_TYPE_MASK;
 			npte |= L2_TYPE_INV;
+		}
 		if (npte != opte) {
 			l2pte_reset(ptep);
 			PTE_SYNC(ptep);
 			/* Flush the TLB entry if a current pmap. */
 			pmap_tlb_flush_SE(pm, va, oflags);
 			l2pte_set(ptep, npte, 0);
 			PTE_SYNC(ptep);
+		}
 		pmap_release_pmap_lock(pm);
 		UVMHIST_LOG(maphist, "pm %#jx va %#jx opte %#jx npte %#jx",
 		    (uintptr_t)pm, va, opte, npte);
 		/* Move to next entry. */
 		pv = SLIST_NEXT(pv, pv_link);
+	}
 #if defined(PMAP_CACHE_VIPT)
 	/*
 	 * If we need to sync the I-cache and we haven't done it yet, do it.
 	 */
 	if (need_syncicache) {
 		pmap_syncicache_page(md, pa);
 		PMAPCOUNT(exec_synced_clearbit);
+	}
 #ifndef ARM_MMU_EXTENDED
 	/*
 	 * If we are changing this to read-only, we need to call vac_me_harder
 	 * so we can change all the read-only pages to cacheable.  We pretend
 	 * this as a page deletion.
 	 */
 	if (need_vac_me_harder) {
 		if (md->pvh_attrs & PVF_NC)
 			pmap_vac_me_harder(md, pa, NULL, 0);
+	}
 #endif /* !ARM_MMU_EXTENDED */
 #endif /* PMAP_CACHE_VIPT */
+}
 /*
  * pmap_clean_page()
+ *
  * This is a local function used to work out the best strategy to clean
  * a single page referenced by its entry in the PV table. It's used by
  * pmap_copy_page, pmap_zero_page and maybe some others later on.
+ *
  * Its policy is effectively:
  *  o If there are no mappings, we don't bother doing anything with the cache.
  *  o If there is one mapping, we clean just that page.
  *  o If there are multiple mappings, we clean the entire cache.
+ *
  * So that some functions can be further optimised, it returns 0 if it didn't
  * clean the entire cache, or 1 if it did.
+ *
  * XXX One bug in this routine is that if the pv_entry has a single page
  * mapped at 0x00000000 a whole cache clean will be performed rather than
  * just the 1 page. Since this should not occur in everyday use and if it does
  * it will just result in not the most efficient clean for the page.
  */
 #ifdef PMAP_CACHE_VIVT
 static bool
 pmap_clean_page(struct vm_page_md *md, bool is_src)
+{
 	struct pv_entry *pv;
 	pmap_t pm_to_clean = NULL;
 	bool cache_needs_cleaning = false;
 	vaddr_t page_to_clean = 0;
 	u_int flags = 0;
 	/*
 	 * Since we flush the cache each time we change to a different
 	 * user vmspace, we only need to flush the page if it is in the
 	 * current pmap.
 	 */
 	KASSERT(pmap_page_locked_p(md));
 	SLIST_FOREACH(pv, &md->pvh_list, pv_link) {
 		if (pmap_is_current(pv->pv_pmap)) {
 			flags |= pv->pv_flags;
 			/*
 			 * The page is mapped non-cacheable in
 			 * this map.  No need to flush the cache.
 			 */
 			if (pv->pv_flags & PVF_NC) {
 #ifdef DIAGNOSTIC
 				KASSERT(!cache_needs_cleaning);
 #endif
 				break;
 			} else if (is_src && (pv->pv_flags & PVF_WRITE) == 0)
 				continue;
 			if (cache_needs_cleaning) {
 				page_to_clean = 0;
 				break;
 			} else {
 				page_to_clean = pv->pv_va;
 				pm_to_clean = pv->pv_pmap;
+			}
 			cache_needs_cleaning = true;
+		}
+	}
 	if (page_to_clean) {
 		pmap_cache_wbinv_page(pm_to_clean, page_to_clean,
 		    !is_src, flags | PVF_REF);
 	} else if (cache_needs_cleaning) {
 		pmap_t const pm = curproc->p_vmspace->vm_map.pmap;
 		pmap_cache_wbinv_all(pm, flags);
 		return true;
+	}
 	return false;
+}
 #endif
 #ifdef PMAP_CACHE_VIPT
 /*
  * Sync a page with the I-cache.  Since this is a VIPT, we must pick the
  * right cache alias to make sure we flush the right stuff.
  */
 void
 pmap_syncicache_page(struct vm_page_md *md, paddr_t pa)
+{
 	pmap_t kpm = pmap_kernel();
 	const size_t way_size = arm_pcache.icache_type == CACHE_TYPE_PIPT
 	    ? PAGE_SIZE
 	    : arm_pcache.icache_way_size;
 	UVMHIST_FUNC(__func__);
 	UVMHIST_CALLARGS(maphist, "md %#jx pa %#jx (attrs=%#jx)",
 	    (uintptr_t)md, pa, md->pvh_attrs, 0);
 	/*
 	 * No need to clean the page if it's non-cached.
 	 */
 #ifndef ARM_MMU_EXTENDED
 	if (md->pvh_attrs & PVF_NC)
 		return;
 	KASSERT(arm_cache_prefer_mask == 0 || md->pvh_attrs & PVF_COLORED);
 #endif
 	pt_entry_t * const ptep = cpu_cdst_pte(0);
 	const vaddr_t dstp = cpu_cdstp(0);
 #ifdef __HAVE_MM_MD_DIRECT_MAPPED_PHYS
 	if (way_size <= PAGE_SIZE) {
 		bool ok = false;
 		vaddr_t vdstp = pmap_direct_mapped_phys(pa, &ok, dstp);
 		if (ok) {
 			cpu_icache_sync_range(vdstp, way_size);
 			return;
+		}
+	}
 #endif
 	/*
 	 * We don't worry about the color of the exec page, we map the
 	 * same page to pages in the way and then do the icache_sync on
 	 * the entire way making sure we are cleaned.
 	 */
 	const pt_entry_t npte = L2_S_PROTO | pa | pte_l2_s_cache_mode
 	    | L2_S_PROT(PTE_KERNEL, VM_PROT_READ|VM_PROT_WRITE);
 	for (size_t i = 0, j = 0; i < way_size;
 	     i += PAGE_SIZE, j += PAGE_SIZE / L2_S_SIZE) {
 		l2pte_reset(ptep + j);
 		PTE_SYNC(ptep + j);
 		pmap_tlb_flush_SE(kpm, dstp + i, PVF_REF | PVF_EXEC);
 		/*
 		 * Set up a PTE with to flush these cache lines.
 		 */
 		l2pte_set(ptep + j, npte, 0);
+	}
 	PTE_SYNC_RANGE(ptep, way_size / L2_S_SIZE);
 	/*
 	 * Flush it.
 	 */
 	cpu_icache_sync_range(dstp, way_size);
 	for (size_t i = 0, j = 0; i < way_size;
 	     i += PAGE_SIZE, j += PAGE_SIZE / L2_S_SIZE) {
 		/*
 		 * Unmap the page(s).
 		 */
 		l2pte_reset(ptep + j);
 		PTE_SYNC(ptep + j);
 		pmap_tlb_flush_SE(kpm, dstp + i, PVF_REF | PVF_EXEC);
+	}
 	md->pvh_attrs |= PVF_EXEC;
 	PMAPCOUNT(exec_synced);
+}
 #ifndef ARM_MMU_EXTENDED
 void
 pmap_flush_page(struct vm_page_md *md, paddr_t pa, enum pmap_flush_op flush)
+{
 	vsize_t va_offset, end_va;
 	bool wbinv_p;
 	if (arm_cache_prefer_mask == 0)
 		return;
 	UVMHIST_FUNC(__func__);
 	UVMHIST_CALLARGS(maphist, "md %#jx pa %#jx op %#jx",
 	    (uintptr_t)md, pa, op, 0);
 	switch (flush) {
 	case PMAP_FLUSH_PRIMARY:
 		if (md->pvh_attrs & PVF_MULTCLR) {
 			va_offset = 0;
 			end_va = arm_cache_prefer_mask;
 			md->pvh_attrs &= ~PVF_MULTCLR;
 			PMAPCOUNT(vac_flush_lots);
 		} else {
 			va_offset = md->pvh_attrs & arm_cache_prefer_mask;
 			end_va = va_offset;
 			PMAPCOUNT(vac_flush_one);
+		}
 		/*
 		 * Mark that the page is no longer dirty.
 		 */
 		md->pvh_attrs &= ~PVF_DIRTY;
 		wbinv_p = true;
 		break;
 	case PMAP_FLUSH_SECONDARY:
 		va_offset = 0;
 		end_va = arm_cache_prefer_mask;
 		wbinv_p = true;
 		md->pvh_attrs &= ~PVF_MULTCLR;
 		PMAPCOUNT(vac_flush_lots);
 		break;
 	case PMAP_CLEAN_PRIMARY:
 		va_offset = md->pvh_attrs & arm_cache_prefer_mask;
 		end_va = va_offset;
 		wbinv_p = false;
 		/*
 		 * Mark that the page is no longer dirty.
 		 */
 		if ((md->pvh_attrs & PVF_DMOD) == 0)
 			md->pvh_attrs &= ~PVF_DIRTY;
 		PMAPCOUNT(vac_clean_one);
 		break;
 	default:
 		return;
+	}
 	KASSERT(!(md->pvh_attrs & PVF_NC));
 	UVMHIST_LOG(maphist, "md %#jx (attrs=%#jx)", (uintptr_t)md,
 	    md->pvh_attrs, 0, 0);
 	const size_t scache_line_size = arm_scache.dcache_line_size;
 	for (; va_offset <= end_va; va_offset += PAGE_SIZE) {
 		pt_entry_t * const ptep = cpu_cdst_pte(va_offset);
 		const vaddr_t dstp = cpu_cdstp(va_offset);
 		const pt_entry_t opte = *ptep;
 		if (flush == PMAP_FLUSH_SECONDARY
 		    && va_offset == (md->pvh_attrs & arm_cache_prefer_mask))
 			continue;
 		pmap_tlb_flush_SE(pmap_kernel(), dstp, PVF_REF | PVF_EXEC);
 		/*
 		 * Set up a PTE with the right coloring to flush
 		 * existing cache entries.
 		 */
 		const pt_entry_t npte = L2_S_PROTO
 		    | pa
 		    | L2_S_PROT(PTE_KERNEL, VM_PROT_READ|VM_PROT_WRITE)
 		    | pte_l2_s_cache_mode;
 		l2pte_set(ptep, npte, opte);
 		PTE_SYNC(ptep);
 		/*
 		 * Flush it.  Make sure to flush secondary cache too since
 		 * bus_dma will ignore uncached pages.
 		 */
 		if (scache_line_size != 0) {
 			cpu_dcache_wb_range(dstp, PAGE_SIZE);
 			if (wbinv_p) {
 				cpu_sdcache_wbinv_range(dstp, pa, PAGE_SIZE);
 				cpu_dcache_inv_range(dstp, PAGE_SIZE);
 			} else {
 				cpu_sdcache_wb_range(dstp, pa, PAGE_SIZE);
+			}
 		} else {
 			if (wbinv_p) {
 				cpu_dcache_wbinv_range(dstp, PAGE_SIZE);
 			} else {
 				cpu_dcache_wb_range(dstp, PAGE_SIZE);
+			}
+		}
 		/*
 		 * Restore the page table entry since we might have interrupted
 		 * pmap_zero_page or pmap_copy_page which was already using
 		 * this pte.
 		 */
 		if (opte) {
 			l2pte_set(ptep, opte, npte);
 		} else {
 			l2pte_reset(ptep);
+		}
 		PTE_SYNC(ptep);
 		pmap_tlb_flush_SE(pmap_kernel(), dstp, PVF_REF | PVF_EXEC);
+	}
+}
 #endif /* ARM_MMU_EXTENDED */
 #endif /* PMAP_CACHE_VIPT */
 /*
  * Routine:	pmap_page_remove
  * Function:
  *		Removes this physical page from
  *		all physical maps in which it resides.
  *		Reflects back modify bits to the pager.
  */
 static void
 pmap_page_remove(struct vm_page_md *md, paddr_t pa)
+{
 	struct l2_bucket *l2b;
 	struct pv_entry *pv;
 	pt_entry_t *ptep;
 #ifndef ARM_MMU_EXTENDED
 	bool flush = false;
 #endif
 	u_int flags = 0;
 	UVMHIST_FUNC(__func__);
 	UVMHIST_CALLARGS(maphist, "md %#jx pa %#jx", (uintptr_t)md, pa, 0, 0);
 	struct pv_entry **pvp = &SLIST_FIRST(&md->pvh_list);
 	pmap_acquire_page_lock(md);
 	if (*pvp == NULL) {
 #ifdef PMAP_CACHE_VIPT
 		/*
 		 * We *know* the page contents are about to be replaced.
 		 * Discard the exec contents
 		 */
 		if (PV_IS_EXEC_P(md->pvh_attrs))
 			PMAPCOUNT(exec_discarded_page_protect);
 		md->pvh_attrs &= ~PVF_EXEC;
 		PMAP_VALIDATE_MD_PAGE(md);
 #endif
 		pmap_release_page_lock(md);
 		return;
+	}
 #if defined(PMAP_CACHE_VIPT) && !defined(ARM_MMU_EXTENDED)
 	KASSERT(arm_cache_prefer_mask == 0 || pmap_is_page_colored_p(md));
 #endif
 	/*
 	 * Clear alias counts
 	 */
 #ifdef PMAP_CACHE_VIVT
 	md->k_mappings = 0;
 #endif
 	md->urw_mappings = md->uro_mappings = 0;
 #ifdef PMAP_CACHE_VIVT
 	pmap_clean_page(md, false);
 #endif
 	for (pv = *pvp; pv != NULL;) {
 		pmap_t pm = pv->pv_pmap;
 #ifndef ARM_MMU_EXTENDED
 		if (flush == false && pmap_is_current(pm))
 			flush = true;
 #endif
 #ifdef PMAP_CACHE_VIPT
 		if (pm == pmap_kernel() && PV_IS_KENTRY_P(pv->pv_flags)) {
 			/* If this was unmanaged mapping, it must be ignored. */
 			pvp = &SLIST_NEXT(pv, pv_link);
 			pv = *pvp;
 			continue;
+		}
 #endif
 		/*
 		 * Try to get a hold on the pmap's lock.  We must do this
 		 * while still holding the page locked, to know that the
 		 * page is still associated with the pmap and the mapping is
 		 * in place.  If a hold can't be had, unlock and wait for
 		 * the pmap's lock to become available and retry.  The pmap
 		 * must be ref'd over this dance to stop it disappearing
 		 * behind us.
 		 */
 		if (!mutex_tryenter(&pm->pm_lock)) {
 			pmap_reference(pm);
 			pmap_release_page_lock(md);
 			pmap_acquire_pmap_lock(pm);
 			/* nothing, just wait for it */
 			pmap_release_pmap_lock(pm);
 			pmap_destroy(pm);
 			/* Restart from the beginning. */
 			pmap_acquire_page_lock(md);
 			pvp = &SLIST_FIRST(&md->pvh_list);
 			pv = *pvp;
 			continue;
+		}
 		if (pm == pmap_kernel()) {
 #ifdef PMAP_CACHE_VIPT
 			if (pv->pv_flags & PVF_WRITE)
 				md->krw_mappings--;
 			else
 				md->kro_mappings--;
 #endif
 			PMAPCOUNT(kernel_unmappings);
+		}
 		*pvp = SLIST_NEXT(pv, pv_link); /* remove from list */
 		PMAPCOUNT(unmappings);
 		pmap_release_page_lock(md);
 		l2b = pmap_get_l2_bucket(pm, pv->pv_va);
 		KASSERTMSG(l2b != NULL, "%#lx", pv->pv_va);
 		ptep = &l2b->l2b_kva[l2pte_index(pv->pv_va)];
 		/*
 		 * Update statistics
 		 */
 		--pm->pm_stats.resident_count;
 		/* Wired bit */
 		if (pv->pv_flags & PVF_WIRED)
 			--pm->pm_stats.wired_count;
 		flags |= pv->pv_flags;
 		/*
 		 * Invalidate the PTEs.
 		 */
 		l2pte_reset(ptep);
 		PTE_SYNC_CURRENT(pm, ptep);
 #ifdef ARM_MMU_EXTENDED
 		pmap_tlb_invalidate_addr(pm, pv->pv_va);
 #endif
 		pmap_free_l2_bucket(pm, l2b, PAGE_SIZE / L2_S_SIZE);
 		pmap_release_pmap_lock(pm);
 		pool_put(&pmap_pv_pool, pv);
 		pmap_acquire_page_lock(md);
 		/*
 		 * Restart at the beginning of the list.
 		 */
 		pvp = &SLIST_FIRST(&md->pvh_list);
 		pv = *pvp;
+	}
 	/*
 	 * if we reach the end of the list and there are still mappings, they
 	 * might be able to be cached now.  And they must be kernel mappings.
 	 */
 	if (!SLIST_EMPTY(&md->pvh_list)) {
 		pmap_vac_me_harder(md, pa, pmap_kernel(), 0);
+	}
 #ifdef PMAP_CACHE_VIPT
 	/*
 	 * Its EXEC cache is now gone.
 	 */
 	if (PV_IS_EXEC_P(md->pvh_attrs))
 		PMAPCOUNT(exec_discarded_page_protect);
 	md->pvh_attrs &= ~PVF_EXEC;
 	KASSERT(md->urw_mappings == 0);
 	KASSERT(md->uro_mappings == 0);
 #ifndef ARM_MMU_EXTENDED
 	if (arm_cache_prefer_mask != 0) {
 		if (md->krw_mappings == 0)
 			md->pvh_attrs &= ~PVF_WRITE;
 		PMAP_VALIDATE_MD_PAGE(md);
+	}
 #endif /* ARM_MMU_EXTENDED */
 #endif /* PMAP_CACHE_VIPT */
 	pmap_release_page_lock(md);
 #ifndef ARM_MMU_EXTENDED
 	if (flush) {
 		/*
 		 * Note: We can't use pmap_tlb_flush{I,D}() here since that
 		 * would need a subsequent call to pmap_update() to ensure
 		 * curpm->pm_cstate.cs_all is reset. Our callers are not
 		 * required to do that (see pmap(9)), so we can't modify
 		 * the current pmap's state.
 		 */
 		if (PV_BEEN_EXECD(flags))
 			cpu_tlb_flushID();
 		else
 			cpu_tlb_flushD();
+	}
 	cpu_cpwait();
 #endif /* ARM_MMU_EXTENDED */
+}
 /*
  * pmap_t pmap_create(void)
+ *
  *      Create a new pmap structure from scratch.
  */
 pmap_t
 pmap_create(void)
+{
 	pmap_t pm;
 	pm = pool_cache_get(&pmap_cache, PR_WAITOK);
 	mutex_init(&pm->pm_lock, MUTEX_DEFAULT, IPL_NONE);
 	pm->pm_refs = 1;
 	pm->pm_stats.wired_count = 0;
 	pm->pm_stats.resident_count = 1;
 #ifdef ARM_MMU_EXTENDED
 #ifdef MULTIPROCESSOR
 	kcpuset_create(&pm->pm_active, true);
 	kcpuset_create(&pm->pm_onproc, true);
 #endif
 #else
 	pm->pm_cstate.cs_all = 0;
 #endif
 	pmap_alloc_l1(pm);
 	/*
 	 * Note: The pool cache ensures that the pm_l2[] array is already
 	 * initialised to zero.
 	 */
 	pmap_pinit(pm);
 	return pm;
+}
 u_int
 arm32_mmap_flags(paddr_t pa)
+{
 	/*
 	 * the upper 8 bits in pmap_enter()'s flags are reserved for MD stuff
 	 * and we're using the upper bits in page numbers to pass flags around
 	 * so we might as well use the same bits
 	 */
 	return (u_int)pa & PMAP_MD_MASK;
+}
 /*
  * int pmap_enter(pmap_t pm, vaddr_t va, paddr_t pa, vm_prot_t prot,
  *      u_int flags)
+ *
  *      Insert the given physical page (p) at
  *      the specified virtual address (v) in the
  *      target physical map with the protection requested.
+ *
  *      NB:  This is the only routine which MAY NOT lazy-evaluate
  *      or lose information.  That is, this routine must actually
  *      insert this page into the given map NOW.
  */
 int
 pmap_enter(pmap_t pm, vaddr_t va, paddr_t pa, vm_prot_t prot, u_int flags)
+{
 	struct l2_bucket *l2b;
 	struct vm_page *pg, *opg;
 	u_int nflags;
 	u_int oflags;
 	const bool kpm_p = (pm == pmap_kernel());
 #ifdef ARM_HAS_VBAR
 	const bool vector_page_p = false;
 #else
 	const bool vector_page_p = (va == vector_page);
 #endif
 	struct pmap_page *pp = pmap_pv_tracked(pa);
 	struct pv_entry *new_pv = NULL;
 	struct pv_entry *old_pv = NULL;
 	int error = 0;
 	UVMHIST_FUNC(__func__);
 	UVMHIST_CALLARGS(maphist, "pm %#jx va %#jx pa %#jx prot %#jx",
 	    (uintptr_t)pm, va, pa, prot);
 	UVMHIST_LOG(maphist, "  flag %#jx", flags, 0, 0, 0);
 	KDASSERT((flags & PMAP_WIRED) == 0 || (flags & VM_PROT_ALL) != 0);
 	KDASSERT(((va | pa) & PGOFSET) == 0);
 	/*
 	 * Get a pointer to the page.  Later on in this function, we
 	 * test for a managed page by checking pg != NULL.
 	 */
 	pg = pmap_initialized ? PHYS_TO_VM_PAGE(pa) : NULL;
 	/*
 	 * if we may need a new pv entry allocate if now, as we can't do it
 	 * with the kernel_pmap locked
 	 */
 	if (pg || pp)
 		new_pv = pool_get(&pmap_pv_pool, PR_NOWAIT);
 	nflags = 0;
 	if (prot & VM_PROT_WRITE)
 		nflags |= PVF_WRITE;
 	if (prot & VM_PROT_EXECUTE)
 		nflags |= PVF_EXEC;
 	if (flags & PMAP_WIRED)
 		nflags |= PVF_WIRED;
 	pmap_acquire_pmap_lock(pm);
 	/*
 	 * Fetch the L2 bucket which maps this page, allocating one if
 	 * necessary for user pmaps.
 	 */
 	if (kpm_p) {
 		l2b = pmap_get_l2_bucket(pm, va);
 	} else {
 		l2b = pmap_alloc_l2_bucket(pm, va);
+	}
 	if (l2b == NULL) {
 		if (flags & PMAP_CANFAIL) {
 			pmap_release_pmap_lock(pm);
 			error = ENOMEM;
 			goto free_pv;
+		}
 		panic("pmap_enter: failed to allocate L2 bucket");
+	}
 	pt_entry_t *ptep = &l2b->l2b_kva[l2pte_index(va)];
 	const pt_entry_t opte = *ptep;
 	pt_entry_t npte = pa;
 	oflags = 0;
 	if (opte) {
 		/*
 		 * There is already a mapping at this address.
 		 * If the physical address is different, lookup the
 		 * vm_page.
 		 */
 		if (l2pte_pa(opte) != pa) {
 			KASSERT(!pmap_pv_tracked(pa));
 			opg = PHYS_TO_VM_PAGE(l2pte_pa(opte));
 		} else
 			opg = pg;
 	} else
 		opg = NULL;
 	if (pg || pp) {
 		KASSERT((pg != NULL) != (pp != NULL));
 		struct vm_page_md *md = (pg != NULL) ? VM_PAGE_TO_MD(pg) :
 		    PMAP_PAGE_TO_MD(pp);
 		/*
 		 * This is to be a managed mapping.
 		 */
 		pmap_acquire_page_lock(md);
 		if ((flags & VM_PROT_ALL) || (md->pvh_attrs & PVF_REF)) {
 			/*
 			 * - The access type indicates that we don't need
 			 *   to do referenced emulation.
 			 * OR
 			 * - The physical page has already been referenced
 			 *   so no need to re-do referenced emulation here.
 			 */
 			npte |= l2pte_set_readonly(L2_S_PROTO);
 			nflags |= PVF_REF;
 			if ((prot & VM_PROT_WRITE) != 0 &&
 			    ((flags & VM_PROT_WRITE) != 0 ||
 			     (md->pvh_attrs & PVF_MOD) != 0)) {
 				/*
 				 * This is a writable mapping, and the
 				 * page's mod state indicates it has
 				 * already been modified. Make it
 				 * writable from the outset.
 				 */
 				npte = l2pte_set_writable(npte);
 				nflags |= PVF_MOD;
+			}
 #ifdef ARM_MMU_EXTENDED
 			/*
 			 * If the page has been cleaned, then the pvh_attrs
 			 * will have PVF_EXEC set, so mark it execute so we
 			 * don't get an access fault when trying to execute
 			 * from it.
 			 */
 			if (md->pvh_attrs & nflags & PVF_EXEC) {
 				npte &= ~L2_XS_XN;
+			}
 #endif
 		} else {
 			/*
 			 * Need to do page referenced emulation.
 			 */
 			npte |= L2_TYPE_INV;
+		}
 		if (flags & ARM32_MMAP_WRITECOMBINE) {
 			npte |= pte_l2_s_wc_mode;
 		} else
 			npte |= pte_l2_s_cache_mode;
 		if (pg != NULL && pg == opg) {
 			/*
 			 * We're changing the attrs of an existing mapping.
 			 */
 			oflags = pmap_modify_pv(md, pa, pm, va,
 			    PVF_WRITE | PVF_EXEC | PVF_WIRED |
 			    PVF_MOD | PVF_REF, nflags);
 #ifdef PMAP_CACHE_VIVT
 			/*
 			 * We may need to flush the cache if we're
 			 * doing rw-ro...
 			 */
 			if (pm->pm_cstate.cs_cache_d &&
 			    (oflags & PVF_NC) == 0 &&
 			    l2pte_writable_p(opte) &&
 			    (prot & VM_PROT_WRITE) == 0)
 				cpu_dcache_wb_range(va, PAGE_SIZE);
 #endif
 		} else {
 			struct pv_entry *pv;
 			/*
 			 * New mapping, or changing the backing page
 			 * of an existing mapping.
 			 */
 			if (opg) {
 				struct vm_page_md *omd = VM_PAGE_TO_MD(opg);
 				paddr_t opa = VM_PAGE_TO_PHYS(opg);
 				/*
 				 * Replacing an existing mapping with a new one.
 				 * It is part of our managed memory so we
 				 * must remove it from the PV list
 				 */
 				pv = pmap_remove_pv(omd, opa, pm, va);
 				pmap_vac_me_harder(omd, opa, pm, 0);
 				oflags = pv->pv_flags;
 #ifdef PMAP_CACHE_VIVT
 				/*
 				 * If the old mapping was valid (ref/mod
 				 * emulation creates 'invalid' mappings
 				 * initially) then make sure to frob
 				 * the cache.
 				 */
 				if (!(oflags & PVF_NC) && l2pte_valid_p(opte)) {
 					pmap_cache_wbinv_page(pm, va, true,
 					    oflags);
+				}
 #endif
 			} else {
 				pv = new_pv;
 				new_pv = NULL;
 				if (pv == NULL) {
 					pmap_release_page_lock(md);
 					pmap_release_pmap_lock(pm);
 					if ((flags & PMAP_CANFAIL) == 0)
 						panic("pmap_enter: "
 						    "no pv entries");
 					pmap_free_l2_bucket(pm, l2b, 0);
 					UVMHIST_LOG(maphist, "  <-- done (ENOMEM)",
 , 0, 0, 0);
 					return ENOMEM;
+				}
+			}
 			pmap_enter_pv(md, pa, pv, pm, va, nflags);
+		}
 		pmap_release_page_lock(md);
 	} else {
 		/*
 		 * We're mapping an unmanaged page.
 		 * These are always readable, and possibly writable, from
 		 * the get go as we don't need to track ref/mod status.
 		 */
 		npte |= l2pte_set_readonly(L2_S_PROTO);
 		if (prot & VM_PROT_WRITE)
 			npte = l2pte_set_writable(npte);
 		/*
 		 * Make sure the vector table is mapped cacheable
 		 */
 		if ((vector_page_p && !kpm_p)
 		    || (flags & ARM32_MMAP_CACHEABLE)) {
 			npte |= pte_l2_s_cache_mode;
 #ifdef ARM_MMU_EXTENDED
 			npte &= ~L2_XS_XN;	/* and executable */
 #endif
 		} else if (flags & ARM32_MMAP_WRITECOMBINE) {
 			npte |= pte_l2_s_wc_mode;
+		}
 		if (opg) {
 			/*
 			 * Looks like there's an existing 'managed' mapping
 			 * at this address.
 			 */
 			struct vm_page_md *omd = VM_PAGE_TO_MD(opg);
 			paddr_t opa = VM_PAGE_TO_PHYS(opg);
 			pmap_acquire_page_lock(omd);
 			old_pv = pmap_remove_pv(omd, opa, pm, va);
 			pmap_vac_me_harder(omd, opa, pm, 0);
 			oflags = old_pv->pv_flags;
 			pmap_release_page_lock(omd);
 #ifdef PMAP_CACHE_VIVT
 			if (!(oflags & PVF_NC) && l2pte_valid_p(opte)) {
 				pmap_cache_wbinv_page(pm, va, true, oflags);
+			}
 #endif
+		}
+	}
 	/*
 	 * Make sure userland mappings get the right permissions
 	 */
 	if (!vector_page_p && !kpm_p) {
 		npte |= L2_S_PROT_U;
 #ifdef ARM_MMU_EXTENDED
 		npte |= L2_XS_nG;	/* user pages are not global */
 #endif
+	}
 	/*
 	 * Keep the stats up to date
 	 */
 	if (opte == 0) {
 		l2b->l2b_occupancy += PAGE_SIZE / L2_S_SIZE;
 		pm->pm_stats.resident_count++;
+	}
 	UVMHIST_LOG(maphist, " opte %#jx npte %#jx", opte, npte, 0, 0);
 #if defined(ARM_MMU_EXTENDED)
 	/*
 	 * If exec protection was requested but the page hasn't been synced,
 	 * sync it now and allow execution from it.
 	 */
 	if ((nflags & PVF_EXEC) && (npte & L2_XS_XN)) {
 		struct vm_page_md *md = VM_PAGE_TO_MD(pg);
 		npte &= ~L2_XS_XN;
 		pmap_syncicache_page(md, pa);
 		PMAPCOUNT(exec_synced_map);
+	}
 #endif
 	/*
 	 * If this is just a wiring change, the two PTEs will be
 	 * identical, so there's no need to update the page table.
 	 */
 	if (npte != opte) {
 		l2pte_reset(ptep);
 		PTE_SYNC(ptep);
 		if (l2pte_valid_p(opte)) {
 			pmap_tlb_flush_SE(pm, va, oflags);
+		}
 		l2pte_set(ptep, npte, 0);
 		PTE_SYNC(ptep);
 #ifndef ARM_MMU_EXTENDED
 		bool is_cached = pmap_is_cached(pm);
 		if (is_cached) {
 			/*
 			 * We only need to frob the cache/tlb if this pmap
 			 * is current
 			 */
 			if (!vector_page_p && l2pte_valid_p(npte)) {
 				/*
 				 * This mapping is likely to be accessed as