Sat Jun 27 13:53:43 2020 UTC ()
Add also a test that writes random garbage to every ifconfig(8) option that
takes parameters. Based on quick testing, iwn(4) and wm(4) pass, but
urtwn(4) panics. Use at your own risk; in some cases, it may be possible
that horrors are written directly to the hardware.


(jruoho)
diff -r1.860 -r1.861 src/distrib/sets/lists/tests/mi
diff -r1.7 -r1.8 src/tests/sbin/ifconfig/Makefile
diff -r0 -r1.1 src/tests/sbin/ifconfig/t_random_garbage.sh

cvs diff -r1.860 -r1.861 src/distrib/sets/lists/tests/mi (expand / switch to unified diff)

--- src/distrib/sets/lists/tests/mi 2020/06/27 10:15:50 1.860
+++ src/distrib/sets/lists/tests/mi 2020/06/27 13:53:43 1.861
@@ -1,14 +1,14 @@ @@ -1,14 +1,14 @@
1# $NetBSD: mi,v 1.860 2020/06/27 10:15:50 jruoho Exp $ 1# $NetBSD: mi,v 1.861 2020/06/27 13:53:43 jruoho Exp $
2# 2#
3# Note: don't delete entries from here - mark them as "obsolete" instead. 3# Note: don't delete entries from here - mark them as "obsolete" instead.
4# 4#
5./etc/mtree/set.tests tests-sys-root 5./etc/mtree/set.tests tests-sys-root
6./usr/libdata/debug/usr/tests tests-base-debug compattestdir 6./usr/libdata/debug/usr/tests tests-base-debug compattestdir
7./usr/libdata/debug/usr/tests/atf tests-atf-debug compattestfile,atf 7./usr/libdata/debug/usr/tests/atf tests-atf-debug compattestfile,atf
8./usr/libdata/debug/usr/tests/atf/atf-c tests-atf-debug compattestfile,atf 8./usr/libdata/debug/usr/tests/atf/atf-c tests-atf-debug compattestfile,atf
9./usr/libdata/debug/usr/tests/atf/atf-c++ tests-atf-debug compattestfile,atf 9./usr/libdata/debug/usr/tests/atf/atf-c++ tests-atf-debug compattestfile,atf
10./usr/libdata/debug/usr/tests/atf/atf-c++/detail tests-atf-debug compattestfile,atf 10./usr/libdata/debug/usr/tests/atf/atf-c++/detail tests-atf-debug compattestfile,atf
11./usr/libdata/debug/usr/tests/atf/atf-c/detail tests-atf-debug compattestfile,atf 11./usr/libdata/debug/usr/tests/atf/atf-c/detail tests-atf-debug compattestfile,atf
12./usr/libdata/debug/usr/tests/atf/atf-compile tests-obsolete obsolete 12./usr/libdata/debug/usr/tests/atf/atf-compile tests-obsolete obsolete
13./usr/libdata/debug/usr/tests/atf/atf-report tests-obsolete obsolete 13./usr/libdata/debug/usr/tests/atf/atf-report tests-obsolete obsolete
14./usr/libdata/debug/usr/tests/atf/atf-run tests-obsolete obsolete 14./usr/libdata/debug/usr/tests/atf/atf-run tests-obsolete obsolete
@@ -3989,26 +3989,27 @@ @@ -3989,26 +3989,27 @@
3989./usr/tests/sbin/gpt/gpt.disklabel tests-sbin-tests compattestfile,atf 3989./usr/tests/sbin/gpt/gpt.disklabel tests-sbin-tests compattestfile,atf
3990./usr/tests/sbin/gpt/gpt.disklabel.show.normal tests-sbin-tests compattestfile,atf 3990./usr/tests/sbin/gpt/gpt.disklabel.show.normal tests-sbin-tests compattestfile,atf
3991./usr/tests/sbin/gpt/gpt.empty.show.normal tests-sbin-tests compattestfile,atf 3991./usr/tests/sbin/gpt/gpt.empty.show.normal tests-sbin-tests compattestfile,atf
3992./usr/tests/sbin/gpt/gpt.removepart.show.normal tests-sbin-tests compattestfile,atf 3992./usr/tests/sbin/gpt/gpt.removepart.show.normal tests-sbin-tests compattestfile,atf
3993./usr/tests/sbin/gpt/gpt.resizedisk.show.normal tests-sbin-tests compattestfile,atf 3993./usr/tests/sbin/gpt/gpt.resizedisk.show.normal tests-sbin-tests compattestfile,atf
3994./usr/tests/sbin/gpt/gpt.resizepart.show.normal tests-sbin-tests compattestfile,atf 3994./usr/tests/sbin/gpt/gpt.resizepart.show.normal tests-sbin-tests compattestfile,atf
3995./usr/tests/sbin/gpt/t_gpt tests-sbin-tests compattestfile,atf 3995./usr/tests/sbin/gpt/t_gpt tests-sbin-tests compattestfile,atf
3996./usr/tests/sbin/ifconfig tests-sbin-tests compattestfile,atf 3996./usr/tests/sbin/ifconfig tests-sbin-tests compattestfile,atf
3997./usr/tests/sbin/ifconfig/Atffile tests-sbin-tests compattestfile,atf 3997./usr/tests/sbin/ifconfig/Atffile tests-sbin-tests compattestfile,atf
3998./usr/tests/sbin/ifconfig/Kyuafile tests-sbin-tests compattestfile,atf,kyua 3998./usr/tests/sbin/ifconfig/Kyuafile tests-sbin-tests compattestfile,atf,kyua
3999./usr/tests/sbin/ifconfig/t_bridge tests-sbin-tests compattestfile,atf 3999./usr/tests/sbin/ifconfig/t_bridge tests-sbin-tests compattestfile,atf
4000./usr/tests/sbin/ifconfig/t_capabilities tests-sbin-tests compattestfile,atf 4000./usr/tests/sbin/ifconfig/t_capabilities tests-sbin-tests compattestfile,atf
4001./usr/tests/sbin/ifconfig/t_nonexistent tests-sbin-tests compattestfile,atf 4001./usr/tests/sbin/ifconfig/t_nonexistent tests-sbin-tests compattestfile,atf
 4002./usr/tests/sbin/ifconfig/t_random_garbage tests-sbin-tests compattestfile,atf
4002./usr/tests/sbin/ifconfig/t_repeated_scan tests-sbin-tests compattestfile,atf 4003./usr/tests/sbin/ifconfig/t_repeated_scan tests-sbin-tests compattestfile,atf
4003./usr/tests/sbin/ifconfig/t_repeated_updown tests-sbin-tests compattestfile,atf 4004./usr/tests/sbin/ifconfig/t_repeated_updown tests-sbin-tests compattestfile,atf
4004./usr/tests/sbin/ifconfig/t_tap tests-sbin-tests compattestfile,atf 4005./usr/tests/sbin/ifconfig/t_tap tests-sbin-tests compattestfile,atf
4005./usr/tests/sbin/ifconfig/t_woptions tests-sbin-tests compattestfile,atf 4006./usr/tests/sbin/ifconfig/t_woptions tests-sbin-tests compattestfile,atf
4006./usr/tests/sbin/newfs tests-sbin-tests compattestfile,atf 4007./usr/tests/sbin/newfs tests-sbin-tests compattestfile,atf
4007./usr/tests/sbin/newfs/Atffile tests-sbin-tests compattestfile,atf 4008./usr/tests/sbin/newfs/Atffile tests-sbin-tests compattestfile,atf
4008./usr/tests/sbin/newfs/Kyuafile tests-sbin-tests compattestfile,atf,kyua 4009./usr/tests/sbin/newfs/Kyuafile tests-sbin-tests compattestfile,atf,kyua
4009./usr/tests/sbin/newfs/t_enable_quotas tests-sbin-tests compattestfile,atf 4010./usr/tests/sbin/newfs/t_enable_quotas tests-sbin-tests compattestfile,atf
4010./usr/tests/sbin/newfs_msdos tests-sbin-tests compattestfile,atf 4011./usr/tests/sbin/newfs_msdos tests-sbin-tests compattestfile,atf
4011./usr/tests/sbin/newfs_msdos/Atffile tests-sbin-tests compattestfile,atf 4012./usr/tests/sbin/newfs_msdos/Atffile tests-sbin-tests compattestfile,atf
4012./usr/tests/sbin/newfs_msdos/Kyuafile tests-sbin-tests compattestfile,atf,kyua 4013./usr/tests/sbin/newfs_msdos/Kyuafile tests-sbin-tests compattestfile,atf,kyua
4013./usr/tests/sbin/newfs_msdos/t_create tests-sbin-tests compattestfile,atf 4014./usr/tests/sbin/newfs_msdos/t_create tests-sbin-tests compattestfile,atf
4014./usr/tests/sbin/resize_ffs tests-sbin-tests compattestfile,atf 4015./usr/tests/sbin/resize_ffs tests-sbin-tests compattestfile,atf

cvs diff -r1.7 -r1.8 src/tests/sbin/ifconfig/Makefile (expand / switch to unified diff)

--- src/tests/sbin/ifconfig/Makefile 2020/06/27 06:57:44 1.7
+++ src/tests/sbin/ifconfig/Makefile 2020/06/27 13:53:43 1.8
@@ -1,15 +1,16 @@ @@ -1,15 +1,16 @@
1# $NetBSD: Makefile,v 1.7 2020/06/27 06:57:44 jruoho Exp $ 1# $NetBSD: Makefile,v 1.8 2020/06/27 13:53:43 jruoho Exp $
2 2
3.include <bsd.own.mk> 3.include <bsd.own.mk>
4 4
5TESTSDIR= ${TESTSBASE}/sbin/ifconfig 5TESTSDIR= ${TESTSBASE}/sbin/ifconfig
6 6
7TESTS_SH= t_bridge \ 7TESTS_SH= t_bridge \
8 t_capabilities \ 8 t_capabilities \
9 t_nonexistent \ 9 t_nonexistent \
 10 t_random_garbage \
10 t_repeated_scan \ 11 t_repeated_scan \
11 t_repeated_updown \ 12 t_repeated_updown \
12 t_tap \ 13 t_tap \
13 t_woptions 14 t_woptions
14 15
15.include <bsd.test.mk> 16.include <bsd.test.mk>

File Added: src/tests/sbin/ifconfig/t_random_garbage.sh
# $NetBSD: t_random_garbage.sh,v 1.1 2020/06/27 13:53:43 jruoho Exp $
#
# Copyright (c) 2020 The NetBSD Foundation, Inc.
# All rights reserved.
#
# This code is derived from software contributed to The NetBSD Foundation
# by Jukka Ruohonen.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions
# are met:
# 1. Redistributions of source code must retain the above copyright
#    notice, this list of conditions and the following disclaimer.
# 2. Redistributions in binary form must reproduce the above copyright
#    notice, this list of conditions and the following disclaimer in the
#    documentation and/or other materials provided with the distribution.
#
# THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
# ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
# TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
# PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
# POSSIBILITY OF SUCH DAMAGE.
#
getrint() {
	echo $(od -An -N2 -i /dev/urandom | sed 's/ //')
}

getrstr() {
	echo $(cat /dev/urandom | head -n 1 | base64)
}

write_garbage() {
	val=$(getrint)
	echo "Test $3: write to $1 opt $2 -> $val"
	ifconfig $1 $opt $val >/dev/null 2>&1
	val=$(getrstr)
	echo "Test $3: write to $1 opt $2 -> $val"
	ifconfig $1 $opt $val >/dev/null 2>&1
}

atf_test_case random_garbage
random_garbage_head() {
	atf_set "require.user" "root"
	atf_set "descr" "Test writing random garbage to ifconfig(8) options"
}

random_garbage_body() {

	# Please note:
	#
	# 1. As some drivers seem to have input validation issues, it may
	#    be possible that horrors are written directly to the hardware.
	#
	# 2. Even if the test passes, there is no easy way to restore
	#    the existing state/configuration of any given interface.
	#
	# Take care.
	#
	atf_skip "The test is not safe"

	opts="advbase advskew broadcast carpdev description \
	      media mediaopt -mediaopt mode instance metric mtu \
	      netmask state frag rts ssid nwid nwkey pass powersavesleep \
	      bssid chan tunnel session cookie pltime prefixlen linkstr \
	      vhid vlan vlanif -vlanif agrport -agrport vltime maxupd \
	      syncdev syncpeer"

	for i in $(ifconfig -l); do

		ifconfig $i up

		for o in $opts; do

			n=10

			while [ $n -gt 0 ]; do
				write_garbage $i $o $n
				n=$(expr $n - 1)
			done
		done
	done

	atf_pass
}

atf_init_test_cases() {
	atf_add_test_case random_garbage
}