 @@ -1,14 +1,14 @@
-/* $NetBSD: ciphy.c,v 1.39 2020/03/15 23:04:50 thorpej Exp $ */
+/* $NetBSD: ciphy.c,v 1.40 2020/07/07 08:44:12 msaitoh Exp $ */
 /*-
  * Copyright (c) 2004
  *	Bill Paul <wpaul@windriver.com>.  All rights reserved.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
 @@ -25,27 +25,27 @@
  * ARE DISCLAIMED.  IN NO EVENT SHALL Bill Paul OR THE VOICES IN HIS HEAD
  * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
  * THE POSSIBILITY OF SUCH DAMAGE.
+ *
  * FreeBSD: src/sys/dev/mii/ciphy.c,v 1.2 2005/01/06 01:42:55 imp Exp
  */
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ciphy.c,v 1.39 2020/03/15 23:04:50 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ciphy.c,v 1.40 2020/07/07 08:44:12 msaitoh Exp $");
 /*
  * Driver for the Cicada CS8201 10/100/1000 copper PHY.
  */
 #include <sys/param.h>
 #include <sys/systm.h>
 #include <sys/device.h>
 #include <sys/kernel.h>
 #include <sys/socket.h>
 #include <sys/bus.h>
 #include <net/if.h>
 @@ -163,27 +163,27 @@ ciphy_service(struct mii_softc *sc, stru
 		if ((mii->mii_ifp->if_flags & IFF_UP) == 0)
 			break;
 		ciphy_fixup(sc);	/* XXX hardware bug work-around */
 		switch (IFM_SUBTYPE(ife->ifm_media)) {
 		case IFM_AUTO:
 #ifdef foo
 			/* If we're already in auto mode, just return. */
 			PHY_READ(sc, MII_BMCR, &reg);
 			if (reg & BMCR_AUTOEN)
 				return 0;
 #endif
-			(void) mii_phy_auto(sc, 0);
+			(void) mii_phy_auto(sc);
 			break;
 		case IFM_1000_T:
 			speed = BMCR_S1000;
 			goto setit;
 		case IFM_100_TX:
 			speed = BMCR_S100;
 			goto setit;
 		case IFM_10_T:
 			speed = BMCR_S10;
 setit:
 			if ((ife->ifm_media & IFM_FDX) != 0) {
 				speed |= BMCR_FDX;
 				gig = GTCR_ADV_1000TFDX;
 @@ -263,27 +263,27 @@ setit:
 		/*
 		 * mii_ticks == 0 means it's the first tick after changing the
 		 * media or the link became down since the last tick
 		 * (see above), so return with 0 to update the status.
 		 */
 		if (sc->mii_ticks++ == 0)
 			break;
 		/* Only retry autonegotiation every N seconds. */
 		if (sc->mii_ticks <= sc->mii_anegticks)
 			break;
-		mii_phy_auto(sc, 0);
+		mii_phy_auto(sc);
 		return 0;
+	}
 	/* Update the media status. */
 	ciphy_status(sc);
 	/*
 	 * Callback if something changed. Note that we need to poke
 	 * apply fixups for certain PHY revs.
 	 */
 	if (sc->mii_media_active != mii->mii_media_active ||
 	    sc->mii_media_status != mii->mii_media_status ||
 	    cmd == MII_MEDIACHG) {

 @@ -1,14 +1,14 @@
-/*	$NetBSD: igphy.c,v 1.33 2020/03/15 23:04:50 thorpej Exp $	*/
+/*	$NetBSD: igphy.c,v 1.34 2020/07/07 08:44:12 msaitoh Exp $	*/
 /*
  * The Intel copyright applies to the analog register setup, and the
  * SmartSpeed workaround code.
  */
 /*******************************************************************************
   Copyright (c) 2001-2003, Intel Corporation
   All rights reserved.
   Redistribution and use in source and binary forms, with or without
   modification, are permitted provided that the following conditions are met:
 @@ -60,27 +60,27 @@
  * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
  * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
  * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
  * POSSIBILITY OF SUCH DAMAGE.
  */
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: igphy.c,v 1.33 2020/03/15 23:04:50 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: igphy.c,v 1.34 2020/07/07 08:44:12 msaitoh Exp $");
 #ifdef _KERNEL_OPT
 #include "opt_mii.h"
 #endif
 #include <sys/param.h>
 #include <sys/systm.h>
 #include <sys/kernel.h>
 #include <sys/device.h>
 #include <sys/socket.h>
 #include <sys/errno.h>
 #include <net/if.h>
 @@ -513,30 +513,30 @@ igphy_smartspeed_workaround(struct mii_s
 	if ((reg & BMSR_LINK) == 0) {
 		switch (igsc->sc_smartspeed) {
 		case 0:
 			PHY_READ(sc, MII_100T2SR, &gtsr);
 			if (!(gtsr & GTSR_MAN_MS_FLT))
 				break;
 			PHY_READ(sc, MII_100T2SR, &gtsr);
 			if (gtsr & GTSR_MAN_MS_FLT) {
 				PHY_READ(sc, MII_100T2CR, &gtcr);
 				if (gtcr & GTCR_MAN_MS) {
 					gtcr &= ~GTCR_MAN_MS;
 					PHY_WRITE(sc, MII_100T2CR, gtcr);
+				}
-				mii_phy_auto(sc, 0);
+				mii_phy_auto(sc);
+			}
 			break;
 		case IGPHY_TICK_DOWNSHIFT:
 			PHY_READ(sc, MII_100T2CR, &gtcr);
 			gtcr |= GTCR_MAN_MS;
 			PHY_WRITE(sc, MII_100T2CR, gtcr);
-			mii_phy_auto(sc, 0);
+			mii_phy_auto(sc);
 			break;
 		default:
 			break;
+		}
 		if (igsc->sc_smartspeed++ == IGPHY_TICK_MAX)
 			igsc->sc_smartspeed = 0;
 	} else
 		igsc->sc_smartspeed = 0;
+}

 @@ -1,14 +1,14 @@
-/*	$NetBSD: mii_physubr.c,v 1.90 2020/03/15 23:04:50 thorpej Exp $	*/
+/*	$NetBSD: mii_physubr.c,v 1.91 2020/07/07 08:44:12 msaitoh Exp $	*/
 /*-
  * Copyright (c) 1998, 1999, 2000, 2001 The NetBSD Foundation, Inc.
  * All rights reserved.
+ *
  * This code is derived from software contributed to The NetBSD Foundation
  * by Jason R. Thorpe of the Numerical Aerospace Simulation Facility,
  * NASA Ames Research Center.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
 @@ -25,27 +25,27 @@
  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
  * POSSIBILITY OF SUCH DAMAGE.
  */
 /*
  * Subroutines common to all PHYs.
  */
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: mii_physubr.c,v 1.90 2020/03/15 23:04:50 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: mii_physubr.c,v 1.91 2020/07/07 08:44:12 msaitoh Exp $");
 #include <sys/param.h>
 #include <sys/device.h>
 #include <sys/systm.h>
 #include <sys/kernel.h>
 #include <sys/socket.h>
 #include <sys/errno.h>
 #include <sys/module.h>
 #include <sys/proc.h>
 #include <net/if.h>
 #include <net/if_media.h>
 #include <net/route.h>
 @@ -137,27 +137,27 @@ mii_phy_setmedia(struct mii_softc *sc)
 	KASSERT(mii_locked(mii));
 	if (IFM_SUBTYPE(ife->ifm_media) == IFM_AUTO) {
 		/*
 		 * Force renegotiation if MIIF_DOPAUSE.
+		 *
 		 * XXX This is only necessary because many NICs don't
 		 * XXX advertise PAUSE capabilities at boot time.  Maybe
 		 * XXX we should force this only once?
 		 */
 		PHY_READ(sc, MII_BMCR, &bmcr);
 		if ((bmcr & BMCR_AUTOEN) == 0 ||
 		    (sc->mii_flags & (MIIF_FORCEANEG | MIIF_DOPAUSE)))
-			(void) mii_phy_auto(sc, 1);
+			(void) mii_phy_auto(sc);
 		return;
+	}
 	/* Table index is stored in the media entry. */
 #ifdef DIAGNOSTIC
 	if (/* ife->ifm_data < 0 || */ ife->ifm_data >= MII_NMEDIA)
 		panic("mii_phy_setmedia");
 #endif
 	anar = mii_media_table[ife->ifm_data].mm_anar;
 	bmcr = mii_media_table[ife->ifm_data].mm_bmcr;
 	gtcr = mii_media_table[ife->ifm_data].mm_gtcr;
 @@ -183,35 +183,34 @@ mii_phy_setmedia(struct mii_softc *sc)
 			    (sc->mii_extcapabilities &
 			     (EXTSR_1000THDX | EXTSR_1000TFDX)))
 				anar |= ANAR_PAUSE_ASYM;
+		}
+	}
 	if (ife->ifm_media & IFM_LOOP)
 		bmcr |= BMCR_LOOP;
 	PHY_WRITE(sc, MII_ANAR, anar);
 	if (sc->mii_flags & MIIF_HAVE_GTCR)
 		PHY_WRITE(sc, MII_100T2CR, gtcr);
 	if (IFM_SUBTYPE(ife->ifm_media) == IFM_1000_T)
-		mii_phy_auto(sc, 0);
+		mii_phy_auto(sc);
 	else
 		PHY_WRITE(sc, MII_BMCR, bmcr);
+}
 int
-mii_phy_auto(struct mii_softc *sc, int waitfor)
+mii_phy_auto(struct mii_softc *sc)
+{
 	int i;
 	struct mii_data *mii = sc->mii_pdata;
 	struct ifmedia_entry *ife = mii->mii_media.ifm_cur;
 	KASSERT(mii_locked(mii));
 	sc->mii_ticks = 0;
 	if ((sc->mii_flags & MIIF_DOINGAUTO) == 0) {
 		/*
 		 * Check for 1000BASE-X.  Autonegotiation is a bit
 		 * different on such devices.
 		 */
 		if (sc->mii_flags & MIIF_IS_1000X) {
 			uint16_t anar = 0;
 @@ -256,69 +255,51 @@ mii_phy_auto(struct mii_softc *sc, int w
 				uint16_t gtcr = 0;
 				if (sc->mii_extcapabilities & EXTSR_1000TFDX)
 					gtcr |= GTCR_ADV_1000TFDX;
 				if (sc->mii_extcapabilities & EXTSR_1000THDX)
 					gtcr |= GTCR_ADV_1000THDX;
 				PHY_WRITE(sc, MII_100T2CR, gtcr);
+			}
+		}
 		PHY_WRITE(sc, MII_BMCR, BMCR_AUTOEN | BMCR_STARTNEG);
+	}
 	if (waitfor) {
 		/* Wait 500ms for it to complete. */
 		for (i = 0; i < 500; i++) {
 			uint16_t bmsr;
 			PHY_READ(sc, MII_BMSR, &bmsr);
 			if (bmsr & BMSR_ACOMP)
 				return 0;
 			delay(1000);
 		/*
 		 * Don't need to worry about clearing MIIF_DOINGAUTO. If that's
 		 * set, a timeout is pending, and it will clear the flag.
 		 */
 		return EIO;
 	/*
 	 * Just let it finish asynchronously.  This is for the benefit of
 	 * the tick handler driving autonegotiation.  Don't want 500ms
 	 * delays all the time while the system is running!
 	 */
 	if (sc->mii_flags & MIIF_AUTOTSLEEP) {
 		ASSERT_SLEEPABLE();
 		sc->mii_flags |= MIIF_DOINGAUTO;
 		kpause("miiaut", false, hz >> 1, mii->mii_media.ifm_lock);
 		mii_phy_auto_timeout_locked(sc);
 	} else if ((sc->mii_flags & MIIF_DOINGAUTO) == 0) {
 		sc->mii_flags |= MIIF_DOINGAUTO;
 		callout_reset(&sc->mii_nway_ch, hz >> 1,
 		    mii_phy_auto_timeout, sc);
+	}
 	return EJUSTRETURN;
+}
 static void
 mii_phy_auto_timeout_locked(struct mii_softc *sc)
+{
 	if (!device_is_active(sc->mii_dev))
 		return;
 	sc->mii_flags &= ~MIIF_DOINGAUTO;
 	/* Update the media status. */
 	(void) PHY_SERVICE(sc, sc->mii_pdata, MII_POLLSTAT);
+}
 static void
 mii_phy_auto_timeout(void *arg)
+{
 	struct mii_softc *sc = arg;
 	if (!device_is_active(sc->mii_dev))
 		return;
 @@ -376,27 +357,27 @@ mii_phy_tick(struct mii_softc *sc)
 	 */
 	if (sc->mii_ticks++ == 0)
 		return 0;
 	/*
 	 * Only retry autonegotiation every N seconds.
 	 */
 	KASSERT(sc->mii_anegticks != 0);
 	if (sc->mii_ticks <= sc->mii_anegticks)
 		return EJUSTRETURN;
 	PHY_RESET(sc);
-	if (mii_phy_auto(sc, 0) == EJUSTRETURN)
+	if (mii_phy_auto(sc) == EJUSTRETURN)
 		return EJUSTRETURN;
 	/*
 	 * Might need to generate a status message if autonegotiation
 	 * failed.
 	 */
 	return 0;
+}
 void
 mii_phy_reset(struct mii_softc *sc)
+{
 	int i;

 @@ -1,14 +1,14 @@
-/*	$NetBSD: miivar.h,v 1.71 2020/05/25 19:47:58 jmcneill Exp $	*/
+/*	$NetBSD: miivar.h,v 1.72 2020/07/07 08:44:12 msaitoh Exp $	*/
 /*-
  * Copyright (c) 1998, 1999, 2000, 2001, 2020 The NetBSD Foundation, Inc.
  * All rights reserved.
+ *
  * This code is derived from software contributed to The NetBSD Foundation
  * by Jason R. Thorpe of the Numerical Aerospace Simulation Facility,
  * NASA Ames Research Center.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
 @@ -321,27 +321,27 @@ uint16_t mii_anar(struct ifmedia_entry *
 int	mii_phy_activate(device_t, enum devact);
 int	mii_phy_detach(device_t, int);
 bool	mii_phy_resume(device_t, const pmf_qual_t *);
 const struct mii_phydesc *mii_phy_match(const struct mii_attach_args *,
 	    const struct mii_phydesc *);
 /* MII must be UNLOCKED */
 void	mii_phy_add_media(struct mii_softc *);
 void	mii_phy_delete_media(struct mii_softc *);
 /* MII must be LOCKED */
 void	mii_phy_setmedia(struct mii_softc *);
-int	mii_phy_auto(struct mii_softc *, int);
+int	mii_phy_auto(struct mii_softc *);
 void	mii_phy_reset(struct mii_softc *);
 void	mii_phy_down(struct mii_softc *);
 int	mii_phy_tick(struct mii_softc *);
 /* MII must be LOCKED */
 void	mii_phy_status(struct mii_softc *);
 void	mii_phy_update(struct mii_softc *, int);
 /* MII must be LOCKED */
 u_int	mii_phy_flowstatus(struct mii_softc *);
 /* MII must be LOCKED */
 void	ukphy_status(struct mii_softc *);

 @@ -1,14 +1,14 @@
-/*	$NetBSD: tlphy.c,v 1.70 2020/07/07 08:35:16 msaitoh Exp $	*/
+/*	$NetBSD: tlphy.c,v 1.71 2020/07/07 08:44:12 msaitoh Exp $	*/
 /*-
  * Copyright (c) 1998, 1999, 2000 The NetBSD Foundation, Inc.
  * All rights reserved.
+ *
  * This code is derived from software contributed to The NetBSD Foundation
  * by Jason R. Thorpe of the Numerical Aerospace Simulation Facility,
  * NASA Ames Research Center.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
 @@ -49,27 +49,27 @@
  * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
  * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 /*
  * Driver for Texas Instruments's ThunderLAN PHYs
  */
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: tlphy.c,v 1.70 2020/07/07 08:35:16 msaitoh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: tlphy.c,v 1.71 2020/07/07 08:44:12 msaitoh Exp $");
 #include <sys/param.h>
 #include <sys/systm.h>
 #include <sys/kernel.h>
 #include <sys/device.h>
 #include <sys/socket.h>
 #include <sys/errno.h>
 #include <sys/bus.h>
 #include <net/if.h>
 #include <net/if_media.h>
 @@ -357,35 +357,27 @@ tlphy_status(struct mii_softc *sc)
 	if (bmcr & BMCR_FDX)
 		mii->mii_media_active |= IFM_FDX;
 	else
 		mii->mii_media_active |= IFM_HDX;
 	mii->mii_media_active |= IFM_10_T;
+}
 static int
 tlphy_auto(struct tlphy_softc *tsc)
+{
 	struct mii_softc *sc = &tsc->sc_mii;
 	int error;
-	switch ((error = mii_phy_auto(sc, 0))) {
+	switch ((error = mii_phy_auto(sc))) {
 	case EIO:
 		/*
 		 * Just assume we're not in full-duplex mode.
 		 * XXX Check link and try AUI/BNC?
 		 */
 		PHY_WRITE(sc, MII_BMCR, 0);
 		break;
 	case EJUSTRETURN:
 		/* Flag that we need to program when it completes. */
 		tsc->sc_need_acomp = 1;
 		break;
 	default:
 		tlphy_acomp(tsc);
+	}
 	return error;
+}
 static void

 @@ -1,14 +1,14 @@
-/*	$NetBSD: urlphy.c,v 1.35 2019/11/27 10:19:21 msaitoh Exp $	*/
+/*	$NetBSD: urlphy.c,v 1.36 2020/07/07 08:44:12 msaitoh Exp $	*/
 /*
  * Copyright (c) 2001, 2002
  *     Shingo WATANABE <nabe@nabechan.org>.  All rights reserved.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  * 3. Neither the name of the author nor the names of any co-contributors
 @@ -24,27 +24,27 @@
  * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
+ *
  */
 /*
  * driver for Realtek RL8150L internal phy
  */
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: urlphy.c,v 1.35 2019/11/27 10:19:21 msaitoh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: urlphy.c,v 1.36 2020/07/07 08:44:12 msaitoh Exp $");
 #include <sys/param.h>
 #include <sys/systm.h>
 #include <sys/kernel.h>
 #include <sys/device.h>
 #include <sys/socket.h>
 #include <net/if.h>
 #include <net/if_media.h>
 #include <dev/mii/mii.h>
 #include <dev/mii/miivar.h>
 #include <dev/mii/miidevs.h>
 @@ -189,27 +189,27 @@ urlphy_service(struct mii_softc *sc, str
 		 * media or the link became down since the last tick (see
 		 * above), so break to update the status.
 		 */
 		if (sc->mii_ticks++ == 0)
 			break;
 		/* Only retry autonegotiation every N seconds. */
 		KASSERT(sc->mii_anegticks != 0);
 		if (sc->mii_ticks <= sc->mii_anegticks)
 			return 0;
 		PHY_RESET(sc);
-		if (mii_phy_auto(sc, 0) == EJUSTRETURN)
+		if (mii_phy_auto(sc) == EJUSTRETURN)
 			return 0;
 		break;
 	case MII_DOWN:
 		mii_phy_down(sc);
 		return 0;
+	}
 	/* Update the media status. */
 	mii_phy_status(sc);
 	/* Callback if something changed. */