Fri Jul 31 20:35:34 2020 UTC ()

no need for continue


(christos)

diff -r1.387 -r1.388 src/sys/dev/raidframe/rf_netbsdkintf.c

--- src/sys/dev/raidframe/rf_netbsdkintf.c 2020/07/31 20:34:38	1.387
+++ src/sys/dev/raidframe/rf_netbsdkintf.c 2020/07/31 20:35:33	1.388

 @@ -1,14 +1,14 @@
-/*	$NetBSD: rf_netbsdkintf.c,v 1.387 2020/07/31 20:34:38 christos Exp $	*/
+/*	$NetBSD: rf_netbsdkintf.c,v 1.388 2020/07/31 20:35:33 christos Exp $	*/
 /*-
  * Copyright (c) 1996, 1997, 1998, 2008-2011 The NetBSD Foundation, Inc.
  * All rights reserved.
+ *
  * This code is derived from software contributed to The NetBSD Foundation
  * by Greg Oster; Jason R. Thorpe.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
 @@ -91,27 +91,27 @@
  *  Pittsburgh PA 15213-3890
+ *
  * any improvements or extensions that they make and grant Carnegie the
  * rights to redistribute these changes.
  */
 /***********************************************************
+ *
  * rf_kintf.c -- the kernel interface routines for RAIDframe
+ *
  ***********************************************************/
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: rf_netbsdkintf.c,v 1.387 2020/07/31 20:34:38 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: rf_netbsdkintf.c,v 1.388 2020/07/31 20:35:33 christos Exp $");
 #ifdef _KERNEL_OPT
 #include "opt_raid_autoconfig.h"
 #include "opt_compat_netbsd32.h"
 #endif
 #include <sys/param.h>
 #include <sys/errno.h>
 #include <sys/pool.h>
 #include <sys/proc.h>
 #include <sys/queue.h>
 #include <sys/disk.h>
 #include <sys/device.h>
 @@ -3687,27 +3687,26 @@ rf_sync_component_caches(RF_Raid_t *raid
 			int e = rf_sync_component_cache(raidPtr, c);
 			if (e && !error)
 				error = e;
+		}
+	}
 	for (c = 0; c < raidPtr->numSpare ; c++) {
 		int sparecol = raidPtr->numCol + c;
 		/* Need to ensure that the reconstruct actually completed! */
 		if (raidPtr->Disks[sparecol].status == rf_ds_used_spare) {
 			int e = rf_sync_component_cache(raidPtr, sparecol);
 			if (e && !error)
 				error = e;
 			continue;
+		}
+	}
 	return error;
+}
 /* Fill in info with the current status */
 void
 rf_check_recon_status_ext(RF_Raid_t *raidPtr, RF_ProgressInfo_t *info)
+{
 	if (raidPtr->status != rf_rs_reconstructing) {
 		info->total = 100;
 		info->completed = 100;