 @@ -1,1043 +1,1043 @@
-/*	$NetBSD: if_wg.c,v 1.24 2020/08/26 16:03:41 riastradh Exp $	*/
+/*	$NetBSD: if_wg.c,v 1.25 2020/08/27 02:52:33 riastradh Exp $	*/
 /*
  * Copyright (C) Ryota Ozaki <ozaki.ryota@gmail.com>
  * All rights reserved.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  * 3. Neither the name of the project nor the names of its contributors
  *    may be used to endorse or promote products derived from this software
  *    without specific prior written permission.
+ *
  * THIS SOFTWARE IS PROVIDED BY THE PROJECT AND CONTRIBUTORS ``AS IS'' AND
  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
  * ARE DISCLAIMED.  IN NO EVENT SHALL THE PROJECT OR CONTRIBUTORS BE LIABLE
  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
  * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  */
 /*
  * This network interface aims to implement the WireGuard protocol.
  * The implementation is based on the paper of WireGuard as of
  * 2018-06-30 [1].  The paper is referred in the source code with label
  * [W].  Also the specification of the Noise protocol framework as of
  * 2018-07-11 [2] is referred with label [N].
+ *
  * [1] https://www.wireguard.com/papers/wireguard.pdf
  * [2] http://noiseprotocol.org/noise.pdf
  */
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_wg.c,v 1.24 2020/08/26 16:03:41 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_wg.c,v 1.25 2020/08/27 02:52:33 riastradh Exp $");
 #ifdef _KERNEL_OPT
 #include "opt_inet.h"
 #endif
 #include <sys/param.h>
 #include <sys/systm.h>
 #include <sys/kernel.h>
 #include <sys/mbuf.h>
 #include <sys/socket.h>
 #include <sys/sockio.h>
 #include <sys/errno.h>
 #include <sys/ioctl.h>
 #include <sys/time.h>
 #include <sys/timespec.h>
 #include <sys/socketvar.h>
 #include <sys/syslog.h>
 #include <sys/cpu.h>
 #include <sys/intr.h>
 #include <sys/kmem.h>
 #include <sys/device.h>
 #include <sys/module.h>
 #include <sys/mutex.h>
 #include <sys/rwlock.h>
 #include <sys/pserialize.h>
 #include <sys/psref.h>
 #include <sys/kthread.h>
 #include <sys/cprng.h>
 #include <sys/atomic.h>
 #include <sys/sysctl.h>
 #include <sys/domain.h>
 #include <sys/pcq.h>
 #include <sys/queue.h>
 #include <sys/percpu.h>
 #include <sys/callout.h>
 #include <net/bpf.h>
 #include <net/if.h>
 #include <net/if_types.h>
 #include <net/route.h>
 #include <netinet/in.h>
 #include <netinet/ip.h>
 #include <netinet/ip_var.h>
 #include <netinet/udp.h>
 #include <netinet/udp_var.h>
 #include <netinet/in_var.h>
 #include <netinet/in_pcb.h>
 #ifdef INET6
 #include <netinet6/in6_var.h>
 #include <netinet/ip6.h>
 #include <netinet6/ip6_var.h>
 #include <netinet6/in6_pcb.h>
 #include <netinet6/udp6_var.h>
 #endif /* INET6 */
 #include <net/if_wg.h>
 #include <prop/proplib.h>
 #include <crypto/blake2/blake2s.h>
 #include <crypto/sodium/crypto_scalarmult.h>
 #include <crypto/sodium/crypto_aead_chacha20poly1305.h>
 #include <crypto/sodium/crypto_aead_xchacha20poly1305.h>
 #include "ioconf.h"
 #ifdef WG_RUMPKERNEL
 #include "wg_user.h"
 #endif
 /*
  * Data structures
  * - struct wg_softc is an instance of wg interfaces
  *   - It has a list of peers (struct wg_peer)
  *   - It has a kthread that sends/receives handshake messages and
  *     runs event handlers
  *   - It has its own two routing tables: one is for IPv4 and the other IPv6
  * - struct wg_peer is a representative of a peer
  *   - It has a softint that is used to send packets over an wg interface
  *     to a peer
  *   - It has a pair of session instances (struct wg_session)
  *   - It has a pair of endpoint instances (struct wg_sockaddr)
  *     - Normally one endpoint is used and the second one is used only on
  *       a peer migration (a change of peer's IP address)
  *   - It has a list of IP addresses and sub networks called allowedips
  *     (struct wg_allowedip)
  *     - A packets sent over a session is allowed if its destination matches
  *       any IP addresses or sub networks of the list
  * - struct wg_session represents a session of a secure tunnel with a peer
  *   - Two instances of sessions belong to a peer; a stable session and a
  *     unstable session
  *   - A handshake process of a session always starts with a unstable instace
  *   - Once a session is established, its instance becomes stable and the
  *     other becomes unstable instead
  *   - Data messages are always sent via a stable session
+ *
  * Locking notes:
  * - wg interfaces (struct wg_softc, wg) is listed in wg_softcs.list and
  *   protected by wg_softcs.lock
  * - Each wg has a mutex(9) and a rwlock(9)
  *   - The mutex (wg_lock) protects its peer list (wg_peers)
  *   - A peer on the list is also protected by pserialize(9) or psref(9)
  *   - The rwlock (wg_rwlock) protects the routing tables (wg_rtable_ipv[46])
  * - Each peer (struct wg_peer, wgp) has a mutex
  *   - The mutex (wgp_lock) protects wgp_session_unstable and wgp_state
  * - Each session (struct wg_session, wgs) has a mutex
  *   - The mutex (wgs_lock) protects its state (wgs_state) and its handshake
  *     states
  *   - wgs_state of a unstable session can be changed while it never be
  *     changed on a stable session, so once get a session instace via
  *     wgp_session_stable we can safely access wgs_state without
  *     holding wgs_lock
  *   - A session is protected by pserialize or psref like wgp
  *     - On a session swap, we must wait for all readers to release a
  *       reference to a stable session before changing wgs_state and
  *       session states
  */
 #define WGLOG(level, fmt, args...)					      \
 	log(level, "%s: " fmt, __func__, ##args)
 /* Debug options */
 #ifdef WG_DEBUG
 /* Output debug logs */
 #ifndef WG_DEBUG_LOG
 #define WG_DEBUG_LOG
 #endif
 /* Output trace logs */
 #ifndef WG_DEBUG_TRACE
 #define WG_DEBUG_TRACE
 #endif
 /* Output hash values, etc. */
 #ifndef WG_DEBUG_DUMP
 #define WG_DEBUG_DUMP
 #endif
 /* Make some internal parameters configurable for testing and debugging */
 #ifndef WG_DEBUG_PARAMS
 #define WG_DEBUG_PARAMS
 #endif
 #endif
 #ifdef WG_DEBUG_TRACE
 #define WG_TRACE(msg)							      \
 	log(LOG_DEBUG, "%s:%d: %s\n", __func__, __LINE__, (msg))
 #else
 #define WG_TRACE(msg)	__nothing
 #endif
 #ifdef WG_DEBUG_LOG
 #define WG_DLOG(fmt, args...)	log(LOG_DEBUG, "%s: " fmt, __func__, ##args)
 #else
 #define WG_DLOG(fmt, args...)	__nothing
 #endif
 #define WG_LOG_RATECHECK(wgprc, level, fmt, args...)	do {		\
 	if (ppsratecheck(&(wgprc)->wgprc_lasttime,			\
 	    &(wgprc)->wgprc_curpps, 1)) {				\
 		log(level, fmt, ##args);				\
 	}								\
 } while (0)
 #ifdef WG_DEBUG_PARAMS
 static bool wg_force_underload = false;
 #endif
 #ifdef WG_DEBUG_DUMP
 #ifdef WG_RUMPKERNEL
 static void
 wg_dump_buf(const char *func, const char *buf, const size_t size)
+{
 	log(LOG_DEBUG, "%s: ", func);
 	for (int i = 0; i < size; i++)
 		log(LOG_DEBUG, "%02x ", (int)(0xff & buf[i]));
 	log(LOG_DEBUG, "\n");
+}
 #endif
 static void
 wg_dump_hash(const uint8_t *func, const uint8_t *name, const uint8_t *hash,
     const size_t size)
+{
 	log(LOG_DEBUG, "%s: %s: ", func, name);
 	for (int i = 0; i < size; i++)
 		log(LOG_DEBUG, "%02x ", (int)(0xff & hash[i]));
 	log(LOG_DEBUG, "\n");
+}
 #define WG_DUMP_HASH(name, hash) \
 	wg_dump_hash(__func__, name, hash, WG_HASH_LEN)
 #define WG_DUMP_HASH48(name, hash) \
 	wg_dump_hash(__func__, name, hash, 48)
 #define WG_DUMP_BUF(buf, size) \
 	wg_dump_buf(__func__, buf, size)
 #else
 #define WG_DUMP_HASH(name, hash)	__nothing
 #define WG_DUMP_HASH48(name, hash)	__nothing
 #define WG_DUMP_BUF(buf, size)	__nothing
 #endif /* WG_DEBUG_DUMP */
 #define WG_MTU			1420
 #define WG_ALLOWEDIPS		16
 #define CURVE25519_KEY_LEN	32
 #define TAI64N_LEN		sizeof(uint32_t) * 3
 #define POLY1305_AUTHTAG_LEN	16
 #define HMAC_BLOCK_LEN		64
 /* [N] 4.1: "DHLEN must be 32 or greater."  WireGuard chooses 32. */
 /* [N] 4.3: Hash functions */
 #define NOISE_DHLEN		32
 /* [N] 4.3: "Must be 32 or 64."  WireGuard chooses 32. */
 #define NOISE_HASHLEN		32
 #define NOISE_BLOCKLEN		64
 #define NOISE_HKDF_OUTPUT_LEN	NOISE_HASHLEN
 /* [N] 5.1: "k" */
 #define NOISE_CIPHER_KEY_LEN	32
 /*
  * [N] 9.2: "psk"
  *          "... psk is a 32-byte secret value provided by the application."
  */
 #define NOISE_PRESHARED_KEY_LEN	32
 #define WG_STATIC_KEY_LEN	CURVE25519_KEY_LEN
 #define WG_TIMESTAMP_LEN	TAI64N_LEN
 #define WG_PRESHARED_KEY_LEN	NOISE_PRESHARED_KEY_LEN
 #define WG_COOKIE_LEN		16
 #define WG_MAC_LEN		16
 #define WG_RANDVAL_LEN		24
 #define WG_EPHEMERAL_KEY_LEN	CURVE25519_KEY_LEN
 /* [N] 5.2: "ck: A chaining key of HASHLEN bytes" */
 #define WG_CHAINING_KEY_LEN	NOISE_HASHLEN
 /* [N] 5.2: "h: A hash output of HASHLEN bytes" */
 #define WG_HASH_LEN		NOISE_HASHLEN
 #define WG_CIPHER_KEY_LEN	NOISE_CIPHER_KEY_LEN
 #define WG_DH_OUTPUT_LEN	NOISE_DHLEN
 #define WG_KDF_OUTPUT_LEN	NOISE_HKDF_OUTPUT_LEN
 #define WG_AUTHTAG_LEN		POLY1305_AUTHTAG_LEN
 #define WG_DATA_KEY_LEN		32
 #define WG_SALT_LEN		24
 /*
  * The protocol messages
  */
 struct wg_msg {
 	uint32_t	wgm_type;
 } __packed;
 /* [W] 5.4.2 First Message: Initiator to Responder */
 struct wg_msg_init {
 	uint32_t	wgmi_type;
 	uint32_t	wgmi_sender;
 	uint8_t		wgmi_ephemeral[WG_EPHEMERAL_KEY_LEN];
 	uint8_t		wgmi_static[WG_STATIC_KEY_LEN + WG_AUTHTAG_LEN];
 	uint8_t		wgmi_timestamp[WG_TIMESTAMP_LEN + WG_AUTHTAG_LEN];
 	uint8_t		wgmi_mac1[WG_MAC_LEN];
 	uint8_t		wgmi_mac2[WG_MAC_LEN];
 } __packed;
 /* [W] 5.4.3 Second Message: Responder to Initiator */
 struct wg_msg_resp {
 	uint32_t	wgmr_type;
 	uint32_t	wgmr_sender;
 	uint32_t	wgmr_receiver;
 	uint8_t		wgmr_ephemeral[WG_EPHEMERAL_KEY_LEN];
 	uint8_t		wgmr_empty[0 + WG_AUTHTAG_LEN];
 	uint8_t		wgmr_mac1[WG_MAC_LEN];
 	uint8_t		wgmr_mac2[WG_MAC_LEN];
 } __packed;
 /* [W] 5.4.6 Subsequent Messages: Transport Data Messages */
 struct wg_msg_data {
 	uint32_t	wgmd_type;
 	uint32_t	wgmd_receiver;
 	uint64_t	wgmd_counter;
 	uint32_t	wgmd_packet[0];
 } __packed;
 /* [W] 5.4.7 Under Load: Cookie Reply Message */
 struct wg_msg_cookie {
 	uint32_t	wgmc_type;
 	uint32_t	wgmc_receiver;
 	uint8_t		wgmc_salt[WG_SALT_LEN];
 	uint8_t		wgmc_cookie[WG_COOKIE_LEN + WG_AUTHTAG_LEN];
 } __packed;
 #define WG_MSG_TYPE_INIT		1
 #define WG_MSG_TYPE_RESP		2
 #define WG_MSG_TYPE_COOKIE		3
 #define WG_MSG_TYPE_DATA		4
 #define WG_MSG_TYPE_MAX			WG_MSG_TYPE_DATA
 /* Sliding windows */
 #define	SLIWIN_BITS	2048u
 #define	SLIWIN_TYPE	uint32_t
 #define	SLIWIN_BPW	NBBY*sizeof(SLIWIN_TYPE)
 #define	SLIWIN_WORDS	howmany(SLIWIN_BITS, SLIWIN_BPW)
 #define	SLIWIN_NPKT	(SLIWIN_BITS - NBBY*sizeof(SLIWIN_TYPE))
 struct sliwin {
 	SLIWIN_TYPE	B[SLIWIN_WORDS];
 	uint64_t	T;
 };
 static void
 sliwin_reset(struct sliwin *W)
+{
 	memset(W, 0, sizeof(*W));
+}
 static int
 sliwin_check_fast(const volatile struct sliwin *W, uint64_t S)
+{
 	/*
 	 * If it's more than one window older than the highest sequence
 	 * number we've seen, reject.
 	 */
 #ifdef __HAVE_ATOMIC64_LOADSTORE
 	if (S + SLIWIN_NPKT < atomic_load_relaxed(&W->T))
 		return EAUTH;
 #endif
 	/*
 	 * Otherwise, we need to take the lock to decide, so don't
 	 * reject just yet.  Caller must serialize a call to
 	 * sliwin_update in this case.
 	 */
 	return 0;
+}
 static int
 sliwin_update(struct sliwin *W, uint64_t S)
+{
 	unsigned word, bit;
 	/*
 	 * If it's more than one window older than the highest sequence
 	 * number we've seen, reject.
 	 */
 	if (S + SLIWIN_NPKT < W->T)
 		return EAUTH;
 	/*
 	 * If it's higher than the highest sequence number we've seen,
 	 * advance the window.
 	 */
 	if (S > W->T) {
 		uint64_t i = W->T / SLIWIN_BPW;
 		uint64_t j = S / SLIWIN_BPW;
 		unsigned k;
 		for (k = 0; k < MIN(j - i, SLIWIN_WORDS); k++)
 			W->B[(i + k + 1) % SLIWIN_WORDS] = 0;
 #ifdef __HAVE_ATOMIC64_LOADSTORE
 		atomic_store_relaxed(&W->T, S);
 #else
 		W->T = S;
 #endif
+	}
 	/* Test and set the bit -- if already set, reject.  */
 	word = (S / SLIWIN_BPW) % SLIWIN_WORDS;
 	bit = S % SLIWIN_BPW;
 	if (W->B[word] & (1UL << bit))
 		return EAUTH;
 	W->B[word] |= 1UL << bit;
 	/* Accept!  */
 	return 0;
+}
 struct wg_worker {
 	kmutex_t	wgw_lock;
 	kcondvar_t	wgw_cv;
 	bool		wgw_todie;
 	struct socket	*wgw_so4;
 	struct socket	*wgw_so6;
 	int		wgw_wakeup_reasons;
 #define WG_WAKEUP_REASON_RECEIVE_PACKETS_IPV4	__BIT(0)
 #define WG_WAKEUP_REASON_RECEIVE_PACKETS_IPV6	__BIT(1)
 #define WG_WAKEUP_REASON_PEER			__BIT(2)
 };
 struct wg_session {
 	struct wg_peer	*wgs_peer;
 	struct psref_target
 			wgs_psref;
 	kmutex_t	*wgs_lock;
 	int		wgs_state;
 #define WGS_STATE_UNKNOWN	0
 #define WGS_STATE_INIT_ACTIVE	1
 #define WGS_STATE_INIT_PASSIVE	2
 #define WGS_STATE_ESTABLISHED	3
 #define WGS_STATE_DESTROYING	4
 	time_t		wgs_time_established;
 	time_t		wgs_time_last_data_sent;
 	bool		wgs_is_initiator;
 	uint32_t	wgs_sender_index;
 	uint32_t	wgs_receiver_index;
 #ifdef __HAVE_ATOMIC64_LOADSTORE
 	volatile uint64_t
 			wgs_send_counter;
 #else
 	kmutex_t	wgs_send_counter_lock;
 	uint64_t	wgs_send_counter;
 #endif
 	struct {
 		kmutex_t	lock;
 		struct sliwin	window;
 	}		*wgs_recvwin;
 	uint8_t		wgs_handshake_hash[WG_HASH_LEN];
 	uint8_t		wgs_chaining_key[WG_CHAINING_KEY_LEN];
 	uint8_t		wgs_ephemeral_key_pub[WG_EPHEMERAL_KEY_LEN];
 	uint8_t		wgs_ephemeral_key_priv[WG_EPHEMERAL_KEY_LEN];
 	uint8_t		wgs_ephemeral_key_peer[WG_EPHEMERAL_KEY_LEN];
 	uint8_t		wgs_tkey_send[WG_DATA_KEY_LEN];
 	uint8_t		wgs_tkey_recv[WG_DATA_KEY_LEN];
 };
 struct wg_sockaddr {
 	union {
 		struct sockaddr_storage _ss;
 		struct sockaddr _sa;
 		struct sockaddr_in _sin;
 		struct sockaddr_in6 _sin6;
 	};
 	struct psref_target	wgsa_psref;
 };
 #define wgsatosa(wgsa)		(&(wgsa)->_sa)
 #define wgsatosin(wgsa)		(&(wgsa)->_sin)
 #define wgsatosin6(wgsa)	(&(wgsa)->_sin6)
 struct wg_peer;
 struct wg_allowedip {
 	struct radix_node	wga_nodes[2];
 	struct wg_sockaddr	_wga_sa_addr;
 	struct wg_sockaddr	_wga_sa_mask;
 #define wga_sa_addr		_wga_sa_addr._sa
 #define wga_sa_mask		_wga_sa_mask._sa
 	int			wga_family;
 	uint8_t			wga_cidr;
 	union {
 		struct in_addr _ip4;
 		struct in6_addr _ip6;
 	} wga_addr;
 #define wga_addr4	wga_addr._ip4
 #define wga_addr6	wga_addr._ip6
 	struct wg_peer		*wga_peer;
 };
 typedef uint8_t wg_timestamp_t[WG_TIMESTAMP_LEN];
 struct wg_ppsratecheck {
 	struct timeval		wgprc_lasttime;
 	int			wgprc_curpps;
 };
 struct wg_softc;
 struct wg_peer {
 	struct wg_softc		*wgp_sc;
 	char			wgp_name[WG_PEER_NAME_MAXLEN + 1];
 	struct pslist_entry	wgp_peerlist_entry;
 	pserialize_t		wgp_psz;
 	struct psref_target	wgp_psref;
 	kmutex_t		*wgp_lock;
 	uint8_t	wgp_pubkey[WG_STATIC_KEY_LEN];
 	struct wg_sockaddr	*wgp_endpoint;
 #define wgp_ss		wgp_endpoint->_ss
 #define wgp_sa		wgp_endpoint->_sa
 #define wgp_sin		wgp_endpoint->_sin
 #define wgp_sin6	wgp_endpoint->_sin6
 	struct wg_sockaddr	*wgp_endpoint0;
 	bool			wgp_endpoint_changing;
 	bool			wgp_endpoint_available;
 			/* The preshared key (optional) */
 	uint8_t		wgp_psk[WG_PRESHARED_KEY_LEN];
 	int wgp_state;
 #define WGP_STATE_INIT		0
 #define WGP_STATE_ESTABLISHED	1
 #define WGP_STATE_GIVEUP	2
 #define WGP_STATE_DESTROYING	3
 	void		*wgp_si;
 	pcq_t		*wgp_q;
 	struct wg_session	*wgp_session_stable;
 	struct wg_session	*wgp_session_unstable;
 	/* timestamp in big-endian */
 	wg_timestamp_t	wgp_timestamp_latest_init;
 	struct timespec		wgp_last_handshake_time;
 	callout_t		wgp_rekey_timer;
 	callout_t		wgp_handshake_timeout_timer;
 	callout_t		wgp_session_dtor_timer;
 	time_t			wgp_handshake_start_time;
 	int			wgp_n_allowedips;
 	struct wg_allowedip	wgp_allowedips[WG_ALLOWEDIPS];
 	time_t			wgp_latest_cookie_time;
 	uint8_t			wgp_latest_cookie[WG_COOKIE_LEN];
 	uint8_t			wgp_last_sent_mac1[WG_MAC_LEN];
 	bool			wgp_last_sent_mac1_valid;
 	uint8_t			wgp_last_sent_cookie[WG_COOKIE_LEN];
 	bool			wgp_last_sent_cookie_valid;
 	time_t			wgp_last_msg_received_time[WG_MSG_TYPE_MAX];
 	time_t			wgp_last_genrandval_time;
 	uint32_t		wgp_randval;
 	struct wg_ppsratecheck	wgp_ppsratecheck;
 	volatile unsigned int	wgp_tasks;
 #define WGP_TASK_SEND_INIT_MESSAGE		__BIT(0)
 #define WGP_TASK_ENDPOINT_CHANGED		__BIT(1)
 #define WGP_TASK_SEND_KEEPALIVE_MESSAGE	__BIT(2)
 #define WGP_TASK_DESTROY_PREV_SESSION		__BIT(3)
 };
 struct wg_ops;
 struct wg_softc {
 	struct ifnet	wg_if;
 	LIST_ENTRY(wg_softc) wg_list;
 	kmutex_t	*wg_lock;
 	krwlock_t	*wg_rwlock;
 	uint8_t		wg_privkey[WG_STATIC_KEY_LEN];
 	uint8_t		wg_pubkey[WG_STATIC_KEY_LEN];
 	int		wg_npeers;
 	struct pslist_head	wg_peers;
 	uint16_t	wg_listen_port;
 	struct wg_worker	*wg_worker;
 	lwp_t			*wg_worker_lwp;
 	struct radix_node_head	*wg_rtable_ipv4;
 	struct radix_node_head	*wg_rtable_ipv6;
 	struct wg_ppsratecheck	wg_ppsratecheck;
 	struct wg_ops		*wg_ops;
 #ifdef WG_RUMPKERNEL
 	struct wg_user		*wg_user;
 #endif
 };
 /* [W] 6.1 Preliminaries */
 #define WG_REKEY_AFTER_MESSAGES		(1ULL << 60)
 #define WG_REJECT_AFTER_MESSAGES	(UINT64_MAX - (1 << 13))
 #define WG_REKEY_AFTER_TIME		120
 #define WG_REJECT_AFTER_TIME		180
 #define WG_REKEY_ATTEMPT_TIME		 90
 #define WG_REKEY_TIMEOUT		  5
 #define WG_KEEPALIVE_TIMEOUT		 10
 #define WG_COOKIE_TIME			120
 #define WG_RANDVAL_TIME			(2 * 60)
 static uint64_t wg_rekey_after_messages = WG_REKEY_AFTER_MESSAGES;
 static uint64_t wg_reject_after_messages = WG_REJECT_AFTER_MESSAGES;
 static unsigned wg_rekey_after_time = WG_REKEY_AFTER_TIME;
 static unsigned wg_reject_after_time = WG_REJECT_AFTER_TIME;
 static unsigned wg_rekey_attempt_time = WG_REKEY_ATTEMPT_TIME;
 static unsigned wg_rekey_timeout = WG_REKEY_TIMEOUT;
 static unsigned wg_keepalive_timeout = WG_KEEPALIVE_TIMEOUT;
 static struct mbuf *
 		wg_get_mbuf(size_t, size_t);
 static void	wg_wakeup_worker(struct wg_worker *, int);
 static int	wg_send_data_msg(struct wg_peer *, struct wg_session *,
 		    struct mbuf *);
 static int	wg_send_cookie_msg(struct wg_softc *, struct wg_peer *,
 		    const uint32_t, const uint8_t [], const struct sockaddr *);
 static int	wg_send_handshake_msg_resp(struct wg_softc *,
 		    struct wg_peer *, const struct wg_msg_init *);
 static void	wg_send_keepalive_msg(struct wg_peer *, struct wg_session *);
 static struct wg_peer *
 		wg_pick_peer_by_sa(struct wg_softc *, const struct sockaddr *,
 		    struct psref *);
 static struct wg_peer *
 		wg_lookup_peer_by_pubkey(struct wg_softc *,
 		    const uint8_t [], struct psref *);
 static struct wg_session *
 		wg_lookup_session_by_index(struct wg_softc *,
 		    const uint32_t, struct psref *);
 static void	wg_update_endpoint_if_necessary(struct wg_peer *,
 		    const struct sockaddr *);
 static void	wg_schedule_rekey_timer(struct wg_peer *);
 static void	wg_schedule_session_dtor_timer(struct wg_peer *);
 static void	wg_stop_session_dtor_timer(struct wg_peer *);
 static bool	wg_is_underload(struct wg_softc *, struct wg_peer *, int);
 static void	wg_calculate_keys(struct wg_session *, const bool);
 static void	wg_clear_states(struct wg_session *);
 static void	wg_get_peer(struct wg_peer *, struct psref *);
 static void	wg_put_peer(struct wg_peer *, struct psref *);
 static int	wg_send_so(struct wg_peer *, struct mbuf *);
 static int	wg_send_udp(struct wg_peer *, struct mbuf *);
 static int	wg_output(struct ifnet *, struct mbuf *,
 			   const struct sockaddr *, const struct rtentry *);
 static void	wg_input(struct ifnet *, struct mbuf *, const int);
 static int	wg_ioctl(struct ifnet *, u_long, void *);
 static int	wg_bind_port(struct wg_softc *, const uint16_t);
 static int	wg_init(struct ifnet *);
 static void	wg_stop(struct ifnet *, int);
 static int	wg_clone_create(struct if_clone *, int);
 static int	wg_clone_destroy(struct ifnet *);
 struct wg_ops {
 	int (*send_hs_msg)(struct wg_peer *, struct mbuf *);
 	int (*send_data_msg)(struct wg_peer *, struct mbuf *);
 	void (*input)(struct ifnet *, struct mbuf *, const int);
 	int (*bind_port)(struct wg_softc *, const uint16_t);
 };
 struct wg_ops wg_ops_rumpkernel = {
 	.send_hs_msg	= wg_send_so,
 	.send_data_msg	= wg_send_udp,
 	.input		= wg_input,
 	.bind_port	= wg_bind_port,
 };
 #ifdef WG_RUMPKERNEL
 static bool	wg_user_mode(struct wg_softc *);
 static int	wg_ioctl_linkstr(struct wg_softc *, struct ifdrv *);
 static int	wg_send_user(struct wg_peer *, struct mbuf *);
 static void	wg_input_user(struct ifnet *, struct mbuf *, const int);
 static int	wg_bind_port_user(struct wg_softc *, const uint16_t);
 struct wg_ops wg_ops_rumpuser = {
 	.send_hs_msg	= wg_send_user,
 	.send_data_msg	= wg_send_user,
 	.input		= wg_input_user,
 	.bind_port	= wg_bind_port_user,
 };
 #endif
 #define WG_PEER_READER_FOREACH(wgp, wg)					\
 	PSLIST_READER_FOREACH((wgp), &(wg)->wg_peers, struct wg_peer,	\
 	    wgp_peerlist_entry)
 #define WG_PEER_WRITER_FOREACH(wgp, wg)					\
 	PSLIST_WRITER_FOREACH((wgp), &(wg)->wg_peers, struct wg_peer,	\
 	    wgp_peerlist_entry)
 #define WG_PEER_WRITER_INSERT_HEAD(wgp, wg)				\
 	PSLIST_WRITER_INSERT_HEAD(&(wg)->wg_peers, (wgp), wgp_peerlist_entry)
 #define WG_PEER_WRITER_REMOVE(wgp)					\
 	PSLIST_WRITER_REMOVE((wgp), wgp_peerlist_entry)
 struct wg_route {
 	struct radix_node	wgr_nodes[2];
 	struct wg_peer		*wgr_peer;
 };
 static struct radix_node_head *
 wg_rnh(struct wg_softc *wg, const int family)
+{
 	switch (family) {
 		case AF_INET:
 			return wg->wg_rtable_ipv4;
 #ifdef INET6
 		case AF_INET6:
 			return wg->wg_rtable_ipv6;
 #endif
 		default:
 			return NULL;
+	}
+}
 /*
  * Global variables
  */
 LIST_HEAD(wg_sclist, wg_softc);
 static struct {
 	struct wg_sclist list;
 	kmutex_t lock;
 } wg_softcs __cacheline_aligned;
 struct psref_class *wg_psref_class __read_mostly;
 static struct if_clone wg_cloner =
     IF_CLONE_INITIALIZER("wg", wg_clone_create, wg_clone_destroy);
 void wgattach(int);
 /* ARGSUSED */
 void
 wgattach(int count)
+{
 	/*
 	 * Nothing to do here, initialization is handled by the
 	 * module initialization code in wginit() below).
 	 */
+}
 static void
 wginit(void)
+{
 	wg_psref_class = psref_class_create("wg", IPL_SOFTNET);
 	mutex_init(&wg_softcs.lock, MUTEX_DEFAULT, IPL_NONE);
 	LIST_INIT(&wg_softcs.list);
 	if_clone_attach(&wg_cloner);
+}
 static int
 wgdetach(void)
+{
 	int error = 0;
 	mutex_enter(&wg_softcs.lock);
 	if (!LIST_EMPTY(&wg_softcs.list)) {
 		mutex_exit(&wg_softcs.lock);
 		error = EBUSY;
+	}
 	if (error == 0) {
 		psref_class_destroy(wg_psref_class);
 		if_clone_detach(&wg_cloner);
+	}
 	return error;
+}
 static void
 wg_init_key_and_hash(uint8_t ckey[WG_CHAINING_KEY_LEN],
     uint8_t hash[WG_HASH_LEN])
+{
 	/* [W] 5.4: CONSTRUCTION */
 	const char *signature = "Noise_IKpsk2_25519_ChaChaPoly_BLAKE2s";
 	/* [W] 5.4: IDENTIFIER */
 	const char *id = "WireGuard v1 zx2c4 Jason@zx2c4.com";
 	struct blake2s state;
 	blake2s(ckey, WG_CHAINING_KEY_LEN, NULL, 0,
 	    signature, strlen(signature));
 	CTASSERT(WG_HASH_LEN == WG_CHAINING_KEY_LEN);
 	memcpy(hash, ckey, WG_CHAINING_KEY_LEN);
 	blake2s_init(&state, WG_HASH_LEN, NULL, 0);
 	blake2s_update(&state, ckey, WG_CHAINING_KEY_LEN);
 	blake2s_update(&state, id, strlen(id));
 	blake2s_final(&state, hash);
 	WG_DUMP_HASH("ckey", ckey);
 	WG_DUMP_HASH("hash", hash);
+}
 static void
 wg_algo_hash(uint8_t hash[WG_HASH_LEN], const uint8_t input[],
     const size_t inputsize)
+{
 	struct blake2s state;
 	blake2s_init(&state, WG_HASH_LEN, NULL, 0);
 	blake2s_update(&state, hash, WG_HASH_LEN);
 	blake2s_update(&state, input, inputsize);
 	blake2s_final(&state, hash);
+}
 static void
 wg_algo_mac(uint8_t out[], const size_t outsize,
     const uint8_t key[], const size_t keylen,
     const uint8_t input1[], const size_t input1len,
     const uint8_t input2[], const size_t input2len)
+{
 	struct blake2s state;
 	blake2s_init(&state, outsize, key, keylen);
 	blake2s_update(&state, input1, input1len);
 	if (input2 != NULL)
 		blake2s_update(&state, input2, input2len);
 	blake2s_final(&state, out);
+}
 static void
 wg_algo_mac_mac1(uint8_t out[], const size_t outsize,
     const uint8_t input1[], const size_t input1len,
     const uint8_t input2[], const size_t input2len)
+{
 	struct blake2s state;
 	/* [W] 5.4: LABEL-MAC1 */
 	const char *label = "mac1----";
 	uint8_t key[WG_HASH_LEN];
 	blake2s_init(&state, sizeof(key), NULL, 0);
 	blake2s_update(&state, label, strlen(label));
 	blake2s_update(&state, input1, input1len);
 	blake2s_final(&state, key);
 	blake2s_init(&state, outsize, key, sizeof(key));
 	if (input2 != NULL)
 		blake2s_update(&state, input2, input2len);
 	blake2s_final(&state, out);
+}
 static void
 wg_algo_mac_cookie(uint8_t out[], const size_t outsize,
     const uint8_t input1[], const size_t input1len)
+{
 	struct blake2s state;
 	/* [W] 5.4: LABEL-COOKIE */
 	const char *label = "cookie--";
 	blake2s_init(&state, outsize, NULL, 0);
 	blake2s_update(&state, label, strlen(label));
 	blake2s_update(&state, input1, input1len);
 	blake2s_final(&state, out);
+}
 static void
 wg_algo_generate_keypair(uint8_t pubkey[WG_EPHEMERAL_KEY_LEN],
     uint8_t privkey[WG_EPHEMERAL_KEY_LEN])
+{
 	CTASSERT(WG_EPHEMERAL_KEY_LEN == crypto_scalarmult_curve25519_BYTES);
 	cprng_strong(kern_cprng, privkey, WG_EPHEMERAL_KEY_LEN, 0);
 	crypto_scalarmult_base(pubkey, privkey);
+}
 static void
 wg_algo_dh(uint8_t out[WG_DH_OUTPUT_LEN],
     const uint8_t privkey[WG_STATIC_KEY_LEN],
     const uint8_t pubkey[WG_STATIC_KEY_LEN])
+{
 	CTASSERT(WG_STATIC_KEY_LEN == crypto_scalarmult_curve25519_BYTES);
 	int ret __diagused = crypto_scalarmult(out, privkey, pubkey);
 	KASSERT(ret == 0);
+}
 static void
 wg_algo_hmac(uint8_t out[], const size_t outlen,
     const uint8_t key[], const size_t keylen,
     const uint8_t in[], const size_t inlen)
+{
 #define IPAD	0x36
 #define OPAD	0x5c
 	uint8_t hmackey[HMAC_BLOCK_LEN] = {0};
 	uint8_t ipad[HMAC_BLOCK_LEN];
 	uint8_t opad[HMAC_BLOCK_LEN];
 	int i;
 	struct blake2s state;
 	KASSERT(outlen == WG_HASH_LEN);
 	KASSERT(keylen <= HMAC_BLOCK_LEN);
 	memcpy(hmackey, key, keylen);
 	for (i = 0; i < sizeof(hmackey); i++) {
 		ipad[i] = hmackey[i] ^ IPAD;
 		opad[i] = hmackey[i] ^ OPAD;
+	}
 	blake2s_init(&state, WG_HASH_LEN, NULL, 0);
 	blake2s_update(&state, ipad, sizeof(ipad));
 	blake2s_update(&state, in, inlen);
 	blake2s_final(&state, out);
 	blake2s_init(&state, WG_HASH_LEN, NULL, 0);
 	blake2s_update(&state, opad, sizeof(opad));
 	blake2s_update(&state, out, WG_HASH_LEN);
 	blake2s_final(&state, out);
 #undef IPAD
 #undef OPAD
+}
 static void
 wg_algo_kdf(uint8_t out1[WG_KDF_OUTPUT_LEN], uint8_t out2[WG_KDF_OUTPUT_LEN],
     uint8_t out3[WG_KDF_OUTPUT_LEN], const uint8_t ckey[WG_CHAINING_KEY_LEN],
     const uint8_t input[], const size_t inputlen)
+{
 	uint8_t tmp1[WG_KDF_OUTPUT_LEN], tmp2[WG_KDF_OUTPUT_LEN + 1];
 	uint8_t one[1];
 	/*
 	 * [N] 4.3: "an input_key_material byte sequence with length
 	 * either zero bytes, 32 bytes, or DHLEN bytes."
 	 */
 	KASSERT(inputlen == 0 || inputlen == 32 || inputlen == NOISE_DHLEN);
 	WG_DUMP_HASH("ckey", ckey);
 	if (input != NULL)
 		WG_DUMP_HASH("input", input);
 	wg_algo_hmac(tmp1, sizeof(tmp1), ckey, WG_CHAINING_KEY_LEN,
 	    input, inputlen);
 	WG_DUMP_HASH("tmp1", tmp1);
 	one[0] = 1;
 	wg_algo_hmac(out1, WG_KDF_OUTPUT_LEN, tmp1, sizeof(tmp1),
 	    one, sizeof(one));
 	WG_DUMP_HASH("out1", out1);
 	if (out2 == NULL)
 		return;
 	memcpy(tmp2, out1, WG_KDF_OUTPUT_LEN);
 	tmp2[WG_KDF_OUTPUT_LEN] = 2;
 	wg_algo_hmac(out2, WG_KDF_OUTPUT_LEN, tmp1, sizeof(tmp1),
 	    tmp2, sizeof(tmp2));
 	WG_DUMP_HASH("out2", out2);
 	if (out3 == NULL)
 		return;
 	memcpy(tmp2, out2, WG_KDF_OUTPUT_LEN);
 	tmp2[WG_KDF_OUTPUT_LEN] = 3;
 	wg_algo_hmac(out3, WG_KDF_OUTPUT_LEN, tmp1, sizeof(tmp1),
 	    tmp2, sizeof(tmp2));
 	WG_DUMP_HASH("out3", out3);
+}
 static void
 wg_algo_dh_kdf(uint8_t ckey[WG_CHAINING_KEY_LEN],
     uint8_t cipher_key[WG_CIPHER_KEY_LEN],
     const uint8_t local_key[WG_STATIC_KEY_LEN],
     const uint8_t remote_key[WG_STATIC_KEY_LEN])
+{
 	uint8_t dhout[WG_DH_OUTPUT_LEN];
 	wg_algo_dh(dhout, local_key, remote_key);
 	wg_algo_kdf(ckey, cipher_key, NULL, ckey, dhout, sizeof(dhout));
 	WG_DUMP_HASH("dhout", dhout);
 	WG_DUMP_HASH("ckey", ckey);
 	if (cipher_key != NULL)
 		WG_DUMP_HASH("cipher_key", cipher_key);
+}
 static void
 wg_algo_aead_enc(uint8_t out[], size_t expected_outsize, const uint8_t key[],
     const uint64_t counter, const uint8_t plain[], const size_t plainsize,
     const uint8_t auth[], size_t authlen)
+{
 	uint8_t nonce[(32 + 64) / 8] = {0};
 	long long unsigned int outsize;
 	int error __diagused;
 	memcpy(&nonce[4], &counter, sizeof(counter));
 	error = crypto_aead_chacha20poly1305_ietf_encrypt(out, &outsize, plain,
 	    plainsize, auth, authlen, NULL, nonce, key);
 	KASSERT(error == 0);
 	KASSERT(outsize == expected_outsize);
+}
 static int
 wg_algo_aead_dec(uint8_t out[], size_t expected_outsize, const uint8_t key[],
     const uint64_t counter, const uint8_t encrypted[],
     const size_t encryptedsize, const uint8_t auth[], size_t authlen)
+{
 	uint8_t nonce[(32 + 64) / 8] = {0};
 	long long unsigned int outsize;
 	int error;
 	memcpy(&nonce[4], &counter, sizeof(counter));
 @@ -1919,2001 +1919,2017 @@ wg_lookup_peer_by_pubkey(struct wg_softc
+}
 static void
 wg_fill_msg_cookie(struct wg_softc *wg, struct wg_peer *wgp,
     struct wg_msg_cookie *wgmc, const uint32_t sender,
     const uint8_t mac1[WG_MAC_LEN], const struct sockaddr *src)
+{
 	uint8_t cookie[WG_COOKIE_LEN];
 	uint8_t key[WG_HASH_LEN];
 	uint8_t addr[sizeof(struct in6_addr)];
 	size_t addrlen;
 	uint16_t uh_sport; /* be */
 	wgmc->wgmc_type = WG_MSG_TYPE_COOKIE;
 	wgmc->wgmc_receiver = sender;
 	cprng_fast(wgmc->wgmc_salt, sizeof(wgmc->wgmc_salt));
 	/*
 	 * [W] 5.4.7: Under Load: Cookie Reply Message
 	 * "The secret variable, Rm, changes every two minutes to a
 	 * random value"
 	 */
 	if ((time_uptime - wgp->wgp_last_genrandval_time) > WG_RANDVAL_TIME) {
 		wgp->wgp_randval = cprng_strong32();
 		wgp->wgp_last_genrandval_time = time_uptime;
+	}
 	switch (src->sa_family) {
 	case AF_INET: {
 		const struct sockaddr_in *sin = satocsin(src);
 		addrlen = sizeof(sin->sin_addr);
 		memcpy(addr, &sin->sin_addr, addrlen);
 		uh_sport = sin->sin_port;
 		break;
+	    }
 #ifdef INET6
 	case AF_INET6: {
 		const struct sockaddr_in6 *sin6 = satocsin6(src);
 		addrlen = sizeof(sin6->sin6_addr);
 		memcpy(addr, &sin6->sin6_addr, addrlen);
 		uh_sport = sin6->sin6_port;
 		break;
+	    }
 #endif
 	default:
 		panic("invalid af=%d", wgp->wgp_sa.sa_family);
+	}
 	wg_algo_mac(cookie, sizeof(cookie),
 	    (const uint8_t *)&wgp->wgp_randval, sizeof(wgp->wgp_randval),
 	    addr, addrlen, (const uint8_t *)&uh_sport, sizeof(uh_sport));
 	wg_algo_mac_cookie(key, sizeof(key), wg->wg_pubkey,
 	    sizeof(wg->wg_pubkey));
 	wg_algo_xaead_enc(wgmc->wgmc_cookie, sizeof(wgmc->wgmc_cookie), key,
 	    cookie, sizeof(cookie), mac1, WG_MAC_LEN, wgmc->wgmc_salt);
 	/* Need to store to calculate mac2 */
 	memcpy(wgp->wgp_last_sent_cookie, cookie, sizeof(cookie));
 	wgp->wgp_last_sent_cookie_valid = true;
+}
 static int
 wg_send_cookie_msg(struct wg_softc *wg, struct wg_peer *wgp,
     const uint32_t sender, const uint8_t mac1[WG_MAC_LEN],
     const struct sockaddr *src)
+{
 	int error;
 	struct mbuf *m;
 	struct wg_msg_cookie *wgmc;
 	m = m_gethdr(M_WAIT, MT_DATA);
 	m->m_pkthdr.len = m->m_len = sizeof(*wgmc);
 	wgmc = mtod(m, struct wg_msg_cookie *);
 	wg_fill_msg_cookie(wg, wgp, wgmc, sender, mac1, src);
 	error = wg->wg_ops->send_hs_msg(wgp, m);
 	if (error == 0)
 		WG_TRACE("cookie msg sent");
 	return error;
+}
 static bool
 wg_is_underload(struct wg_softc *wg, struct wg_peer *wgp, int msgtype)
+{
 #ifdef WG_DEBUG_PARAMS
 	if (wg_force_underload)
 		return true;
 #endif
 	/*
 	 * XXX we don't have a means of a load estimation.  The purpose of
 	 * the mechanism is a DoS mitigation, so we consider frequent handshake
 	 * messages as (a kind of) load; if a message of the same type comes
 	 * to a peer within 1 second, we consider we are under load.
 	 */
 	time_t last = wgp->wgp_last_msg_received_time[msgtype];
 	wgp->wgp_last_msg_received_time[msgtype] = time_uptime;
 	return (time_uptime - last) == 0;
+}
 static void
 wg_calculate_keys(struct wg_session *wgs, const bool initiator)
+{
 	/*
 	 * [W] 5.4.5: Ti^send = Tr^recv, Ti^recv = Tr^send := KDF2(Ci = Cr, e)
 	 */
 	if (initiator) {
 		wg_algo_kdf(wgs->wgs_tkey_send, wgs->wgs_tkey_recv, NULL,
 		    wgs->wgs_chaining_key, NULL, 0);
 	} else {
 		wg_algo_kdf(wgs->wgs_tkey_recv, wgs->wgs_tkey_send, NULL,
 		    wgs->wgs_chaining_key, NULL, 0);
+	}
 	WG_DUMP_HASH("wgs_tkey_send", wgs->wgs_tkey_send);
 	WG_DUMP_HASH("wgs_tkey_recv", wgs->wgs_tkey_recv);
+}
 static uint64_t
 wg_session_get_send_counter(struct wg_session *wgs)
+{
 #ifdef __HAVE_ATOMIC64_LOADSTORE
 	return atomic_load_relaxed(&wgs->wgs_send_counter);
 #else
 	uint64_t send_counter;
 	mutex_enter(&wgs->wgs_send_counter_lock);
 	send_counter = wgs->wgs_send_counter;
 	mutex_exit(&wgs->wgs_send_counter_lock);
 	return send_counter;
 #endif
+}
 static uint64_t
 wg_session_inc_send_counter(struct wg_session *wgs)
+{
 #ifdef __HAVE_ATOMIC64_LOADSTORE
 	return atomic_inc_64_nv(&wgs->wgs_send_counter) - 1;
 #else
 	uint64_t send_counter;
 	mutex_enter(&wgs->wgs_send_counter_lock);
 	send_counter = wgs->wgs_send_counter++;
 	mutex_exit(&wgs->wgs_send_counter_lock);
 	return send_counter;
 #endif
+}
 static void
 wg_clear_states(struct wg_session *wgs)
+{
 	wgs->wgs_send_counter = 0;
 	sliwin_reset(&wgs->wgs_recvwin->window);
 #define wgs_clear(v)	explicit_memset(wgs->wgs_##v, 0, sizeof(wgs->wgs_##v))
 	wgs_clear(handshake_hash);
 	wgs_clear(chaining_key);
 	wgs_clear(ephemeral_key_pub);
 	wgs_clear(ephemeral_key_priv);
 	wgs_clear(ephemeral_key_peer);
 #undef wgs_clear
+}
 static struct wg_session *
 wg_lookup_session_by_index(struct wg_softc *wg, const uint32_t index,
     struct psref *psref)
+{
 	struct wg_peer *wgp;
 	struct wg_session *wgs;
 	int s = pserialize_read_enter();
 	/* XXX O(n) */
 	WG_PEER_READER_FOREACH(wgp, wg) {
 		wgs = wgp->wgp_session_stable;
 		WG_DLOG("index=%x wgs_sender_index=%x\n",
 		    index, wgs->wgs_sender_index);
 		if (wgs->wgs_sender_index == index)
 			break;
 		wgs = wgp->wgp_session_unstable;
 		WG_DLOG("index=%x wgs_sender_index=%x\n",
 		    index, wgs->wgs_sender_index);
 		if (wgs->wgs_sender_index == index)
 			break;
 		wgs = NULL;
+	}
 	if (wgs != NULL)
 		psref_acquire(psref, &wgs->wgs_psref, wg_psref_class);
 	pserialize_read_exit(s);
 	return wgs;
+}
 static void
 wg_schedule_rekey_timer(struct wg_peer *wgp)
+{
 	int timeout = MIN(wg_rekey_after_time, INT_MAX/hz);
 	callout_schedule(&wgp->wgp_rekey_timer, timeout * hz);
+}
 static void
 wg_send_keepalive_msg(struct wg_peer *wgp, struct wg_session *wgs)
+{
 	struct mbuf *m;
 	/*
 	 * [W] 6.5 Passive Keepalive
 	 * "A keepalive message is simply a transport data message with
 	 *  a zero-length encapsulated encrypted inner-packet."
 	 */
 	m = m_gethdr(M_WAIT, MT_DATA);
 	wg_send_data_msg(wgp, wgs, m);
+}
 static bool
 wg_need_to_send_init_message(struct wg_session *wgs)
+{
 	/*
 	 * [W] 6.2 Transport Message Limits
 	 * "if a peer is the initiator of a current secure session,
 	 *  WireGuard will send a handshake initiation message to begin
 	 *  a new secure session ... if after receiving a transport data
 	 *  message, the current secure session is (REJECT-AFTER-TIME −
 	 *  KEEPALIVE-TIMEOUT − REKEY-TIMEOUT) seconds old and it has
 	 *  not yet acted upon this event."
 	 */
 	return wgs->wgs_is_initiator && wgs->wgs_time_last_data_sent == 0 &&
 	    (time_uptime - wgs->wgs_time_established) >=
 	    (wg_reject_after_time - wg_keepalive_timeout - wg_rekey_timeout);
+}
 static void
 wg_schedule_peer_task(struct wg_peer *wgp, int task)
+{
 	atomic_or_uint(&wgp->wgp_tasks, task);
 	WG_DLOG("tasks=%d, task=%d\n", wgp->wgp_tasks, task);
 	wg_wakeup_worker(wgp->wgp_sc->wg_worker, WG_WAKEUP_REASON_PEER);
+}
 static void
 wg_change_endpoint(struct wg_peer *wgp, const struct sockaddr *new)
+{
 	KASSERT(mutex_owned(wgp->wgp_lock));
 	WG_TRACE("Changing endpoint");
 	memcpy(wgp->wgp_endpoint0, new, new->sa_len);
 	wgp->wgp_endpoint0 = atomic_swap_ptr(&wgp->wgp_endpoint,
 	    wgp->wgp_endpoint0);
 	if (!wgp->wgp_endpoint_available)
 		wgp->wgp_endpoint_available = true;
 	wgp->wgp_endpoint_changing = true;
 	wg_schedule_peer_task(wgp, WGP_TASK_ENDPOINT_CHANGED);
+}
 static bool
 wg_validate_inner_packet(const char *packet, size_t decrypted_len, int *af)
+{
 	uint16_t packet_len;
 	const struct ip *ip;
 	if (__predict_false(decrypted_len < sizeof(struct ip)))
 		return false;
 	ip = (const struct ip *)packet;
 	if (ip->ip_v == 4)
 		*af = AF_INET;
 	else if (ip->ip_v == 6)
 		*af = AF_INET6;
 	else
 		return false;
 	WG_DLOG("af=%d\n", *af);
 	if (*af == AF_INET) {
 		packet_len = ntohs(ip->ip_len);
 	} else {
 		const struct ip6_hdr *ip6;
 		if (__predict_false(decrypted_len < sizeof(struct ip6_hdr)))
 			return false;
 		ip6 = (const struct ip6_hdr *)packet;
 		packet_len = sizeof(struct ip6_hdr) + ntohs(ip6->ip6_plen);
+	}
 	WG_DLOG("packet_len=%u\n", packet_len);
 	if (packet_len > decrypted_len)
 		return false;
 	return true;
+}
 static bool
 wg_validate_route(struct wg_softc *wg, struct wg_peer *wgp_expected,
     int af, char *packet)
+{
 	struct sockaddr_storage ss;
 	struct sockaddr *sa;
 	struct psref psref;
 	struct wg_peer *wgp;
 	bool ok;
 	/*
 	 * II CRYPTOKEY ROUTING
 	 * "it will only accept it if its source IP resolves in the
 	 *  table to the public key used in the secure session for
 	 *  decrypting it."
 	 */
 	if (af == AF_INET) {
 		const struct ip *ip = (const struct ip *)packet;
 		struct sockaddr_in *sin = (struct sockaddr_in *)&ss;
 		sockaddr_in_init(sin, &ip->ip_src, 0);
 		sa = sintosa(sin);
 #ifdef INET6
 	} else {
 		const struct ip6_hdr *ip6 = (const struct ip6_hdr *)packet;
 		struct sockaddr_in6 *sin6 = (struct sockaddr_in6 *)&ss;
 		sockaddr_in6_init(sin6, &ip6->ip6_src, 0, 0, 0);
 		sa = sin6tosa(sin6);
 #endif
+	}
 	wgp = wg_pick_peer_by_sa(wg, sa, &psref);
 	ok = (wgp == wgp_expected);
 	if (wgp != NULL)
 		wg_put_peer(wgp, &psref);
 	return ok;
+}
 static void
 wg_session_dtor_timer(void *arg)
+{
 	struct wg_peer *wgp = arg;
 	WG_TRACE("enter");
 	mutex_enter(wgp->wgp_lock);
 	if (__predict_false(wgp->wgp_state == WGP_STATE_DESTROYING)) {
 		mutex_exit(wgp->wgp_lock);
 		return;
+	}
 	mutex_exit(wgp->wgp_lock);
 	wg_schedule_peer_task(wgp, WGP_TASK_DESTROY_PREV_SESSION);
+}
 static void
 wg_schedule_session_dtor_timer(struct wg_peer *wgp)
+{
 	/* 1 second grace period */
 	callout_schedule(&wgp->wgp_session_dtor_timer, hz);
+}
 static void
 wg_stop_session_dtor_timer(struct wg_peer *wgp)
+{
 	callout_halt(&wgp->wgp_session_dtor_timer, NULL);
+}
 static bool
 sockaddr_port_match(const struct sockaddr *sa1, const struct sockaddr *sa2)
+{
 	if (sa1->sa_family != sa2->sa_family)
 		return false;
 	switch (sa1->sa_family) {
 	case AF_INET:
 		return satocsin(sa1)->sin_port == satocsin(sa2)->sin_port;
 	case AF_INET6:
 		return satocsin6(sa1)->sin6_port == satocsin6(sa2)->sin6_port;
 	default:
 		return true;
+	}
+}
 static void
 wg_update_endpoint_if_necessary(struct wg_peer *wgp,
     const struct sockaddr *src)
+{
 #ifdef WG_DEBUG_LOG
 	char oldaddr[128], newaddr[128];
 	sockaddr_format(&wgp->wgp_sa, oldaddr, sizeof(oldaddr));
 	sockaddr_format(src, newaddr, sizeof(newaddr));
 	WG_DLOG("old=%s, new=%s\n", oldaddr, newaddr);
 #endif
 	/*
 	 * III: "Since the packet has authenticated correctly, the source IP of
 	 * the outer UDP/IP packet is used to update the endpoint for peer..."
 	 */
 	if (__predict_false(sockaddr_cmp(src, &wgp->wgp_sa) != 0 ||
 	                    !sockaddr_port_match(src, &wgp->wgp_sa))) {
 		mutex_enter(wgp->wgp_lock);
 		/* XXX We can't change the endpoint twice in a short period */
 		if (!wgp->wgp_endpoint_changing) {
 			wg_change_endpoint(wgp, src);
+		}
 		mutex_exit(wgp->wgp_lock);
+	}
+}
 static void
 wg_handle_msg_data(struct wg_softc *wg, struct mbuf *m,
     const struct sockaddr *src)
+{
 	struct wg_msg_data *wgmd;
 	char *encrypted_buf = NULL, *decrypted_buf;
 	size_t encrypted_len, decrypted_len;
 	struct wg_session *wgs;
 	struct wg_peer *wgp;
 	size_t mlen;
 	struct psref psref;
 	int error, af;
 	bool success, free_encrypted_buf = false, ok;
 	struct mbuf *n;
 	if (m->m_len < sizeof(struct wg_msg_data)) {
 		m = m_pullup(m, sizeof(struct wg_msg_data));
 		if (m == NULL)
 			return;
+	}
 	wgmd = mtod(m, struct wg_msg_data *);
 	KASSERT(wgmd->wgmd_type == WG_MSG_TYPE_DATA);
 	WG_TRACE("data");
 	wgs = wg_lookup_session_by_index(wg, wgmd->wgmd_receiver, &psref);
 	if (wgs == NULL) {
 		WG_TRACE("No session found");
 		m_freem(m);
 		return;
+	}
 	wgp = wgs->wgs_peer;
 	error = sliwin_check_fast(&wgs->wgs_recvwin->window,
 	    wgmd->wgmd_counter);
 	if (error) {
 		WG_LOG_RATECHECK(&wgp->wgp_ppsratecheck, LOG_DEBUG,
 		    "out-of-window packet: %"PRIu64"\n",
 		    wgmd->wgmd_counter);
 		goto out;
+	}
 	mlen = m_length(m);
 	encrypted_len = mlen - sizeof(*wgmd);
 	if (encrypted_len < WG_AUTHTAG_LEN) {
 		WG_DLOG("Short encrypted_len: %lu\n", encrypted_len);
 		goto out;
+	}
 	success = m_ensure_contig(&m, sizeof(*wgmd) + encrypted_len);
 	if (success) {
 		encrypted_buf = mtod(m, char *) + sizeof(*wgmd);
 	} else {
 		encrypted_buf = kmem_intr_alloc(encrypted_len, KM_NOSLEEP);
 		if (encrypted_buf == NULL) {
 			WG_DLOG("failed to allocate encrypted_buf\n");
 			goto out;
+		}
 		m_copydata(m, sizeof(*wgmd), encrypted_len, encrypted_buf);
 		free_encrypted_buf = true;
+	}
 	/* m_ensure_contig may change m regardless of its result */
 	wgmd = mtod(m, struct wg_msg_data *);
 	decrypted_len = encrypted_len - WG_AUTHTAG_LEN;
 	if (decrypted_len > MCLBYTES) {
 		/* FIXME handle larger data than MCLBYTES */
 		WG_DLOG("couldn't handle larger data than MCLBYTES\n");
 		goto out;
+	}
 	/* To avoid zero length */
 	n = wg_get_mbuf(0, decrypted_len + WG_AUTHTAG_LEN);
 	if (n == NULL) {
 		WG_DLOG("wg_get_mbuf failed\n");
 		goto out;
+	}
 	decrypted_buf = mtod(n, char *);
 	WG_DLOG("mlen=%lu, encrypted_len=%lu\n", mlen, encrypted_len);
 	error = wg_algo_aead_dec(decrypted_buf,
 	    encrypted_len - WG_AUTHTAG_LEN /* can be 0 */,
 	    wgs->wgs_tkey_recv, wgmd->wgmd_counter, encrypted_buf,
 	    encrypted_len, NULL, 0);
 	if (error != 0) {
 		WG_LOG_RATECHECK(&wgp->wgp_ppsratecheck, LOG_DEBUG,
 		    "failed to wg_algo_aead_dec\n");
 		m_freem(n);
 		goto out;
+	}
 	WG_DLOG("outsize=%u\n", (u_int)decrypted_len);
 	mutex_enter(&wgs->wgs_recvwin->lock);
 	error = sliwin_update(&wgs->wgs_recvwin->window,
 	    wgmd->wgmd_counter);
 	mutex_exit(&wgs->wgs_recvwin->lock);
 	if (error) {
 		WG_LOG_RATECHECK(&wgp->wgp_ppsratecheck, LOG_DEBUG,
 		    "replay or out-of-window packet: %"PRIu64"\n",
 		    wgmd->wgmd_counter);
 		m_freem(n);
 		goto out;
+	}
 	m_freem(m);
 	m = NULL;
 	wgmd = NULL;
 	ok = wg_validate_inner_packet(decrypted_buf, decrypted_len, &af);
 	if (!ok) {
 		/* something wrong... */
 		m_freem(n);
 		goto out;
+	}
 	wg_update_endpoint_if_necessary(wgp, src);
 	ok = wg_validate_route(wg, wgp, af, decrypted_buf);
 	if (ok) {
 		wg->wg_ops->input(&wg->wg_if, n, af);
 	} else {
 		WG_LOG_RATECHECK(&wgp->wgp_ppsratecheck, LOG_DEBUG,
 		    "invalid source address\n");
 		m_freem(n);
 		/*
 		 * The inner address is invalid however the session is valid
 		 * so continue the session processing below.
 		 */
+	}
 	n = NULL;
 	if (wgs->wgs_state == WGS_STATE_INIT_PASSIVE) {
 		struct wg_session *wgs_prev;
 		KASSERT(wgs == wgp->wgp_session_unstable);
 		wgs->wgs_state = WGS_STATE_ESTABLISHED;
 		wgs->wgs_time_established = time_uptime;
 		wgs->wgs_time_last_data_sent = 0;
 		wgs->wgs_is_initiator = false;
 		WG_TRACE("WGS_STATE_ESTABLISHED");
 		mutex_enter(wgp->wgp_lock);
 		wg_swap_sessions(wgp);
 		wgs_prev = wgp->wgp_session_unstable;
 		mutex_enter(wgs_prev->wgs_lock);
 		getnanotime(&wgp->wgp_last_handshake_time);
 		wgp->wgp_handshake_start_time = 0;
 		wgp->wgp_last_sent_mac1_valid = false;
 		wgp->wgp_last_sent_cookie_valid = false;
 		mutex_exit(wgp->wgp_lock);
 		if (wgs_prev->wgs_state == WGS_STATE_ESTABLISHED) {
 			wgs_prev->wgs_state = WGS_STATE_DESTROYING;
 			/* We can't destroy the old session immediately */
 			wg_schedule_session_dtor_timer(wgp);
 		} else {
 			wg_clear_states(wgs_prev);
 			wgs_prev->wgs_state = WGS_STATE_UNKNOWN;
+		}
 		mutex_exit(wgs_prev->wgs_lock);
 		/* Anyway run a softint to flush pending packets */
 		kpreempt_disable();
 		softint_schedule(wgp->wgp_si);
 		kpreempt_enable();
 	} else {
 		if (__predict_false(wg_need_to_send_init_message(wgs))) {
 			wg_schedule_peer_task(wgp, WGP_TASK_SEND_INIT_MESSAGE);
+		}
 		/*
 		 * [W] 6.5 Passive Keepalive
 		 * "If a peer has received a validly-authenticated transport
 		 *  data message (section 5.4.6), but does not have any packets
 		 *  itself to send back for KEEPALIVE-TIMEOUT seconds, it sends
 		 *  a keepalive message."
 		 */
 		WG_DLOG("time_uptime=%lu wgs_time_last_data_sent=%lu\n",
 		    time_uptime, wgs->wgs_time_last_data_sent);
 		if ((time_uptime - wgs->wgs_time_last_data_sent) >=
 		    wg_keepalive_timeout) {
 			WG_TRACE("Schedule sending keepalive message");
 			/*
 			 * We can't send a keepalive message here to avoid
 			 * a deadlock;  we already hold the solock of a socket
 			 * that is used to send the message.
 			 */
 			wg_schedule_peer_task(wgp,
 			    WGP_TASK_SEND_KEEPALIVE_MESSAGE);
+		}
+	}
 out:
 	wg_put_session(wgs, &psref);
 	if (m != NULL)
 		m_freem(m);
 	if (free_encrypted_buf)
 		kmem_intr_free(encrypted_buf, encrypted_len);
+}
 static void
 wg_handle_msg_cookie(struct wg_softc *wg, const struct wg_msg_cookie *wgmc)
+{
 	struct wg_session *wgs;
 	struct wg_peer *wgp;
 	struct psref psref;
 	int error;
 	uint8_t key[WG_HASH_LEN];
 	uint8_t cookie[WG_COOKIE_LEN];
 	WG_TRACE("cookie msg received");
 	wgs = wg_lookup_session_by_index(wg, wgmc->wgmc_receiver, &psref);
 	if (wgs == NULL) {
 		WG_TRACE("No session found");
 		return;
+	}
 	wgp = wgs->wgs_peer;
 	if (!wgp->wgp_last_sent_mac1_valid) {
 		WG_TRACE("No valid mac1 sent (or expired)");
 		goto out;
+	}
 	wg_algo_mac_cookie(key, sizeof(key), wgp->wgp_pubkey,
 	    sizeof(wgp->wgp_pubkey));
 	error = wg_algo_xaead_dec(cookie, sizeof(cookie), key, 0,
 	    wgmc->wgmc_cookie, sizeof(wgmc->wgmc_cookie),
 	    wgp->wgp_last_sent_mac1, sizeof(wgp->wgp_last_sent_mac1),
 	    wgmc->wgmc_salt);
 	if (error != 0) {
 		WG_LOG_RATECHECK(&wgp->wgp_ppsratecheck, LOG_DEBUG,
 		    "wg_algo_aead_dec for cookie failed: error=%d\n", error);
 		goto out;
+	}
 	/*
 	 * [W] 6.6: Interaction with Cookie Reply System
 	 * "it should simply store the decrypted cookie value from the cookie
 	 *  reply message, and wait for the expiration of the REKEY-TIMEOUT
 	 *  timer for retrying a handshake initiation message."
 	 */
 	wgp->wgp_latest_cookie_time = time_uptime;
 	memcpy(wgp->wgp_latest_cookie, cookie, sizeof(wgp->wgp_latest_cookie));
 out:
 	wg_put_session(wgs, &psref);
+}
 static bool
 wg_validate_msg_length(struct wg_softc *wg, const struct mbuf *m)
+{
 	struct wg_msg *wgm;
 	size_t mlen;
 	mlen = m_length(m);
 	if (__predict_false(mlen < sizeof(struct wg_msg)))
 		return false;
 	wgm = mtod(m, struct wg_msg *);
 	switch (wgm->wgm_type) {
 	case WG_MSG_TYPE_INIT:
 		if (__predict_true(mlen >= sizeof(struct wg_msg_init)))
 			return true;
 		break;
 	case WG_MSG_TYPE_RESP:
 		if (__predict_true(mlen >= sizeof(struct wg_msg_resp)))
 			return true;
 		break;
 	case WG_MSG_TYPE_COOKIE:
 		if (__predict_true(mlen >= sizeof(struct wg_msg_cookie)))
 			return true;
 		break;
 	case WG_MSG_TYPE_DATA:
 		if (__predict_true(mlen >= sizeof(struct wg_msg_data)))
 			return true;
 		break;
 	default:
 		WG_LOG_RATECHECK(&wg->wg_ppsratecheck, LOG_DEBUG,
 		    "Unexpected msg type: %u\n", wgm->wgm_type);
 		return false;
+	}
 	WG_DLOG("Invalid msg size: mlen=%lu type=%u\n", mlen, wgm->wgm_type);
 	return false;
+}
 static void
 wg_handle_packet(struct wg_softc *wg, struct mbuf *m,
     const struct sockaddr *src)
+{
 	struct wg_msg *wgm;
 	bool valid;
 	valid = wg_validate_msg_length(wg, m);
 	if (!valid) {
 		m_freem(m);
 		return;
+	}
 	wgm = mtod(m, struct wg_msg *);
 	switch (wgm->wgm_type) {
 	case WG_MSG_TYPE_INIT:
 		wg_handle_msg_init(wg, (struct wg_msg_init *)wgm, src);
 		break;
 	case WG_MSG_TYPE_RESP:
 		wg_handle_msg_resp(wg, (struct wg_msg_resp *)wgm, src);
 		break;
 	case WG_MSG_TYPE_COOKIE:
 		wg_handle_msg_cookie(wg, (struct wg_msg_cookie *)wgm);
 		break;
 	case WG_MSG_TYPE_DATA:
 		wg_handle_msg_data(wg, m, src);
 		break;
 	default:
 		/* wg_validate_msg_length should already reject this case */
 		break;
+	}
+}
 static void
 wg_receive_packets(struct wg_softc *wg, const int af)
+{
 	for (;;) {
 		int error, flags;
 		struct socket *so;
 		struct mbuf *m = NULL;
 		struct uio dummy_uio;
 		struct mbuf *paddr = NULL;
 		struct sockaddr *src;
 		so = wg_get_so_by_af(wg->wg_worker, af);
 		flags = MSG_DONTWAIT;
 		dummy_uio.uio_resid = 1000000000;
 		error = so->so_receive(so, &paddr, &dummy_uio, &m, NULL,
 		    &flags);
 		if (error || m == NULL) {
 			//if (error == EWOULDBLOCK)
 			return;
+		}
 		KASSERT(paddr != NULL);
 		src = mtod(paddr, struct sockaddr *);
 		wg_handle_packet(wg, m, src);
+	}
+}
 static void
 wg_get_peer(struct wg_peer *wgp, struct psref *psref)
+{
 	psref_acquire(psref, &wgp->wgp_psref, wg_psref_class);
+}
 static void
 wg_put_peer(struct wg_peer *wgp, struct psref *psref)
+{
 	psref_release(psref, &wgp->wgp_psref, wg_psref_class);
+}
 static void
 wg_task_send_init_message(struct wg_softc *wg, struct wg_peer *wgp)
+{
 	struct psref psref;
 	struct wg_session *wgs;
 	WG_TRACE("WGP_TASK_SEND_INIT_MESSAGE");
 	if (!wgp->wgp_endpoint_available) {
 		WGLOG(LOG_DEBUG, "No endpoint available\n");
 		/* XXX should do something? */
 		return;
+	}
 	wgs = wg_get_stable_session(wgp, &psref);
 	if (wgs->wgs_state == WGS_STATE_UNKNOWN) {
 		wg_put_session(wgs, &psref);
 		wg_send_handshake_msg_init(wg, wgp);
 	} else {
 		wg_put_session(wgs, &psref);
 		/* rekey */
 		wgs = wg_get_unstable_session(wgp, &psref);
 		if (wgs->wgs_state != WGS_STATE_INIT_ACTIVE)
 			wg_send_handshake_msg_init(wg, wgp);
 		wg_put_session(wgs, &psref);
+	}
+}
 static void
 wg_task_endpoint_changed(struct wg_softc *wg, struct wg_peer *wgp)
+{
 	WG_TRACE("WGP_TASK_ENDPOINT_CHANGED");
 	mutex_enter(wgp->wgp_lock);
 	if (wgp->wgp_endpoint_changing) {
 		pserialize_perform(wgp->wgp_psz);
 		psref_target_destroy(&wgp->wgp_endpoint0->wgsa_psref,
 		    wg_psref_class);
 		psref_target_init(&wgp->wgp_endpoint0->wgsa_psref,
 		    wg_psref_class);
 		wgp->wgp_endpoint_changing = false;
+	}
 	mutex_exit(wgp->wgp_lock);
+}
 static void
 wg_task_send_keepalive_message(struct wg_softc *wg, struct wg_peer *wgp)
+{
 	struct psref psref;
 	struct wg_session *wgs;
 	WG_TRACE("WGP_TASK_SEND_KEEPALIVE_MESSAGE");
 	wgs = wg_get_stable_session(wgp, &psref);
 	wg_send_keepalive_msg(wgp, wgs);
 	wg_put_session(wgs, &psref);
+}
 static void
 wg_task_destroy_prev_session(struct wg_softc *wg, struct wg_peer *wgp)
+{
 	struct wg_session *wgs;
 	WG_TRACE("WGP_TASK_DESTROY_PREV_SESSION");
 	mutex_enter(wgp->wgp_lock);
 	wgs = wgp->wgp_session_unstable;
 	mutex_enter(wgs->wgs_lock);
 	if (wgs->wgs_state == WGS_STATE_DESTROYING) {
 		pserialize_perform(wgp->wgp_psz);
 		psref_target_destroy(&wgs->wgs_psref, wg_psref_class);
 		psref_target_init(&wgs->wgs_psref, wg_psref_class);
 		wg_clear_states(wgs);
 		wgs->wgs_state = WGS_STATE_UNKNOWN;
+	}
 	mutex_exit(wgs->wgs_lock);
 	mutex_exit(wgp->wgp_lock);
+}
 static void
 wg_process_peer_tasks(struct wg_softc *wg)
+{
 	struct wg_peer *wgp;
 	int s;
 	/* XXX should avoid checking all peers */
 	s = pserialize_read_enter();
 	WG_PEER_READER_FOREACH(wgp, wg) {
 		struct psref psref;
 		unsigned int tasks;
 		if (wgp->wgp_tasks == 0)
 			continue;
 		wg_get_peer(wgp, &psref);
 		pserialize_read_exit(s);
 	restart:
 		tasks = atomic_swap_uint(&wgp->wgp_tasks, 0);
 		KASSERT(tasks != 0);
 		WG_DLOG("tasks=%x\n", tasks);
 		if (ISSET(tasks, WGP_TASK_SEND_INIT_MESSAGE))
 			wg_task_send_init_message(wg, wgp);
 		if (ISSET(tasks, WGP_TASK_ENDPOINT_CHANGED))
 			wg_task_endpoint_changed(wg, wgp);
 		if (ISSET(tasks, WGP_TASK_SEND_KEEPALIVE_MESSAGE))
 			wg_task_send_keepalive_message(wg, wgp);
 		if (ISSET(tasks, WGP_TASK_DESTROY_PREV_SESSION))
 			wg_task_destroy_prev_session(wg, wgp);
 		/* New tasks may be scheduled during processing tasks */
 		WG_DLOG("wgp_tasks=%d\n", wgp->wgp_tasks);
 		if (wgp->wgp_tasks != 0)
 			goto restart;
 		s = pserialize_read_enter();
 		wg_put_peer(wgp, &psref);
+	}
 	pserialize_read_exit(s);
+}
 static void
 wg_worker(void *arg)
+{
 	struct wg_softc *wg = arg;
 	struct wg_worker *wgw = wg->wg_worker;
 	bool todie = false;
 	KASSERT(wg != NULL);
 	KASSERT(wgw != NULL);
 	while (!todie) {
 		int reasons;
 		int bound;
 		mutex_enter(&wgw->wgw_lock);
 		/* New tasks may come during task handling */
 		while ((reasons = wgw->wgw_wakeup_reasons) == 0 &&
 		    !(todie = wgw->wgw_todie))
 			cv_wait(&wgw->wgw_cv, &wgw->wgw_lock);
 		wgw->wgw_wakeup_reasons = 0;
 		mutex_exit(&wgw->wgw_lock);
 		bound = curlwp_bind();
 		if (ISSET(reasons, WG_WAKEUP_REASON_RECEIVE_PACKETS_IPV4))
 			wg_receive_packets(wg, AF_INET);
 		if (ISSET(reasons, WG_WAKEUP_REASON_RECEIVE_PACKETS_IPV6))
 			wg_receive_packets(wg, AF_INET6);
 		if (ISSET(reasons, WG_WAKEUP_REASON_PEER))
 			wg_process_peer_tasks(wg);
 		curlwp_bindx(bound);
+	}
 	kthread_exit(0);
+}
 static void
 wg_wakeup_worker(struct wg_worker *wgw, const int reason)
+{
 	mutex_enter(&wgw->wgw_lock);
 	wgw->wgw_wakeup_reasons |= reason;
 	cv_broadcast(&wgw->wgw_cv);
 	mutex_exit(&wgw->wgw_lock);
+}
 static int
 wg_bind_port(struct wg_softc *wg, const uint16_t port)
+{
 	int error;
 	struct wg_worker *wgw = wg->wg_worker;
 	uint16_t old_port = wg->wg_listen_port;
 	if (port != 0 && old_port == port)
 		return 0;
 	struct sockaddr_in _sin, *sin = &_sin;
 	sin->sin_len = sizeof(*sin);
 	sin->sin_family = AF_INET;
 	sin->sin_addr.s_addr = INADDR_ANY;
 	sin->sin_port = htons(port);
 	error = sobind(wgw->wgw_so4, sintosa(sin), curlwp);
 	if (error != 0)
 		return error;
 #ifdef INET6
 	struct sockaddr_in6 _sin6, *sin6 = &_sin6;
 	sin6->sin6_len = sizeof(*sin6);
 	sin6->sin6_family = AF_INET6;
 	sin6->sin6_addr = in6addr_any;
 	sin6->sin6_port = htons(port);
 	error = sobind(wgw->wgw_so6, sin6tosa(sin6), curlwp);
 	if (error != 0)
 		return error;
 #endif
 	wg->wg_listen_port = port;
 	return 0;
+}
 static void
 wg_so_upcall(struct socket *so, void *arg, int events, int waitflag)
+{
 	struct wg_worker *wgw = arg;
 	int reason;
 	reason = (so->so_proto->pr_domain->dom_family == AF_INET) ?
 	    WG_WAKEUP_REASON_RECEIVE_PACKETS_IPV4 :
 	    WG_WAKEUP_REASON_RECEIVE_PACKETS_IPV6;
 	wg_wakeup_worker(wgw, reason);
+}
 static int
 wg_overudp_cb(struct mbuf **mp, int offset, struct socket *so,
     struct sockaddr *src, void *arg)
+{
 	struct wg_softc *wg = arg;
 	struct wg_msg wgm;
 	struct mbuf *m = *mp;
 	WG_TRACE("enter");
 	/* Verify the mbuf chain is long enough to have a wg msg header.  */
 	KASSERT(offset <= m_length(m));
 	if (__predict_false(m_length(m) - offset < sizeof(struct wg_msg))) {
 		m_freem(m);
 		return -1;
+	}
 	/*
 	 * Copy the message header (32-bit message type) out -- we'll
 	 * worry about contiguity and alignment later.
 	 */
 	m_copydata(m, offset, sizeof(struct wg_msg), &wgm);
 	WG_DLOG("type=%d\n", wgm.wgm_type);
 	/*
 	 * Handle DATA packets promptly as they arrive.  Other packets
 	 * may require expensive public-key crypto and are not as
 	 * sensitive to latency, so defer them to the worker thread.
 	 */
 	switch (wgm.wgm_type) {
 	case WG_MSG_TYPE_DATA:
 		m_adj(m, offset);
 		wg_handle_msg_data(wg, m, src);
 		*mp = NULL;
 		return 1;
 	default:
 		break;
+	}
 	return 0;
+}
 static int
 wg_worker_socreate(struct wg_softc *wg, struct wg_worker *wgw, const int af,
     struct socket **sop)
+{
 	int error;
 	struct socket *so;
 	error = socreate(af, &so, SOCK_DGRAM, 0, curlwp, NULL);
 	if (error != 0)
 		return error;
 	solock(so);
 	so->so_upcallarg = wgw;
 	so->so_upcall = wg_so_upcall;
 	so->so_rcv.sb_flags |= SB_UPCALL;
 	if (af == AF_INET)
 		in_pcb_register_overudp_cb(sotoinpcb(so), wg_overudp_cb, wg);
 #if INET6
 	else
 		in6_pcb_register_overudp_cb(sotoin6pcb(so), wg_overudp_cb, wg);
 #endif
 	sounlock(so);
 	*sop = so;
 	return 0;
+}
 static int
 wg_worker_init(struct wg_softc *wg)
+{
 	int error;
 	struct wg_worker *wgw;
 	const char *ifname = wg->wg_if.if_xname;
 	struct socket *so;
 	wgw = kmem_zalloc(sizeof(struct wg_worker), KM_SLEEP);
 	mutex_init(&wgw->wgw_lock, MUTEX_DEFAULT, IPL_NONE);
 	cv_init(&wgw->wgw_cv, ifname);
 	wgw->wgw_todie = false;
 	wgw->wgw_wakeup_reasons = 0;
 	error = wg_worker_socreate(wg, wgw, AF_INET, &so);
 	if (error != 0)
 		goto error;
 	wgw->wgw_so4 = so;
 #ifdef INET6
 	error = wg_worker_socreate(wg, wgw, AF_INET6, &so);
 	if (error != 0)
 		goto error;
 	wgw->wgw_so6 = so;
 #endif
 	wg->wg_worker = wgw;
 	error = kthread_create(PRI_NONE, KTHREAD_MPSAFE | KTHREAD_MUSTJOIN,
 	    NULL, wg_worker, wg, &wg->wg_worker_lwp, "%s", ifname);
 	if (error != 0)
 		goto error;
 	return 0;
 error:
 #ifdef INET6
 	if (wgw->wgw_so6 != NULL)
 		soclose(wgw->wgw_so6);
 #endif
 	if (wgw->wgw_so4 != NULL)
 		soclose(wgw->wgw_so4);
 	cv_destroy(&wgw->wgw_cv);
 	mutex_destroy(&wgw->wgw_lock);
 	return error;
+}
 static void
 wg_worker_destroy(struct wg_softc *wg)
+{
 	struct wg_worker *wgw = wg->wg_worker;
 	mutex_enter(&wgw->wgw_lock);
 	wgw->wgw_todie = true;
 	wgw->wgw_wakeup_reasons = 0;
 	cv_broadcast(&wgw->wgw_cv);
 	mutex_exit(&wgw->wgw_lock);
 	kthread_join(wg->wg_worker_lwp);
 #ifdef INET6
 	soclose(wgw->wgw_so6);
 #endif
 	soclose(wgw->wgw_so4);
 	cv_destroy(&wgw->wgw_cv);
 	mutex_destroy(&wgw->wgw_lock);
 	kmem_free(wg->wg_worker, sizeof(struct wg_worker));
 	wg->wg_worker = NULL;
+}
 static bool
 wg_session_hit_limits(struct wg_session *wgs)
+{
 	/*
 	 * [W] 6.2: Transport Message Limits
 	 * "After REJECT-AFTER-MESSAGES transport data messages or after the
 	 *  current secure session is REJECT-AFTER-TIME seconds old, whichever
 	 *  comes first, WireGuard will refuse to send any more transport data
 	 *  messages using the current secure session, ..."
 	 */
 	KASSERT(wgs->wgs_time_established != 0);
 	if ((time_uptime - wgs->wgs_time_established) > wg_reject_after_time) {
 		WG_DLOG("The session hits REJECT_AFTER_TIME\n");
 		return true;
 	} else if (wg_session_get_send_counter(wgs) >
 	    wg_reject_after_messages) {
 		WG_DLOG("The session hits REJECT_AFTER_MESSAGES\n");
 		return true;
+	}
 	return false;
+}
 static void
 wg_peer_softint(void *arg)
+{
 	struct wg_peer *wgp = arg;
 	struct wg_session *wgs;
 	struct mbuf *m;
 	struct psref psref;
 	wgs = wg_get_stable_session(wgp, &psref);
 	if (wgs->wgs_state != WGS_STATE_ESTABLISHED) {
 		/* XXX how to treat? */
 		WG_TRACE("skipped");
 		goto out;
+	}
 	if (wg_session_hit_limits(wgs)) {
 		wg_schedule_peer_task(wgp, WGP_TASK_SEND_INIT_MESSAGE);
 		goto out;
+	}
 	WG_TRACE("running");
 	while ((m = pcq_get(wgp->wgp_q)) != NULL) {
 		wg_send_data_msg(wgp, wgs, m);
+	}
 out:
 	wg_put_session(wgs, &psref);
+}
 static void
 wg_rekey_timer(void *arg)
+{
 	struct wg_peer *wgp = arg;
 	mutex_enter(wgp->wgp_lock);
 	if (__predict_true(wgp->wgp_state != WGP_STATE_DESTROYING)) {
 		wg_schedule_peer_task(wgp, WGP_TASK_SEND_INIT_MESSAGE);
+	}
 	mutex_exit(wgp->wgp_lock);
+}
 static void
 wg_purge_pending_packets(struct wg_peer *wgp)
+{
 	struct mbuf *m;
 	while ((m = pcq_get(wgp->wgp_q)) != NULL) {
 		m_freem(m);
+	}
+}
 static void
 wg_handshake_timeout_timer(void *arg)
+{
 	struct wg_peer *wgp = arg;
 	struct wg_session *wgs;
 	struct psref psref;
 	WG_TRACE("enter");
 	mutex_enter(wgp->wgp_lock);
 	if (__predict_false(wgp->wgp_state == WGP_STATE_DESTROYING)) {
 		mutex_exit(wgp->wgp_lock);
 		return;
+	}
 	mutex_exit(wgp->wgp_lock);
 	KASSERT(wgp->wgp_handshake_start_time != 0);
 	wgs = wg_get_unstable_session(wgp, &psref);
 	KASSERT(wgs->wgs_state == WGS_STATE_INIT_ACTIVE);
 	/* [W] 6.4 Handshake Initiation Retransmission */
 	if ((time_uptime - wgp->wgp_handshake_start_time) >
 	    wg_rekey_attempt_time) {
 		/* Give up handshaking */
 		wgs->wgs_state = WGS_STATE_UNKNOWN;
 		wg_clear_states(wgs);
 		wgp->wgp_state = WGP_STATE_GIVEUP;
 		wgp->wgp_handshake_start_time = 0;
 		wg_put_session(wgs, &psref);
 		WG_TRACE("give up");
 		/*
 		 * If a new data packet comes, handshaking will be retried
 		 * and a new session would be established at that time,
 		 * however we don't want to send pending packets then.
 		 */
 		wg_purge_pending_packets(wgp);
 		return;
+	}
 	/* No response for an initiation message sent, retry handshaking */
 	wgs->wgs_state = WGS_STATE_UNKNOWN;
 	wg_clear_states(wgs);
 	wg_put_session(wgs, &psref);
 	wg_schedule_peer_task(wgp, WGP_TASK_SEND_INIT_MESSAGE);
+}
 static struct wg_peer *
 wg_alloc_peer(struct wg_softc *wg)
+{
 	struct wg_peer *wgp;
 	wgp = kmem_zalloc(sizeof(*wgp), KM_SLEEP);
 	wgp->wgp_sc = wg;
 	wgp->wgp_state = WGP_STATE_INIT;
 	wgp->wgp_q = pcq_create(1024, KM_SLEEP);
 	wgp->wgp_si = softint_establish(SOFTINT_NET, wg_peer_softint, wgp);
 	callout_init(&wgp->wgp_rekey_timer, CALLOUT_MPSAFE);
 	callout_setfunc(&wgp->wgp_rekey_timer, wg_rekey_timer, wgp);
 	callout_init(&wgp->wgp_handshake_timeout_timer, CALLOUT_MPSAFE);
 	callout_setfunc(&wgp->wgp_handshake_timeout_timer,
 	    wg_handshake_timeout_timer, wgp);
 	callout_init(&wgp->wgp_session_dtor_timer, CALLOUT_MPSAFE);
 	callout_setfunc(&wgp->wgp_session_dtor_timer,
 	    wg_session_dtor_timer, wgp);
 	PSLIST_ENTRY_INIT(wgp, wgp_peerlist_entry);
 	wgp->wgp_endpoint_changing = false;
 	wgp->wgp_endpoint_available = false;
 	wgp->wgp_lock = mutex_obj_alloc(MUTEX_DEFAULT, IPL_NONE);
 	wgp->wgp_psz = pserialize_create();
 	psref_target_init(&wgp->wgp_psref, wg_psref_class);
 	wgp->wgp_endpoint = kmem_zalloc(sizeof(*wgp->wgp_endpoint), KM_SLEEP);
 	wgp->wgp_endpoint0 = kmem_zalloc(sizeof(*wgp->wgp_endpoint0), KM_SLEEP);
 	psref_target_init(&wgp->wgp_endpoint->wgsa_psref, wg_psref_class);
 	psref_target_init(&wgp->wgp_endpoint0->wgsa_psref, wg_psref_class);
 	struct wg_session *wgs;
 	wgp->wgp_session_stable =
 	    kmem_zalloc(sizeof(*wgp->wgp_session_stable), KM_SLEEP);
 	wgp->wgp_session_unstable =
 	    kmem_zalloc(sizeof(*wgp->wgp_session_unstable), KM_SLEEP);
 	wgs = wgp->wgp_session_stable;
 	wgs->wgs_peer = wgp;
 	wgs->wgs_state = WGS_STATE_UNKNOWN;
 	psref_target_init(&wgs->wgs_psref, wg_psref_class);
 	wgs->wgs_lock = mutex_obj_alloc(MUTEX_DEFAULT, IPL_NONE);
 #ifndef __HAVE_ATOMIC64_LOADSTORE
 	mutex_init(&wgs->wgs_send_counter_lock, MUTEX_DEFAULT, IPL_SOFTNET);
 #endif
 	wgs->wgs_recvwin = kmem_zalloc(sizeof(*wgs->wgs_recvwin), KM_SLEEP);
 	mutex_init(&wgs->wgs_recvwin->lock, MUTEX_DEFAULT, IPL_NONE);
 	wgs = wgp->wgp_session_unstable;
 	wgs->wgs_peer = wgp;
 	wgs->wgs_state = WGS_STATE_UNKNOWN;
 	psref_target_init(&wgs->wgs_psref, wg_psref_class);
 	wgs->wgs_lock = mutex_obj_alloc(MUTEX_DEFAULT, IPL_NONE);
 #ifndef __HAVE_ATOMIC64_LOADSTORE
 	mutex_init(&wgs->wgs_send_counter_lock, MUTEX_DEFAULT, IPL_SOFTNET);
 #endif
 	wgs->wgs_recvwin = kmem_zalloc(sizeof(*wgs->wgs_recvwin), KM_SLEEP);
 	mutex_init(&wgs->wgs_recvwin->lock, MUTEX_DEFAULT, IPL_NONE);
 	return wgp;
+}
 static void
 wg_destroy_peer(struct wg_peer *wgp)
+{
 	struct wg_session *wgs;
 	struct wg_softc *wg = wgp->wgp_sc;
 	rw_enter(wg->wg_rwlock, RW_WRITER);
 	for (int i = 0; i < wgp->wgp_n_allowedips; i++) {
 		struct wg_allowedip *wga = &wgp->wgp_allowedips[i];
 		struct radix_node_head *rnh = wg_rnh(wg, wga->wga_family);
 		struct radix_node *rn;
 		KASSERT(rnh != NULL);
 		rn = rnh->rnh_deladdr(&wga->wga_sa_addr,
 		    &wga->wga_sa_mask, rnh);
 		if (rn == NULL) {
 			char addrstr[128];
 			sockaddr_format(&wga->wga_sa_addr, addrstr,
 			    sizeof(addrstr));
 			WGLOG(LOG_WARNING, "Couldn't delete %s", addrstr);
+		}
+	}
 	rw_exit(wg->wg_rwlock);
 	softint_disestablish(wgp->wgp_si);
 	callout_halt(&wgp->wgp_rekey_timer, NULL);
 	callout_halt(&wgp->wgp_handshake_timeout_timer, NULL);
 	callout_halt(&wgp->wgp_session_dtor_timer, NULL);
 	wgs = wgp->wgp_session_unstable;
 	psref_target_destroy(&wgs->wgs_psref, wg_psref_class);
 	mutex_obj_free(wgs->wgs_lock);
 	mutex_destroy(&wgs->wgs_recvwin->lock);
 	kmem_free(wgs->wgs_recvwin, sizeof(*wgs->wgs_recvwin));
 #ifndef __HAVE_ATOMIC64_LOADSTORE
 	mutex_destroy(&wgs->wgs_send_counter_lock);
 #endif
 	kmem_free(wgs, sizeof(*wgs));
 	wgs = wgp->wgp_session_stable;
 	psref_target_destroy(&wgs->wgs_psref, wg_psref_class);
 	mutex_obj_free(wgs->wgs_lock);
 	mutex_destroy(&wgs->wgs_recvwin->lock);
 	kmem_free(wgs->wgs_recvwin, sizeof(*wgs->wgs_recvwin));
 #ifndef __HAVE_ATOMIC64_LOADSTORE
 	mutex_destroy(&wgs->wgs_send_counter_lock);
 #endif
 	kmem_free(wgs, sizeof(*wgs));
 	psref_target_destroy(&wgp->wgp_endpoint->wgsa_psref, wg_psref_class);
 	psref_target_destroy(&wgp->wgp_endpoint0->wgsa_psref, wg_psref_class);
 	kmem_free(wgp->wgp_endpoint, sizeof(*wgp->wgp_endpoint));
 	kmem_free(wgp->wgp_endpoint0, sizeof(*wgp->wgp_endpoint0));
 	pserialize_destroy(wgp->wgp_psz);
 	pcq_destroy(wgp->wgp_q);
 	mutex_obj_free(wgp->wgp_lock);
 	kmem_free(wgp, sizeof(*wgp));
+}
 static void
 wg_destroy_all_peers(struct wg_softc *wg)
+{
 	struct wg_peer *wgp;
 restart:
 	mutex_enter(wg->wg_lock);
 	WG_PEER_WRITER_FOREACH(wgp, wg) {
 		WG_PEER_WRITER_REMOVE(wgp);
 		mutex_enter(wgp->wgp_lock);
 		wgp->wgp_state = WGP_STATE_DESTROYING;
 		pserialize_perform(wgp->wgp_psz);
 		mutex_exit(wgp->wgp_lock);
 		PSLIST_ENTRY_DESTROY(wgp, wgp_peerlist_entry);
 		break;
+	}
 	mutex_exit(wg->wg_lock);
 	if (wgp == NULL)
 		return;
 	psref_target_destroy(&wgp->wgp_psref, wg_psref_class);
 	wg_destroy_peer(wgp);
 	goto restart;
+}
 static int
 wg_destroy_peer_name(struct wg_softc *wg, const char *name)
+{
 	struct wg_peer *wgp;
 	mutex_enter(wg->wg_lock);
 	WG_PEER_WRITER_FOREACH(wgp, wg) {
 		if (strcmp(wgp->wgp_name, name) == 0)
 			break;
+	}
 	if (wgp != NULL) {
 		WG_PEER_WRITER_REMOVE(wgp);
 		wg->wg_npeers--;
 		mutex_enter(wgp->wgp_lock);
 		wgp->wgp_state = WGP_STATE_DESTROYING;
 		pserialize_perform(wgp->wgp_psz);
 		mutex_exit(wgp->wgp_lock);
 		PSLIST_ENTRY_DESTROY(wgp, wgp_peerlist_entry);
+	}
 	mutex_exit(wg->wg_lock);
 	if (wgp == NULL)
 		return ENOENT;
 	psref_target_destroy(&wgp->wgp_psref, wg_psref_class);
 	wg_destroy_peer(wgp);
 	return 0;
+}
 static int
 wg_if_attach(struct wg_softc *wg)
+{
 	int error;
 	wg->wg_if.if_addrlen = 0;
 	wg->wg_if.if_mtu = WG_MTU;
 	wg->wg_if.if_flags = IFF_POINTOPOINT;
 	wg->wg_if.if_extflags = IFEF_NO_LINK_STATE_CHANGE;
 	wg->wg_if.if_extflags |= IFEF_MPSAFE;
 	wg->wg_if.if_ioctl = wg_ioctl;
 	wg->wg_if.if_output = wg_output;
 	wg->wg_if.if_init = wg_init;
 	wg->wg_if.if_stop = wg_stop;
 	wg->wg_if.if_type = IFT_OTHER;
 	wg->wg_if.if_dlt = DLT_NULL;
 	wg->wg_if.if_softc = wg;
 	IFQ_SET_READY(&wg->wg_if.if_snd);
 	error = if_initialize(&wg->wg_if);
 	if (error != 0)
 		return error;
 	if_alloc_sadl(&wg->wg_if);
 	if_register(&wg->wg_if);
 	bpf_attach(&wg->wg_if, DLT_NULL, sizeof(uint32_t));
 	return 0;
+}
 static int
 wg_clone_create(struct if_clone *ifc, int unit)
+{
 	struct wg_softc *wg;
 	int error;
 	wg = kmem_zalloc(sizeof(struct wg_softc), KM_SLEEP);
 	if_initname(&wg->wg_if, ifc->ifc_name, unit);
 	error = wg_worker_init(wg);
 	if (error != 0) {
 		kmem_free(wg, sizeof(struct wg_softc));
 		return error;
+	}
 	rn_inithead((void **)&wg->wg_rtable_ipv4,
 	    offsetof(struct sockaddr_in, sin_addr) * NBBY);
 #ifdef INET6
 	rn_inithead((void **)&wg->wg_rtable_ipv6,
 	    offsetof(struct sockaddr_in6, sin6_addr) * NBBY);
 #endif
 	PSLIST_INIT(&wg->wg_peers);
 	wg->wg_lock = mutex_obj_alloc(MUTEX_DEFAULT, IPL_NONE);
 	wg->wg_rwlock = rw_obj_alloc();
 	wg->wg_ops = &wg_ops_rumpkernel;
 	error = wg_if_attach(wg);
 	if (error != 0) {
 		wg_worker_destroy(wg);
 		if (wg->wg_rtable_ipv4 != NULL)
 			free(wg->wg_rtable_ipv4, M_RTABLE);
 		if (wg->wg_rtable_ipv6 != NULL)
 			free(wg->wg_rtable_ipv6, M_RTABLE);
 		PSLIST_DESTROY(&wg->wg_peers);
 		mutex_obj_free(wg->wg_lock);
 		kmem_free(wg, sizeof(struct wg_softc));
 		return error;
+	}
 	mutex_enter(&wg_softcs.lock);
 	LIST_INSERT_HEAD(&wg_softcs.list, wg, wg_list);
 	mutex_exit(&wg_softcs.lock);
 	return 0;
+}
 static int
 wg_clone_destroy(struct ifnet *ifp)
+{
 	struct wg_softc *wg = container_of(ifp, struct wg_softc, wg_if);
 	mutex_enter(&wg_softcs.lock);
 	LIST_REMOVE(wg, wg_list);
 	mutex_exit(&wg_softcs.lock);
 #ifdef WG_RUMPKERNEL
 	if (wg_user_mode(wg)) {
 		rumpuser_wg_destroy(wg->wg_user);
 		wg->wg_user = NULL;
+	}
 #endif
 	bpf_detach(ifp);
 	if_detach(ifp);
 	wg_worker_destroy(wg);
 	wg_destroy_all_peers(wg);
 	if (wg->wg_rtable_ipv4 != NULL)
 		free(wg->wg_rtable_ipv4, M_RTABLE);
 	if (wg->wg_rtable_ipv6 != NULL)
 		free(wg->wg_rtable_ipv6, M_RTABLE);
 	PSLIST_DESTROY(&wg->wg_peers);
 	mutex_obj_free(wg->wg_lock);
 	rw_obj_free(wg->wg_rwlock);
 	kmem_free(wg, sizeof(struct wg_softc));
 	return 0;
+}
 static struct wg_peer *
 wg_pick_peer_by_sa(struct wg_softc *wg, const struct sockaddr *sa,
     struct psref *psref)
+{
 	struct radix_node_head *rnh;
 	struct radix_node *rn;
 	struct wg_peer *wgp = NULL;
 	struct wg_allowedip *wga;
 #ifdef WG_DEBUG_LOG
 	char addrstr[128];
 	sockaddr_format(sa, addrstr, sizeof(addrstr));
 	WG_DLOG("sa=%s\n", addrstr);
 #endif
 	rw_enter(wg->wg_rwlock, RW_READER);
 	rnh = wg_rnh(wg, sa->sa_family);
 	if (rnh == NULL)
 		goto out;
 	rn = rnh->rnh_matchaddr(sa, rnh);
 	if (rn == NULL || (rn->rn_flags & RNF_ROOT) != 0)
 		goto out;
 	WG_TRACE("success");
 	wga = container_of(rn, struct wg_allowedip, wga_nodes[0]);
 	wgp = wga->wga_peer;
 	wg_get_peer(wgp, psref);
 out:
 	rw_exit(wg->wg_rwlock);
 	return wgp;
+}
 static void
 wg_fill_msg_data(struct wg_softc *wg, struct wg_peer *wgp,
     struct wg_session *wgs, struct wg_msg_data *wgmd)
+{
 	memset(wgmd, 0, sizeof(*wgmd));
 	wgmd->wgmd_type = WG_MSG_TYPE_DATA;
 	wgmd->wgmd_receiver = wgs->wgs_receiver_index;
 	/* [W] 5.4.6: msg.counter := Nm^send */
 	/* [W] 5.4.6: Nm^send := Nm^send + 1 */
 	wgmd->wgmd_counter = wg_session_inc_send_counter(wgs);
 	WG_DLOG("counter=%"PRIu64"\n", wgmd->wgmd_counter);
+}
 static int
 wg_output(struct ifnet *ifp, struct mbuf *m, const struct sockaddr *dst,
     const struct rtentry *rt)
+{
 	struct wg_softc *wg = ifp->if_softc;
 	int error = 0;
 	int bound;
 	struct psref psref;
 	/* TODO make the nest limit configurable via sysctl */
 	error = if_tunnel_check_nesting(ifp, m, 1);
 	if (error != 0) {
 		m_freem(m);
 		WGLOG(LOG_ERR, "tunneling loop detected and packet dropped\n");
 		return error;
+	}
 	bound = curlwp_bind();
 	IFQ_CLASSIFY(&ifp->if_snd, m, dst->sa_family);
 	bpf_mtap_af(ifp, dst->sa_family, m, BPF_D_OUT);
 	m->m_flags &= ~(M_BCAST|M_MCAST);
 	struct wg_peer *wgp = wg_pick_peer_by_sa(wg, dst, &psref);
 	if (wgp == NULL) {
 		WG_TRACE("peer not found");
 		error = EHOSTUNREACH;
 		goto error;
+	}
 	/* Clear checksum-offload flags. */
 	m->m_pkthdr.csum_flags = 0;
 	m->m_pkthdr.csum_data = 0;
 	if (!pcq_put(wgp->wgp_q, m)) {
 		error = ENOBUFS;
 		goto error;
+	}
 	struct psref psref_wgs;
 	struct wg_session *wgs;
 	wgs = wg_get_stable_session(wgp, &psref_wgs);
 	if (wgs->wgs_state == WGS_STATE_ESTABLISHED &&
 	    !wg_session_hit_limits(wgs)) {
 		kpreempt_disable();
 		softint_schedule(wgp->wgp_si);
 		kpreempt_enable();
 		WG_TRACE("softint scheduled");
 	} else {
 		wg_schedule_peer_task(wgp, WGP_TASK_SEND_INIT_MESSAGE);
 		WG_TRACE("softint NOT scheduled");
+	}
 	wg_put_session(wgs, &psref_wgs);
 	wg_put_peer(wgp, &psref);
 	return 0;
 error:
 	if (wgp != NULL)
 		wg_put_peer(wgp, &psref);
 	if (m != NULL)
 		m_freem(m);
 	curlwp_bindx(bound);
 	return error;
+}
 static int
 wg_send_udp(struct wg_peer *wgp, struct mbuf *m)
+{
 	struct psref psref;
 	struct wg_sockaddr *wgsa;
 	int error;
 	struct socket *so = wg_get_so_by_peer(wgp);
 	solock(so);
 	wgsa = wg_get_endpoint_sa(wgp, &psref);
 	if (wgsatosa(wgsa)->sa_family == AF_INET) {
 		error = udp_send(so, m, wgsatosa(wgsa), NULL, curlwp);
 	} else {
 #ifdef INET6
 		error = udp6_output(sotoin6pcb(so), m, wgsatosin6(wgsa),
 		    NULL, curlwp);
 #else
 		error = EPROTONOSUPPORT;
 #endif
+	}
 	wg_put_sa(wgp, wgsa, &psref);
 	sounlock(so);
 	return error;
+}
 /* Inspired by pppoe_get_mbuf */
 static struct mbuf *
 wg_get_mbuf(size_t leading_len, size_t len)
+{
 	struct mbuf *m;
 	m = m_gethdr(M_DONTWAIT, MT_DATA);
 	if (m == NULL)
 		return NULL;
 	if (len + leading_len > MHLEN) {
 		m_clget(m, M_DONTWAIT);
 		if ((m->m_flags & M_EXT) == 0) {
 			m_free(m);
 			return NULL;
+		}
+	}
 	m->m_data += leading_len;
 	m->m_pkthdr.len = m->m_len = len;
 	return m;
+}
 static int
 wg_send_data_msg(struct wg_peer *wgp, struct wg_session *wgs,
     struct mbuf *m)
+{
 	struct wg_softc *wg = wgp->wgp_sc;
 	int error;
 	size_t inner_len, padded_len, encrypted_len;
 	char *padded_buf = NULL;
 	size_t mlen;
 	struct wg_msg_data *wgmd;
 	bool free_padded_buf = false;
 	struct mbuf *n;
 	size_t leading_len = max_linkhdr + sizeof(struct ip6_hdr) +
 	    sizeof(struct udphdr);
 	mlen = m_length(m);
 	inner_len = mlen;
 	padded_len = roundup(mlen, 16);
 	encrypted_len = padded_len + WG_AUTHTAG_LEN;
 	WG_DLOG("inner=%lu, padded=%lu, encrypted_len=%lu\n",
 	    inner_len, padded_len, encrypted_len);
 	if (mlen != 0) {
 		bool success;
 		success = m_ensure_contig(&m, padded_len);
 		if (success) {
 			padded_buf = mtod(m, char *);
 		} else {
 			padded_buf = kmem_intr_alloc(padded_len, KM_NOSLEEP);
 			if (padded_buf == NULL) {
 				error = ENOBUFS;
 				goto end;
+			}
 			free_padded_buf = true;
 			m_copydata(m, 0, mlen, padded_buf);
+		}
 		memset(padded_buf + mlen, 0, padded_len - inner_len);
+	}
 	n = wg_get_mbuf(leading_len, sizeof(*wgmd) + encrypted_len);
 	if (n == NULL) {
 		error = ENOBUFS;
 		goto end;
+	}
 	wgmd = mtod(n, struct wg_msg_data *);
 	wg_fill_msg_data(wg, wgp, wgs, wgmd);
 	/* [W] 5.4.6: AEAD(Tm^send, Nm^send, P, e) */
 	wg_algo_aead_enc((char *)wgmd + sizeof(*wgmd), encrypted_len,
 	    wgs->wgs_tkey_send, wgmd->wgmd_counter, padded_buf, padded_len,
 	    NULL, 0);
 	error = wg->wg_ops->send_data_msg(wgp, n);
 	if (error == 0) {
 		struct ifnet *ifp = &wg->wg_if;
 		if_statadd(ifp, if_obytes, mlen);
 		if_statinc(ifp, if_opackets);
 		if (wgs->wgs_is_initiator &&
 		    wgs->wgs_time_last_data_sent == 0) {
 			/*
 			 * [W] 6.2 Transport Message Limits
 			 * "if a peer is the initiator of a current secure
 			 *  session, WireGuard will send a handshake initiation
 			 *  message to begin a new secure session if, after
 			 *  transmitting a transport data message, the current
 			 *  secure session is REKEY-AFTER-TIME seconds old,"
 			 */
 			wg_schedule_rekey_timer(wgp);
+		}
 		wgs->wgs_time_last_data_sent = time_uptime;
 		if (wg_session_get_send_counter(wgs) >=
 		    wg_rekey_after_messages) {
 			/*
 			 * [W] 6.2 Transport Message Limits
 			 * "WireGuard will try to create a new session, by
 			 *  sending a handshake initiation message (section
 			 *  5.4.2), after it has sent REKEY-AFTER-MESSAGES
 			 *  transport data messages..."
 			 */
 			wg_schedule_peer_task(wgp, WGP_TASK_SEND_INIT_MESSAGE);
+		}
+	}
 end:
 	m_freem(m);
 	if (free_padded_buf)
 		kmem_intr_free(padded_buf, padded_len);
 	return error;
+}
 static void
 wg_input(struct ifnet *ifp, struct mbuf *m, const int af)
+{
 	pktqueue_t *pktq;
 	size_t pktlen;
 	KASSERT(af == AF_INET || af == AF_INET6);
 	WG_TRACE("");
 	m_set_rcvif(m, ifp);
 	pktlen = m->m_pkthdr.len;
 	bpf_mtap_af(ifp, af, m, BPF_D_IN);
 	switch (af) {
 	case AF_INET:
 		pktq = ip_pktq;
 		break;
 #ifdef INET6
 	case AF_INET6:
 		pktq = ip6_pktq;
 		break;
 #endif
 	default:
 		panic("invalid af=%d", af);
+	}
 	const u_int h = curcpu()->ci_index;
 	if (__predict_true(pktq_enqueue(pktq, m, h))) {
 		if_statadd(ifp, if_ibytes, pktlen);
 		if_statinc(ifp, if_ipackets);
 	} else {
 		m_freem(m);
+	}
+}
 static void
 wg_calc_pubkey(uint8_t pubkey[WG_STATIC_KEY_LEN],
     const uint8_t privkey[WG_STATIC_KEY_LEN])
+{
 	crypto_scalarmult_base(pubkey, privkey);
+}
 static int
 wg_rtable_add_route(struct wg_softc *wg, struct wg_allowedip *wga)
+{
 	struct radix_node_head *rnh;
 	struct radix_node *rn;
 	int error = 0;
 	rw_enter(wg->wg_rwlock, RW_WRITER);
 	rnh = wg_rnh(wg, wga->wga_family);
 	KASSERT(rnh != NULL);
 	rn = rnh->rnh_addaddr(&wga->wga_sa_addr, &wga->wga_sa_mask, rnh,
 	    wga->wga_nodes);
 	rw_exit(wg->wg_rwlock);
 	if (rn == NULL)
 		error = EEXIST;
 	return error;
+}
 static int
 wg_handle_prop_peer(struct wg_softc *wg, prop_dictionary_t peer,
     struct wg_peer **wgpp)
+{
 	int error = 0;
 	const void *pubkey;
 	size_t pubkey_len;
 	const void *psk;
 	size_t psk_len;
 	const char *name = NULL;
 	if (prop_dictionary_get_string(peer, "name", &name)) {
 		if (strlen(name) > WG_PEER_NAME_MAXLEN) {
 			error = EINVAL;
 			goto out;
+		}
+	}
 	if (!prop_dictionary_get_data(peer, "public_key",
 		&pubkey, &pubkey_len)) {
 		error = EINVAL;
 		goto out;
+	}
 #ifdef WG_DEBUG_DUMP
 	log(LOG_DEBUG, "pubkey=%p, pubkey_len=%lu\n", pubkey, pubkey_len);
 	for (int _i = 0; _i < pubkey_len; _i++)
 		log(LOG_DEBUG, "%c", ((const char *)pubkey)[_i]);
 	log(LOG_DEBUG, "\n");
 #endif
 	struct wg_peer *wgp = wg_alloc_peer(wg);
 	memcpy(wgp->wgp_pubkey, pubkey, sizeof(wgp->wgp_pubkey));
 	if (name != NULL)
 		strncpy(wgp->wgp_name, name, sizeof(wgp->wgp_name));
 	if (prop_dictionary_get_data(peer, "preshared_key", &psk, &psk_len)) {
 		if (psk_len != sizeof(wgp->wgp_psk)) {
 			error = EINVAL;
 			goto out;
+		}
 		memcpy(wgp->wgp_psk, psk, sizeof(wgp->wgp_psk));
+	}
 	struct sockaddr_storage sockaddr;
 	const void *addr;
 	size_t addr_len;
 	if (!prop_dictionary_get_data(peer, "endpoint", &addr, &addr_len))
 		goto skip_endpoint;
 	memcpy(&sockaddr, addr, addr_len);
 	switch (sockaddr.ss_family) {
 	case AF_INET: {
 		struct sockaddr_in sin;
 		sockaddr_copy(sintosa(&sin), sizeof(sin),
 		    (const struct sockaddr *)&sockaddr);
 		sockaddr_copy(sintosa(&wgp->wgp_sin),
 		    sizeof(wgp->wgp_sin), (const struct sockaddr *)&sockaddr);
 		char addrstr[128];
 		sockaddr_format(sintosa(&sin), addrstr, sizeof(addrstr));
 		WG_DLOG("addr=%s\n", addrstr);
 		break;
+	    }
 #ifdef INET6
 	case AF_INET6: {
 		struct sockaddr_in6 sin6;
 		char addrstr[128];
 		sockaddr_copy(sintosa(&sin6), sizeof(sin6),
 		    (const struct sockaddr *)&sockaddr);
 		sockaddr_format(sintosa(&sin6), addrstr, sizeof(addrstr));
 		WG_DLOG("addr=%s\n", addrstr);
 		sockaddr_copy(sin6tosa(&wgp->wgp_sin6),
 		    sizeof(wgp->wgp_sin6), (const struct sockaddr *)&sockaddr);
 		break;
+	    }
 #endif
 	default:
 		break;
+	}
 	wgp->wgp_endpoint_available = true;
 	prop_array_t allowedips;
 skip_endpoint:
 	allowedips = prop_dictionary_get(peer, "allowedips");
 	if (allowedips == NULL)
 		goto skip;
 	prop_object_iterator_t _it = prop_array_iterator(allowedips);
 	prop_dictionary_t prop_allowedip;
 	int j = 0;
 	while ((prop_allowedip = prop_object_iterator_next(_it)) != NULL) {
 		struct wg_allowedip *wga = &wgp->wgp_allowedips[j];
 		if (!prop_dictionary_get_int(prop_allowedip, "family",
 			&wga->wga_family))
 			continue;
 		if (!prop_dictionary_get_data(prop_allowedip, "ip",
 			&addr, &addr_len))
 			continue;
 		if (!prop_dictionary_get_uint8(prop_allowedip, "cidr",
 			&wga->wga_cidr))
 			continue;
 		switch (wga->wga_family) {
 		case AF_INET: {
 			struct sockaddr_in sin;
 			char addrstr[128];
 			struct in_addr mask;
 			struct sockaddr_in sin_mask;
 			if (addr_len != sizeof(struct in_addr))
 				return EINVAL;
 			memcpy(&wga->wga_addr4, addr, addr_len);
 			sockaddr_in_init(&sin, (const struct in_addr *)addr,
 );
 			sockaddr_copy(&wga->wga_sa_addr,
 			    sizeof(sin), sintosa(&sin));
 			sockaddr_format(sintosa(&sin),
 			    addrstr, sizeof(addrstr));
 			WG_DLOG("addr=%s/%d\n", addrstr, wga->wga_cidr);
 			in_len2mask(&mask, wga->wga_cidr);
 			sockaddr_in_init(&sin_mask, &mask, 0);
 			sockaddr_copy(&wga->wga_sa_mask,
 			    sizeof(sin_mask), sintosa(&sin_mask));
 			break;
+		    }
 #ifdef INET6
 		case AF_INET6: {
 			struct sockaddr_in6 sin6;
 			char addrstr[128];
 			struct in6_addr mask;
 			struct sockaddr_in6 sin6_mask;
 			if (addr_len != sizeof(struct in6_addr))
 				return EINVAL;
 			memcpy(&wga->wga_addr6, addr, addr_len);
 			sockaddr_in6_init(&sin6, (const struct in6_addr *)addr,
 , 0, 0);
 			sockaddr_copy(&wga->wga_sa_addr,
 			    sizeof(sin6), sin6tosa(&sin6));
 			sockaddr_format(sin6tosa(&sin6),
 			    addrstr, sizeof(addrstr));
 			WG_DLOG("addr=%s/%d\n", addrstr, wga->wga_cidr);
 			in6_prefixlen2mask(&mask, wga->wga_cidr);
 			sockaddr_in6_init(&sin6_mask, &mask, 0, 0, 0);
 			sockaddr_copy(&wga->wga_sa_mask,
 			    sizeof(sin6_mask), sin6tosa(&sin6_mask));
 			break;
+		    }

 @@ -1,600 +1,673 @@
-#	$NetBSD: t_misc.sh,v 1.2 2020/08/27 02:51:49 riastradh Exp $
+#	$NetBSD: t_misc.sh,v 1.3 2020/08/27 02:52:33 riastradh Exp $
+#
 # Copyright (c) 2018 Ryota Ozaki <ozaki.ryota@gmail.com>
 # All rights reserved.
+#
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
 # are met:
 # 1. Redistributions of source code must retain the above copyright
 #    notice, this list of conditions and the following disclaimer.
 # 2. Redistributions in binary form must reproduce the above copyright
 #    notice, this list of conditions and the following disclaimer in the
 #    documentation and/or other materials provided with the distribution.
+#
 # THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS
 # ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
 # TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
 # PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS
 # BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
 # CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
 # SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
 # INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
 # CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
 # ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 # POSSIBILITY OF SUCH DAMAGE.
+#
 BUS=bus
 SOCK_LOCAL=unix://wg_local
 SOCK_PEER=unix://wg_peer
 atf_test_case wg_rekey cleanup
 wg_rekey_head()
+{
 	atf_set "descr" "tests of rekeying of wg(4)"
 	atf_set "require.progs" "rump_server" "wgconfig" "wg-keygen"
+}
 wg_rekey_body()
+{
 	local ifconfig="atf_check -s exit:0 rump.ifconfig"
 	local ping="atf_check -s exit:0 -o ignore rump.ping -n -c 1 -w 1"
 	local ip_local=192.168.1.1
 	local ip_peer=192.168.1.2
 	local ip_wg_local=10.0.0.1
 	local ip_wg_peer=10.0.0.2
 	local port=51820
 	local rekey_after_time=3
 	local latest_handshake=
 	setup_servers
 	export RUMP_SERVER=$SOCK_LOCAL
 	atf_check -s exit:0 -o ignore \
 	    rump.sysctl -w net.wg.rekey_after_time=$rekey_after_time
 	export RUMP_SERVER=$SOCK_PEER
 	atf_check -s exit:0 -o ignore \
 	    rump.sysctl -w net.wg.rekey_after_time=$rekey_after_time
 	# It sets key_priv_local key_pub_local key_priv_peer key_pub_peer
 	generate_keys
 	export RUMP_SERVER=$SOCK_LOCAL
 	setup_common shmif0 inet $ip_local 24
 	setup_wg_common wg0 inet $ip_wg_local 24 $port "$key_priv_local"
 	export RUMP_SERVER=$SOCK_PEER
 	setup_common shmif0 inet $ip_peer 24
 	setup_wg_common wg0 inet $ip_wg_peer 24 $port "$key_priv_peer"
 	export RUMP_SERVER=$SOCK_LOCAL
 	add_peer wg0 peer0 $key_pub_peer $ip_peer:$port $ip_wg_peer/32
 	export RUMP_SERVER=$SOCK_PEER
 	add_peer wg0 peer0 $key_pub_local $ip_local:$port $ip_wg_local/32
 	export RUMP_SERVER=$SOCK_LOCAL
 	$ping $ip_wg_peer
 	latest_handshake=$($HIJACKING wgconfig wg0 show peer peer0 \
 	    | awk -F : '/latest-handshake/ {print $2;}')
 	$DEBUG && echo $latest_handshake
 	sleep 1
 	$ping $ip_wg_peer
 	# No reinitiation is performed
 	atf_check -s exit:0 -o match:"$latest_handshake" \
 	    $HIJACKING wgconfig wg0 show peer peer0
 	# Wait for a reinitiation to be performed
 	sleep $rekey_after_time
 	$ping $ip_wg_peer
 	# A reinitiation should be performed
 	atf_check -s exit:0 -o not-match:"$latest_handshake" \
 	    $HIJACKING wgconfig wg0 show peer peer0
 	latest_handshake=$($HIJACKING wgconfig wg0 show peer peer0 \
 	    | awk -F : '/latest-handshake/ {print $2;}')
 	$DEBUG && echo $latest_handshake
 	# Wait for a reinitiation to be performed again
 	sleep $rekey_after_time
 	$ping $ip_wg_peer
 	# A reinitiation should be performed
 	atf_check -s exit:0 -o not-match:"$latest_handshake" \
 	    $HIJACKING wgconfig wg0 show peer peer0
 	destroy_wg_interfaces
+}
 wg_rekey_cleanup()
+{
 	$DEBUG && dump
 	cleanup
+}
 atf_test_case wg_handshake_timeout cleanup
 wg_handshake_timeout_head()
+{
 	atf_set "descr" "tests of handshake timeout of wg(4)"
 	atf_set "require.progs" "rump_server" "wgconfig" "wg-keygen"
+}
 wg_handshake_timeout_body()
+{
 	local ifconfig="atf_check -s exit:0 rump.ifconfig"
 	local ping="atf_check -s exit:0 -o ignore rump.ping -n -c 1 -w 1"
 	local ip_local=192.168.1.1
 	local ip_peer=192.168.1.2
 	local ip_wg_local=10.0.0.1
 	local ip_wg_peer=10.0.0.2
 	local port=51820
 	local rekey_after_time=3
 	local latest_handshake=
 	local outfile=./out
 	local rekey_timeout=3
 	local rekey_attempt_time=8
 	local n=
 	setup_servers
 	export RUMP_SERVER=$SOCK_LOCAL
 	atf_check -s exit:0 -o ignore \
 	    rump.sysctl -w net.wg.rekey_timeout=$rekey_timeout
 	atf_check -s exit:0 -o ignore \
 	    rump.sysctl -w net.wg.rekey_attempt_time=$rekey_attempt_time
 	export RUMP_SERVER=$SOCK_PEER
 	atf_check -s exit:0 -o ignore \
 	    rump.sysctl -w net.wg.rekey_timeout=$rekey_timeout
 	atf_check -s exit:0 -o ignore \
 	    rump.sysctl -w net.wg.rekey_attempt_time=$rekey_attempt_time
 	# It sets key_priv_local key_pub_local key_priv_peer key_pub_peer
 	generate_keys
 	export RUMP_SERVER=$SOCK_LOCAL
 	setup_common shmif0 inet $ip_local 24
 	setup_wg_common wg0 inet $ip_wg_local 24 $port "$key_priv_local"
 	export RUMP_SERVER=$SOCK_PEER
 	setup_common shmif0 inet $ip_peer 24
 	setup_wg_common wg0 inet $ip_wg_peer 24 $port "$key_priv_peer"
 	export RUMP_SERVER=$SOCK_LOCAL
 	add_peer wg0 peer0 $key_pub_peer $ip_peer:$port $ip_wg_peer/32
 	export RUMP_SERVER=$SOCK_PEER
 	add_peer wg0 peer0 $key_pub_local $ip_local:$port $ip_wg_local/32
 	# Resolve arp
 	export RUMP_SERVER=$SOCK_LOCAL
 	$ping $ip_peer
 	export RUMP_SERVER=$SOCK_PEER
 	$ifconfig shmif0 down
 	export RUMP_SERVER=$SOCK_LOCAL
 	extract_new_packets $BUS > $outfile
 	# Should fail
 	atf_check -s not-exit:0 -o match:'100.0% packet loss' \
 	    rump.ping -n -c 1 -w 1 $ip_wg_peer
 	sleep $((rekey_attempt_time + rekey_timeout))
 	extract_new_packets $BUS > $outfile
 	$DEBUG && cat $outfile
 	n=$(grep "$ip_local.$port > $ip_peer.$port" $outfile |wc -l)
 	# Give up handshaking after three attempts
 	atf_check_equal $n 3
 	export RUMP_SERVER=$SOCK_PEER
 	$ifconfig shmif0 up
 	export RUMP_SERVER=$SOCK_LOCAL
 	destroy_wg_interfaces
+}
 wg_handshake_timeout_cleanup()
+{
 	$DEBUG && dump
 	cleanup
+}
 atf_test_case wg_cookie cleanup
 wg_cookie_head()
+{
 	atf_set "descr" "tests of cookie messages of the wg(4) protocol"
 	atf_set "require.progs" "rump_server" "wgconfig" "wg-keygen"
+}
 wg_cookie_body()
+{
 	local ifconfig="atf_check -s exit:0 rump.ifconfig"
 	local ping="atf_check -s exit:0 -o ignore rump.ping -n -i 0.1 -c 3 -w 1"
 	local ping_fail="atf_check -s not-exit:0 -o ignore rump.ping -n -c 1 -w 1"
 	local ip_local=192.168.1.1
 	local ip_peer=192.168.1.2
 	local ip_wg_local=10.0.0.1
 	local ip_wg_peer=10.0.0.2
 	local port=51820
 	local outfile=./out
 	local rekey_timeout=5
 	setup_servers
 	# It sets key_priv_local key_pub_local key_priv_peer key_pub_peer
 	generate_keys
 	export RUMP_SERVER=$SOCK_LOCAL
 	setup_common shmif0 inet $ip_local 24
 	setup_wg_common wg0 inet $ip_wg_local 24 $port "$key_priv_local"
 	export RUMP_SERVER=$SOCK_PEER
 	setup_common shmif0 inet $ip_peer 24
 	setup_wg_common wg0 inet $ip_wg_peer 24 $port "$key_priv_peer"
 	export RUMP_SERVER=$SOCK_LOCAL
 	add_peer wg0 peer0 $key_pub_peer $ip_peer:$port $ip_wg_peer/32
 	export RUMP_SERVER=$SOCK_PEER
 	add_peer wg0 peer0 $key_pub_local $ip_local:$port $ip_wg_local/32
 	export RUMP_SERVER=$SOCK_PEER
 	# Emulate load on the peer
 	atf_check -s exit:0 -o ignore \
 	    rump.sysctl -w net.wg.force_underload=1
 	export RUMP_SERVER=$SOCK_LOCAL
 	extract_new_packets $BUS > $outfile
 	$DEBUG && cat $outfile
 	# The peer doesn't return a response message but a cookie message
 	# and a session doesn't start
 	$ping_fail $ip_wg_peer
 	extract_new_packets $BUS > $outfile
 	$DEBUG && cat $outfile
 	# XXX length 64 indicates the message is a cookie message
 	atf_check -s exit:0 \
 	    -o match:"$ip_peer.$port > $ip_local.$port: UDP, length 64" \
 	    cat $outfile
 	$DEBUG && $HIJACKING wgconfig wg0 show all
 	atf_check -s exit:0 -o match:"latest-handshake: 0" \
 	    $HIJACKING wgconfig wg0
 	# Wait for restarting a session
 	sleep $rekey_timeout
 	# The second attempt should be success because the init message has
 	# a valid cookie.
 	$ping $ip_wg_peer
 	$DEBUG && $HIJACKING wgconfig wg0 show all
 	atf_check -s exit:0 -o not-match:"latest-handshake: 0" \
 	    $HIJACKING wgconfig wg0
 	destroy_wg_interfaces
+}
 wg_cookie_cleanup()
+{
 	$DEBUG && dump
 	cleanup
+}
 atf_test_case wg_mobility cleanup
 wg_mobility_head()
+{
 	atf_set "descr" "tests of the mobility of wg(4)"
 	atf_set "require.progs" "rump_server" "wgconfig" "wg-keygen"
+}
 wg_mobility_body()
+{
 	local ifconfig="atf_check -s exit:0 rump.ifconfig"
 	local ping="atf_check -s exit:0 -o ignore rump.ping -n -i 0.1 -c 3 -w 1"
 	local ping_fail="atf_check -s not-exit:0 -o ignore rump.ping -n -c 1 -w 1"
 	local ip_local=192.168.1.1
 	local ip_peer=192.168.1.2
 	local ip_peer_new=192.168.1.3
 	local ip_wg_local=10.0.0.1
 	local ip_wg_peer=10.0.0.2
 	local port=51820
 	local outfile=./out
 	setup_servers
 	# It sets key_priv_local key_pub_local key_priv_peer key_pub_peer
 	generate_keys
 	export RUMP_SERVER=$SOCK_LOCAL
 	setup_common shmif0 inet $ip_local 24
 	setup_wg_common wg0 inet $ip_wg_local 24 $port "$key_priv_local"
 	export RUMP_SERVER=$SOCK_PEER
 	setup_common shmif0 inet $ip_peer 24
 	setup_wg_common wg0 inet $ip_wg_peer 24 $port "$key_priv_peer"
 	export RUMP_SERVER=$SOCK_LOCAL
 	# Initially, the local doesn't know the endpoint of the peer
 	add_peer wg0 peer0 $key_pub_peer "" $ip_wg_peer/32
 	export RUMP_SERVER=$SOCK_PEER
 	add_peer wg0 peer0 $key_pub_local $ip_local:$port $ip_wg_local/32
 	extract_new_packets $BUS > $outfile
 	$DEBUG && cat $outfile
 	# Ping from the local to the peer doesn't work because the local
 	# doesn't know the endpoint of the peer
 	export RUMP_SERVER=$SOCK_LOCAL
 	$ping_fail $ip_wg_peer
 	extract_new_packets $BUS > $outfile
 	$DEBUG && cat $outfile
 	export RUMP_SERVER=$SOCK_PEER
 	$ping $ip_wg_local
 	extract_new_packets $BUS > $outfile
 	$DEBUG && cat $outfile
 	atf_check -s exit:0 -o match:"$ip_local.$port > $ip_peer.$port" cat $outfile
 	# Change the IP address of the peer
 	setup_common shmif0 inet $ip_peer_new 24
 	atf_check -s exit:0 rump.ifconfig -w 10
 	# Ping from the local to the peer doesn't work because the local
 	# doesn't know the change of the IP address of the peer
 	export RUMP_SERVER=$SOCK_LOCAL
 	$ping_fail $ip_wg_peer
 	extract_new_packets $BUS > $outfile
 	$DEBUG && cat $outfile
 	atf_check -s exit:0 -o match:"$ip_local.$port > $ip_peer.$port" cat $outfile
 	# Ping from the peer to the local works because the local notices
 	# the change and updates the IP address of the peer
 	export RUMP_SERVER=$SOCK_PEER
 	$ping $ip_wg_local
 	extract_new_packets $BUS > $outfile
 	$DEBUG && cat $outfile
 	atf_check -s exit:0 -o match:"$ip_local.$port > $ip_peer_new.$port" cat $outfile
 	atf_check -s exit:0 -o match:"$ip_peer_new.$port > $ip_local.$port" cat $outfile
 	atf_check -s exit:0 -o not-match:"$ip_local.$port > $ip_peer.$port" cat $outfile
 	destroy_wg_interfaces
+}
 wg_mobility_cleanup()
+{
 	$DEBUG && dump
 	cleanup
+}
 atf_test_case wg_keepalive cleanup
 wg_keepalive_head()
+{
 	atf_set "descr" "tests keepalive messages"
 	atf_set "require.progs" "rump_server" "wgconfig" "wg-keygen"
+}
 wg_keepalive_body()
+{
 	local ifconfig="atf_check -s exit:0 rump.ifconfig"
 	local ping="atf_check -s exit:0 -o ignore rump.ping -n -i 0.1 -c 3 -w 1"
 	local ping_fail="atf_check -s not-exit:0 -o ignore rump.ping -n -c 1 -w 1"
 	local ip_local=192.168.1.1
 	local ip_peer=192.168.1.2
 	local ip_peer_new=192.168.1.3
 	local ip_wg_local=10.0.0.1
 	local ip_wg_peer=10.0.0.2
 	local port=51820
 	local outfile=./out
 	local keepalive_timeout=3
 	setup_servers
 	# It sets key_priv_local key_pub_local key_priv_peer key_pub_peer
 	generate_keys
 	export RUMP_SERVER=$SOCK_LOCAL
 	setup_common shmif0 inet $ip_local 24
 	setup_wg_common wg0 inet $ip_wg_local 24 $port "$key_priv_local"
 	export RUMP_SERVER=$SOCK_PEER
 	setup_common shmif0 inet $ip_peer 24
 	setup_wg_common wg0 inet $ip_wg_peer 24 $port "$key_priv_peer"
 	export RUMP_SERVER=$SOCK_LOCAL
 	add_peer wg0 peer0 $key_pub_peer $ip_peer:$port $ip_wg_peer/32
 	export RUMP_SERVER=$SOCK_PEER
 	add_peer wg0 peer0 $key_pub_local $ip_local:$port $ip_wg_local/32
 	# Shorten keepalive_timeout of the peer
 	atf_check -s exit:0 -o ignore \
 	    rump.sysctl -w net.wg.keepalive_timeout=$keepalive_timeout
 	export RUMP_SERVER=$SOCK_LOCAL
 	extract_new_packets $BUS > $outfile
 	$DEBUG && cat $outfile
 	$ping $ip_wg_peer
 	extract_new_packets $BUS > $outfile
 	$DEBUG && cat $outfile
 	sleep $((keepalive_timeout + 1))
 	$ping $ip_wg_peer
 	extract_new_packets $BUS > $outfile
 	$DEBUG && cat $outfile
 	# XXX length 32 indicates the message is a keepalive (empty) message
 	atf_check -s exit:0 -o match:"$ip_peer.$port > $ip_local.$port: UDP, length 32" \
 	    cat $outfile
 	destroy_wg_interfaces
+}
 wg_keepalive_cleanup()
+{
 	$DEBUG && dump
 	cleanup
+}
 atf_test_case wg_psk cleanup
 wg_psk_head()
+{
 	atf_set "descr" "tests preshared-key"
 	atf_set "require.progs" "rump_server" "wgconfig" "wg-keygen"
+}
 test_psk_common()
+{
+}
 wg_psk_body()
+{
 	local ifconfig="atf_check -s exit:0 rump.ifconfig"
 	local ping="atf_check -s exit:0 -o ignore rump.ping -n -i 0.1 -c 3 -w 1"
 	local ping_fail="atf_check -s not-exit:0 -o ignore rump.ping -n -c 1 -w 1"
 	local ip_local=192.168.1.1
 	local ip_peer=192.168.1.2
 	local ip_peer_new=192.168.1.3
 	local ip_wg_local=10.0.0.1
 	local ip_wg_peer=10.0.0.2
 	local port=51820
 	local outfile=./out
 	local pskfile=./psk
 	local rekey_after_time=3
 	setup_servers
 	export RUMP_SERVER=$SOCK_LOCAL
 	atf_check -s exit:0 -o ignore \
 	    rump.sysctl -w net.wg.rekey_after_time=$rekey_after_time
 	export RUMP_SERVER=$SOCK_PEER
 	atf_check -s exit:0 -o ignore \
 	    rump.sysctl -w net.wg.rekey_after_time=$rekey_after_time
 	# It sets key_priv_local key_pub_local key_priv_peer key_pub_peer
 	generate_keys
 	key_psk=$(wg-keygen --psk)
 	$DEBUG && echo $key_psk
 	export RUMP_SERVER=$SOCK_LOCAL
 	setup_common shmif0 inet $ip_local 24
 	setup_wg_common wg0 inet $ip_wg_local 24 $port "$key_priv_local"
 	export RUMP_SERVER=$SOCK_PEER
 	setup_common shmif0 inet $ip_peer 24
 	setup_wg_common wg0 inet $ip_wg_peer 24 $port "$key_priv_peer"
 	echo "$key_psk" > $pskfile
 	export RUMP_SERVER=$SOCK_LOCAL
 	# The local always has the preshared key
 	add_peer wg0 peer0 $key_pub_peer $ip_peer:$port $ip_wg_peer/32 \
 	    $pskfile "$key_psk"
 	export RUMP_SERVER=$SOCK_PEER
 	# First, try the peer without the preshared key
 	add_peer wg0 peer0 $key_pub_local $ip_local:$port $ip_wg_local/32
 	export RUMP_SERVER=$SOCK_LOCAL
 	extract_new_packets $BUS > $outfile
 	$DEBUG && cat $outfile
 	$ping_fail $ip_wg_peer
 	extract_new_packets $BUS > $outfile
 	$DEBUG && cat $outfile
 	# Next, try with the preshared key
 	export RUMP_SERVER=$SOCK_PEER
 	delete_peer wg0 peer0
 	add_peer wg0 peer0 $key_pub_local $ip_local:$port $ip_wg_local/32 \
 	    $pskfile "$key_psk"
 	# Need a rekey
 	atf_check -s exit:0 sleep $((rekey_after_time + 1))
 	export RUMP_SERVER=$SOCK_LOCAL
 	extract_new_packets $BUS > $outfile
 	$DEBUG && cat $outfile
 	$ping $ip_wg_peer
 	extract_new_packets $BUS > $outfile
 	$DEBUG && cat $outfile
 	# Then, try again without the preshared key just in case
 	export RUMP_SERVER=$SOCK_PEER
 	delete_peer wg0 peer0
 	add_peer wg0 peer0 $key_pub_local $ip_local:$port $ip_wg_local/32
 	# Need a rekey
 	atf_check -s exit:0 sleep $((rekey_after_time + 1))
 	export RUMP_SERVER=$SOCK_LOCAL
 	$ping_fail $ip_wg_peer
 	rm -f $pskfile
 	destroy_wg_interfaces
+}
 wg_psk_cleanup()
+{
 	$DEBUG && dump
 	cleanup
+}
 atf_test_case wg_malformed cleanup
 wg_malformed_head()
+{
 	atf_set "descr" "tests malformed packet headers"
 	atf_set "require.progs" "nc" "rump_server" "wgconfig" "wg-keygen"
 	atf_set "timeout" "10"
+}
 wg_malformed_body()
+{
 	local ifconfig="atf_check -s exit:0 rump.ifconfig"
 	local ping="atf_check -s exit:0 -o ignore rump.ping -n -c 1 -w 1"
 	local ip_local=192.168.1.1
 	local ip_peer=192.168.1.2
 	local ip_wg_local=10.0.0.1
 	local ip_wg_peer=10.0.0.2
 	local port=51820
 	setup_servers
 	# It sets key_priv_local key_pub_local key_priv_peer key_pub_peer
 	generate_keys
 	export RUMP_SERVER=$SOCK_LOCAL
 	setup_common shmif0 inet $ip_local 24
 	setup_wg_common wg0 inet $ip_wg_local 24 $port "$key_priv_local"
 	export RUMP_SERVER=$SOCK_PEER
 	setup_common shmif0 inet $ip_peer 24
 	setup_wg_common wg0 inet $ip_wg_peer 24 $port "$key_priv_peer"
 	export RUMP_SERVER=$SOCK_LOCAL
 	add_peer wg0 peer0 $key_pub_peer $ip_peer:$port $ip_wg_peer/32
 	export RUMP_SERVER=$SOCK_PEER
 	add_peer wg0 peer0 $key_pub_local $ip_local:$port $ip_wg_local/32
 	export RUMP_SERVER=$SOCK_LOCAL
 	$ping $ip_wg_peer
 	printf 'send malformed packets\n'
 	$HIJACKING ping -c 1 -n $ip_peer
 	printf 'x' | $HIJACKING nc -Nu -w 0 $ip_peer $port
 	printf 'xy' | $HIJACKING nc -Nu -w 0 $ip_peer $port
 	printf 'xyz' | $HIJACKING nc -Nu -w 0 $ip_peer $port
 	printf 'xyzw' | $HIJACKING nc -Nu -w 0 $ip_peer $port
 	printf '\x00\x00\x00\x00' | $HIJACKING nc -Nu -w 0 $ip_peer $port
 	printf '\x00\x00\x00\x00z' | $HIJACKING nc -Nu -w 0 $ip_peer $port
 	printf '\x01\x00\x00\x00' | $HIJACKING nc -Nu -w 0 $ip_peer $port
 	printf '\x01\x00\x00\x00z' | $HIJACKING nc -Nu -w 0 $ip_peer $port
 	printf '\x02\x00\x00\x00' | $HIJACKING nc -Nu -w 0 $ip_peer $port
 	printf '\x02\x00\x00\x00z' | $HIJACKING nc -Nu -w 0 $ip_peer $port
 	printf '\x03\x00\x00\x00' | $HIJACKING nc -Nu -w 0 $ip_peer $port
 	printf '\x03\x00\x00\x00z' | $HIJACKING nc -Nu -w 0 $ip_peer $port
 	printf '\x04\x00\x00\x00' | $HIJACKING nc -Nu -w 0 $ip_peer $port
 	printf '\x04\x00\x00\x00z' | $HIJACKING nc -Nu -w 0 $ip_peer $port
 	printf 'done sending malformed packets\n'
 	$ping $ip_wg_peer
+}
 wg_malformed_cleanup()
+{
 	$DEBUG && dump
 	cleanup
+}
 atf_init_test_cases()
+{
 	atf_add_test_case wg_rekey
 	atf_add_test_case wg_handshake_timeout
 	atf_add_test_case wg_cookie
 	atf_add_test_case wg_mobility
 	atf_add_test_case wg_keepalive
 	atf_add_test_case wg_psk
 	atf_add_test_case wg_malformed
+}