Tue Oct 27 17:09:09 2020 UTC ()

make(1): extract InitRandom from main


(rillig)

diff -r1.403 -r1.404 src/usr.bin/make/main.c

--- src/usr.bin/make/main.c 2020/10/27 08:05:20	1.403
+++ src/usr.bin/make/main.c 2020/10/27 17:09:09	1.404

 @@ -1,14 +1,14 @@
-/*	$NetBSD: main.c,v 1.403 2020/10/27 08:05:20 rillig Exp $	*/
+/*	$NetBSD: main.c,v 1.404 2020/10/27 17:09:09 rillig Exp $	*/
 /*
  * Copyright (c) 1988, 1989, 1990, 1993
  *	The Regents of the University of California.  All rights reserved.
+ *
  * This code is derived from software contributed to Berkeley by
  * Adam de Boor.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
 @@ -108,27 +108,27 @@
 #include <errno.h>
 #include <signal.h>
 #include <stdarg.h>
 #include <time.h>
 #include "make.h"
 #include "dir.h"
 #include "job.h"
 #include "pathnames.h"
 #include "trace.h"
 /*	"@(#)main.c	8.3 (Berkeley) 3/19/94"	*/
-MAKE_RCSID("$NetBSD: main.c,v 1.403 2020/10/27 08:05:20 rillig Exp $");
+MAKE_RCSID("$NetBSD: main.c,v 1.404 2020/10/27 17:09:09 rillig Exp $");
 #if defined(MAKE_NATIVE) && !defined(lint)
 __COPYRIGHT("@(#) Copyright (c) 1988, 1989, 1990, 1993 "
 	    "The Regents of the University of California.  "
 	    "All rights reserved.");
 #endif
 #ifndef	DEFMAXLOCAL
 #define	DEFMAXLOCAL DEFMAXJOBS
 #endif
 CmdOpts opts;
 time_t			now;		/* Time at start of make */
 GNode			*DEFAULT;	/* .DEFAULT node */
 @@ -938,26 +938,35 @@ InitVarTargets(void)
 	StringListNode *ln;
 	if (Lst_IsEmpty(opts.create)) {
 		Var_Set(".TARGETS", "", VAR_GLOBAL);
 		return;
+	}
 	for (ln = opts.create->first; ln != NULL; ln = ln->next) {
 		char *name = ln->datum;
 		Var_Append(".TARGETS", name, VAR_GLOBAL);
+	}
+}
 static void
 InitRandom(void)
+{
 	struct timeval tv;
 	gettimeofday(&tv, NULL);
 	srandom((unsigned int)(tv.tv_sec + tv.tv_usec));
+}
 static const char *
 init_machine(const struct utsname *utsname)
+{
 	const char *machine = getenv("MACHINE");
 	if (machine != NULL)
 		return machine;
 #ifdef MAKE_NATIVE
 	return utsname->machine;
 #else
 #ifdef MAKE_MACHINE
 	return MAKE_MACHINE;
 #else
 @@ -1245,41 +1254,36 @@ CleanUp(void)
  * Side Effects:
  *	The program exits when done. Targets are created. etc. etc. etc.
  */
 int
 main(int argc, char **argv)
+{
 	Boolean outOfDate;	/* FALSE if all targets up to date */
 	struct stat sa;
 	char *p1;
 	char mdpath[MAXPATHLEN];
 	const char *machine;
 	const char *machine_arch;
 	char *syspath = getenv("MAKESYSPATH");
 	struct timeval rightnow;	/* to initialize random seed */
 	struct utsname utsname;
 	/* default to writing debug to stderr */
 	opts.debug_file = stderr;
 #ifdef SIGINFO
 	(void)bmake_signal(SIGINFO, siginfo);
 #endif
 	/*
-	 * Set the seed to produce a different random sequence
+	InitRandom();
 	 * on each program execution.
 	 */
 	gettimeofday(&rightnow, NULL);
 	srandom((unsigned int)(rightnow.tv_sec + rightnow.tv_usec));
 	if ((progname = strrchr(argv[0], '/')) != NULL)
 		progname++;
 	else
 		progname = argv[0];
 	UnlimitFiles();
 	if (uname(&utsname) == -1) {
 	    (void)fprintf(stderr, "%s: uname failed (%s).\n", progname,
 		strerror(errno));
 	    exit(2);
+	}