Fri Oct 30 19:14:20 2020 UTC ()
make(1): remove comment about adding is_shell_metachar to ctype.h

This function is so specialized that it would be wrong to have it in a
general-purpose C header.


(rillig)
diff -r1.7 -r1.8 src/usr.bin/make/metachar.c
cvs diff -r1.7 -r1.8 src/usr.bin/make/metachar.c (expand / switch to unified diff)

--- src/usr.bin/make/metachar.c 2020/09/13 15:15:51 1.7
+++ src/usr.bin/make/metachar.c 2020/10/30 19:14:20 1.8
@@ -1,14 +1,14 @@ @@ -1,14 +1,14 @@
1/* $NetBSD: metachar.c,v 1.7 2020/09/13 15:15:51 rillig Exp $ */ 1/* $NetBSD: metachar.c,v 1.8 2020/10/30 19:14:20 rillig Exp $ */
2 2
3/*- 3/*-
4 * Copyright (c) 2015 The NetBSD Foundation, Inc. 4 * Copyright (c) 2015 The NetBSD Foundation, Inc.
5 * All rights reserved. 5 * All rights reserved.
6 * 6 *
7 * This code is derived from software contributed to The NetBSD Foundation 7 * This code is derived from software contributed to The NetBSD Foundation
8 * by Christos Zoulas. 8 * by Christos Zoulas.
9 * 9 *
10 * Redistribution and use in source and binary forms, with or without 10 * Redistribution and use in source and binary forms, with or without
11 * modification, are permitted provided that the following conditions 11 * modification, are permitted provided that the following conditions
12 * are met: 12 * are met:
13 * 1. Redistributions of source code must retain the above copyright 13 * 1. Redistributions of source code must retain the above copyright
14 * notice, this list of conditions and the following disclaimer. 14 * notice, this list of conditions and the following disclaimer.
@@ -29,35 +29,33 @@ @@ -29,35 +29,33 @@
29 * POSSIBILITY OF SUCH DAMAGE. 29 * POSSIBILITY OF SUCH DAMAGE.
30 */ 30 */
31 31
32#if HAVE_NBTOOL_CONFIG_H 32#if HAVE_NBTOOL_CONFIG_H
33#include "nbtool_config.h" 33#include "nbtool_config.h"
34#endif 34#endif
35 35
36#if defined(MAKE_NATIVE) || defined(HAVE_NBTOOL_CONFIG_H) 36#if defined(MAKE_NATIVE) || defined(HAVE_NBTOOL_CONFIG_H)
37#include <sys/cdefs.h> 37#include <sys/cdefs.h>
38#endif 38#endif
39 39
40#include "metachar.h" 40#include "metachar.h"
41 41
42MAKE_RCSID("$NetBSD: metachar.c,v 1.7 2020/09/13 15:15:51 rillig Exp $"); 42MAKE_RCSID("$NetBSD: metachar.c,v 1.8 2020/10/30 19:14:20 rillig Exp $");
43 43
44/* 44/*
45 * The following array is used to make a fast determination of which 45 * The following array is used to make a fast determination of which
46 * characters are interpreted specially by the shell. If a command 46 * characters are interpreted specially by the shell. If a command
47 * contains any of these characters, it is executed by the shell, not 47 * contains any of these characters, it is executed by the shell, not
48 * directly by us. 48 * directly by us.
49 * 
50 * perhaps move it to ctype? 
51 */ 49 */
52 50
53unsigned char _metachar[128] = { 51unsigned char _metachar[128] = {
54/* nul soh stx etx eot enq ack bel */ 52/* nul soh stx etx eot enq ack bel */
55 1, 0, 0, 0, 0, 0, 0, 0, 53 1, 0, 0, 0, 0, 0, 0, 0,
56/* bs ht nl vt np cr so si */ 54/* bs ht nl vt np cr so si */
57 0, 0, 1, 0, 0, 0, 0, 0, 55 0, 0, 1, 0, 0, 0, 0, 0,
58/* dle dc1 dc2 dc3 dc4 nak syn etb */ 56/* dle dc1 dc2 dc3 dc4 nak syn etb */
59 0, 0, 0, 0, 0, 0, 0, 0, 57 0, 0, 0, 0, 0, 0, 0, 0,
60/* can em sub esc fs gs rs us */ 58/* can em sub esc fs gs rs us */
61 0, 0, 0, 0, 0, 0, 0, 0, 59 0, 0, 0, 0, 0, 0, 0, 0,
62/* sp ! " # $ % & ' */ 60/* sp ! " # $ % & ' */
63 0, 1, 1, 1, 1, 0, 1, 1, 61 0, 1, 1, 1, 1, 0, 1, 1,