Sat Jan 30 16:05:45 2021 UTC ()
make(1): run lint with strict bool mode

The make code is not supposed to use constructs such as "if (strcmp(s1,
s2))" or "if (p && *p)", instead all boolean expressions have a form
that would be accepted by a C#, Go or Java compiler as well.  This also
ensures that pre-C99 compilers generate equivalent code as C99
compilers, at least regarding boolean expressions.


(rillig)
diff -r1.111 -r1.112 src/usr.bin/make/Makefile

cvs diff -r1.111 -r1.112 src/usr.bin/make/Makefile (switch to unified diff)

--- src/usr.bin/make/Makefile 2020/12/12 16:54:20 1.111
+++ src/usr.bin/make/Makefile 2021/01/30 16:05:45 1.112
@@ -1,217 +1,219 @@ @@ -1,217 +1,219 @@
1# $NetBSD: Makefile,v 1.111 2020/12/12 16:54:20 rillig Exp $ 1# $NetBSD: Makefile,v 1.112 2021/01/30 16:05:45 rillig Exp $
2# @(#)Makefile 5.2 (Berkeley) 12/28/90 2# @(#)Makefile 5.2 (Berkeley) 12/28/90
3 3
4PROG= make 4PROG= make
5SRCS= arch.c 5SRCS= arch.c
6SRCS+= buf.c 6SRCS+= buf.c
7SRCS+= compat.c 7SRCS+= compat.c
8SRCS+= cond.c 8SRCS+= cond.c
9SRCS+= dir.c 9SRCS+= dir.c
10SRCS+= enum.c 10SRCS+= enum.c
11SRCS+= for.c 11SRCS+= for.c
12SRCS+= hash.c 12SRCS+= hash.c
13SRCS+= job.c 13SRCS+= job.c
14SRCS+= lst.c 14SRCS+= lst.c
15SRCS+= main.c 15SRCS+= main.c
16SRCS+= make.c 16SRCS+= make.c
17SRCS+= make_malloc.c 17SRCS+= make_malloc.c
18SRCS+= metachar.c 18SRCS+= metachar.c
19SRCS+= parse.c 19SRCS+= parse.c
20SRCS+= str.c 20SRCS+= str.c
21SRCS+= suff.c 21SRCS+= suff.c
22SRCS+= targ.c 22SRCS+= targ.c
23SRCS+= trace.c 23SRCS+= trace.c
24SRCS+= var.c 24SRCS+= var.c
25SRCS+= util.c 25SRCS+= util.c
26HDRS= buf.h 26HDRS= buf.h
27HDRS+= config.h 27HDRS+= config.h
28HDRS+= dir.h 28HDRS+= dir.h
29HDRS+= enum.h 29HDRS+= enum.h
30HDRS+= hash.h 30HDRS+= hash.h
31HDRS+= job.h 31HDRS+= job.h
32HDRS+= lst.h 32HDRS+= lst.h
33HDRS+= make.h 33HDRS+= make.h
34HDRS+= make_malloc.h 34HDRS+= make_malloc.h
35HDRS+= meta.h 35HDRS+= meta.h
36HDRS+= metachar.h 36HDRS+= metachar.h
37HDRS+= nonints.h 37HDRS+= nonints.h
38HDRS+= pathnames.h 38HDRS+= pathnames.h
39HDRS+= trace.h 39HDRS+= trace.h
40 40
41# Whether to generate a coverage report after running the tests. 41# Whether to generate a coverage report after running the tests.
42USE_COVERAGE?= no # works only with gcc; clang9 fails to link 42USE_COVERAGE?= no # works only with gcc; clang9 fails to link
43.if ${USE_COVERAGE} == "yes" 43.if ${USE_COVERAGE} == "yes"
44GCOV?= gcov 44GCOV?= gcov
45COPTS+= --coverage -O0 -ggdb 45COPTS+= --coverage -O0 -ggdb
46GCOV_PERL= if (/^File '(?:.*\/)?(\S+)'/) { 46GCOV_PERL= if (/^File '(?:.*\/)?(\S+)'/) {
47GCOV_PERL+= $$file = $$1; $$func = ""; 47GCOV_PERL+= $$file = $$1; $$func = "";
48GCOV_PERL+= } elsif (/^Function '(\S+)'/) { 48GCOV_PERL+= } elsif (/^Function '(\S+)'/) {
49GCOV_PERL+= $$func = $$1; 49GCOV_PERL+= $$func = $$1;
50GCOV_PERL+= } elsif (/^Lines executed:(\d+\.\d+)% of (\d+)/ && defined($$file)) { 50GCOV_PERL+= } elsif (/^Lines executed:(\d+\.\d+)% of (\d+)/ && defined($$file)) {
51GCOV_PERL+= my ($$percent, $$lines) = ($$1, $$2); 51GCOV_PERL+= my ($$percent, $$lines) = ($$1, $$2);
52GCOV_PERL+= my $$uncovered = `grep -c '\#\#\#\#\#:' < \$$(basename $$file.gcov)`; 52GCOV_PERL+= my $$uncovered = `grep -c '\#\#\#\#\#:' < \$$(basename $$file.gcov)`;
53GCOV_PERL+= printf("%7.2f %4d/%4d %s%s\n", 53GCOV_PERL+= printf("%7.2f %4d/%4d %s%s\n",
54GCOV_PERL+= $$percent, $$uncovered, $$lines, $$file, $$func); 54GCOV_PERL+= $$percent, $$uncovered, $$lines, $$file, $$func);
55GCOV_PERL+= $$file = undef; 55GCOV_PERL+= $$file = undef;
56GCOV_PERL+= } 56GCOV_PERL+= }
57LDADD+= --coverage 57LDADD+= --coverage
58.endif 58.endif
59CLEANFILES+= *.gcda *.gcno *.gcov 59CLEANFILES+= *.gcda *.gcno *.gcov
60 60
61# Whether to compile using the Undefined Behavior Sanitizer (GCC, Clang). 61# Whether to compile using the Undefined Behavior Sanitizer (GCC, Clang).
62USE_UBSAN?= no 62USE_UBSAN?= no
63.if ${USE_UBSAN} == "yes" 63.if ${USE_UBSAN} == "yes"
64COPTS+= -fsanitize=undefined 64COPTS+= -fsanitize=undefined
65LDADD+= -fsanitize=undefined 65LDADD+= -fsanitize=undefined
66.endif 66.endif
67 67
68# Whether to compile with GCC 10 from pkgsrc, during development. 68# Whether to compile with GCC 10 from pkgsrc, during development.
69USE_GCC10?= no 69USE_GCC10?= no
70.if ${USE_GCC10} == "yes" 70.if ${USE_GCC10} == "yes"
71# CC is set further down in this file 71# CC is set further down in this file
72COPTS+= -Wno-attributes # for abs and labs 72COPTS+= -Wno-attributes # for abs and labs
73COPTS.arch.c+= -Wno-error=format-truncation 73COPTS.arch.c+= -Wno-error=format-truncation
74COPTS.dir.c+= -Wno-error=format-truncation 74COPTS.dir.c+= -Wno-error=format-truncation
75COPTS.main.c+= -Wno-error=format-truncation 75COPTS.main.c+= -Wno-error=format-truncation
76COPTS.meta.c+= -Wno-error=format-truncation 76COPTS.meta.c+= -Wno-error=format-truncation
77.endif 77.endif
78 78
79# Whether to compile with GCC 9 from pkgsrc, during development. 79# Whether to compile with GCC 9 from pkgsrc, during development.
80USE_GCC9?= no 80USE_GCC9?= no
81.if ${USE_GCC9} == "yes" 81.if ${USE_GCC9} == "yes"
82# CC is set further down in this file 82# CC is set further down in this file
83COPTS+= -Wno-attributes # for abs and labs 83COPTS+= -Wno-attributes # for abs and labs
84COPTS.arch.c+= -Wno-error=format-truncation 84COPTS.arch.c+= -Wno-error=format-truncation
85COPTS.dir.c+= -Wno-error=format-truncation 85COPTS.dir.c+= -Wno-error=format-truncation
86COPTS.main.c+= -Wno-error=format-truncation 86COPTS.main.c+= -Wno-error=format-truncation
87COPTS.meta.c+= -Wno-error=format-truncation 87COPTS.meta.c+= -Wno-error=format-truncation
88.endif 88.endif
89 89
90# Whether to compile with GCC 8 from pkgsrc, during development. 90# Whether to compile with GCC 8 from pkgsrc, during development.
91USE_GCC8?= no 91USE_GCC8?= no
92.if ${USE_GCC8} == "yes" 92.if ${USE_GCC8} == "yes"
93# CC is set further down in this file 93# CC is set further down in this file
94COPTS+= -Wno-attributes # for abs and labs 94COPTS+= -Wno-attributes # for abs and labs
95COPTS.arch.c+= -Wno-error=format-truncation 95COPTS.arch.c+= -Wno-error=format-truncation
96COPTS.dir.c+= -Wno-error=format-truncation 96COPTS.dir.c+= -Wno-error=format-truncation
97COPTS.main.c+= -Wno-error=format-truncation 97COPTS.main.c+= -Wno-error=format-truncation
98COPTS.meta.c+= -Wno-error=format-truncation 98COPTS.meta.c+= -Wno-error=format-truncation
99.endif 99.endif
100 100
101USE_META?= yes 101USE_META?= yes
102.if ${USE_META:tl} != "no" 102.if ${USE_META:tl} != "no"
103 103
104SRCS+= meta.c 104SRCS+= meta.c
105CPPFLAGS+= -DUSE_META 105CPPFLAGS+= -DUSE_META
106 106
107USE_FILEMON?= ktrace 107USE_FILEMON?= ktrace
108. if ${USE_FILEMON:tl} != "no" 108. if ${USE_FILEMON:tl} != "no"
109 109
110.PATH: ${.CURDIR}/filemon 110.PATH: ${.CURDIR}/filemon
111SRCS+= filemon_${USE_FILEMON}.c 111SRCS+= filemon_${USE_FILEMON}.c
112CPPFLAGS+= -DUSE_FILEMON 112CPPFLAGS+= -DUSE_FILEMON
113CPPFLAGS+= -DUSE_FILEMON_${USE_FILEMON:tu} 113CPPFLAGS+= -DUSE_FILEMON_${USE_FILEMON:tu}
114 114
115. if ${USE_FILEMON} == "dev" 115. if ${USE_FILEMON} == "dev"
116FILEMON_H?= /usr/include/dev/filemon/filemon.h 116FILEMON_H?= /usr/include/dev/filemon/filemon.h
117. if exists(${FILEMON_H}) && ${FILEMON_H:T} == "filemon.h" 117. if exists(${FILEMON_H}) && ${FILEMON_H:T} == "filemon.h"
118COPTS.filemon_dev.c+= \ 118COPTS.filemon_dev.c+= \
119 -DHAVE_FILEMON_H -I${FILEMON_H:H} 119 -DHAVE_FILEMON_H -I${FILEMON_H:H}
120. endif 120. endif
121. endif 121. endif
122. endif 122. endif
123.endif 123.endif
124 124
125SUBDIR.roff+= PSD.doc 125SUBDIR.roff+= PSD.doc
126.if make(obj) || make(clean) 126.if make(obj) || make(clean)
127SUBDIR+= unit-tests 127SUBDIR+= unit-tests
128.endif 128.endif
129 129
 130LINTFLAGS+= -T # strict bool mode, available since 2021-01-11
 131
130${SRCS:M*.c:.c=.o}: ${HDRS} 132${SRCS:M*.c:.c=.o}: ${HDRS}
131CLEANFILES+= *.o 133CLEANFILES+= *.o
132 134
133COPTS.arch.c+= ${GCC_NO_FORMAT_TRUNCATION} 135COPTS.arch.c+= ${GCC_NO_FORMAT_TRUNCATION}
134COPTS.dir.c+= ${GCC_NO_FORMAT_TRUNCATION} 136COPTS.dir.c+= ${GCC_NO_FORMAT_TRUNCATION}
135COPTS.job.c+= -Wno-format-nonliteral 137COPTS.job.c+= -Wno-format-nonliteral
136COPTS.main.c+= ${GCC_NO_FORMAT_TRUNCATION} ${GCC_NO_STRINGOP_TRUNCATION} 138COPTS.main.c+= ${GCC_NO_FORMAT_TRUNCATION} ${GCC_NO_STRINGOP_TRUNCATION}
137COPTS.meta.c+= ${GCC_NO_FORMAT_TRUNCATION} 139COPTS.meta.c+= ${GCC_NO_FORMAT_TRUNCATION}
138COPTS.parse.c+= -Wno-format-nonliteral 140COPTS.parse.c+= -Wno-format-nonliteral
139COPTS.var.c+= -Wno-format-nonliteral 141COPTS.var.c+= -Wno-format-nonliteral
140 142
141CPPFLAGS+= -DMAKE_NATIVE 143CPPFLAGS+= -DMAKE_NATIVE
142 144
143.if ${USE_GCC10} == "yes" 145.if ${USE_GCC10} == "yes"
144GCC10BASE?= /usr/pkg/gcc10 146GCC10BASE?= /usr/pkg/gcc10
145LATE_CC= ${GCC10BASE}/bin/gcc 147LATE_CC= ${GCC10BASE}/bin/gcc
146GCOV= ${GCC10BASE}/bin/gcov 148GCOV= ${GCC10BASE}/bin/gcov
147.endif 149.endif
148 150
149.if ${USE_GCC9} == "yes" 151.if ${USE_GCC9} == "yes"
150GCC9BASE?= /usr/pkg/gcc9 152GCC9BASE?= /usr/pkg/gcc9
151LATE_CC= ${GCC9BASE}/bin/gcc 153LATE_CC= ${GCC9BASE}/bin/gcc
152GCOV= ${GCC9BASE}/bin/gcov 154GCOV= ${GCC9BASE}/bin/gcov
153.endif 155.endif
154 156
155.if ${USE_GCC8} == "yes" 157.if ${USE_GCC8} == "yes"
156GCC8BASE?= /usr/pkg/gcc8 158GCC8BASE?= /usr/pkg/gcc8
157LATE_CC= ${GCC8BASE}/bin/gcc 159LATE_CC= ${GCC8BASE}/bin/gcc
158GCOV= ${GCC8BASE}/bin/gcov 160GCOV= ${GCC8BASE}/bin/gcov
159.endif 161.endif
160 162
161.if defined(TOOLDIR) 163.if defined(TOOLDIR)
162# This is a native NetBSD build, use libutil rather than the local emalloc etc. 164# This is a native NetBSD build, use libutil rather than the local emalloc etc.
163CPPFLAGS+= -DUSE_EMALLOC 165CPPFLAGS+= -DUSE_EMALLOC
164LDADD+= -lutil 166LDADD+= -lutil
165DPADD+= ${LIBUTIL} 167DPADD+= ${LIBUTIL}
166.endif 168.endif
167 169
168COPTS+= -Wdeclaration-after-statement 170COPTS+= -Wdeclaration-after-statement
169 171
170# A simple unit-test driver to help catch regressions 172# A simple unit-test driver to help catch regressions
171TEST_MAKE ?= ${.OBJDIR}/${PROG:T} 173TEST_MAKE ?= ${.OBJDIR}/${PROG:T}
172test: .MAKE 174test: .MAKE
173 cd ${.CURDIR}/unit-tests \ 175 cd ${.CURDIR}/unit-tests \
174 && MAKEFLAGS= ${TEST_MAKE} -r -m / TEST_MAKE=${TEST_MAKE} ${TESTS:DTESTS=${TESTS:Q}} ${.TARGET} 176 && MAKEFLAGS= ${TEST_MAKE} -r -m / TEST_MAKE=${TEST_MAKE} ${TESTS:DTESTS=${TESTS:Q}} ${.TARGET}
175.if ${USE_COVERAGE} == yes 177.if ${USE_COVERAGE} == yes
176 ${MAKE} report-coverage 178 ${MAKE} report-coverage
177.endif 179.endif
178 180
179accept sync-mi: .MAKE 181accept sync-mi: .MAKE
180 cd ${.CURDIR}/unit-tests && ${.MAKE} ${.TARGET} 182 cd ${.CURDIR}/unit-tests && ${.MAKE} ${.TARGET}
181 183
182retest: 184retest:
183 ${.MAKE} -C ${.CURDIR}/unit-tests cleandir 185 ${.MAKE} -C ${.CURDIR}/unit-tests cleandir
184.if ${USE_COVERAGE} == yes 186.if ${USE_COVERAGE} == yes
185 rm -f *.gcov *.gcda 187 rm -f *.gcov *.gcda
186.endif 188.endif
187 ${.MAKE} test 189 ${.MAKE} test
188 190
189# Just out of curiosity, during development. 191# Just out of curiosity, during development.
190.SUFFIXES: .cpre .casm 192.SUFFIXES: .cpre .casm
191.c.cpre: 193.c.cpre:
192 ${COMPILE.c:S,^-c$,-E,} ${COPTS.${.IMPSRC}} ${.IMPSRC} -o ${.TARGET} 194 ${COMPILE.c:S,^-c$,-E,} ${COPTS.${.IMPSRC}} ${.IMPSRC} -o ${.TARGET}
193.c.casm: 195.c.casm:
194 ${COMPILE.c:S,^-c$,-S,} ${COPTS.${.IMPSRC}} ${.IMPSRC} -o ${.TARGET} 196 ${COMPILE.c:S,^-c$,-S,} ${COPTS.${.IMPSRC}} ${.IMPSRC} -o ${.TARGET}
195 197
196test-coverage: .PHONY 198test-coverage: .PHONY
197 @make -s clean cleandir 199 @make -s clean cleandir
198 @env USE_COVERAGE=yes COPTS="-O0 -ggdb" USER_CPPFLAGS="-DCLEANUP" \ 200 @env USE_COVERAGE=yes COPTS="-O0 -ggdb" USER_CPPFLAGS="-DCLEANUP" \
199 sh -c 'make -s all -j8 && make -s test' 201 sh -c 'make -s all -j8 && make -s test'
200 202
201report-coverage: .PHONY 203report-coverage: .PHONY
202 @echo 'covered uncovered file' 204 @echo 'covered uncovered file'
203 @${GCOV} ${GCOV_OPTS} ${SRCS} 2>&1 \ 205 @${GCOV} ${GCOV_OPTS} ${SRCS} 2>&1 \
204 | perl -ne ${GCOV_PERL:Q} \ 206 | perl -ne ${GCOV_PERL:Q} \
205 | sort -nr 207 | sort -nr
206 @sed -i 's,^\([^:]*\): *[0-9]*:,\1: ,' *.gcov 208 @sed -i 's,^\([^:]*\): *[0-9]*:,\1: ,' *.gcov
207 209
208.include <bsd.prog.mk> 210.include <bsd.prog.mk>
209.include <bsd.subdir.mk> 211.include <bsd.subdir.mk>
210 212
211# For -DCLEANUP and similar feature toggles. 213# For -DCLEANUP and similar feature toggles.
212CPPFLAGS+= ${USER_CPPFLAGS} 214CPPFLAGS+= ${USER_CPPFLAGS}
213# For overriding -std=gnu99 or similar options. 215# For overriding -std=gnu99 or similar options.
214CFLAGS+= ${USER_CFLAGS} 216CFLAGS+= ${USER_CFLAGS}
215.if defined(LATE_CC) 217.if defined(LATE_CC)
216CC= ${LATE_CC} 218CC= ${LATE_CC}
217.endif 219.endif