lint: remove message 189, add tests for a few other messages Message 189 would have applied to traditional C and was supposed to detect assignments between struct and union types. The corresponding check had never been implemented though. Traditional C has been superseded for 30 years now, therefore there is no point in adding this check retroactively.

(rillig)

 @@ -1,14 +1,14 @@
-/*	$NetBSD: err.c,v 1.69 2021/01/17 17:14:34 rillig Exp $	*/
+/*	$NetBSD: err.c,v 1.70 2021/01/30 17:56:29 rillig Exp $	*/
 /*
  * Copyright (c) 1994, 1995 Jochen Pohl
  * All Rights Reserved.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
 @@ -27,27 +27,27 @@
  * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 #if HAVE_NBTOOL_CONFIG_H
 #include "nbtool_config.h"
 #endif
 #include <sys/cdefs.h>
 #if defined(__RCSID) && !defined(lint)
-__RCSID("$NetBSD: err.c,v 1.69 2021/01/17 17:14:34 rillig Exp $");
+__RCSID("$NetBSD: err.c,v 1.70 2021/01/30 17:56:29 rillig Exp $");
 #endif
 #include <sys/types.h>
 #include <stdarg.h>
 #include <stdlib.h>
 #include "lint1.h"
 /* number of errors found */
 int	nerr;
 /* number of syntax errors */
 int	sytxerr;
 @@ -238,27 +238,27 @@ const	char *msgs[] = {
 	"invalid initializer type %s",				      /* 176 */
 	"non-constant initializer",				      /* 177 */
 	"initializer does not fit",				      /* 178 */
 	"cannot initialize struct/union with no named member",	      /* 179 */
 	"bit-field initializer does not fit",			      /* 180 */
 	"{}-enclosed initializer required",			      /* 181 */
 	"incompatible pointer types (%s != %s)",		      /* 182 */
 	"illegal combination of %s (%s) and %s (%s)",		      /* 183 */
 	"illegal pointer combination",				      /* 184 */
 	"initialisation type mismatch (%s) and (%s)",		      /* 185 */
 	"bit-field initialisation is illegal in traditional C",	      /* 186 */
 	"non-null byte ignored in string initializer",		      /* 187 */
 	"no automatic aggregate initialization in traditional C",     /* 188 */
-	"assignment of struct/union illegal in traditional C",	      /* 189 */
+	"",			/* no longer used */		      /* 189 */
 	"empty array declaration: %s",				      /* 190 */
 	"%s set but not used in function %s",			      /* 191 */
 	"%s unused in function %s",				      /* 192 */
 	"statement not reached",				      /* 193 */
 	"label %s redefined",					      /* 194 */
 	"case not in switch",					      /* 195 */
 	"case label affected by conversion",			      /* 196 */
 	"non-constant case expression",				      /* 197 */
 	"non-integral case expression",				      /* 198 */
 	"duplicate case in switch: %ld",			      /* 199 */
 	"duplicate case in switch: %lu",			      /* 200 */
 	"default outside switch",				      /* 201 */
 	"duplicate default in switch",				      /* 202 */

 @@ -1,7 +1,19 @@
-/*	$NetBSD: msg_189.c,v 1.1 2021/01/02 10:22:43 rillig Exp $	*/
+/*	$NetBSD: msg_189.c,v 1.2 2021/01/30 17:56:29 rillig Exp $	*/
 # 3 "msg_189.c"
-// Test for message: assignment of struct/union illegal in traditional C [189]
+/* Test for message: assignment of struct/union illegal in traditional C [189] */
-TODO: "Add example code that triggers the above message."
+/* lint1-flags: -tw */
 TODO: "Add example code that almost triggers the above message."
 struct s {
 	int member;
 };
 void
 example()
+{
 	struct s a, b;
 	a.member = 3;
 	b = a;			/* message 189 is not triggered anymore */
+}

 @@ -1,7 +1,14 @@
-/*	$NetBSD: msg_191.c,v 1.1 2021/01/02 10:22:43 rillig Exp $	*/
+/*	$NetBSD: msg_191.c,v 1.2 2021/01/30 17:56:29 rillig Exp $	*/
 # 3 "msg_191.c"
 // Test for message: %s set but not used in function %s [191]
-TODO: "Add example code that triggers the above message."
+void
-TODO: "Add example code that almost triggers the above message."
+example(void)
+{
 	int local;
 	local = 3;		/* expect: 191 */
 	local = 5;
+}

 @@ -1,7 +1,10 @@
-/*	$NetBSD: msg_192.c,v 1.1 2021/01/02 10:22:43 rillig Exp $	*/
+/*	$NetBSD: msg_192.c,v 1.2 2021/01/30 17:56:29 rillig Exp $	*/
 # 3 "msg_192.c"
 // Test for message: %s unused in function %s [192]
-TODO: "Add example code that triggers the above message."
+void
-TODO: "Add example code that almost triggers the above message."
+example(int param)		/* expect: 231 */
+{
 	int local;		/* expect: 192 */
+}

 @@ -1,7 +1,10 @@
-/*	$NetBSD: msg_193.c,v 1.1 2021/01/02 10:22:43 rillig Exp $	*/
+/*	$NetBSD: msg_193.c,v 1.2 2021/01/30 17:56:29 rillig Exp $	*/
 # 3 "msg_193.c"
 // Test for message: statement not reached [193]
-TODO: "Add example code that triggers the above message."
+void example(void)
 TODO: "Add example code that almost triggers the above message."
 	return;
 	return;			/* expect: 193 */
+}

 @@ -1,7 +1,13 @@
-/*	$NetBSD: msg_194.c,v 1.1 2021/01/02 10:22:43 rillig Exp $	*/
+/*	$NetBSD: msg_194.c,v 1.2 2021/01/30 17:56:29 rillig Exp $	*/
 # 3 "msg_194.c"
 // Test for message: label %s redefined [194]
-TODO: "Add example code that triggers the above message."
+void example(void)
 TODO: "Add example code that almost triggers the above message."
 	int i = 0;
 label:				/* expect: 232 */
 	i = 1;
 label:				/* expect: 194 */
 	i = 2;
+}