Sun Feb 27 18:51:21 2022 UTC ()
tests/lint: demonstrate unexpected ordering of string concatenations

When lint concatenates the strings "1" "2" "3" "4", it first
concatenates "23", then "234" and finally "1234".


(rillig)
diff -r1.2 -r1.3 src/tests/usr.bin/xlint/lint1/msg_292.c
diff -r1.2 -r1.3 src/tests/usr.bin/xlint/lint1/msg_292.exp

cvs diff -r1.2 -r1.3 src/tests/usr.bin/xlint/lint1/msg_292.c (expand / switch to context diff)
--- src/tests/usr.bin/xlint/lint1/msg_292.c 2021/02/21 09:07:58 1.2
+++ src/tests/usr.bin/xlint/lint1/msg_292.c 2022/02/27 18:51:21 1.3
@@ -1,7 +1,39 @@
-/*	$NetBSD: msg_292.c,v 1.2 2021/02/21 09:07:58 rillig Exp $	*/
+/*	$NetBSD: msg_292.c,v 1.3 2022/02/27 18:51:21 rillig Exp $	*/
 # 3 "msg_292.c"
 
 // Test for message: cannot concatenate wide and regular string literals [292]
 
-TODO: "Add example code that triggers the above message." /* expect: 249 */
+const char c_c_c_w_w_w[] =
-TODO: "Add example code that almost triggers the above message."
+	"c2"
+	"c  4"
+	"c      8"
+	/* expect+1: error: cannot concatenate wide and regular string literals [292] */
+	L"w2"
+	/* expect+1: error: cannot concatenate wide and regular string literals [292] */
+	L"w  4"
+	/* expect+1: error: cannot concatenate wide and regular string literals [292] */
+	L"w      8";
+/* The 15 results from 2 + 4 + 8 + '\0'. */
+/* expect+1: error: negative array dimension (-15) [20] */
+typedef int reveal_sizeof_c_c_c_w_w_w[-(int)sizeof(c_c_c_w_w_w)];
+
+const char c_w_c_w_c_w[] =
+	"c2"
+	L"w2"
+	/* expect+1: error: cannot concatenate wide and regular string literals [292] */
+	"c  4"
+	L"w  4"
+	/* expect+1: error: cannot concatenate wide and regular string literals [292] */
+	"c      8"
+	/* expect+1: error: cannot concatenate wide and regular string literals [292] */
+	L"w      8";
+/*
+ * Concatenating L"w2" with "c4" fails, keeping L"w2".
+ * Concatenating L"w2" with L"w4" succeeds, resulting in L"w2w4".
+ * Concatenating L"w2w4" with "c8" fails, keeping L"w2w4".
+ * Concatenating L"w2w4" with L"w8" succeeds, resulting in L"w2w4w8".
+ * Concatenating "c2" with L"w2w4w8" fails, keeping "c2".
+ * The size of "c2" is 3.
+ */
+/* expect+1: error: negative array dimension (-3) [20] */
+typedef int reveal_sizeof_c_w_c_w_c_w[-(int)sizeof(c_w_c_w_c_w)];

cvs diff -r1.2 -r1.3 src/tests/usr.bin/xlint/lint1/Attic/msg_292.exp (expand / switch to context diff)
--- src/tests/usr.bin/xlint/lint1/Attic/msg_292.exp 2021/03/21 20:45:00 1.2
+++ src/tests/usr.bin/xlint/lint1/Attic/msg_292.exp 2022/02/27 18:51:21 1.3
@@ -1 +1,8 @@
-msg_292.c(6): error: syntax error ':' [249]
+msg_292.c(11): error: cannot concatenate wide and regular string literals [292]
+msg_292.c(13): error: cannot concatenate wide and regular string literals [292]
+msg_292.c(15): error: cannot concatenate wide and regular string literals [292]
+msg_292.c(18): error: negative array dimension (-15) [20]
+msg_292.c(24): error: cannot concatenate wide and regular string literals [292]
+msg_292.c(27): error: cannot concatenate wide and regular string literals [292]
+msg_292.c(29): error: cannot concatenate wide and regular string literals [292]
+msg_292.c(39): error: negative array dimension (-3) [20]