Wed Apr 12 19:09:48 2023 UTC ()

lint: suppress warnings about LDBL_MAX in cross-build mode

This fixes the cross build for sparc64 on x86_64, in which lint
complained:
	warning: floating-point constant out of range [248]
	warning: floating point overflow on operator '-' [142]
	warning: floating-point constant out of range [248]


(rillig)

diff -r1.511 -r1.512 src/usr.bin/xlint/lint1/tree.c

--- src/usr.bin/xlint/lint1/tree.c 2023/04/11 19:40:04	1.511
+++ src/usr.bin/xlint/lint1/tree.c 2023/04/12 19:09:48	1.512

 @@ -1,14 +1,14 @@
-/*	$NetBSD: tree.c,v 1.511 2023/04/11 19:40:04 rillig Exp $	*/
+/*	$NetBSD: tree.c,v 1.512 2023/04/12 19:09:48 rillig Exp $	*/
 /*
  * Copyright (c) 1994, 1995 Jochen Pohl
  * All Rights Reserved.
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
 @@ -27,27 +27,27 @@
  * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 #if HAVE_NBTOOL_CONFIG_H
 #include "nbtool_config.h"
 #endif
 #include <sys/cdefs.h>
 #if defined(__RCSID)
-__RCSID("$NetBSD: tree.c,v 1.511 2023/04/11 19:40:04 rillig Exp $");
+__RCSID("$NetBSD: tree.c,v 1.512 2023/04/12 19:09:48 rillig Exp $");
 #endif
 #include <float.h>
 #include <limits.h>
 #include <math.h>
 #include <signal.h>
 #include <stdlib.h>
 #include <string.h>
 #include "lint1.h"
 typedef struct integer_constraints {
 @@ -1497,27 +1497,43 @@ fold_bool(tnode_t *tn)
 		lint_assert(/*CONSTCOND*/false);
+	}
 	return build_constant(tn->tn_type, v);
+}
 static ldbl_t
 floating_error_value(tspec_t t, ldbl_t lv)
+{
 	if (t == FLOAT)
 		return lv < 0 ? -FLT_MAX : FLT_MAX;
 	if (t == DOUBLE)
 		return lv < 0 ? -DBL_MAX : DBL_MAX;
-	return lv < 0 ? -LDBL_MAX : LDBL_MAX;
+	/*
 	 * When lint is compiled on x86_64 to check for sparc64, it uses the
 	 * type 'long double' from x86_64, which is the Intel 80-bit format.
 	 * The constant LDBL_MAX comes from the sparc64 preprocessor though
 	 * and uses the IEEE-754-binary128 format, with the same exponent
 	 * range but a wider mantissa.
+	 *
 	 * To properly handle this situation, lint would have to implement the
 	 * floating-point types in a platform-independent way, which is not
 	 * worth the effort, given how few programs practically use 'long
 	 * double'.
+	 *
 	 * This caveat only affects cross builds.
 	 */
 	/* LINTED 248: floating-point constant out of range */
 	ldbl_t max = LDBL_MAX;
 	return lv < 0 ? -max : max;
+}
 /*
  * Fold constant nodes having operands with floating point type.
  */
 static tnode_t *
 fold_float(tnode_t *tn)
+{
 	val_t	*v;
 	tspec_t	t;
 	ldbl_t	lv, rv = 0;
 	fpe = 0;