---
- branch: MAIN
  date: Fri Apr 24 10:19:32 UTC 2020
  files:
  - new: '1.42'
    old: '1.41'
    path: pkgsrc/devel/libffi/Makefile
    pathrev: pkgsrc/devel/libffi/Makefile@1.42
    type: modified
  - new: '1.54'
    old: '1.53'
    path: pkgsrc/devel/libffi/distinfo
    pathrev: pkgsrc/devel/libffi/distinfo@1.54
    type: modified
  - new: '1.2'
    old: '1.1'
    path: pkgsrc/devel/libffi/patches/patch-configure
    pathrev: pkgsrc/devel/libffi/patches/patch-configure@1.2
    type: modified
  id: 20200424T101932Z.7d714d00b9a93e7da3d1a4636a0d54623122a4e0
  log: |
    Revert portions of PR/48587 - applied in 2014 to resolve some issue
    with building on Irix.  The changes applied to 'configure' introduce
    some quite ugly quote nesting that not all shells (E.g. ksh) can
    comprehend.

    After discussion, prefer to roll back what looks like undesirable and
    unnecessary changes, and drop the 'bash' dependency.  My suspicion is
    that the old 'configure' patch is unhelpful even for Irix.

    The reason for the PR/48587 changes are not clear, given that part of
    that patch also selected 'bash' as the shell to use - which should
    have made editing the script unnecessary in the first place.

    Demonstrating the problem bringing all this to attention, this is what
    happens if you are using ksh as the Pkgsrc shell on MacOS X:

    ===> Building for libffi-3.3nb2
    /bin/ksh: : cannot execute [Is a directory]
    <hangs>

    The cause is this ugly looking quote nesting that was introduced by
    patch-configure in PR/48587...

    $ BUILD="` grep "^#### $HOST " Makefile | sed -e 's/.*|//' `"
    ksh: : cannot execute [Is a directory]
    ^C
    % bash
    bash-5.0$ BUILD="` grep "^#### $$HOST " Makefile | sed -e 's/.*|//' `"
    bash-5.0$ exit
    % sh
    sh-3.2$ BUILD="` grep "^#### $$HOST " Makefile | sed -e 's/.*|//' `"
    sh-3.2$ exit

    Removing patch-configure results in this much simpler, portable looking
    script:

    $ BUILD=` grep "^#### $$HOST " Makefile | sed -e 's/.*|//' `

    No PKGREVISION bump, this change is not anticipated to affect the
    package contents, only the success or failure of the build.
  module: pkgsrc
  subject: 'CVS commit: pkgsrc/devel/libffi'
  unixtime: '1587723572'
  user: dsainty