---
- branch: MAIN
  date: Sat Jul  9 07:46:03 UTC 2022
  files:
  - new: '1.249'
    old: '1.248'
    path: pkgsrc/mk/buildlink3/bsd.buildlink3.mk
    pathrev: pkgsrc/mk/buildlink3/bsd.buildlink3.mk@1.249
    type: modified
  id: 20220709T074603Z.54641f4f274211dc2d3eeb038586c14fd103d89e
  log: |
    mk/buildlink3: remove makefile hacks for NetBSD 5

    pkgsrc does not support NetBSD 5 anymore.

    Back then, when expanding the body of a .for loop, the variable values
    were inserted verbatim in the body, allowing for lots of unintended
    special effects, making it essentially impossible to use these values
    directly in conditions.

    In this case, the values do not contain double quotes, that's why
    enclosing the ${_pkg_} in double quotes worked.

    See src/usr.bin/make/unit-tests/directive-for.mk for more details,
    search for '2008-12-21'.

    Combining .for loops with 'empty(...)' conditions still does not work,
    so replace these with direct comparisons.  Before 2008-12-21, using
    'empty(...)' was the safer variant because it avoided the uncontrolled
    code injection.

    No functional change.
  module: pkgsrc
  subject: 'CVS commit: pkgsrc/mk/buildlink3'
  unixtime: '1657352763'
  user: rillig