---
- branch: MAIN
  date: Tue Mar 19 23:18:21 UTC 2024
  files:
  - new: '1.18'
    old: '1.17'
    path: pkgsrc/pkgtools/libnbcompat/inplace.mk
    pathrev: pkgsrc/pkgtools/libnbcompat/inplace.mk@1.18
    type: modified
  id: 20240319T231821Z.aab3e234cf0e63cbc3172d00eee85658eddaa4f8
  log: |
    libnbcompat: Rework in-place linking.

    Prevent libtool from detecting -lnbcompat in the command line arguments
    then declaring it as a dependency in the resulting libtool archive.

    Filter -lnbcompat from all of the environment when compiling an
    in-place copy to prevent circular dependencies.

    Drop LIBNBCOMPAT_USE_PIC, I can't find anywhere this is used in the
    tree, it's incomplete (needs handling in mk/) and complicates things
    needlessly.

    What still needs to be done is figure out why certain packages don't
    seem to properly link with libnbcompat when USE_FEATURES is used - it's
    a long-term problem, might be related to some newer build systems not
    using ${LIBS}.

    Bootstrap tested on Darwin and NetBSD.
  module: pkgsrc
  subject: 'CVS commit: pkgsrc/pkgtools/libnbcompat'
  unixtime: '1710890301'
  user: nia