Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66]) by www.NetBSD.org (Postfix) with ESMTP id A86D163E059 for ; Mon, 15 Oct 2012 15:29:16 +0000 (UTC) Received: by mail.netbsd.org (Postfix, from userid 605) id 813E714A219; Mon, 15 Oct 2012 15:29:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 5E76214A218 for ; Mon, 15 Oct 2012 15:29:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at NetBSD.org Received: from mail.netbsd.org ([127.0.0.1]) by localhost (mail.NetBSD.org [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id D3JD3oVU6wju for ; Mon, 15 Oct 2012 15:29:13 +0000 (UTC) Received: from cvs.netbsd.org (cvs.NetBSD.org [IPv6:2001:4f8:3:7:2e0:81ff:fe30:95bd]) by mail.netbsd.org (Postfix) with ESMTP id A59DE14A20D for ; Mon, 15 Oct 2012 15:29:13 +0000 (UTC) Received: by cvs.netbsd.org (Postfix, from userid 500) id 70CD4175DD; Mon, 15 Oct 2012 15:29:12 +0000 (UTC) MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Date: Mon, 15 Oct 2012 15:29:11 +0000 From: "Ignatios Souvatzis" Subject: CVS commit: pkgsrc/x11 To: pkgsrc-changes@NetBSD.org Reply-To: is@netbsd.org X-Mailer: log_accum Message-Id: <20121015152912.70CD4175DD@cvs.netbsd.org> Sender: pkgsrc-changes-owner@NetBSD.org List-Id: pkgsrc-changes.NetBSD.org Precedence: bulk Module Name: pkgsrc Committed By: is Date: Mon Oct 15 15:29:11 UTC 2012 Modified Files: pkgsrc/x11/xlockmore: Makefile distinfo pkgsrc/x11/xlockmore-lite: Makefile Added Files: pkgsrc/x11/xlockmore/patches: patch-modes_dclock.c Log Message: xlock -mode dclock would segfault on OSes with sizeof(time_t)>sizeof(long); this includes NetBSD-6 on 32bit systems. As a result, xlock -mode random (the default) would eventually unlock the screen, without the user being aware of this (as she/he's can be presumed to have left the monitor). The reason was that some variables in dclock.c were declared long, but contain essentially time_t values. In on case, a pointer to such a variable was casted to (struct time_t *) and passed to localtime(), and the resulting pointer is not checked for error before being used. The variables have been changed to time_t and the typecast has been removed. To generate a diff of this commit: cvs rdiff -u -r1.99 -r1.100 pkgsrc/x11/xlockmore/Makefile cvs rdiff -u -r1.48 -r1.49 pkgsrc/x11/xlockmore/distinfo cvs rdiff -u -r1.15 -r1.16 pkgsrc/x11/xlockmore-lite/Makefile cvs rdiff -u -r0 -r1.1 pkgsrc/x11/xlockmore/patches/patch-modes_dclock.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.