Received: from mail.netbsd.org (mail.netbsd.org [149.20.53.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK)) by mollari.NetBSD.org (Postfix) with ESMTPS id 3E6BFA567D for ; Thu, 15 Oct 2015 03:00:58 +0000 (UTC) Received: by mail.netbsd.org (Postfix, from userid 605) id 9AE0214A4D1; Thu, 15 Oct 2015 03:00:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id DFE9514A4D0 for ; Thu, 15 Oct 2015 03:00:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at NetBSD.org Received: from mail.netbsd.org ([127.0.0.1]) by localhost (mail.NetBSD.org [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id iM5tnL7CiuT9 for ; Thu, 15 Oct 2015 03:00:56 +0000 (UTC) Received: from cvs.netbsd.org (cvs.NetBSD.org [IPv6:2001:4f8:3:7:2e0:81ff:fe30:95bd]) by mail.netbsd.org (Postfix) with ESMTP id 73A4514A4CB for ; Thu, 15 Oct 2015 03:00:56 +0000 (UTC) Received: by cvs.netbsd.org (Postfix, from userid 500) id 6783A98; Thu, 15 Oct 2015 03:00:56 +0000 (UTC) Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" MIME-Version: 1.0 Date: Thu, 15 Oct 2015 03:00:56 +0000 From: "Roland Illig" Subject: CVS commit: pkgsrc/pkgtools/pkglint/files To: pkgsrc-changes@NetBSD.org Reply-To: rillig@netbsd.org X-Mailer: log_accum Message-Id: <20151015030056.6783A98@cvs.netbsd.org> Sender: pkgsrc-changes-owner@NetBSD.org List-Id: pkgsrc-changes.NetBSD.org Precedence: bulk Module Name: pkgsrc Committed By: rillig Date: Thu Oct 15 03:00:56 UTC 2015 Modified Files: pkgsrc/pkgtools/pkglint/files: pkglint.pl Log Message: Reverted part of 1.888 (perlcritic --stern) The warning that "return undef" is bad must be taken with great care. Although perlcritic explains it a lot and warns to think before simply fixing it, it doesn't mention that in some cases a simple "return" means "return '0'", which had happened here. To generate a diff of this commit: cvs rdiff -u -r1.892 -r1.893 pkgsrc/pkgtools/pkglint/files/pkglint.pl Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.