Received: by mail.netbsd.org (Postfix, from userid 605) id 63C6185110; Sat, 7 Jul 2018 11:48:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id A8E4485105 for ; Sat, 7 Jul 2018 11:48:19 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([IPv6:::1]) by localhost (mail.netbsd.org [IPv6:::1]) (amavisd-new, port 10025) with ESMTP id W9It7U6xZgUy for ; Sat, 7 Jul 2018 11:48:19 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.NetBSD.org [IPv6:2001:470:a085:999:28c:faff:fe03:5984]) by mail.netbsd.org (Postfix) with ESMTP id D064F84D8E for ; Sat, 7 Jul 2018 11:48:18 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id C1B60FBEC; Sat, 7 Jul 2018 11:48:18 +0000 (UTC) Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_1530964098168690" MIME-Version: 1.0 Date: Sat, 7 Jul 2018 11:48:18 +0000 From: "Greg Troxel" Subject: CVS commit: pkgsrc/lang To: pkgsrc-changes@NetBSD.org Reply-To: gdt@netbsd.org X-Mailer: log_accum Message-Id: <20180707114818.C1B60FBEC@cvs.NetBSD.org> Sender: pkgsrc-changes-owner@NetBSD.org List-Id: pkgsrc-changes.NetBSD.org Precedence: bulk List-Unsubscribe: This is a multi-part message in MIME format. --_----------=_1530964098168690 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Module Name: pkgsrc Committed By: gdt Date: Sat Jul 7 11:48:18 UTC 2018 Modified Files: pkgsrc/lang/openjdk7: Makefile pkgsrc/lang/openjdk8: Makefile Log Message: openjdk[78]: Add a \todo comment about the cups dependency. Having a language install a printing system violates the Principle of Least Astonishment. Add a comment to be replaced with an explanation of why this is necessary or helpful. To generate a diff of this commit: cvs rdiff -u -r1.124 -r1.125 pkgsrc/lang/openjdk7/Makefile cvs rdiff -u -r1.65 -r1.66 pkgsrc/lang/openjdk8/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. --_----------=_1530964098168690 Content-Disposition: inline Content-Length: 1832 Content-Transfer-Encoding: binary Content-Type: text/x-diff; charset=us-ascii Modified files: Index: pkgsrc/lang/openjdk7/Makefile diff -u pkgsrc/lang/openjdk7/Makefile:1.124 pkgsrc/lang/openjdk7/Makefile:1.125 --- pkgsrc/lang/openjdk7/Makefile:1.124 Tue Apr 17 22:29:40 2018 +++ pkgsrc/lang/openjdk7/Makefile Sat Jul 7 11:48:18 2018 @@ -1,4 +1,4 @@ -# $NetBSD: Makefile,v 1.124 2018/04/17 22:29:40 wiz Exp $ +# $NetBSD: Makefile,v 1.125 2018/07/07 11:48:18 gdt Exp $ JDK_MICRO= 141 DISTNAME= openjdk-1.7.${JDK_MICRO}-20170813 @@ -295,6 +295,9 @@ MAKE_ENV+= STRIP=${PREFIX}/bin/gstrip .include "../../devel/zlib/buildlink3.mk" .include "../../fonts/fontconfig/buildlink3.mk" .include "../../graphics/freetype2/buildlink3.mk" +# \todo Explain why cups needs to be included, because having the +# package installed is unexpected for those who have not chosen to use +# cups. BUILDLINK_DEPMETHOD.cups-base?= build .include "../../print/cups-base/buildlink3.mk" .include "../../mk/java-env.mk" Index: pkgsrc/lang/openjdk8/Makefile diff -u pkgsrc/lang/openjdk8/Makefile:1.65 pkgsrc/lang/openjdk8/Makefile:1.66 --- pkgsrc/lang/openjdk8/Makefile:1.65 Sat May 26 21:26:46 2018 +++ pkgsrc/lang/openjdk8/Makefile Sat Jul 7 11:48:18 2018 @@ -1,4 +1,4 @@ -# $NetBSD: Makefile,v 1.65 2018/05/26 21:26:46 ryoon Exp $ +# $NetBSD: Makefile,v 1.66 2018/07/07 11:48:18 gdt Exp $ DISTNAME= openjdk-1.8.172-20180527 PKGNAME= openjdk8-1.8.172 @@ -270,6 +270,9 @@ MAKE_ENV+= STRIP=${PREFIX}/bin/gstrip .include "../../devel/zlib/buildlink3.mk" .include "../../fonts/fontconfig/buildlink3.mk" .include "../../graphics/freetype2/buildlink3.mk" +# \todo Explain why cups needs to be included, because having the +# package installed is unexpected for those who have not chosen to use +# cups. BUILDLINK_DEPMETHOD.cups-base?= build .include "../../print/cups-base/buildlink3.mk" .include "../../mk/java-env.mk" --_----------=_1530964098168690--